godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Adds fuzzy search for help search dialog"

Browse Source 
This reverts commit 481dbceed0.

Current fuzzy search implementation results in too many
non-useful results.

Could be re-added after result sort/filter/score functionality
is added. See #30072 for example existing implementation.

Fixes: #39128

Reverts: #32043

Fixed format style conflicts:
	editor/editor_help_search.cpp

(cherry picked from commit 55d706c352)
This commit is contained in:
follower 2020-07-01 03:19:24 +12:00 committed by Rémi Verschelde
parent 89421c58cd
commit 9388237e2d
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
editor/editor_help_search.cpp
View File

@ -344,16 +344,12 @@ bool EditorHelpSearch::Runner::_phase_match_classes() {
if (search_flags & SEARCH_METHODS) if (search_flags & SEARCH_METHODS)
for (int i = 0; i < class_doc.methods.size(); i++) { for (int i = 0; i < class_doc.methods.size(); i++) {
String method_name = (search_flags & SEARCH_CASE_SENSITIVE) ? class_doc.methods[i].name : class_doc.methods[i].name.to_lower(); String method_name = (search_flags & SEARCH_CASE_SENSITIVE) ? class_doc.methods[i].name : class_doc.methods[i].name.to_lower();
String aux_term = (search_flags & SEARCH_CASE_SENSITIVE) ? term : term.to_lower(); if (method_name.find(term) > -1 ||
(term.begins_with(".") && method_name.begins_with(term.right(1))) ||
if (aux_term.begins_with(".")) (term.ends_with("(") && method_name.ends_with(term.left(term.length() - 1).strip_edges())) ||
aux_term = aux_term.right(1); (term.begins_with(".") && term.ends_with("(") && method_name == term.substr(1, term.length() - 2).strip_edges())) {
if (aux_term.ends_with("("))
aux_term = aux_term.left(aux_term.length() - 1).strip_edges();
if (aux_term.is_subsequence_of(method_name))
match.methods.push_back(const_cast<DocData::MethodDoc *>(&class_doc.methods[i])); match.methods.push_back(const_cast<DocData::MethodDoc *>(&class_doc.methods[i]));
}
} }
if (search_flags & SEARCH_SIGNALS) if (search_flags & SEARCH_SIGNALS)
for (int i = 0; i < class_doc.signals.size(); i++) for (int i = 0; i < class_doc.signals.size(); i++)
@ -440,11 +436,11 @@ bool EditorHelpSearch::Runner::_phase_select_match() {
} }
bool EditorHelpSearch::Runner::_match_string(const String &p_term, const String &p_string) const { bool EditorHelpSearch::Runner::_match_string(const String &p_term, const String &p_string) const {
if (search_flags & SEARCH_CASE_SENSITIVE) {
if (search_flags & SEARCH_CASE_SENSITIVE) return p_string.find(p_term) > -1;
return p_term.is_subsequence_of(p_string); } else {
else return p_string.findn(p_term) > -1;
return p_term.is_subsequence_ofi(p_string); }
} }
void EditorHelpSearch::Runner::_match_item(TreeItem *p_item, const String &p_text) { void EditorHelpSearch::Runner::_match_item(TreeItem *p_item, const String &p_text) {