godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #17834 from Rubonnek/move-to-initializer-list 

Move GodotSharp and MonoBuildTab member variables to initializer list
This commit is contained in:
Rémi Verschelde 2018-04-03 21:01:58 +02:00 committed by GitHub
parent 9ad1800298 3f86fefb64
commit 95b499644e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
modules/mono/editor/godotsharp_builds.cpp
View File

@ -525,11 +525,10 @@ void GodotSharpBuilds::BuildProcess::start(bool p_blocking) {
} }
} }
GodotSharpBuilds::BuildProcess::BuildProcess(const MonoBuildInfo &p_build_info, GodotSharpBuild_ExitCallback p_callback) { GodotSharpBuilds::BuildProcess::BuildProcess(const MonoBuildInfo &p_build_info, GodotSharpBuild_ExitCallback p_callback) :
build_info(p_build_info),
build_info = p_build_info; build_tab(NULL),
build_tab = NULL; exit_callback(p_callback),
exit_callback = p_callback; exited(true),
exited = true; exit_code(-1) {
exit_code = -1;
} }

23
modules/mono/editor/mono_bottom_panel.cpp
View File

@ -437,21 +437,16 @@ void MonoBuildTab::_bind_methods() {
ClassDB::bind_method("_issue_activated", &MonoBuildTab::_issue_activated); ClassDB::bind_method("_issue_activated", &MonoBuildTab::_issue_activated);
} }
MonoBuildTab::MonoBuildTab(const MonoBuildInfo &p_build_info, const String &p_logs_dir) { MonoBuildTab::MonoBuildTab(const MonoBuildInfo &p_build_info, const String &p_logs_dir) :
build_info(p_build_info),
build_info = p_build_info; logs_dir(p_logs_dir),
logs_dir = p_logs_dir; build_exited(false),
issues_list(memnew(ItemList)),
build_exited = false; error_count(0),
warning_count(0),
issues_list = memnew(ItemList); errors_visible(true),
warnings_visible(true) {
issues_list->set_v_size_flags(SIZE_EXPAND_FILL); issues_list->set_v_size_flags(SIZE_EXPAND_FILL);
issues_list->connect("item_activated", this, "_issue_activated"); issues_list->connect("item_activated", this, "_issue_activated");
add_child(issues_list); add_child(issues_list);
error_count = 0;
warning_count = 0;
errors_visible = true;
warnings_visible = true;
} }