godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when toggling flag property value

This commit is contained in:
Haoyu Qiu 2022-08-31 09:26:54 +08:00
parent c40855f818
commit 97f547a63a
1 changed files with 28 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
editor/editor_properties.cpp
View File

@ -832,15 +832,14 @@ void EditorPropertyFlags::setup(const Vector<String> &p_options) {
bool first = true;
uint32_t current_val;
for (int i = 0; i < p_options.size(); i++) {
// An empty option is not considered a "flag".
String option = p_options[i].strip_edges();
if (!option.is_empty()) {
CheckBox *cb = memnew(CheckBox);
cb->set_text(option);
cb->set_clip_text(true);
cb->connect("pressed", callable_mp(this, &EditorPropertyFlags::_flag_toggled).bind(i));
add_focusable(cb);
vbox->add_child(cb);
flags.push_back(cb);
if (option.is_empty()) {
continue;
}
const int flag_index = flags.size(); // Index of the next element (added by the code below).
// Value for a flag can be explicitly overridden.
Vector<String> text_split = p_options[i].split(":");
if (text_split.size() != 1) {
current_val = text_split[1].to_int();
@ -848,13 +847,23 @@ void EditorPropertyFlags::setup(const Vector<String> &p_options) {
current_val = 1 << i;
}
flag_values.push_back(current_val);
// Create a CheckBox for the current flag.
CheckBox *cb = memnew(CheckBox);
cb->set_text(option);
cb->set_clip_text(true);
cb->connect("pressed", callable_mp(this, &EditorPropertyFlags::_flag_toggled).bind(flag_index));
add_focusable(cb);
vbox->add_child(cb);
flags.push_back(cb);
// Can't use `i == 0` because we want to find the first none-empty option.
if (first) {
set_label_reference(cb);
first = false;
}
}
}
}
void EditorPropertyFlags::_bind_methods() {
}