From c6ea3768429d42418bc7a597fcd798daa58c70db Mon Sep 17 00:00:00 2001 From: jpcerrone Date: Fri, 12 May 2023 16:15:16 -0300 Subject: [PATCH] fix errors while reordering input maps --- editor/project_settings_editor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/editor/project_settings_editor.cpp b/editor/project_settings_editor.cpp index 95cf9496dc6..17826c8310e 100644 --- a/editor/project_settings_editor.cpp +++ b/editor/project_settings_editor.cpp @@ -451,7 +451,8 @@ void ProjectSettingsEditor::_action_reordered(const String &p_action_name, const for (const PropertyInfo &prop : props) { // Skip builtins and non-inputs - if (ProjectSettings::get_singleton()->is_builtin_setting(prop.name) || !prop.name.begins_with("input/")) { + // Order matters here, checking for "input/" filters out properties that aren't settings and produce errors in is_builtin_setting(). + if (!prop.name.begins_with("input/") || ProjectSettings::get_singleton()->is_builtin_setting(prop.name)) { continue; }