From 9c4c541bca8793aebafbff15cc0f8550b68bbb41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Thu, 20 Jan 2022 08:07:53 +0100 Subject: [PATCH] thorvg: Fix usage of min/max breaking on VS 2017 Fixes https://github.com/godotengine/godot/issues/56894#issuecomment-1015956706. --- .../patches/thorvg-pr1166-vs2017-minmax.patch | 49 +++++++++++++++++++ .../src/lib/sw_engine/tvgSwRenderer.cpp | 9 ++-- thirdparty/thorvg/src/lib/tvgMath.h | 6 ++- 3 files changed, 59 insertions(+), 5 deletions(-) create mode 100644 thirdparty/thorvg/patches/thorvg-pr1166-vs2017-minmax.patch diff --git a/thirdparty/thorvg/patches/thorvg-pr1166-vs2017-minmax.patch b/thirdparty/thorvg/patches/thorvg-pr1166-vs2017-minmax.patch new file mode 100644 index 00000000000..0b045bd05a1 --- /dev/null +++ b/thirdparty/thorvg/patches/thorvg-pr1166-vs2017-minmax.patch @@ -0,0 +1,49 @@ +diff --git a/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp b/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp +index 78537e7726..c75e73760e 100644 +--- a/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp ++++ b/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp +@@ -23,6 +23,7 @@ + #include "tvgSwCommon.h" + #include "tvgTaskScheduler.h" + #include "tvgSwRenderer.h" ++#include "tvgMath.h" + + /************************************************************************/ + /* Internal Class Implementation */ +@@ -594,10 +595,10 @@ void* SwRenderer::prepareCommon(SwTask* task, const RenderTransform* transform, + task->surface = surface; + task->mpool = mpool; + task->flags = flags; +- task->bbox.min.x = max(static_cast(0), static_cast(vport.x)); +- task->bbox.min.y = max(static_cast(0), static_cast(vport.y)); +- task->bbox.max.x = min(static_cast(surface->w), static_cast(vport.x + vport.w)); +- task->bbox.max.y = min(static_cast(surface->h), static_cast(vport.y + vport.h)); ++ task->bbox.min.x = mathMax(static_cast(0), static_cast(vport.x)); ++ task->bbox.min.y = mathMax(static_cast(0), static_cast(vport.y)); ++ task->bbox.max.x = mathMin(static_cast(surface->w), static_cast(vport.x + vport.w)); ++ task->bbox.max.y = mathMin(static_cast(surface->h), static_cast(vport.y + vport.h)); + + if (!task->pushed) { + task->pushed = true; +diff --git a/thirdparty/thorvg/src/lib/tvgMath.h b/thirdparty/thorvg/src/lib/tvgMath.h +index 9e5c915fc3..94b4fe1cf1 100644 +--- a/thirdparty/thorvg/src/lib/tvgMath.h ++++ b/thirdparty/thorvg/src/lib/tvgMath.h +@@ -29,6 +29,10 @@ + #include "tvgCommon.h" + + ++#define mathMin(x, y) (((x) < (y)) ? (x) : (y)) ++#define mathMax(x, y) (((x) > (y)) ? (x) : (y)) ++ ++ + static inline bool mathZero(float a) + { + return (fabsf(a) < FLT_EPSILON) ? true : false; +@@ -154,4 +158,4 @@ static inline Matrix mathMultiply(const Matrix* lhs, const Matrix* rhs) + } + + +-#endif //_TVG_MATH_H_ +\ No newline at end of file ++#endif //_TVG_MATH_H_ diff --git a/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp b/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp index 78537e7726d..c75e73760e0 100644 --- a/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp +++ b/thirdparty/thorvg/src/lib/sw_engine/tvgSwRenderer.cpp @@ -23,6 +23,7 @@ #include "tvgSwCommon.h" #include "tvgTaskScheduler.h" #include "tvgSwRenderer.h" +#include "tvgMath.h" /************************************************************************/ /* Internal Class Implementation */ @@ -594,10 +595,10 @@ void* SwRenderer::prepareCommon(SwTask* task, const RenderTransform* transform, task->surface = surface; task->mpool = mpool; task->flags = flags; - task->bbox.min.x = max(static_cast(0), static_cast(vport.x)); - task->bbox.min.y = max(static_cast(0), static_cast(vport.y)); - task->bbox.max.x = min(static_cast(surface->w), static_cast(vport.x + vport.w)); - task->bbox.max.y = min(static_cast(surface->h), static_cast(vport.y + vport.h)); + task->bbox.min.x = mathMax(static_cast(0), static_cast(vport.x)); + task->bbox.min.y = mathMax(static_cast(0), static_cast(vport.y)); + task->bbox.max.x = mathMin(static_cast(surface->w), static_cast(vport.x + vport.w)); + task->bbox.max.y = mathMin(static_cast(surface->h), static_cast(vport.y + vport.h)); if (!task->pushed) { task->pushed = true; diff --git a/thirdparty/thorvg/src/lib/tvgMath.h b/thirdparty/thorvg/src/lib/tvgMath.h index 9e5c915fc3d..94b4fe1cf18 100644 --- a/thirdparty/thorvg/src/lib/tvgMath.h +++ b/thirdparty/thorvg/src/lib/tvgMath.h @@ -29,6 +29,10 @@ #include "tvgCommon.h" +#define mathMin(x, y) (((x) < (y)) ? (x) : (y)) +#define mathMax(x, y) (((x) > (y)) ? (x) : (y)) + + static inline bool mathZero(float a) { return (fabsf(a) < FLT_EPSILON) ? true : false; @@ -154,4 +158,4 @@ static inline Matrix mathMultiply(const Matrix* lhs, const Matrix* rhs) } -#endif //_TVG_MATH_H_ \ No newline at end of file +#endif //_TVG_MATH_H_