godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #42925 from Chaosus/graph_rename_signals

Browse Source 
Removed underscore from GraphEdit begin/end_node_move signals
This commit is contained in:
Rémi Verschelde 2020-10-20 08:45:16 +02:00 committed by GitHub
commit 9dad483920
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/classes/GraphEdit.xml
View File

@ -193,16 +193,11 @@
</member>
</members>
<signals>
<signal name="_begin_node_move">
<signal name="begin_node_move">
<description>
Emitted at the beginning of a GraphNode movement.
</description>
</signal>
<signal name="_end_node_move">
<description>
Emitted at the end of a GraphNode movement.
</description>
</signal>
<signal name="connection_from_empty">
<argument index="0" name="to" type="StringName">
</argument>
@ -266,6 +261,11 @@
Emitted when a GraphNode is attempted to be duplicated in the GraphEdit.
</description>
</signal>
<signal name="end_node_move">
<description>
Emitted at the end of a GraphNode movement.
</description>
</signal>
<signal name="node_selected">
<argument index="0" name="node" type="Node">
</argument>

4
modules/visual_script/visual_script_editor.cpp
View File

@ -4783,8 +4783,8 @@ VisualScriptEditor::VisualScriptEditor() {
graph->set_v_size_flags(Control::SIZE_EXPAND_FILL);
graph->set_anchors_and_margins_preset(Control::PRESET_WIDE);
graph->connect("node_selected", callable_mp(this, &VisualScriptEditor::_node_selected));
graph->connect("_begin_node_move", callable_mp(this, &VisualScriptEditor::_begin_node_move));
graph->connect("_end_node_move", callable_mp(this, &VisualScriptEditor::_end_node_move));
graph->connect("begin_node_move", callable_mp(this, &VisualScriptEditor::_begin_node_move));
graph->connect("end_node_move", callable_mp(this, &VisualScriptEditor::_end_node_move));
graph->connect("delete_nodes_request", callable_mp(this, &VisualScriptEditor::_on_nodes_delete));
graph->connect("duplicate_nodes_request", callable_mp(this, &VisualScriptEditor::_on_nodes_duplicate));
graph->connect("gui_input", callable_mp(this, &VisualScriptEditor::_graph_gui_input));

8
scene/gui/graph_edit.cpp
View File

@ -776,7 +776,7 @@ void GraphEdit::_gui_input(const Ref<InputEvent> &p_ev) {
if (mm.is_valid() && dragging) {
if (!moving_selection) {
emit_signal("_begin_node_move");
emit_signal("begin_node_move");
moving_selection = true;
}
@ -895,7 +895,7 @@ void GraphEdit::_gui_input(const Ref<InputEvent> &p_ev) {
}
if (moving_selection) {
emit_signal("_end_node_move");
emit_signal("end_node_move");
moving_selection = false;
}
@ -1287,8 +1287,8 @@ void GraphEdit::_bind_methods() {
ADD_SIGNAL(MethodInfo("connection_to_empty", PropertyInfo(Variant::STRING_NAME, "from"), PropertyInfo(Variant::INT, "from_slot"), PropertyInfo(Variant::VECTOR2, "release_position")));
ADD_SIGNAL(MethodInfo("connection_from_empty", PropertyInfo(Variant::STRING_NAME, "to"), PropertyInfo(Variant::INT, "to_slot"), PropertyInfo(Variant::VECTOR2, "release_position")));
ADD_SIGNAL(MethodInfo("delete_nodes_request"));
ADD_SIGNAL(MethodInfo("_begin_node_move"));
ADD_SIGNAL(MethodInfo("_end_node_move"));
ADD_SIGNAL(MethodInfo("begin_node_move"));
ADD_SIGNAL(MethodInfo("end_node_move"));
ADD_SIGNAL(MethodInfo("scroll_offset_changed", PropertyInfo(Variant::VECTOR2, "ofs")));
}