godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #67336 from jbcolli2/Normal-of-CylinderMesh 

Fix bug in CylinderMesh when computing normals
This commit is contained in:
Rémi Verschelde 2022-10-13 15:24:55 +02:00
parent 58822717ff 491ec622f6
commit 9eb8eb5f7d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scene/resources/primitive_meshes.cpp
View File

@ -771,6 +771,7 @@ void CylinderMesh::create_mesh_array(Array &p_arr, float top_radius, float botto
thisrow = 0; thisrow = 0;
prevrow = 0; prevrow = 0;
const real_t side_normal_y = (bottom_radius - top_radius) / height;
for (j = 0; j <= (rings + 1); j++) { for (j = 0; j <= (rings + 1); j++) {
v = j; v = j;
v /= (rings + 1); v /= (rings + 1);
@ -789,7 +790,7 @@ void CylinderMesh::create_mesh_array(Array &p_arr, float top_radius, float botto
Vector3 p = Vector3(x * radius, y, z * radius); Vector3 p = Vector3(x * radius, y, z * radius);
points.push_back(p); points.push_back(p);
normals.push_back(Vector3(x, 0.0, z)); normals.push_back(Vector3(x, side_normal_y, z).normalized());
ADD_TANGENT(z, 0.0, -x, 1.0) ADD_TANGENT(z, 0.0, -x, 1.0)
uvs.push_back(Vector2(u, v * 0.5)); uvs.push_back(Vector2(u, v * 0.5));
point++; point++;