godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Linux: Don't attempt linking embree3 on non-tools, link it for headless too

Browse Source 
`tech_debt++`, that's what we get for not taking the time to cleanup all this
and do it right...

Follow-up to #48073 and #48102.
This commit is contained in:
Rémi Verschelde 2021-04-23 10:25:51 +02:00
parent adaf488963
commit a14b51df92
No known key found for this signature in database
GPG Key ID: C3336907360768E1
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
platform/server/detect.py
View File

@ -222,6 +222,13 @@ def configure(env):
if not env["builtin_pcre2"]: if not env["builtin_pcre2"]:
env.ParseConfig("pkg-config libpcre2-32 --cflags --libs") env.ParseConfig("pkg-config libpcre2-32 --cflags --libs")
# Embree is only compatible with x86_64. Yet another unreliable hack that will break
# cross-compilation, this will really need to be handle better. Thankfully only affects
# people who disable builtin_embree (likely distro packagers).
if env["tools"] and not env["builtin_embree"] and (is64 and platform.machine() == "x86_64"):
# No pkgconfig file so far, hardcode expected lib name.
env.Append(LIBS=["embree3"])
## Flags ## Flags
# Linkflags below this line should typically stay the last ones # Linkflags below this line should typically stay the last ones

2
platform/x11/detect.py
View File

@ -313,7 +313,7 @@ def configure(env):
# Embree is only compatible with x86_64. Yet another unreliable hack that will break # Embree is only compatible with x86_64. Yet another unreliable hack that will break
# cross-compilation, this will really need to be handle better. Thankfully only affects # cross-compilation, this will really need to be handle better. Thankfully only affects
# people who disable builtin_embree (likely distro packagers). # people who disable builtin_embree (likely distro packagers).
if not env["builtin_embree"] and (is64 and platform.machine() == "x86_64"): if env["tools"] and not env["builtin_embree"] and (is64 and platform.machine() == "x86_64"):
# No pkgconfig file so far, hardcode expected lib name. # No pkgconfig file so far, hardcode expected lib name.
env.Append(LIBS=["embree3"]) env.Append(LIBS=["embree3"])