godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add shorthand for using singleton string names

This commit is contained in:
kobewi 2023-09-04 17:01:33 +02:00
parent 916ea002c1
commit a262d2d881
77 changed files with 382 additions and 380 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/config/project_settings.cpp
View File

@ -291,7 +291,7 @@ bool ProjectSettings::_set(const StringName &p_name, const Variant &p_value) {
} }
} }
} else { } else {
if (p_name == CoreStringNames::get_singleton()->_custom_features) { if (p_name == CoreStringName(_custom_features)) {
Vector<String> custom_feature_array = String(p_value).split(","); Vector<String> custom_feature_array = String(p_value).split(",");
for (int i = 0; i < custom_feature_array.size(); i++) { for (int i = 0; i < custom_feature_array.size(); i++) {
custom_features.insert(custom_feature_array[i]); custom_features.insert(custom_feature_array[i]);
@ -875,7 +875,7 @@ Error ProjectSettings::_save_settings_binary(const String &p_file, const RBMap<S
if (!p_custom_features.is_empty()) { if (!p_custom_features.is_empty()) {
// Store how many properties are saved, add one for custom features, which must always go first. // Store how many properties are saved, add one for custom features, which must always go first.
file->store_32(count + 1); file->store_32(count + 1);
String key = CoreStringNames::get_singleton()->_custom_features; String key = CoreStringName(_custom_features);
file->store_pascal_string(key); file->store_pascal_string(key);
int len; int len;

6
core/core_string_names.cpp
View File

@ -33,12 +33,10 @@
CoreStringNames *CoreStringNames::singleton = nullptr; CoreStringNames *CoreStringNames::singleton = nullptr;
CoreStringNames::CoreStringNames() : CoreStringNames::CoreStringNames() :
_free(StaticCString::create("free")), free_(StaticCString::create("free")),
changed(StaticCString::create("changed")), changed(StaticCString::create("changed")),
_script(StaticCString::create("script")), script(StaticCString::create("script")),
script_changed(StaticCString::create("script_changed")), script_changed(StaticCString::create("script_changed")),
___pdcdata(StaticCString::create("___pdcdata")),
__getvar(StaticCString::create("__getvar")),
_iter_init(StaticCString::create("_iter_init")), _iter_init(StaticCString::create("_iter_init")),
_iter_next(StaticCString::create("_iter_next")), _iter_next(StaticCString::create("_iter_next")),
_iter_get(StaticCString::create("_iter_get")), _iter_get(StaticCString::create("_iter_get")),

8
core/core_string_names.h
View File

@ -50,12 +50,10 @@ public:
static CoreStringNames *singleton; static CoreStringNames *singleton;
StringName _free; StringName free_; // "free", conflict with C++ keyword.
StringName changed; StringName changed;
StringName _script; StringName script;
StringName script_changed; StringName script_changed;
StringName ___pdcdata;
StringName __getvar;
StringName _iter_init; StringName _iter_init;
StringName _iter_next; StringName _iter_next;
StringName _iter_get; StringName _iter_get;
@ -98,4 +96,6 @@ public:
StringName property_list_changed; StringName property_list_changed;
}; };
#define CoreStringName(m_name) CoreStringNames::get_singleton()->m_name
#endif // CORE_STRING_NAMES_H #endif // CORE_STRING_NAMES_H

2
core/io/marshalls.cpp
View File

@ -1696,7 +1696,7 @@ Error encode_variant(const Variant &p_variant, uint8_t *r_buffer, int &r_len, bo
Variant value; Variant value;
if (E.name == CoreStringNames::get_singleton()->_script) { if (E.name == CoreStringName(script)) {
Ref<Script> script = obj->get_script(); Ref<Script> script = obj->get_script();
if (script.is_valid()) { if (script.is_valid()) {
String path = script->get_path(); String path = script->get_path();

12
core/io/resource.cpp
View File

@ -43,9 +43,9 @@
void Resource::emit_changed() { void Resource::emit_changed() {
if (ResourceLoader::is_within_load() && !Thread::is_main_thread()) { if (ResourceLoader::is_within_load() && !Thread::is_main_thread()) {
// Let the connection happen on the main thread, later, since signals are not thread-safe. // Let the connection happen on the main thread, later, since signals are not thread-safe.
call_deferred("emit_signal", CoreStringNames::get_singleton()->changed); call_deferred("emit_signal", CoreStringName(changed));
} else { } else {
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
} }
@ -172,8 +172,8 @@ void Resource::connect_changed(const Callable &p_callable, uint32_t p_flags) {
callable_mp(this, &Resource::connect_changed).call_deferred(p_callable, p_flags); callable_mp(this, &Resource::connect_changed).call_deferred(p_callable, p_flags);
return; return;
} }
if (!is_connected(CoreStringNames::get_singleton()->changed, p_callable) || p_flags & CONNECT_REFERENCE_COUNTED) { if (!is_connected(CoreStringName(changed), p_callable) || p_flags & CONNECT_REFERENCE_COUNTED) {
connect(CoreStringNames::get_singleton()->changed, p_callable, p_flags); connect(CoreStringName(changed), p_callable, p_flags);
} }
} }
@ -183,8 +183,8 @@ void Resource::disconnect_changed(const Callable &p_callable) {
callable_mp(this, &Resource::disconnect_changed).call_deferred(p_callable); callable_mp(this, &Resource::disconnect_changed).call_deferred(p_callable);
return; return;
} }
if (is_connected(CoreStringNames::get_singleton()->changed, p_callable)) { if (is_connected(CoreStringName(changed), p_callable)) {
disconnect(CoreStringNames::get_singleton()->changed, p_callable); disconnect(CoreStringName(changed), p_callable);
} }
} }

2
core/object/class_db.cpp
View File

@ -1554,7 +1554,7 @@ bool ClassDB::get_property(Object *p_object, const StringName &p_property, Varia
} }
// The "free()" method is special, so we assume it exists and return a Callable. // The "free()" method is special, so we assume it exists and return a Callable.
if (p_property == CoreStringNames::get_singleton()->_free) { if (p_property == CoreStringName(free_)) {
r_value = Callable(p_object, p_property); r_value = Callable(p_object, p_property);
return true; return true;
} }

2
core/object/message_queue.cpp
View File

@ -197,7 +197,7 @@ Error CallQueue::push_notification(ObjectID p_id, int p_notification) {
Message *msg = memnew_placement(buffer_end, Message); Message *msg = memnew_placement(buffer_end, Message);
msg->type = TYPE_NOTIFICATION; msg->type = TYPE_NOTIFICATION;
msg->callable = Callable(p_id, CoreStringNames::get_singleton()->notification); //name is meaningless but callable needs it msg->callable = Callable(p_id, CoreStringName(notification)); //name is meaningless but callable needs it
//msg->target; //msg->target;
msg->notification = p_notification; msg->notification = p_notification;

16
core/object/object.cpp
View File

@ -260,7 +260,7 @@ void Object::set(const StringName &p_name, const Variant &p_value, bool *r_valid
} }
} }
if (p_name == CoreStringNames::get_singleton()->_script) { if (p_name == CoreStringName(script)) {
set_script(p_value); set_script(p_value);
if (r_valid) { if (r_valid) {
*r_valid = true; *r_valid = true;
@ -351,7 +351,7 @@ Variant Object::get(const StringName &p_name, bool *r_valid) const {
} }
} }
if (p_name == CoreStringNames::get_singleton()->_script) { if (p_name == CoreStringName(script)) {
ret = get_script(); ret = get_script();
if (r_valid) { if (r_valid) {
*r_valid = true; *r_valid = true;
@ -672,7 +672,7 @@ Variant Object::_call_deferred_bind(const Variant **p_args, int p_argcount, Call
} }
bool Object::has_method(const StringName &p_method) const { bool Object::has_method(const StringName &p_method) const {
if (p_method == CoreStringNames::get_singleton()->_free) { if (p_method == CoreStringName(free_)) {
return true; return true;
} }
@ -698,7 +698,7 @@ int Object::_get_method_argument_count_bind(const StringName &p_method) const {
} }
int Object::get_method_argument_count(const StringName &p_method, bool *r_is_valid) const { int Object::get_method_argument_count(const StringName &p_method, bool *r_is_valid) const {
if (p_method == CoreStringNames::get_singleton()->_free) { if (p_method == CoreStringName(free_)) {
if (r_is_valid) { if (r_is_valid) {
*r_is_valid = true; *r_is_valid = true;
} }
@ -787,7 +787,7 @@ Variant Object::callv(const StringName &p_method, const Array &p_args) {
Variant Object::callp(const StringName &p_method, const Variant **p_args, int p_argcount, Callable::CallError &r_error) { Variant Object::callp(const StringName &p_method, const Variant **p_args, int p_argcount, Callable::CallError &r_error) {
r_error.error = Callable::CallError::CALL_OK; r_error.error = Callable::CallError::CALL_OK;
if (p_method == CoreStringNames::get_singleton()->_free) { if (p_method == CoreStringName(free_)) {
//free must be here, before anything, always ready //free must be here, before anything, always ready
#ifdef DEBUG_ENABLED #ifdef DEBUG_ENABLED
if (p_argcount != 0) { if (p_argcount != 0) {
@ -850,7 +850,7 @@ Variant Object::callp(const StringName &p_method, const Variant **p_args, int p_
Variant Object::call_const(const StringName &p_method, const Variant **p_args, int p_argcount, Callable::CallError &r_error) { Variant Object::call_const(const StringName &p_method, const Variant **p_args, int p_argcount, Callable::CallError &r_error) {
r_error.error = Callable::CallError::CALL_OK; r_error.error = Callable::CallError::CALL_OK;
if (p_method == CoreStringNames::get_singleton()->_free) { if (p_method == CoreStringName(free_)) {
// Free is not const, so fail. // Free is not const, so fail.
r_error.error = Callable::CallError::CALL_ERROR_METHOD_NOT_CONST; r_error.error = Callable::CallError::CALL_ERROR_METHOD_NOT_CONST;
return Variant(); return Variant();
@ -979,7 +979,7 @@ void Object::set_script(const Variant &p_script) {
} }
notify_property_list_changed(); //scripts may add variables, so refresh is desired notify_property_list_changed(); //scripts may add variables, so refresh is desired
emit_signal(CoreStringNames::get_singleton()->script_changed); emit_signal(CoreStringName(script_changed));
} }
void Object::set_script_instance(ScriptInstance *p_instance) { void Object::set_script_instance(ScriptInstance *p_instance) {
@ -1654,7 +1654,7 @@ void Object::clear_internal_resource_paths() {
} }
void Object::notify_property_list_changed() { void Object::notify_property_list_changed() {
emit_signal(CoreStringNames::get_singleton()->property_list_changed); emit_signal(CoreStringName(property_list_changed));
} }
void Object::_bind_methods() { void Object::_bind_methods() {

2
core/variant/variant.cpp
View File

@ -2121,7 +2121,7 @@ Variant::operator ::RID() const {
} }
#endif #endif
Callable::CallError ce; Callable::CallError ce;
Variant ret = _get_obj().obj->callp(CoreStringNames::get_singleton()->get_rid, nullptr, 0, ce); Variant ret = _get_obj().obj->callp(CoreStringName(get_rid), nullptr, 0, ce);
if (ce.error == Callable::CallError::CALL_OK && ret.get_type() == Variant::RID) { if (ce.error == Callable::CallError::CALL_OK && ret.get_type() == Variant::RID) {
return ret; return ret;
} }

6
core/variant/variant_setget.cpp
View File

@ -1384,7 +1384,7 @@ bool Variant::iter_init(Variant &r_iter, bool &valid) const {
ref.push_back(r_iter); ref.push_back(r_iter);
Variant vref = ref; Variant vref = ref;
const Variant *refp[] = { &vref }; const Variant *refp[] = { &vref };
Variant ret = _get_obj().obj->callp(CoreStringNames::get_singleton()->_iter_init, refp, 1, ce); Variant ret = _get_obj().obj->callp(CoreStringName(_iter_init), refp, 1, ce);
if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) { if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) {
valid = false; valid = false;
@ -1619,7 +1619,7 @@ bool Variant::iter_next(Variant &r_iter, bool &valid) const {
ref.push_back(r_iter); ref.push_back(r_iter);
Variant vref = ref; Variant vref = ref;
const Variant *refp[] = { &vref }; const Variant *refp[] = { &vref };
Variant ret = _get_obj().obj->callp(CoreStringNames::get_singleton()->_iter_next, refp, 1, ce); Variant ret = _get_obj().obj->callp(CoreStringName(_iter_next), refp, 1, ce);
if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) { if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) {
valid = false; valid = false;
@ -1811,7 +1811,7 @@ Variant Variant::iter_get(const Variant &r_iter, bool &r_valid) const {
Callable::CallError ce; Callable::CallError ce;
ce.error = Callable::CallError::CALL_OK; ce.error = Callable::CallError::CALL_OK;
const Variant *refp[] = { &r_iter }; const Variant *refp[] = { &r_iter };
Variant ret = _get_obj().obj->callp(CoreStringNames::get_singleton()->_iter_get, refp, 1, ce); Variant ret = _get_obj().obj->callp(CoreStringName(_iter_get), refp, 1, ce);
if (ce.error != Callable::CallError::CALL_OK) { if (ce.error != Callable::CallError::CALL_OK) {
r_valid = false; r_valid = false;

4
editor/action_map_editor.cpp
View File

@ -547,8 +547,8 @@ ActionMapEditor::ActionMapEditor() {
action_list_search_by_event->set_h_size_flags(Control::SIZE_EXPAND_FILL); action_list_search_by_event->set_h_size_flags(Control::SIZE_EXPAND_FILL);
action_list_search_by_event->set_stretch_ratio(0.75); action_list_search_by_event->set_stretch_ratio(0.75);
action_list_search_by_event->connect("event_changed", callable_mp(this, &ActionMapEditor::_search_by_event)); action_list_search_by_event->connect("event_changed", callable_mp(this, &ActionMapEditor::_search_by_event));
action_list_search_by_event->connect(SceneStringNames::get_singleton()->focus_entered, callable_mp(this, &ActionMapEditor::_on_filter_focused)); action_list_search_by_event->connect(SceneStringName(focus_entered), callable_mp(this, &ActionMapEditor::_on_filter_focused));
action_list_search_by_event->connect(SceneStringNames::get_singleton()->focus_exited, callable_mp(this, &ActionMapEditor::_on_filter_unfocused)); action_list_search_by_event->connect(SceneStringName(focus_exited), callable_mp(this, &ActionMapEditor::_on_filter_unfocused));
top_hbox->add_child(action_list_search_by_event); top_hbox->add_child(action_list_search_by_event);
Button *clear_all_search = memnew(Button); Button *clear_all_search = memnew(Button);

20
editor/animation_track_editor.cpp
View File

@ -2932,7 +2932,7 @@ void AnimationTrackEdit::gui_input(const Ref<InputEvent> &p_event) {
} }
if (selected || editor->is_selection_active()) { if (selected || editor->is_selection_active()) {
AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player(); AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player();
if (!player->has_animation(SceneStringNames::get_singleton()->RESET) || animation != player->get_animation(SceneStringNames::get_singleton()->RESET)) { if (!player->has_animation(SceneStringName(RESET)) || animation != player->get_animation(SceneStringName(RESET))) {
menu->add_icon_item(get_editor_theme_icon(SNAME("Reload")), TTR("Add RESET Value(s)"), MENU_KEY_ADD_RESET); menu->add_icon_item(get_editor_theme_icon(SNAME("Reload")), TTR("Add RESET Value(s)"), MENU_KEY_ADD_RESET);
} }
@ -3691,8 +3691,8 @@ void AnimationTrackEditor::_animation_track_remove_request(int p_track, Ref<Anim
// Remove corresponding reset tracks if they are no longer needed. // Remove corresponding reset tracks if they are no longer needed.
AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player(); AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player();
if (player->has_animation(SceneStringNames::get_singleton()->RESET)) { if (player->has_animation(SceneStringName(RESET))) {
Ref<Animation> reset = player->get_animation(SceneStringNames::get_singleton()->RESET); Ref<Animation> reset = player->get_animation(SceneStringName(RESET));
if (reset != p_from_animation) { if (reset != p_from_animation) {
for (int i = 0; i < reset->get_track_count(); i++) { for (int i = 0; i < reset->get_track_count(); i++) {
if (reset->track_get_path(i) == p_from_animation->track_get_path(p_track)) { if (reset->track_get_path(i) == p_from_animation->track_get_path(p_track)) {
@ -3798,7 +3798,7 @@ void AnimationTrackEditor::make_insert_queue() {
void AnimationTrackEditor::commit_insert_queue() { void AnimationTrackEditor::commit_insert_queue() {
bool reset_allowed = true; bool reset_allowed = true;
AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player(); AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player();
if (player->has_animation(SceneStringNames::get_singleton()->RESET) && player->get_animation(SceneStringNames::get_singleton()->RESET) == animation) { if (player->has_animation(SceneStringName(RESET)) && player->get_animation(SceneStringName(RESET)) == animation) {
// Avoid messing with the reset animation itself. // Avoid messing with the reset animation itself.
reset_allowed = false; reset_allowed = false;
} else { } else {
@ -4207,8 +4207,8 @@ void AnimationTrackEditor::insert_value_key(const String &p_property, const Vari
Ref<Animation> AnimationTrackEditor::_create_and_get_reset_animation() { Ref<Animation> AnimationTrackEditor::_create_and_get_reset_animation() {
AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player(); AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player();
if (player->has_animation(SceneStringNames::get_singleton()->RESET)) { if (player->has_animation(SceneStringName(RESET))) {
return player->get_animation(SceneStringNames::get_singleton()->RESET); return player->get_animation(SceneStringName(RESET));
} else { } else {
Ref<AnimationLibrary> al; Ref<AnimationLibrary> al;
AnimationMixer *mixer = AnimationPlayerEditor::get_singleton()->fetch_mixer_for_library(); AnimationMixer *mixer = AnimationPlayerEditor::get_singleton()->fetch_mixer_for_library();
@ -4224,9 +4224,9 @@ Ref<Animation> AnimationTrackEditor::_create_and_get_reset_animation() {
reset_anim.instantiate(); reset_anim.instantiate();
reset_anim->set_length(ANIM_MIN_LENGTH); reset_anim->set_length(ANIM_MIN_LENGTH);
EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton(); EditorUndoRedoManager *undo_redo = EditorUndoRedoManager::get_singleton();
undo_redo->add_do_method(al.ptr(), "add_animation", SceneStringNames::get_singleton()->RESET, reset_anim); undo_redo->add_do_method(al.ptr(), "add_animation", SceneStringName(RESET), reset_anim);
undo_redo->add_do_method(AnimationPlayerEditor::get_singleton(), "_animation_player_changed", player); undo_redo->add_do_method(AnimationPlayerEditor::get_singleton(), "_animation_player_changed", player);
undo_redo->add_undo_method(al.ptr(), "remove_animation", SceneStringNames::get_singleton()->RESET); undo_redo->add_undo_method(al.ptr(), "remove_animation", SceneStringName(RESET));
undo_redo->add_undo_method(AnimationPlayerEditor::get_singleton(), "_animation_player_changed", player); undo_redo->add_undo_method(AnimationPlayerEditor::get_singleton(), "_animation_player_changed", player);
return reset_anim; return reset_anim;
} }
@ -5024,8 +5024,8 @@ void AnimationTrackEditor::_add_track(int p_type) {
void AnimationTrackEditor::_fetch_value_track_options(const NodePath &p_path, Animation::UpdateMode *r_update_mode, Animation::InterpolationType *r_interpolation_type, bool *r_loop_wrap) { void AnimationTrackEditor::_fetch_value_track_options(const NodePath &p_path, Animation::UpdateMode *r_update_mode, Animation::InterpolationType *r_interpolation_type, bool *r_loop_wrap) {
AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player(); AnimationPlayer *player = AnimationPlayerEditor::get_singleton()->get_player();
if (player->has_animation(SceneStringNames::get_singleton()->RESET)) { if (player->has_animation(SceneStringName(RESET))) {
Ref<Animation> reset_anim = player->get_animation(SceneStringNames::get_singleton()->RESET); Ref<Animation> reset_anim = player->get_animation(SceneStringName(RESET));
int rt = reset_anim->find_track(p_path, Animation::TrackType::TYPE_VALUE); int rt = reset_anim->find_track(p_path, Animation::TrackType::TYPE_VALUE);
if (rt >= 0) { if (rt >= 0) {
*r_update_mode = reset_anim->value_track_get_update_mode(rt); *r_update_mode = reset_anim->value_track_get_update_mode(rt);

2
editor/editor_properties.cpp
View File

@ -3141,7 +3141,7 @@ void EditorPropertyResource::_resource_changed(const Ref<Resource> &p_resource)
// Changing the value of Script-type exported variables of the main script should not trigger saving/reloading properties. // Changing the value of Script-type exported variables of the main script should not trigger saving/reloading properties.
bool is_script = false; bool is_script = false;
Ref<Script> s = p_resource; Ref<Script> s = p_resource;
if (get_edited_object() && s.is_valid() && get_edited_property() == CoreStringNames::get_singleton()->_script) { if (get_edited_object() && s.is_valid() && get_edited_property() == CoreStringName(script)) {
is_script = true; is_script = true;
InspectorDock::get_singleton()->store_script_properties(get_edited_object()); InspectorDock::get_singleton()->store_script_properties(get_edited_object());
s->call("set_instance_base_type", get_edited_object()->get_class()); s->call("set_instance_base_type", get_edited_object()->get_class());

10
editor/plugins/animation_player_editor_plugin.cpp
View File

@ -984,12 +984,12 @@ void AnimationPlayerEditor::_update_animation_list_icons() {
Ref<Texture2D> icon; Ref<Texture2D> icon;
if (anim_name == player->get_autoplay()) { if (anim_name == player->get_autoplay()) {
if (anim_name == SceneStringNames::get_singleton()->RESET) { if (anim_name == SceneStringName(RESET)) {
icon = autoplay_reset_icon; icon = autoplay_reset_icon;
} else { } else {
icon = autoplay_icon; icon = autoplay_icon;
} }
} else if (anim_name == SceneStringNames::get_singleton()->RESET) { } else if (anim_name == SceneStringName(RESET)) {
icon = reset_icon; icon = reset_icon;
} }
@ -1459,7 +1459,7 @@ void AnimationPlayerEditor::_onion_skinning_menu(int p_option) {
onion.enabled = !onion.enabled; onion.enabled = !onion.enabled;
if (onion.enabled) { if (onion.enabled) {
if (get_player() && !get_player()->has_animation(SceneStringNames::get_singleton()->RESET)) { if (get_player() && !get_player()->has_animation(SceneStringName(RESET))) {
EditorNode::get_singleton()->show_warning(TTR("Onion skinning requires a RESET animation.")); EditorNode::get_singleton()->show_warning(TTR("Onion skinning requires a RESET animation."));
} }
_start_onion_skinning(); // It will check for RESET animation anyway. _start_onion_skinning(); // It will check for RESET animation anyway.
@ -1592,7 +1592,7 @@ void AnimationPlayerEditor::_prepare_onion_layers_1() {
return; return;
} }
if (!onion.enabled || !is_visible() || !get_player() || !get_player()->has_animation(SceneStringNames::get_singleton()->RESET)) { if (!onion.enabled || !is_visible() || !get_player() || !get_player()->has_animation(SceneStringName(RESET))) {
_stop_onion_skinning(); _stop_onion_skinning();
return; return;
} }
@ -1783,7 +1783,7 @@ void AnimationPlayerEditor::_prepare_onion_layers_2_epilog() {
} }
void AnimationPlayerEditor::_start_onion_skinning() { void AnimationPlayerEditor::_start_onion_skinning() {
if (get_player() && !get_player()->has_animation(SceneStringNames::get_singleton()->RESET)) { if (get_player() && !get_player()->has_animation(SceneStringName(RESET))) {
onion.enabled = false; onion.enabled = false;
onion_toggle->set_pressed_no_signal(false); onion_toggle->set_pressed_no_signal(false);
return; return;

2
editor/plugins/animation_state_machine_editor.cpp
View File

@ -119,7 +119,7 @@ String AnimationNodeStateMachineEditor::_get_root_playback_path(String &r_node_d
if (node_directory_path.size()) { if (node_directory_path.size()) {
r_node_directory += "/"; r_node_directory += "/";
} }
base_path = !edited_path.size() ? String(SceneStringNames::get_singleton()->parameters_base_path) + "playback" : String(SceneStringNames::get_singleton()->parameters_base_path) + base_path + "/playback"; base_path = !edited_path.size() ? String(SceneStringName(parameters_base_path)) + "playback" : String(SceneStringName(parameters_base_path)) + base_path + "/playback";
} else { } else {
// Hmmm, we have to return Grouped state machine playback... // Hmmm, we have to return Grouped state machine playback...
// It will give the user the error that Root/Nested state machine should be retrieved, that would be kind :-) // It will give the user the error that Root/Nested state machine should be retrieved, that would be kind :-)

2
editor/plugins/animation_tree_editor_plugin.cpp
View File

@ -221,7 +221,7 @@ void AnimationTreeEditor::remove_plugin(AnimationTreeNodeEditorPlugin *p_editor)
} }
String AnimationTreeEditor::get_base_path() { String AnimationTreeEditor::get_base_path() {
String path = SceneStringNames::get_singleton()->parameters_base_path; String path = SceneStringName(parameters_base_path);
for (int i = 0; i < edited_path.size(); i++) { for (int i = 0; i < edited_path.size(); i++) {
path += edited_path[i] + "/"; path += edited_path[i] + "/";
} }

4
editor/plugins/collision_shape_2d_editor_plugin.cpp
View File

@ -387,7 +387,7 @@ void CollisionShape2DEditor::_shape_changed() {
canvas_item_editor->update_viewport(); canvas_item_editor->update_viewport();
if (current_shape.is_valid()) { if (current_shape.is_valid()) {
current_shape->disconnect(SceneStringNames::get_singleton()->changed, callable_mp(canvas_item_editor, &CanvasItemEditor::update_viewport)); current_shape->disconnect_changed(callable_mp(canvas_item_editor, &CanvasItemEditor::update_viewport));
current_shape = Ref<Shape2D>(); current_shape = Ref<Shape2D>();
shape_type = -1; shape_type = -1;
} }
@ -399,7 +399,7 @@ void CollisionShape2DEditor::_shape_changed() {
current_shape = node->get_shape(); current_shape = node->get_shape();
if (current_shape.is_valid()) { if (current_shape.is_valid()) {
current_shape->connect(SceneStringNames::get_singleton()->changed, callable_mp(canvas_item_editor, &CanvasItemEditor::update_viewport)); current_shape->connect_changed(callable_mp(canvas_item_editor, &CanvasItemEditor::update_viewport));
} else { } else {
return; return;
} }

10
editor/plugins/mesh_instance_3d_editor_plugin.cpp
View File

@ -172,14 +172,14 @@ void MeshInstance3DEditor::_create_collision_shape() {
ur->add_do_method(instance, "add_child", body, true); ur->add_do_method(instance, "add_child", body, true);
ur->add_do_method(body, "set_owner", owner); ur->add_do_method(body, "set_owner", owner);
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, body); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), body);
for (Ref<Shape3D> shape : shapes) { for (Ref<Shape3D> shape : shapes) {
CollisionShape3D *cshape = memnew(CollisionShape3D); CollisionShape3D *cshape = memnew(CollisionShape3D);
cshape->set_shape(shape); cshape->set_shape(shape);
body->add_child(cshape, true); body->add_child(cshape, true);
ur->add_do_method(cshape, "set_owner", owner); ur->add_do_method(cshape, "set_owner", owner);
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, cshape); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), cshape);
} }
ur->add_do_reference(body); ur->add_do_reference(body);
ur->add_undo_method(instance, "remove_child", body); ur->add_undo_method(instance, "remove_child", body);
@ -191,7 +191,7 @@ void MeshInstance3DEditor::_create_collision_shape() {
cshape->set_transform(node->get_transform()); cshape->set_transform(node->get_transform());
ur->add_do_method(E, "add_sibling", cshape, true); ur->add_do_method(E, "add_sibling", cshape, true);
ur->add_do_method(cshape, "set_owner", owner); ur->add_do_method(cshape, "set_owner", owner);
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, cshape); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), cshape);
ur->add_do_reference(cshape); ur->add_do_reference(cshape);
ur->add_undo_method(node->get_parent(), "remove_child", cshape); ur->add_undo_method(node->get_parent(), "remove_child", cshape);
} }
@ -232,7 +232,7 @@ void MeshInstance3DEditor::_menu_option(int p_option) {
ur->add_do_method(node, "add_child", nmi, true); ur->add_do_method(node, "add_child", nmi, true);
ur->add_do_method(nmi, "set_owner", owner); ur->add_do_method(nmi, "set_owner", owner);
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, nmi); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), nmi);
ur->add_do_reference(nmi); ur->add_do_reference(nmi);
ur->add_undo_method(node, "remove_child", nmi); ur->add_undo_method(node, "remove_child", nmi);
@ -509,7 +509,7 @@ void MeshInstance3DEditor::_create_outline_mesh() {
ur->add_do_method(node, "add_child", mi, true); ur->add_do_method(node, "add_child", mi, true);
ur->add_do_method(mi, "set_owner", owner); ur->add_do_method(mi, "set_owner", owner);
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, mi); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), mi);
ur->add_do_reference(mi); ur->add_do_reference(mi);
ur->add_undo_method(node, "remove_child", mi); ur->add_undo_method(node, "remove_child", mi);

4
editor/plugins/script_editor_plugin.cpp
View File

@ -973,7 +973,7 @@ void ScriptEditor::_queue_close_tabs() {
// Maybe there are unsaved changes. // Maybe there are unsaved changes.
if (se->is_unsaved()) { if (se->is_unsaved()) {
_ask_close_current_unsaved_tab(se); _ask_close_current_unsaved_tab(se);
erase_tab_confirm->connect(SceneStringNames::get_singleton()->visibility_changed, callable_mp(this, &ScriptEditor::_queue_close_tabs), CONNECT_ONE_SHOT); erase_tab_confirm->connect(SceneStringName(visibility_changed), callable_mp(this, &ScriptEditor::_queue_close_tabs), CONNECT_ONE_SHOT);
break; break;
} }
} }
@ -4238,7 +4238,7 @@ ScriptEditor::ScriptEditor(WindowWrapper *p_wrapper) {
autosave_timer = memnew(Timer); autosave_timer = memnew(Timer);
autosave_timer->set_one_shot(false); autosave_timer->set_one_shot(false);
autosave_timer->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &ScriptEditor::_update_autosave_timer)); autosave_timer->connect(SceneStringName(tree_entered), callable_mp(this, &ScriptEditor::_update_autosave_timer));
autosave_timer->connect("timeout", callable_mp(this, &ScriptEditor::_autosave_scripts)); autosave_timer->connect("timeout", callable_mp(this, &ScriptEditor::_autosave_scripts));
add_child(autosave_timer); add_child(autosave_timer);

20
editor/plugins/skeleton_3d_editor_plugin.cpp
View File

@ -410,8 +410,8 @@ void Skeleton3DEditor::create_physical_skeleton() {
ur->add_do_method(physical_bone, "set_joint_type", PhysicalBone3D::JOINT_TYPE_PIN); ur->add_do_method(physical_bone, "set_joint_type", PhysicalBone3D::JOINT_TYPE_PIN);
} }
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, physical_bone); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), physical_bone);
ur->add_do_method(Node3DEditor::get_singleton(), SceneStringNames::get_singleton()->_request_gizmo, collision_shape); ur->add_do_method(Node3DEditor::get_singleton(), SceneStringName(_request_gizmo), collision_shape);
ur->add_do_reference(physical_bone); ur->add_do_reference(physical_bone);
ur->add_undo_method(simulator, "remove_child", physical_bone); ur->add_undo_method(simulator, "remove_child", physical_bone);
@ -842,10 +842,10 @@ void Skeleton3DEditor::_notification(int p_what) {
joint_tree->connect("item_selected", callable_mp(this, &Skeleton3DEditor::_joint_tree_selection_changed)); joint_tree->connect("item_selected", callable_mp(this, &Skeleton3DEditor::_joint_tree_selection_changed));
joint_tree->connect("item_mouse_selected", callable_mp(this, &Skeleton3DEditor::_joint_tree_rmb_select)); joint_tree->connect("item_mouse_selected", callable_mp(this, &Skeleton3DEditor::_joint_tree_rmb_select));
#ifdef TOOLS_ENABLED #ifdef TOOLS_ENABLED
skeleton->connect(SceneStringNames::get_singleton()->pose_updated, callable_mp(this, &Skeleton3DEditor::_draw_gizmo)); skeleton->connect(SceneStringName(pose_updated), callable_mp(this, &Skeleton3DEditor::_draw_gizmo));
skeleton->connect(SceneStringNames::get_singleton()->pose_updated, callable_mp(this, &Skeleton3DEditor::_update_properties)); skeleton->connect(SceneStringName(pose_updated), callable_mp(this, &Skeleton3DEditor::_update_properties));
skeleton->connect(SceneStringNames::get_singleton()->bone_enabled_changed, callable_mp(this, &Skeleton3DEditor::_bone_enabled_changed)); skeleton->connect(SceneStringName(bone_enabled_changed), callable_mp(this, &Skeleton3DEditor::_bone_enabled_changed));
skeleton->connect(SceneStringNames::get_singleton()->show_rest_only_changed, callable_mp(this, &Skeleton3DEditor::_update_gizmo_visible)); skeleton->connect(SceneStringName(show_rest_only_changed), callable_mp(this, &Skeleton3DEditor::_update_gizmo_visible));
#endif #endif
get_tree()->connect("node_removed", callable_mp(this, &Skeleton3DEditor::_node_removed), Object::CONNECT_ONE_SHOT); get_tree()->connect("node_removed", callable_mp(this, &Skeleton3DEditor::_node_removed), Object::CONNECT_ONE_SHOT);
@ -870,10 +870,10 @@ void Skeleton3DEditor::_notification(int p_what) {
if (skeleton) { if (skeleton) {
select_bone(-1); // Requires that the joint_tree has not been deleted. select_bone(-1); // Requires that the joint_tree has not been deleted.
#ifdef TOOLS_ENABLED #ifdef TOOLS_ENABLED
skeleton->disconnect(SceneStringNames::get_singleton()->show_rest_only_changed, callable_mp(this, &Skeleton3DEditor::_update_gizmo_visible)); skeleton->disconnect(SceneStringName(show_rest_only_changed), callable_mp(this, &Skeleton3DEditor::_update_gizmo_visible));
skeleton->disconnect(SceneStringNames::get_singleton()->bone_enabled_changed, callable_mp(this, &Skeleton3DEditor::_bone_enabled_changed)); skeleton->disconnect(SceneStringName(bone_enabled_changed), callable_mp(this, &Skeleton3DEditor::_bone_enabled_changed));
skeleton->disconnect(SceneStringNames::get_singleton()->pose_updated, callable_mp(this, &Skeleton3DEditor::_draw_gizmo)); skeleton->disconnect(SceneStringName(pose_updated), callable_mp(this, &Skeleton3DEditor::_draw_gizmo));
skeleton->disconnect(SceneStringNames::get_singleton()->pose_updated, callable_mp(this, &Skeleton3DEditor::_update_properties)); skeleton->disconnect(SceneStringName(pose_updated), callable_mp(this, &Skeleton3DEditor::_update_properties));
skeleton->set_transform_gizmo_visible(true); skeleton->set_transform_gizmo_visible(true);
#endif #endif
if (handles_mesh_instance->get_parent()) { if (handles_mesh_instance->get_parent()) {

14
editor/plugins/tiles/tile_set_atlas_source_editor.cpp
View File

@ -135,7 +135,7 @@ void TileSetAtlasSourceEditor::TileSetAtlasSourceProxyObject::edit(Ref<TileSet>
// Disconnect to changes. // Disconnect to changes.
if (tile_set_atlas_source.is_valid()) { if (tile_set_atlas_source.is_valid()) {
tile_set_atlas_source->disconnect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); tile_set_atlas_source->disconnect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
tile_set = p_tile_set; tile_set = p_tile_set;
@ -144,8 +144,8 @@ void TileSetAtlasSourceEditor::TileSetAtlasSourceProxyObject::edit(Ref<TileSet>
// Connect to changes. // Connect to changes.
if (tile_set_atlas_source.is_valid()) { if (tile_set_atlas_source.is_valid()) {
if (!tile_set_atlas_source->is_connected(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed))) { if (!tile_set_atlas_source->is_connected(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed))) {
tile_set_atlas_source->connect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); tile_set_atlas_source->connect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
} }
@ -522,8 +522,8 @@ void TileSetAtlasSourceEditor::AtlasTileProxyObject::edit(Ref<TileSetAtlasSource
if (tile_set_atlas_source.is_valid() && tile_set_atlas_source->has_tile(coords) && tile_set_atlas_source->has_alternative_tile(coords, alternative)) { if (tile_set_atlas_source.is_valid() && tile_set_atlas_source->has_tile(coords) && tile_set_atlas_source->has_alternative_tile(coords, alternative)) {
TileData *tile_data = tile_set_atlas_source->get_tile_data(coords, alternative); TileData *tile_data = tile_set_atlas_source->get_tile_data(coords, alternative);
if (tile_data->is_connected(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed))) { if (tile_data->is_connected(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed))) {
tile_data->disconnect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); tile_data->disconnect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
} }
} }
@ -538,8 +538,8 @@ void TileSetAtlasSourceEditor::AtlasTileProxyObject::edit(Ref<TileSetAtlasSource
if (tile_set_atlas_source->has_tile(coords) && tile_set_atlas_source->has_alternative_tile(coords, alternative)) { if (tile_set_atlas_source->has_tile(coords) && tile_set_atlas_source->has_alternative_tile(coords, alternative)) {
TileData *tile_data = tile_set_atlas_source->get_tile_data(coords, alternative); TileData *tile_data = tile_set_atlas_source->get_tile_data(coords, alternative);
if (!tile_data->is_connected(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed))) { if (!tile_data->is_connected(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed))) {
tile_data->connect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); tile_data->connect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
} }
} }

6
editor/plugins/tiles/tile_set_scenes_collection_source_editor.cpp
View File

@ -117,7 +117,7 @@ void TileSetScenesCollectionSourceEditor::TileSetScenesCollectionProxyObject::ed
// Disconnect to changes. // Disconnect to changes.
if (tile_set_scenes_collection_source) { if (tile_set_scenes_collection_source) {
tile_set_scenes_collection_source->disconnect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); tile_set_scenes_collection_source->disconnect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
tile_set = p_tile_set; tile_set = p_tile_set;
@ -126,8 +126,8 @@ void TileSetScenesCollectionSourceEditor::TileSetScenesCollectionProxyObject::ed
// Connect to changes. // Connect to changes.
if (tile_set_scenes_collection_source) { if (tile_set_scenes_collection_source) {
if (!tile_set_scenes_collection_source->is_connected(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed))) { if (!tile_set_scenes_collection_source->is_connected(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed))) {
tile_set_scenes_collection_source->connect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); tile_set_scenes_collection_source->connect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
} }

6
modules/gdscript/gdscript.cpp
View File

@ -2038,15 +2038,15 @@ void GDScriptInstance::notification(int p_notification, bool p_reversed) {
} }
String GDScriptInstance::to_string(bool *r_valid) { String GDScriptInstance::to_string(bool *r_valid) {
if (has_method(CoreStringNames::get_singleton()->_to_string)) { if (has_method(CoreStringName(_to_string))) {
Callable::CallError ce; Callable::CallError ce;
Variant ret = callp(CoreStringNames::get_singleton()->_to_string, nullptr, 0, ce); Variant ret = callp(CoreStringName(_to_string), nullptr, 0, ce);
if (ce.error == Callable::CallError::CALL_OK) { if (ce.error == Callable::CallError::CALL_OK) {
if (ret.get_type() != Variant::STRING) { if (ret.get_type() != Variant::STRING) {
if (r_valid) { if (r_valid) {
*r_valid = false; *r_valid = false;
} }
ERR_FAIL_V_MSG(String(), "Wrong type for " + CoreStringNames::get_singleton()->_to_string + ", must be a String."); ERR_FAIL_V_MSG(String(), "Wrong type for " + CoreStringName(_to_string) + ", must be a String.");
} }
if (r_valid) { if (r_valid) {
*r_valid = true; *r_valid = true;

4
modules/gdscript/gdscript_analyzer.cpp
View File

@ -231,7 +231,7 @@ bool GDScriptAnalyzer::has_member_name_conflict_in_native_type(const StringName
if (ClassDB::has_integer_constant(p_native_type_string, p_member_name)) { if (ClassDB::has_integer_constant(p_native_type_string, p_member_name)) {
return true; return true;
} }
if (p_member_name == CoreStringNames::get_singleton()->_script) { if (p_member_name == CoreStringName(script)) {
return true; return true;
} }
@ -2172,7 +2172,7 @@ void GDScriptAnalyzer::resolve_for(GDScriptParser::ForNode *p_for) {
List<GDScriptParser::DataType> par_types; List<GDScriptParser::DataType> par_types;
int default_arg_count = 0; int default_arg_count = 0;
BitField<MethodFlags> method_flags; BitField<MethodFlags> method_flags;
if (get_function_signature(p_for->list, false, list_type, CoreStringNames::get_singleton()->_iter_get, return_type, par_types, default_arg_count, method_flags)) { if (get_function_signature(p_for->list, false, list_type, CoreStringName(_iter_get), return_type, par_types, default_arg_count, method_flags)) {
variable_type = return_type; variable_type = return_type;
variable_type.type_source = list_type.type_source; variable_type.type_source = list_type.type_source;
} else if (!list_type.is_hard_type()) { } else if (!list_type.is_hard_type()) {

2
modules/gdscript/gdscript_compiler.cpp
View File

@ -346,7 +346,7 @@ GDScriptCodeGenerator::Address GDScriptCompiler::_parse_expression(CodeGen &code
scr = scr->_base; scr = scr->_base;
} }
if (nc && (identifier == CoreStringNames::get_singleton()->_free || ClassDB::has_signal(nc->get_name(), identifier) || ClassDB::has_method(nc->get_name(), identifier))) { if (nc && (identifier == CoreStringName(free_) || ClassDB::has_signal(nc->get_name(), identifier) || ClassDB::has_method(nc->get_name(), identifier))) {
// Get like it was a property. // Get like it was a property.
GDScriptCodeGenerator::Address temp = codegen.add_temporary(); // TODO: Get type here. GDScriptCodeGenerator::Address temp = codegen.add_temporary(); // TODO: Get type here.
GDScriptCodeGenerator::Address self(GDScriptCodeGenerator::Address::SELF); GDScriptCodeGenerator::Address self(GDScriptCodeGenerator::Address::SELF);

10
modules/gdscript/gdscript_vm.cpp
View File

@ -1741,7 +1741,7 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
if (base_type == Variant::OBJECT) { if (base_type == Variant::OBJECT) {
if (base_obj) { if (base_obj) {
MethodBind *method = ClassDB::get_method(base_class, *methodname); MethodBind *method = ClassDB::get_method(base_class, *methodname);
if (*methodname == CoreStringNames::get_singleton()->_free || (method && !method->has_return())) { if (*methodname == CoreStringName(free_) || (method && !method->has_return())) {
err_text = R"(Trying to get a return value of a method that returns "void")"; err_text = R"(Trying to get a return value of a method that returns "void")";
OPCODE_BREAK; OPCODE_BREAK;
} }
@ -3097,7 +3097,7 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
const Variant *args[] = { &vref }; const Variant *args[] = { &vref };
Callable::CallError ce; Callable::CallError ce;
Variant has_next = obj->callp(CoreStringNames::get_singleton()->_iter_init, args, 1, ce); Variant has_next = obj->callp(CoreStringName(_iter_init), args, 1, ce);
#ifdef DEBUG_ENABLED #ifdef DEBUG_ENABLED
if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) { if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) {
@ -3113,7 +3113,7 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
*counter = ref[0]; *counter = ref[0];
GET_VARIANT_PTR(iterator, 2); GET_VARIANT_PTR(iterator, 2);
*iterator = obj->callp(CoreStringNames::get_singleton()->_iter_get, (const Variant **)&counter, 1, ce); *iterator = obj->callp(CoreStringName(_iter_get), (const Variant **)&counter, 1, ce);
#ifdef DEBUG_ENABLED #ifdef DEBUG_ENABLED
if (ce.error != Callable::CallError::CALL_OK) { if (ce.error != Callable::CallError::CALL_OK) {
err_text = vformat(R"(There was an error calling "_iter_get" on iterator object of type %s.)", *container); err_text = vformat(R"(There was an error calling "_iter_get" on iterator object of type %s.)", *container);
@ -3431,7 +3431,7 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
const Variant *args[] = { &vref }; const Variant *args[] = { &vref };
Callable::CallError ce; Callable::CallError ce;
Variant has_next = obj->callp(CoreStringNames::get_singleton()->_iter_next, args, 1, ce); Variant has_next = obj->callp(CoreStringName(_iter_next), args, 1, ce);
#ifdef DEBUG_ENABLED #ifdef DEBUG_ENABLED
if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) { if (ref.size() != 1 || ce.error != Callable::CallError::CALL_OK) {
@ -3447,7 +3447,7 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
*counter = ref[0]; *counter = ref[0];
GET_VARIANT_PTR(iterator, 2); GET_VARIANT_PTR(iterator, 2);
*iterator = obj->callp(CoreStringNames::get_singleton()->_iter_get, (const Variant **)&counter, 1, ce); *iterator = obj->callp(CoreStringName(_iter_get), (const Variant **)&counter, 1, ce);
#ifdef DEBUG_ENABLED #ifdef DEBUG_ENABLED
if (ce.error != Callable::CallError::CALL_OK) { if (ce.error != Callable::CallError::CALL_OK) {
err_text = vformat(R"(There was an error calling "_iter_get" on iterator object of type %s.)", *container); err_text = vformat(R"(There was an error calling "_iter_get" on iterator object of type %s.)", *container);

4
modules/gridmap/editor/grid_map_editor_plugin.cpp
View File

@ -949,7 +949,7 @@ void GridMapEditor::_update_mesh_library() {
void GridMapEditor::edit(GridMap *p_gridmap) { void GridMapEditor::edit(GridMap *p_gridmap) {
if (node) { if (node) {
node->disconnect(SNAME("cell_size_changed"), callable_mp(this, &GridMapEditor::_draw_grids)); node->disconnect(SNAME("cell_size_changed"), callable_mp(this, &GridMapEditor::_draw_grids));
node->disconnect(CoreStringNames::get_singleton()->changed, callable_mp(this, &GridMapEditor::_update_mesh_library)); node->disconnect(CoreStringName(changed), callable_mp(this, &GridMapEditor::_update_mesh_library));
if (mesh_library.is_valid()) { if (mesh_library.is_valid()) {
mesh_library->disconnect_changed(callable_mp(this, &GridMapEditor::update_palette)); mesh_library->disconnect_changed(callable_mp(this, &GridMapEditor::update_palette));
mesh_library = Ref<MeshLibrary>(); mesh_library = Ref<MeshLibrary>();
@ -987,7 +987,7 @@ void GridMapEditor::edit(GridMap *p_gridmap) {
update_grid(); update_grid();
node->connect(SNAME("cell_size_changed"), callable_mp(this, &GridMapEditor::_draw_grids)); node->connect(SNAME("cell_size_changed"), callable_mp(this, &GridMapEditor::_draw_grids));
node->connect(CoreStringNames::get_singleton()->changed, callable_mp(this, &GridMapEditor::_update_mesh_library)); node->connect(CoreStringName(changed), callable_mp(this, &GridMapEditor::_update_mesh_library));
_update_mesh_library(); _update_mesh_library();
} }

4
modules/gridmap/grid_map.cpp
View File

@ -266,7 +266,7 @@ void GridMap::set_mesh_library(const Ref<MeshLibrary> &p_mesh_library) {
} }
_recreate_octant_data(); _recreate_octant_data();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
Ref<MeshLibrary> GridMap::get_mesh_library() const { Ref<MeshLibrary> GridMap::get_mesh_library() const {
@ -1136,7 +1136,7 @@ void GridMap::_bind_methods() {
BIND_CONSTANT(INVALID_CELL_ITEM); BIND_CONSTANT(INVALID_CELL_ITEM);
ADD_SIGNAL(MethodInfo("cell_size_changed", PropertyInfo(Variant::VECTOR3, "cell_size"))); ADD_SIGNAL(MethodInfo("cell_size_changed", PropertyInfo(Variant::VECTOR3, "cell_size")));
ADD_SIGNAL(MethodInfo(CoreStringNames::get_singleton()->changed)); ADD_SIGNAL(MethodInfo(CoreStringName(changed)));
} }
void GridMap::set_cell_scale(float p_scale) { void GridMap::set_cell_scale(float p_scale) {

4
modules/multiplayer/multiplayer_spawner.cpp
View File

@ -216,7 +216,7 @@ void MultiplayerSpawner::_notification(int p_what) {
for (const KeyValue<ObjectID, SpawnInfo> &E : tracked_nodes) { for (const KeyValue<ObjectID, SpawnInfo> &E : tracked_nodes) {
Node *node = Object::cast_to<Node>(ObjectDB::get_instance(E.key)); Node *node = Object::cast_to<Node>(ObjectDB::get_instance(E.key));
ERR_CONTINUE(!node); ERR_CONTINUE(!node);
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &MultiplayerSpawner::_node_exit)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &MultiplayerSpawner::_node_exit));
get_multiplayer()->object_configuration_remove(node, this); get_multiplayer()->object_configuration_remove(node, this);
} }
tracked_nodes.clear(); tracked_nodes.clear();
@ -258,7 +258,7 @@ void MultiplayerSpawner::_track(Node *p_node, const Variant &p_argument, int p_s
ObjectID oid = p_node->get_instance_id(); ObjectID oid = p_node->get_instance_id();
if (!tracked_nodes.has(oid)) { if (!tracked_nodes.has(oid)) {
tracked_nodes[oid] = SpawnInfo(p_argument.duplicate(true), p_scene_id); tracked_nodes[oid] = SpawnInfo(p_argument.duplicate(true), p_scene_id);
p_node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &MultiplayerSpawner::_node_exit).bind(p_node->get_instance_id()), CONNECT_ONE_SHOT); p_node->connect(SceneStringName(tree_exiting), callable_mp(this, &MultiplayerSpawner::_node_exit).bind(p_node->get_instance_id()), CONNECT_ONE_SHOT);
_spawn_notify(p_node->get_instance_id()); _spawn_notify(p_node->get_instance_id());
} }
} }

4
modules/multiplayer/scene_cache_interface.cpp
View File

@ -42,7 +42,7 @@ SceneCacheInterface::NodeCache &SceneCacheInterface::_track(Node *p_node) {
NodeCache *nc = nodes_cache.getptr(oid); NodeCache *nc = nodes_cache.getptr(oid);
if (!nc) { if (!nc) {
nodes_cache[oid] = NodeCache(); nodes_cache[oid] = NodeCache();
p_node->connect(SceneStringNames::get_singleton()->tree_exited, callable_mp(this, &SceneCacheInterface::_remove_node_cache).bind(oid), Object::CONNECT_ONE_SHOT); p_node->connect(SceneStringName(tree_exited), callable_mp(this, &SceneCacheInterface::_remove_node_cache).bind(oid), Object::CONNECT_ONE_SHOT);
} }
return nodes_cache[oid]; return nodes_cache[oid];
} }
@ -286,7 +286,7 @@ void SceneCacheInterface::clear() {
for (KeyValue<ObjectID, NodeCache> &E : nodes_cache) { for (KeyValue<ObjectID, NodeCache> &E : nodes_cache) {
Object *obj = ObjectDB::get_instance(E.key); Object *obj = ObjectDB::get_instance(E.key);
ERR_CONTINUE(!obj); ERR_CONTINUE(!obj);
obj->disconnect(SceneStringNames::get_singleton()->tree_exited, callable_mp(this, &SceneCacheInterface::_remove_node_cache)); obj->disconnect(SceneStringName(tree_exited), callable_mp(this, &SceneCacheInterface::_remove_node_cache));
} }
peers_info.clear(); peers_info.clear();
nodes_cache.clear(); nodes_cache.clear();

8
modules/multiplayer/scene_replication_interface.cpp
View File

@ -57,7 +57,7 @@ SceneReplicationInterface::TrackedNode &SceneReplicationInterface::_track(const
if (!tracked_nodes.has(p_id)) { if (!tracked_nodes.has(p_id)) {
tracked_nodes[p_id] = TrackedNode(p_id); tracked_nodes[p_id] = TrackedNode(p_id);
Node *node = get_id_as<Node>(p_id); Node *node = get_id_as<Node>(p_id);
node->connect(SceneStringNames::get_singleton()->tree_exited, callable_mp(this, &SceneReplicationInterface::_untrack).bind(p_id), Node::CONNECT_ONE_SHOT); node->connect(SceneStringName(tree_exited), callable_mp(this, &SceneReplicationInterface::_untrack).bind(p_id), Node::CONNECT_ONE_SHOT);
} }
return tracked_nodes[p_id]; return tracked_nodes[p_id];
} }
@ -135,8 +135,8 @@ void SceneReplicationInterface::on_network_process() {
for (const ObjectID &oid : spawn_queue) { for (const ObjectID &oid : spawn_queue) {
Node *node = get_id_as<Node>(oid); Node *node = get_id_as<Node>(oid);
ERR_CONTINUE(!node); ERR_CONTINUE(!node);
if (node->is_connected(SceneStringNames::get_singleton()->ready, callable_mp(this, &SceneReplicationInterface::_node_ready))) { if (node->is_connected(SceneStringName(ready), callable_mp(this, &SceneReplicationInterface::_node_ready))) {
node->disconnect(SceneStringNames::get_singleton()->ready, callable_mp(this, &SceneReplicationInterface::_node_ready)); node->disconnect(SceneStringName(ready), callable_mp(this, &SceneReplicationInterface::_node_ready));
} }
} }
spawn_queue.clear(); spawn_queue.clear();
@ -168,7 +168,7 @@ Error SceneReplicationInterface::on_spawn(Object *p_obj, Variant p_config) {
ERR_FAIL_COND_V(tobj.spawner != ObjectID(), ERR_ALREADY_IN_USE); ERR_FAIL_COND_V(tobj.spawner != ObjectID(), ERR_ALREADY_IN_USE);
tobj.spawner = spawner->get_instance_id(); tobj.spawner = spawner->get_instance_id();
spawn_queue.insert(oid); spawn_queue.insert(oid);
node->connect(SceneStringNames::get_singleton()->ready, callable_mp(this, &SceneReplicationInterface::_node_ready).bind(oid), Node::CONNECT_ONE_SHOT); node->connect(SceneStringName(ready), callable_mp(this, &SceneReplicationInterface::_node_ready).bind(oid), Node::CONNECT_ONE_SHOT);
return OK; return OK;
} }

14
scene/2d/animated_sprite_2d.cpp
View File

@ -202,7 +202,7 @@ void AnimatedSprite2D::_notification(int p_what) {
} else { } else {
frame = last_frame; frame = last_frame;
pause(); pause();
emit_signal(SceneStringNames::get_singleton()->animation_finished); emit_signal(SceneStringName(animation_finished));
return; return;
} }
} else { } else {
@ -211,7 +211,7 @@ void AnimatedSprite2D::_notification(int p_what) {
_calc_frame_speed_scale(); _calc_frame_speed_scale();
frame_progress = 0.0; frame_progress = 0.0;
queue_redraw(); queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
double to_process = MIN((1.0 - frame_progress) / abs_speed, remaining); double to_process = MIN((1.0 - frame_progress) / abs_speed, remaining);
frame_progress += to_process * abs_speed; frame_progress += to_process * abs_speed;
@ -226,7 +226,7 @@ void AnimatedSprite2D::_notification(int p_what) {
} else { } else {
frame = 0; frame = 0;
pause(); pause();
emit_signal(SceneStringNames::get_singleton()->animation_finished); emit_signal(SceneStringName(animation_finished));
return; return;
} }
} else { } else {
@ -235,7 +235,7 @@ void AnimatedSprite2D::_notification(int p_what) {
_calc_frame_speed_scale(); _calc_frame_speed_scale();
frame_progress = 1.0; frame_progress = 1.0;
queue_redraw(); queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
double to_process = MIN(frame_progress / abs_speed, remaining); double to_process = MIN(frame_progress / abs_speed, remaining);
frame_progress -= to_process * abs_speed; frame_progress -= to_process * abs_speed;
@ -291,12 +291,12 @@ void AnimatedSprite2D::set_sprite_frames(const Ref<SpriteFrames> &p_frames) {
} }
if (frames.is_valid()) { if (frames.is_valid()) {
frames->disconnect(SceneStringNames::get_singleton()->changed, callable_mp(this, &AnimatedSprite2D::_res_changed)); frames->disconnect(SceneStringName(changed), callable_mp(this, &AnimatedSprite2D::_res_changed));
} }
stop(); stop();
frames = p_frames; frames = p_frames;
if (frames.is_valid()) { if (frames.is_valid()) {
frames->connect(SceneStringNames::get_singleton()->changed, callable_mp(this, &AnimatedSprite2D::_res_changed)); frames->connect(SceneStringName(changed), callable_mp(this, &AnimatedSprite2D::_res_changed));
List<StringName> al; List<StringName> al;
frames->get_animation_list(&al); frames->get_animation_list(&al);
@ -363,7 +363,7 @@ void AnimatedSprite2D::set_frame_and_progress(int p_frame, real_t p_progress) {
return; // No change, don't redraw. return; // No change, don't redraw.
} }
queue_redraw(); queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
void AnimatedSprite2D::set_speed_scale(float p_speed_scale) { void AnimatedSprite2D::set_speed_scale(float p_speed_scale) {

4
scene/2d/audio_stream_player_2d.cpp
View File

@ -81,10 +81,10 @@ StringName AudioStreamPlayer2D::_get_actual_bus() {
//check if any area is diverting sound into a bus //check if any area is diverting sound into a bus
Ref<World2D> world_2d = get_world_2d(); Ref<World2D> world_2d = get_world_2d();
ERR_FAIL_COND_V(world_2d.is_null(), SceneStringNames::get_singleton()->Master); ERR_FAIL_COND_V(world_2d.is_null(), SceneStringName(Master));
PhysicsDirectSpaceState2D *space_state = PhysicsServer2D::get_singleton()->space_get_direct_state(world_2d->get_space()); PhysicsDirectSpaceState2D *space_state = PhysicsServer2D::get_singleton()->space_get_direct_state(world_2d->get_space());
ERR_FAIL_NULL_V(space_state, SceneStringNames::get_singleton()->Master); ERR_FAIL_COND_V(space_state, SceneStringName(Master));
PhysicsDirectSpaceState2D::ShapeResult sr[MAX_INTERSECT_AREAS]; PhysicsDirectSpaceState2D::ShapeResult sr[MAX_INTERSECT_AREAS];
PhysicsDirectSpaceState2D::PointParameters point_params; PhysicsDirectSpaceState2D::PointParameters point_params;

2
scene/2d/cpu_particles_2d.cpp
View File

@ -997,7 +997,7 @@ void CPUParticles2D::_particles_process(double p_delta) {
} }
if (!Math::is_equal_approx(time, 0.0) && active && !should_be_active) { if (!Math::is_equal_approx(time, 0.0) && active && !should_be_active) {
active = false; active = false;
emit_signal(SceneStringNames::get_singleton()->finished); emit_signal(SceneStringName(finished));
} }
} }

2
scene/2d/gpu_particles_2d.cpp
View File

@ -731,7 +731,7 @@ void GPUParticles2D::_notification(int p_what) {
} }
if (time > active_time) { if (time > active_time) {
if (active && !signal_canceled) { if (active && !signal_canceled) {
emit_signal(SceneStringNames::get_singleton()->finished); emit_signal(SceneStringName(finished));
} }
active = false; active = false;
if (!emitting) { if (!emitting) {

2
scene/2d/mesh_instance_2d.cpp
View File

@ -70,7 +70,7 @@ void MeshInstance2D::set_texture(const Ref<Texture2D> &p_texture) {
} }
texture = p_texture; texture = p_texture;
queue_redraw(); queue_redraw();
emit_signal(SceneStringNames::get_singleton()->texture_changed); emit_signal(SceneStringName(texture_changed));
} }
Ref<Texture2D> MeshInstance2D::get_texture() const { Ref<Texture2D> MeshInstance2D::get_texture() const {

2
scene/2d/multimesh_instance_2d.cpp
View File

@ -79,7 +79,7 @@ void MultiMeshInstance2D::set_texture(const Ref<Texture2D> &p_texture) {
} }
texture = p_texture; texture = p_texture;
queue_redraw(); queue_redraw();
emit_signal(SceneStringNames::get_singleton()->texture_changed); emit_signal(SceneStringName(texture_changed));
} }
Ref<Texture2D> MultiMeshInstance2D::get_texture() const { Ref<Texture2D> MultiMeshInstance2D::get_texture() const {

74
scene/2d/physics/area_2d.cpp
View File

@ -142,9 +142,9 @@ void Area2D::_body_enter_tree(ObjectID p_id) {
ERR_FAIL_COND(E->value.in_tree); ERR_FAIL_COND(E->value.in_tree);
E->value.in_tree = true; E->value.in_tree = true;
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape); emit_signal(SceneStringName(body_shape_entered), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape);
} }
} }
@ -156,9 +156,9 @@ void Area2D::_body_exit_tree(ObjectID p_id) {
ERR_FAIL_COND(!E); ERR_FAIL_COND(!E);
ERR_FAIL_COND(!E->value.in_tree); ERR_FAIL_COND(!E->value.in_tree);
E->value.in_tree = false; E->value.in_tree = false;
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape); emit_signal(SceneStringName(body_shape_exited), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape);
} }
} }
@ -172,9 +172,9 @@ void Area2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
lock_callback(); lock_callback();
locked = true; locked = true;
if (body_in) { if (body_in) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, p_body, (Node *)nullptr, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_entered), p_body, (Node *)nullptr, p_body_shape, p_area_shape);
} else { } else {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, p_body, (Node *)nullptr, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_exited), p_body, (Node *)nullptr, p_body_shape, p_area_shape);
} }
locked = false; locked = false;
unlock_callback(); unlock_callback();
@ -200,10 +200,10 @@ void Area2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
E->value.rc = 0; E->value.rc = 0;
E->value.in_tree = node && node->is_inside_tree(); E->value.in_tree = node && node->is_inside_tree();
if (node) { if (node) {
node->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area2D::_body_enter_tree).bind(objid)); node->connect(SceneStringName(tree_entered), callable_mp(this, &Area2D::_body_enter_tree).bind(objid));
node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area2D::_body_exit_tree).bind(objid)); node->connect(SceneStringName(tree_exiting), callable_mp(this, &Area2D::_body_exit_tree).bind(objid));
if (E->value.in_tree) { if (E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
} }
} }
} }
@ -213,7 +213,7 @@ void Area2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
} }
if (!node || E->value.in_tree) { if (!node || E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, p_body, node, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_entered), p_body, node, p_body_shape, p_area_shape);
} }
} else { } else {
@ -227,15 +227,15 @@ void Area2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
if (E->value.rc == 0) { if (E->value.rc == 0) {
body_map.remove(E); body_map.remove(E);
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area2D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area2D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area2D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area2D::_body_exit_tree));
if (in_tree) { if (in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_exited, obj); emit_signal(SceneStringName(body_exited), obj);
} }
} }
} }
if (!node || in_tree) { if (!node || in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, p_body, obj, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_exited), p_body, obj, p_body_shape, p_area_shape);
} }
} }
@ -253,9 +253,9 @@ void Area2D::_area_enter_tree(ObjectID p_id) {
ERR_FAIL_COND(E->value.in_tree); ERR_FAIL_COND(E->value.in_tree);
E->value.in_tree = true; E->value.in_tree = true;
emit_signal(SceneStringNames::get_singleton()->area_entered, node); emit_signal(SceneStringName(area_entered), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->area_shape_entered, E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape); emit_signal(SceneStringName(area_shape_entered), E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape);
} }
} }
@ -267,9 +267,9 @@ void Area2D::_area_exit_tree(ObjectID p_id) {
ERR_FAIL_COND(!E); ERR_FAIL_COND(!E);
ERR_FAIL_COND(!E->value.in_tree); ERR_FAIL_COND(!E->value.in_tree);
E->value.in_tree = false; E->value.in_tree = false;
emit_signal(SceneStringNames::get_singleton()->area_exited, node); emit_signal(SceneStringName(area_exited), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape); emit_signal(SceneStringName(area_shape_exited), E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape);
} }
} }
@ -283,9 +283,9 @@ void Area2D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
lock_callback(); lock_callback();
locked = true; locked = true;
if (area_in) { if (area_in) {
emit_signal(SceneStringNames::get_singleton()->area_shape_entered, p_area, (Node *)nullptr, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_entered), p_area, (Node *)nullptr, p_area_shape, p_self_shape);
} else { } else {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, p_area, (Node *)nullptr, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_exited), p_area, (Node *)nullptr, p_area_shape, p_self_shape);
} }
locked = false; locked = false;
unlock_callback(); unlock_callback();
@ -311,10 +311,10 @@ void Area2D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
E->value.rc = 0; E->value.rc = 0;
E->value.in_tree = node && node->is_inside_tree(); E->value.in_tree = node && node->is_inside_tree();
if (node) { if (node) {
node->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area2D::_area_enter_tree).bind(objid)); node->connect(SceneStringName(tree_entered), callable_mp(this, &Area2D::_area_enter_tree).bind(objid));
node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area2D::_area_exit_tree).bind(objid)); node->connect(SceneStringName(tree_exiting), callable_mp(this, &Area2D::_area_exit_tree).bind(objid));
if (E->value.in_tree) { if (E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_entered, node); emit_signal(SceneStringName(area_entered), node);
} }
} }
} }
@ -324,7 +324,7 @@ void Area2D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
} }
if (!node || E->value.in_tree) { if (!node || E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_shape_entered, p_area, node, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_entered), p_area, node, p_area_shape, p_self_shape);
} }
} else { } else {
@ -338,15 +338,15 @@ void Area2D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
if (E->value.rc == 0) { if (E->value.rc == 0) {
area_map.remove(E); area_map.remove(E);
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area2D::_area_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area2D::_area_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area2D::_area_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area2D::_area_exit_tree));
if (in_tree) { if (in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_exited, obj); emit_signal(SceneStringName(area_exited), obj);
} }
} }
} }
if (!node || in_tree) { if (!node || in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, p_area, obj, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_exited), p_area, obj, p_area_shape, p_self_shape);
} }
} }
@ -370,18 +370,18 @@ void Area2D::_clear_monitoring() {
continue; continue;
} }
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area2D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area2D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area2D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area2D::_body_exit_tree));
if (!E.value.in_tree) { if (!E.value.in_tree) {
continue; continue;
} }
for (int i = 0; i < E.value.shapes.size(); i++) { for (int i = 0; i < E.value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, E.value.rid, node, E.value.shapes[i].body_shape, E.value.shapes[i].area_shape); emit_signal(SceneStringName(body_shape_exited), E.value.rid, node, E.value.shapes[i].body_shape, E.value.shapes[i].area_shape);
} }
emit_signal(SceneStringNames::get_singleton()->body_exited, obj); emit_signal(SceneStringName(body_exited), obj);
} }
} }
@ -398,18 +398,18 @@ void Area2D::_clear_monitoring() {
continue; continue;
} }
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area2D::_area_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area2D::_area_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area2D::_area_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area2D::_area_exit_tree));
if (!E.value.in_tree) { if (!E.value.in_tree) {
continue; continue;
} }
for (int i = 0; i < E.value.shapes.size(); i++) { for (int i = 0; i < E.value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, E.value.rid, node, E.value.shapes[i].area_shape, E.value.shapes[i].self_shape); emit_signal(SceneStringName(area_shape_exited), E.value.rid, node, E.value.shapes[i].area_shape, E.value.shapes[i].self_shape);
} }
emit_signal(SceneStringNames::get_singleton()->area_exited, obj); emit_signal(SceneStringName(area_exited), obj);
} }
} }
} }
@ -538,7 +538,7 @@ StringName Area2D::get_audio_bus_name() const {
return audio_bus; return audio_bus;
} }
} }
return SceneStringNames::get_singleton()->Master; return SceneStringName(Master);
} }
void Area2D::_validate_property(PropertyInfo &p_property) const { void Area2D::_validate_property(PropertyInfo &p_property) const {

10
scene/2d/physics/collision_object_2d.cpp
View File

@ -519,27 +519,27 @@ bool CollisionObject2D::is_pickable() const {
void CollisionObject2D::_input_event_call(Viewport *p_viewport, const Ref<InputEvent> &p_input_event, int p_shape) { void CollisionObject2D::_input_event_call(Viewport *p_viewport, const Ref<InputEvent> &p_input_event, int p_shape) {
GDVIRTUAL_CALL(_input_event, p_viewport, p_input_event, p_shape); GDVIRTUAL_CALL(_input_event, p_viewport, p_input_event, p_shape);
emit_signal(SceneStringNames::get_singleton()->input_event, p_viewport, p_input_event, p_shape); emit_signal(SceneStringName(input_event), p_viewport, p_input_event, p_shape);
} }
void CollisionObject2D::_mouse_enter() { void CollisionObject2D::_mouse_enter() {
GDVIRTUAL_CALL(_mouse_enter); GDVIRTUAL_CALL(_mouse_enter);
emit_signal(SceneStringNames::get_singleton()->mouse_entered); emit_signal(SceneStringName(mouse_entered));
} }
void CollisionObject2D::_mouse_exit() { void CollisionObject2D::_mouse_exit() {
GDVIRTUAL_CALL(_mouse_exit); GDVIRTUAL_CALL(_mouse_exit);
emit_signal(SceneStringNames::get_singleton()->mouse_exited); emit_signal(SceneStringName(mouse_exited));
} }
void CollisionObject2D::_mouse_shape_enter(int p_shape) { void CollisionObject2D::_mouse_shape_enter(int p_shape) {
GDVIRTUAL_CALL(_mouse_shape_enter, p_shape); GDVIRTUAL_CALL(_mouse_shape_enter, p_shape);
emit_signal(SceneStringNames::get_singleton()->mouse_shape_entered, p_shape); emit_signal(SceneStringName(mouse_shape_entered), p_shape);
} }
void CollisionObject2D::_mouse_shape_exit(int p_shape) { void CollisionObject2D::_mouse_shape_exit(int p_shape) {
GDVIRTUAL_CALL(_mouse_shape_exit, p_shape); GDVIRTUAL_CALL(_mouse_shape_exit, p_shape);
emit_signal(SceneStringNames::get_singleton()->mouse_shape_exited, p_shape); emit_signal(SceneStringName(mouse_shape_exited), p_shape);
} }
void CollisionObject2D::set_only_update_transform_changes(bool p_enable) { void CollisionObject2D::set_only_update_transform_changes(bool p_enable) {

8
scene/2d/physics/joints/joint_2d.cpp
View File

@ -37,13 +37,13 @@ void Joint2D::_disconnect_signals() {
Node *node_a = get_node_or_null(a); Node *node_a = get_node_or_null(a);
PhysicsBody2D *body_a = Object::cast_to<PhysicsBody2D>(node_a); PhysicsBody2D *body_a = Object::cast_to<PhysicsBody2D>(node_a);
if (body_a) { if (body_a) {
body_a->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint2D::_body_exit_tree)); body_a->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Joint2D::_body_exit_tree));
} }
Node *node_b = get_node_or_null(b); Node *node_b = get_node_or_null(b);
PhysicsBody2D *body_b = Object::cast_to<PhysicsBody2D>(node_b); PhysicsBody2D *body_b = Object::cast_to<PhysicsBody2D>(node_b);
if (body_b) { if (body_b) {
body_b->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint2D::_body_exit_tree)); body_b->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Joint2D::_body_exit_tree));
} }
} }
@ -117,8 +117,8 @@ void Joint2D::_update_joint(bool p_only_free) {
ba = body_a->get_rid(); ba = body_a->get_rid();
bb = body_b->get_rid(); bb = body_b->get_rid();
body_a->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint2D::_body_exit_tree)); body_a->connect(SceneStringName(tree_exiting), callable_mp(this, &Joint2D::_body_exit_tree));
body_b->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint2D::_body_exit_tree)); body_b->connect(SceneStringName(tree_exiting), callable_mp(this, &Joint2D::_body_exit_tree));
PhysicsServer2D::get_singleton()->joint_disable_collisions_between_bodies(joint, exclude_from_collision); PhysicsServer2D::get_singleton()->joint_disable_collisions_between_bodies(joint, exclude_from_collision);
} }

30
scene/2d/physics/rigid_body_2d.cpp
View File

@ -44,10 +44,10 @@ void RigidBody2D::_body_enter_tree(ObjectID p_id) {
contact_monitor->locked = true; contact_monitor->locked = true;
E->value.in_scene = true; E->value.in_scene = true;
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape); emit_signal(SceneStringName(body_shape_entered), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape);
} }
contact_monitor->locked = false; contact_monitor->locked = false;
@ -65,10 +65,10 @@ void RigidBody2D::_body_exit_tree(ObjectID p_id) {
contact_monitor->locked = true; contact_monitor->locked = true;
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape); emit_signal(SceneStringName(body_shape_exited), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape);
} }
contact_monitor->locked = false; contact_monitor->locked = false;
@ -93,10 +93,10 @@ void RigidBody2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instan
//E->value.rc=0; //E->value.rc=0;
E->value.in_scene = node && node->is_inside_tree(); E->value.in_scene = node && node->is_inside_tree();
if (node) { if (node) {
node->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &RigidBody2D::_body_enter_tree).bind(objid)); node->connect(SceneStringName(tree_entered), callable_mp(this, &RigidBody2D::_body_enter_tree).bind(objid));
node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &RigidBody2D::_body_exit_tree).bind(objid)); node->connect(SceneStringName(tree_exiting), callable_mp(this, &RigidBody2D::_body_exit_tree).bind(objid));
if (E->value.in_scene) { if (E->value.in_scene) {
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
} }
} }
@ -108,7 +108,7 @@ void RigidBody2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instan
} }
if (E->value.in_scene) { if (E->value.in_scene) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, p_body, node, p_body_shape, p_local_shape); emit_signal(SceneStringName(body_shape_entered), p_body, node, p_body_shape, p_local_shape);
} }
} else { } else {
@ -122,17 +122,17 @@ void RigidBody2D::_body_inout(int p_status, const RID &p_body, ObjectID p_instan
if (E->value.shapes.is_empty()) { if (E->value.shapes.is_empty()) {
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &RigidBody2D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &RigidBody2D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &RigidBody2D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &RigidBody2D::_body_exit_tree));
if (in_scene) { if (in_scene) {
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
} }
} }
contact_monitor->body_map.remove(E); contact_monitor->body_map.remove(E);
} }
if (node && in_scene) { if (node && in_scene) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, p_body, node, p_body_shape, p_local_shape); emit_signal(SceneStringName(body_shape_exited), p_body, node, p_body_shape, p_local_shape);
} }
} }
} }
@ -158,7 +158,7 @@ void RigidBody2D::_sync_body_state(PhysicsDirectBodyState2D *p_state) {
if (sleeping != p_state->is_sleeping()) { if (sleeping != p_state->is_sleeping()) {
sleeping = p_state->is_sleeping(); sleeping = p_state->is_sleeping();
emit_signal(SceneStringNames::get_singleton()->sleeping_state_changed); emit_signal(SceneStringName(sleeping_state_changed));
} }
} }
@ -605,8 +605,8 @@ void RigidBody2D::set_contact_monitor(bool p_enabled) {
Node *node = Object::cast_to<Node>(obj); Node *node = Object::cast_to<Node>(obj);
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &RigidBody2D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &RigidBody2D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &RigidBody2D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &RigidBody2D::_body_exit_tree));
} }
} }

4
scene/2d/sprite_2d.cpp
View File

@ -146,7 +146,7 @@ void Sprite2D::set_texture(const Ref<Texture2D> &p_texture) {
} }
queue_redraw(); queue_redraw();
emit_signal(SceneStringNames::get_singleton()->texture_changed); emit_signal(SceneStringName(texture_changed));
item_rect_changed(); item_rect_changed();
} }
@ -260,7 +260,7 @@ void Sprite2D::set_frame(int p_frame) {
frame = p_frame; frame = p_frame;
item_rect_changed(); item_rect_changed();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
int Sprite2D::get_frame() const { int Sprite2D::get_frame() const {

10
scene/2d/tile_map.cpp
View File

@ -54,7 +54,7 @@ void TileMap::_tile_set_changed() {
} }
void TileMap::_emit_changed() { void TileMap::_emit_changed() {
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMap::_set_tile_map_data_using_compatibility_format(int p_layer, TileMapDataFormat p_format, const Vector<int> &p_data) { void TileMap::_set_tile_map_data_using_compatibility_format(int p_layer, TileMapDataFormat p_format, const Vector<int> &p_data) {
@ -360,7 +360,7 @@ void TileMap::add_layer(int p_to_pos) {
for (uint32_t i = 0; i < layers.size(); i++) { for (uint32_t i = 0; i < layers.size(); i++) {
layers[i]->set_as_tile_map_internal_node(i); layers[i]->set_as_tile_map_internal_node(i);
} }
new_layer->connect(CoreStringNames::get_singleton()->changed, callable_mp(this, &TileMap::_emit_changed)); new_layer->connect(CoreStringName(changed), callable_mp(this, &TileMap::_emit_changed));
notify_property_list_changed(); notify_property_list_changed();
@ -768,7 +768,7 @@ bool TileMap::_set(const StringName &p_name, const Variant &p_value) {
new_layer->set_as_tile_map_internal_node(index); new_layer->set_as_tile_map_internal_node(index);
new_layer->set_name(vformat("Layer%d", index)); new_layer->set_name(vformat("Layer%d", index));
new_layer->set_tile_set(tile_set); new_layer->set_tile_set(tile_set);
new_layer->connect(CoreStringNames::get_singleton()->changed, callable_mp(this, &TileMap::_emit_changed)); new_layer->connect(CoreStringName(changed), callable_mp(this, &TileMap::_emit_changed));
layers.push_back(new_layer); layers.push_back(new_layer);
} }
@ -1051,7 +1051,7 @@ void TileMap::_bind_methods() {
ADD_PROPERTY_DEFAULT("format", TileMapDataFormat::TILE_MAP_DATA_FORMAT_1); ADD_PROPERTY_DEFAULT("format", TileMapDataFormat::TILE_MAP_DATA_FORMAT_1);
ADD_SIGNAL(MethodInfo(CoreStringNames::get_singleton()->changed)); ADD_SIGNAL(MethodInfo(CoreStringName(changed)));
BIND_ENUM_CONSTANT(VISIBILITY_MODE_DEFAULT); BIND_ENUM_CONSTANT(VISIBILITY_MODE_DEFAULT);
BIND_ENUM_CONSTANT(VISIBILITY_MODE_FORCE_HIDE); BIND_ENUM_CONSTANT(VISIBILITY_MODE_FORCE_HIDE);
@ -1064,7 +1064,7 @@ TileMap::TileMap() {
new_layer->set_as_tile_map_internal_node(0); new_layer->set_as_tile_map_internal_node(0);
new_layer->set_name("Layer0"); new_layer->set_name("Layer0");
new_layer->set_tile_set(tile_set); new_layer->set_tile_set(tile_set);
new_layer->connect(CoreStringNames::get_singleton()->changed, callable_mp(this, &TileMap::_emit_changed)); new_layer->connect(CoreStringName(changed), callable_mp(this, &TileMap::_emit_changed));
layers.push_back(new_layer); layers.push_back(new_layer);
if (!base_property_helper.is_initialized()) { if (!base_property_helper.is_initialized()) {

40
scene/2d/tile_map_layer.cpp
View File

@ -1598,11 +1598,11 @@ RBSet<TerrainConstraint> TileMapLayer::_get_terrain_constraints_from_painted_cel
void TileMapLayer::_tile_set_changed() { void TileMapLayer::_tile_set_changed() {
dirty.flags[DIRTY_FLAGS_TILE_SET] = true; dirty.flags[DIRTY_FLAGS_TILE_SET] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::_renamed() { void TileMapLayer::_renamed() {
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::_update_notify_local_transform() { void TileMapLayer::_update_notify_local_transform() {
@ -1805,7 +1805,7 @@ void TileMapLayer::_bind_methods() {
ADD_PROPERTY(PropertyInfo(Variant::BOOL, "navigation_enabled"), "set_navigation_enabled", "is_navigation_enabled"); ADD_PROPERTY(PropertyInfo(Variant::BOOL, "navigation_enabled"), "set_navigation_enabled", "is_navigation_enabled");
ADD_PROPERTY(PropertyInfo(Variant::INT, "navigation_visibility_mode", PROPERTY_HINT_ENUM, "Default,Force Show,Force Hide"), "set_navigation_visibility_mode", "get_navigation_visibility_mode"); ADD_PROPERTY(PropertyInfo(Variant::INT, "navigation_visibility_mode", PROPERTY_HINT_ENUM, "Default,Force Show,Force Hide"), "set_navigation_visibility_mode", "get_navigation_visibility_mode");
ADD_SIGNAL(MethodInfo(CoreStringNames::get_singleton()->changed)); ADD_SIGNAL(MethodInfo(CoreStringName(changed)));
ADD_PROPERTY_DEFAULT("tile_map_data_format", TileMapDataFormat::TILE_MAP_DATA_FORMAT_1); ADD_PROPERTY_DEFAULT("tile_map_data_format", TileMapDataFormat::TILE_MAP_DATA_FORMAT_1);
@ -1819,7 +1819,7 @@ void TileMapLayer::_update_self_texture_filter(RS::CanvasItemTextureFilter p_tex
CanvasItem::_update_self_texture_filter(p_texture_filter); CanvasItem::_update_self_texture_filter(p_texture_filter);
dirty.flags[DIRTY_FLAGS_LAYER_TEXTURE_FILTER] = true; dirty.flags[DIRTY_FLAGS_LAYER_TEXTURE_FILTER] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::_update_self_texture_repeat(RS::CanvasItemTextureRepeat p_texture_repeat) { void TileMapLayer::_update_self_texture_repeat(RS::CanvasItemTextureRepeat p_texture_repeat) {
@ -1827,7 +1827,7 @@ void TileMapLayer::_update_self_texture_repeat(RS::CanvasItemTextureRepeat p_tex
CanvasItem::_update_self_texture_repeat(p_texture_repeat); CanvasItem::_update_self_texture_repeat(p_texture_repeat);
dirty.flags[DIRTY_FLAGS_LAYER_TEXTURE_REPEAT] = true; dirty.flags[DIRTY_FLAGS_LAYER_TEXTURE_REPEAT] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::set_as_tile_map_internal_node(int p_index) { void TileMapLayer::set_as_tile_map_internal_node(int p_index) {
@ -2502,7 +2502,7 @@ void TileMapLayer::update_internals() {
void TileMapLayer::notify_runtime_tile_data_update() { void TileMapLayer::notify_runtime_tile_data_update() {
dirty.flags[TileMapLayer::DIRTY_FLAGS_LAYER_RUNTIME_UPDATE] = true; dirty.flags[TileMapLayer::DIRTY_FLAGS_LAYER_RUNTIME_UPDATE] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
Vector2i TileMapLayer::map_pattern(const Vector2i &p_position_in_tilemap, const Vector2i &p_coords_in_pattern, Ref<TileMapPattern> p_pattern) { Vector2i TileMapLayer::map_pattern(const Vector2i &p_position_in_tilemap, const Vector2i &p_coords_in_pattern, Ref<TileMapPattern> p_pattern) {
@ -2537,7 +2537,7 @@ void TileMapLayer::set_enabled(bool p_enabled) {
enabled = p_enabled; enabled = p_enabled;
dirty.flags[DIRTY_FLAGS_LAYER_ENABLED] = true; dirty.flags[DIRTY_FLAGS_LAYER_ENABLED] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
bool TileMapLayer::is_enabled() const { bool TileMapLayer::is_enabled() const {
@ -2563,7 +2563,7 @@ void TileMapLayer::set_tile_set(const Ref<TileSet> &p_tile_set) {
tile_set->connect_changed(callable_mp(this, &TileMapLayer::_tile_set_changed)); tile_set->connect_changed(callable_mp(this, &TileMapLayer::_tile_set_changed));
} }
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
// Trigger updates for TileSet's read-only status. // Trigger updates for TileSet's read-only status.
notify_property_list_changed(); notify_property_list_changed();
@ -2675,7 +2675,7 @@ void TileMapLayer::set_self_modulate(const Color &p_self_modulate) {
CanvasItem::set_self_modulate(p_self_modulate); CanvasItem::set_self_modulate(p_self_modulate);
dirty.flags[DIRTY_FLAGS_LAYER_SELF_MODULATE] = true; dirty.flags[DIRTY_FLAGS_LAYER_SELF_MODULATE] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::set_y_sort_enabled(bool p_y_sort_enabled) { void TileMapLayer::set_y_sort_enabled(bool p_y_sort_enabled) {
@ -2685,7 +2685,7 @@ void TileMapLayer::set_y_sort_enabled(bool p_y_sort_enabled) {
CanvasItem::set_y_sort_enabled(p_y_sort_enabled); CanvasItem::set_y_sort_enabled(p_y_sort_enabled);
dirty.flags[DIRTY_FLAGS_LAYER_Y_SORT_ENABLED] = true; dirty.flags[DIRTY_FLAGS_LAYER_Y_SORT_ENABLED] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
_update_notify_local_transform(); _update_notify_local_transform();
} }
@ -2697,7 +2697,7 @@ void TileMapLayer::set_y_sort_origin(int p_y_sort_origin) {
y_sort_origin = p_y_sort_origin; y_sort_origin = p_y_sort_origin;
dirty.flags[DIRTY_FLAGS_LAYER_Y_SORT_ORIGIN] = true; dirty.flags[DIRTY_FLAGS_LAYER_Y_SORT_ORIGIN] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
int TileMapLayer::get_y_sort_origin() const { int TileMapLayer::get_y_sort_origin() const {
@ -2711,7 +2711,7 @@ void TileMapLayer::set_z_index(int p_z_index) {
CanvasItem::set_z_index(p_z_index); CanvasItem::set_z_index(p_z_index);
dirty.flags[DIRTY_FLAGS_LAYER_Z_INDEX] = true; dirty.flags[DIRTY_FLAGS_LAYER_Z_INDEX] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::set_light_mask(int p_light_mask) { void TileMapLayer::set_light_mask(int p_light_mask) {
@ -2721,7 +2721,7 @@ void TileMapLayer::set_light_mask(int p_light_mask) {
CanvasItem::set_light_mask(p_light_mask); CanvasItem::set_light_mask(p_light_mask);
dirty.flags[DIRTY_FLAGS_LAYER_LIGHT_MASK] = true; dirty.flags[DIRTY_FLAGS_LAYER_LIGHT_MASK] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
void TileMapLayer::set_rendering_quadrant_size(int p_size) { void TileMapLayer::set_rendering_quadrant_size(int p_size) {
@ -2733,7 +2733,7 @@ void TileMapLayer::set_rendering_quadrant_size(int p_size) {
rendering_quadrant_size = p_size; rendering_quadrant_size = p_size;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
int TileMapLayer::get_rendering_quadrant_size() const { int TileMapLayer::get_rendering_quadrant_size() const {
@ -2747,7 +2747,7 @@ void TileMapLayer::set_collision_enabled(bool p_enabled) {
collision_enabled = p_enabled; collision_enabled = p_enabled;
dirty.flags[DIRTY_FLAGS_LAYER_COLLISION_ENABLED] = true; dirty.flags[DIRTY_FLAGS_LAYER_COLLISION_ENABLED] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
bool TileMapLayer::is_collision_enabled() const { bool TileMapLayer::is_collision_enabled() const {
@ -2758,7 +2758,7 @@ void TileMapLayer::set_use_kinematic_bodies(bool p_use_kinematic_bodies) {
use_kinematic_bodies = p_use_kinematic_bodies; use_kinematic_bodies = p_use_kinematic_bodies;
dirty.flags[DIRTY_FLAGS_LAYER_USE_KINEMATIC_BODIES] = p_use_kinematic_bodies; dirty.flags[DIRTY_FLAGS_LAYER_USE_KINEMATIC_BODIES] = p_use_kinematic_bodies;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
bool TileMapLayer::is_using_kinematic_bodies() const { bool TileMapLayer::is_using_kinematic_bodies() const {
@ -2772,7 +2772,7 @@ void TileMapLayer::set_collision_visibility_mode(TileMapLayer::DebugVisibilityMo
collision_visibility_mode = p_show_collision; collision_visibility_mode = p_show_collision;
dirty.flags[DIRTY_FLAGS_LAYER_COLLISION_VISIBILITY_MODE] = true; dirty.flags[DIRTY_FLAGS_LAYER_COLLISION_VISIBILITY_MODE] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
TileMapLayer::DebugVisibilityMode TileMapLayer::get_collision_visibility_mode() const { TileMapLayer::DebugVisibilityMode TileMapLayer::get_collision_visibility_mode() const {
@ -2786,7 +2786,7 @@ void TileMapLayer::set_navigation_enabled(bool p_enabled) {
navigation_enabled = p_enabled; navigation_enabled = p_enabled;
dirty.flags[DIRTY_FLAGS_LAYER_NAVIGATION_ENABLED] = true; dirty.flags[DIRTY_FLAGS_LAYER_NAVIGATION_ENABLED] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
bool TileMapLayer::is_navigation_enabled() const { bool TileMapLayer::is_navigation_enabled() const {
@ -2800,7 +2800,7 @@ void TileMapLayer::set_navigation_map(RID p_map) {
navigation_map_override = p_map; navigation_map_override = p_map;
dirty.flags[DIRTY_FLAGS_LAYER_NAVIGATION_MAP] = true; dirty.flags[DIRTY_FLAGS_LAYER_NAVIGATION_MAP] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
RID TileMapLayer::get_navigation_map() const { RID TileMapLayer::get_navigation_map() const {
@ -2819,7 +2819,7 @@ void TileMapLayer::set_navigation_visibility_mode(TileMapLayer::DebugVisibilityM
navigation_visibility_mode = p_show_navigation; navigation_visibility_mode = p_show_navigation;
dirty.flags[DIRTY_FLAGS_LAYER_NAVIGATION_VISIBILITY_MODE] = true; dirty.flags[DIRTY_FLAGS_LAYER_NAVIGATION_VISIBILITY_MODE] = true;
_queue_internal_update(); _queue_internal_update();
emit_signal(CoreStringNames::get_singleton()->changed); emit_signal(CoreStringName(changed));
} }
TileMapLayer::DebugVisibilityMode TileMapLayer::get_navigation_visibility_mode() const { TileMapLayer::DebugVisibilityMode TileMapLayer::get_navigation_visibility_mode() const {

8
scene/2d/touch_screen_button.cpp
View File

@ -38,11 +38,11 @@ void TouchScreenButton::set_texture_normal(const Ref<Texture2D> &p_texture) {
return; return;
} }
if (texture_normal.is_valid()) { if (texture_normal.is_valid()) {
texture_normal->disconnect(SceneStringNames::get_singleton()->changed, callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw)); texture_normal->disconnect(SceneStringName(changed), callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw));
} }
texture_normal = p_texture; texture_normal = p_texture;
if (texture_normal.is_valid()) { if (texture_normal.is_valid()) {
texture_normal->connect(SceneStringNames::get_singleton()->changed, callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw), CONNECT_REFERENCE_COUNTED); texture_normal->connect(SceneStringName(changed), callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw), CONNECT_REFERENCE_COUNTED);
} }
queue_redraw(); queue_redraw();
} }
@ -56,11 +56,11 @@ void TouchScreenButton::set_texture_pressed(const Ref<Texture2D> &p_texture_pres
return; return;
} }
if (texture_pressed.is_valid()) { if (texture_pressed.is_valid()) {
texture_pressed->disconnect(SceneStringNames::get_singleton()->changed, callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw)); texture_pressed->disconnect(SceneStringName(changed), callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw));
} }
texture_pressed = p_texture_pressed; texture_pressed = p_texture_pressed;
if (texture_pressed.is_valid()) { if (texture_pressed.is_valid()) {
texture_pressed->connect(SceneStringNames::get_singleton()->changed, callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw), CONNECT_REFERENCE_COUNTED); texture_pressed->connect(SceneStringName(changed), callable_mp((CanvasItem *)this, &CanvasItem::queue_redraw), CONNECT_REFERENCE_COUNTED);
} }
queue_redraw(); queue_redraw();
} }

4
scene/2d/visible_on_screen_notifier_2d.cpp
View File

@ -48,7 +48,7 @@ void VisibleOnScreenNotifier2D::_visibility_enter() {
} }
on_screen = true; on_screen = true;
emit_signal(SceneStringNames::get_singleton()->screen_entered); emit_signal(SceneStringName(screen_entered));
_screen_enter(); _screen_enter();
} }
void VisibleOnScreenNotifier2D::_visibility_exit() { void VisibleOnScreenNotifier2D::_visibility_exit() {
@ -57,7 +57,7 @@ void VisibleOnScreenNotifier2D::_visibility_exit() {
} }
on_screen = false; on_screen = false;
emit_signal(SceneStringNames::get_singleton()->screen_exited); emit_signal(SceneStringName(screen_exited));
_screen_exit(); _screen_exit();
} }

2
scene/3d/cpu_particles_3d.cpp
View File

@ -1156,7 +1156,7 @@ void CPUParticles3D::_particles_process(double p_delta) {
} }
if (!Math::is_equal_approx(time, 0.0) && active && !should_be_active) { if (!Math::is_equal_approx(time, 0.0) && active && !should_be_active) {
active = false; active = false;
emit_signal(SceneStringNames::get_singleton()->finished); emit_signal(SceneStringName(finished));
} }
} }

2
scene/3d/gpu_particles_3d.cpp
View File

@ -478,7 +478,7 @@ void GPUParticles3D::_notification(int p_what) {
} }
if (time > active_time) { if (time > active_time) {
if (active && !signal_canceled) { if (active && !signal_canceled) {
emit_signal(SceneStringNames::get_singleton()->finished); emit_signal(SceneStringName(finished));
} }
active = false; active = false;
if (!emitting) { if (!emitting) {

14
scene/3d/node_3d.cpp
View File

@ -193,12 +193,12 @@ void Node3D::_notification(int p_what) {
ERR_FAIL_NULL(data.viewport); ERR_FAIL_NULL(data.viewport);
if (get_script_instance()) { if (get_script_instance()) {
get_script_instance()->call(SceneStringNames::get_singleton()->_enter_world); get_script_instance()->call(SceneStringName(_enter_world));
} }
#ifdef TOOLS_ENABLED #ifdef TOOLS_ENABLED
if (is_part_of_edited_scene()) { if (is_part_of_edited_scene()) {
get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringNames::get_singleton()->_spatial_editor_group, SNAME("_request_gizmo_for_id"), get_instance_id()); get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringName(_spatial_editor_group), SNAME("_request_gizmo_for_id"), get_instance_id());
} }
#endif #endif
} break; } break;
@ -211,7 +211,7 @@ void Node3D::_notification(int p_what) {
#endif #endif
if (get_script_instance()) { if (get_script_instance()) {
get_script_instance()->call(SceneStringNames::get_singleton()->_exit_world); get_script_instance()->call(SceneStringName(_exit_world));
} }
data.viewport = nullptr; data.viewport = nullptr;
@ -564,7 +564,7 @@ void Node3D::update_gizmos() {
} }
if (data.gizmos.is_empty()) { if (data.gizmos.is_empty()) {
get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringNames::get_singleton()->_spatial_editor_group, SNAME("_request_gizmo_for_id"), get_instance_id()); get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringName(_spatial_editor_group), SNAME("_request_gizmo_for_id"), get_instance_id());
return; return;
} }
if (data.gizmos_dirty) { if (data.gizmos_dirty) {
@ -583,7 +583,7 @@ void Node3D::set_subgizmo_selection(Ref<Node3DGizmo> p_gizmo, int p_id, Transfor
} }
if (is_part_of_edited_scene()) { if (is_part_of_edited_scene()) {
get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringNames::get_singleton()->_spatial_editor_group, SceneStringNames::get_singleton()->_set_subgizmo_selection, this, p_gizmo, p_id, p_transform); get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringName(_spatial_editor_group), SceneStringName(_set_subgizmo_selection), this, p_gizmo, p_id, p_transform);
} }
#endif #endif
} }
@ -600,7 +600,7 @@ void Node3D::clear_subgizmo_selection() {
} }
if (is_part_of_edited_scene()) { if (is_part_of_edited_scene()) {
get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringNames::get_singleton()->_spatial_editor_group, SceneStringNames::get_singleton()->_clear_subgizmo_selection, this); get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringName(_spatial_editor_group), SceneStringName(_clear_subgizmo_selection), this);
} }
#endif #endif
} }
@ -777,7 +777,7 @@ Ref<World3D> Node3D::get_world_3d() const {
void Node3D::_propagate_visibility_changed() { void Node3D::_propagate_visibility_changed() {
notification(NOTIFICATION_VISIBILITY_CHANGED); notification(NOTIFICATION_VISIBILITY_CHANGED);
emit_signal(SceneStringNames::get_singleton()->visibility_changed); emit_signal(SceneStringName(visibility_changed));
#ifdef TOOLS_ENABLED #ifdef TOOLS_ENABLED
if (!data.gizmos.is_empty()) { if (!data.gizmos.is_empty()) {

78
scene/3d/physics/area_3d.cpp
View File

@ -199,9 +199,9 @@ void Area3D::_body_enter_tree(ObjectID p_id) {
ERR_FAIL_COND(E->value.in_tree); ERR_FAIL_COND(E->value.in_tree);
E->value.in_tree = true; E->value.in_tree = true;
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape); emit_signal(SceneStringName(body_shape_entered), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape);
} }
} }
@ -213,9 +213,9 @@ void Area3D::_body_exit_tree(ObjectID p_id) {
ERR_FAIL_COND(!E); ERR_FAIL_COND(!E);
ERR_FAIL_COND(!E->value.in_tree); ERR_FAIL_COND(!E->value.in_tree);
E->value.in_tree = false; E->value.in_tree = false;
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape); emit_signal(SceneStringName(body_shape_exited), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].area_shape);
} }
} }
@ -229,9 +229,9 @@ void Area3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
locked = true; locked = true;
// Emit the appropriate signals. // Emit the appropriate signals.
if (body_in) { if (body_in) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, p_body, (Node *)nullptr, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_entered), p_body, (Node *)nullptr, p_body_shape, p_area_shape);
} else { } else {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, p_body, (Node *)nullptr, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_exited), p_body, (Node *)nullptr, p_body_shape, p_area_shape);
} }
locked = false; locked = false;
unlock_callback(); unlock_callback();
@ -257,10 +257,10 @@ void Area3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
E->value.rc = 0; E->value.rc = 0;
E->value.in_tree = node && node->is_inside_tree(); E->value.in_tree = node && node->is_inside_tree();
if (node) { if (node) {
node->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area3D::_body_enter_tree).bind(objid)); node->connect(SceneStringName(tree_entered), callable_mp(this, &Area3D::_body_enter_tree).bind(objid));
node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area3D::_body_exit_tree).bind(objid)); node->connect(SceneStringName(tree_exiting), callable_mp(this, &Area3D::_body_exit_tree).bind(objid));
if (E->value.in_tree) { if (E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
} }
} }
} }
@ -270,7 +270,7 @@ void Area3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
} }
if (!node || E->value.in_tree) { if (!node || E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, p_body, node, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_entered), p_body, node, p_body_shape, p_area_shape);
} }
} else { } else {
@ -284,15 +284,15 @@ void Area3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instance, i
if (E->value.rc == 0) { if (E->value.rc == 0) {
body_map.remove(E); body_map.remove(E);
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area3D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area3D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area3D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area3D::_body_exit_tree));
if (in_tree) { if (in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_exited, obj); emit_signal(SceneStringName(body_exited), obj);
} }
} }
} }
if (!node || in_tree) { if (!node || in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, p_body, obj, p_body_shape, p_area_shape); emit_signal(SceneStringName(body_shape_exited), p_body, obj, p_body_shape, p_area_shape);
} }
} }
@ -317,18 +317,18 @@ void Area3D::_clear_monitoring() {
} }
//ERR_CONTINUE(!node); //ERR_CONTINUE(!node);
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area3D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area3D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area3D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area3D::_body_exit_tree));
if (!E.value.in_tree) { if (!E.value.in_tree) {
continue; continue;
} }
for (int i = 0; i < E.value.shapes.size(); i++) { for (int i = 0; i < E.value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, E.value.rid, node, E.value.shapes[i].body_shape, E.value.shapes[i].area_shape); emit_signal(SceneStringName(body_shape_exited), E.value.rid, node, E.value.shapes[i].body_shape, E.value.shapes[i].area_shape);
} }
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
} }
} }
@ -346,18 +346,18 @@ void Area3D::_clear_monitoring() {
} }
//ERR_CONTINUE(!node); //ERR_CONTINUE(!node);
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area3D::_area_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area3D::_area_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area3D::_area_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area3D::_area_exit_tree));
if (!E.value.in_tree) { if (!E.value.in_tree) {
continue; continue;
} }
for (int i = 0; i < E.value.shapes.size(); i++) { for (int i = 0; i < E.value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, E.value.rid, node, E.value.shapes[i].area_shape, E.value.shapes[i].self_shape); emit_signal(SceneStringName(area_shape_exited), E.value.rid, node, E.value.shapes[i].area_shape, E.value.shapes[i].self_shape);
} }
emit_signal(SceneStringNames::get_singleton()->area_exited, obj); emit_signal(SceneStringName(area_exited), obj);
} }
} }
} }
@ -405,9 +405,9 @@ void Area3D::_area_enter_tree(ObjectID p_id) {
ERR_FAIL_COND(E->value.in_tree); ERR_FAIL_COND(E->value.in_tree);
E->value.in_tree = true; E->value.in_tree = true;
emit_signal(SceneStringNames::get_singleton()->area_entered, node); emit_signal(SceneStringName(area_entered), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->area_shape_entered, E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape); emit_signal(SceneStringName(area_shape_entered), E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape);
} }
} }
@ -419,9 +419,9 @@ void Area3D::_area_exit_tree(ObjectID p_id) {
ERR_FAIL_COND(!E); ERR_FAIL_COND(!E);
ERR_FAIL_COND(!E->value.in_tree); ERR_FAIL_COND(!E->value.in_tree);
E->value.in_tree = false; E->value.in_tree = false;
emit_signal(SceneStringNames::get_singleton()->area_exited, node); emit_signal(SceneStringName(area_exited), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape); emit_signal(SceneStringName(area_shape_exited), E->value.rid, node, E->value.shapes[i].area_shape, E->value.shapes[i].self_shape);
} }
} }
@ -435,9 +435,9 @@ void Area3D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
locked = true; locked = true;
// Emit the appropriate signals. // Emit the appropriate signals.
if (area_in) { if (area_in) {
emit_signal(SceneStringNames::get_singleton()->area_shape_entered, p_area, (Node *)nullptr, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_entered), p_area, (Node *)nullptr, p_area_shape, p_self_shape);
} else { } else {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, p_area, (Node *)nullptr, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_exited), p_area, (Node *)nullptr, p_area_shape, p_self_shape);
} }
locked = false; locked = false;
unlock_callback(); unlock_callback();
@ -463,10 +463,10 @@ void Area3D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
E->value.rc = 0; E->value.rc = 0;
E->value.in_tree = node && node->is_inside_tree(); E->value.in_tree = node && node->is_inside_tree();
if (node) { if (node) {
node->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area3D::_area_enter_tree).bind(objid)); node->connect(SceneStringName(tree_entered), callable_mp(this, &Area3D::_area_enter_tree).bind(objid));
node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area3D::_area_exit_tree).bind(objid)); node->connect(SceneStringName(tree_exiting), callable_mp(this, &Area3D::_area_exit_tree).bind(objid));
if (E->value.in_tree) { if (E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_entered, node); emit_signal(SceneStringName(area_entered), node);
} }
} }
} }
@ -476,7 +476,7 @@ void Area3D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
} }
if (!node || E->value.in_tree) { if (!node || E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_shape_entered, p_area, node, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_entered), p_area, node, p_area_shape, p_self_shape);
} }
} else { } else {
@ -490,15 +490,15 @@ void Area3D::_area_inout(int p_status, const RID &p_area, ObjectID p_instance, i
if (E->value.rc == 0) { if (E->value.rc == 0) {
area_map.remove(E); area_map.remove(E);
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &Area3D::_area_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &Area3D::_area_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Area3D::_area_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Area3D::_area_exit_tree));
if (in_tree) { if (in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_exited, obj); emit_signal(SceneStringName(area_exited), obj);
} }
} }
} }
if (!node || in_tree) { if (!node || in_tree) {
emit_signal(SceneStringNames::get_singleton()->area_shape_exited, p_area, obj, p_area_shape, p_self_shape); emit_signal(SceneStringName(area_shape_exited), p_area, obj, p_area_shape, p_self_shape);
} }
} }
@ -605,7 +605,7 @@ StringName Area3D::get_audio_bus_name() const {
return audio_bus; return audio_bus;
} }
} }
return SceneStringNames::get_singleton()->Master; return SceneStringName(Master);
} }
void Area3D::set_use_reverb_bus(bool p_enable) { void Area3D::set_use_reverb_bus(bool p_enable) {
@ -626,7 +626,7 @@ StringName Area3D::get_reverb_bus_name() const {
return reverb_bus; return reverb_bus;
} }
} }
return SceneStringNames::get_singleton()->Master; return SceneStringName(Master);
} }
void Area3D::set_reverb_amount(float p_amount) { void Area3D::set_reverb_amount(float p_amount) {
@ -812,6 +812,8 @@ void Area3D::_bind_methods() {
Area3D::Area3D() : Area3D::Area3D() :
CollisionObject3D(PhysicsServer3D::get_singleton()->area_create(), true) { CollisionObject3D(PhysicsServer3D::get_singleton()->area_create(), true) {
audio_bus = SceneStringName(Master);
reverb_bus = SceneStringName(Master);
set_gravity(9.8); set_gravity(9.8);
set_gravity_direction(Vector3(0, -1, 0)); set_gravity_direction(Vector3(0, -1, 0));
set_monitoring(true); set_monitoring(true);

4
scene/3d/physics/area_3d.h
View File

@ -135,10 +135,10 @@ private:
void _clear_monitoring(); void _clear_monitoring();
bool audio_bus_override = false; bool audio_bus_override = false;
StringName audio_bus = SceneStringNames::get_singleton()->Master; StringName audio_bus;
bool use_reverb_bus = false; bool use_reverb_bus = false;
StringName reverb_bus = SceneStringNames::get_singleton()->Master; StringName reverb_bus;
float reverb_amount = 0.0; float reverb_amount = 0.0;
float reverb_uniformity = 0.0; float reverb_uniformity = 0.0;

6
scene/3d/physics/collision_object_3d.cpp
View File

@ -291,17 +291,17 @@ void CollisionObject3D::_apply_enabled() {
void CollisionObject3D::_input_event_call(Camera3D *p_camera, const Ref<InputEvent> &p_input_event, const Vector3 &p_pos, const Vector3 &p_normal, int p_shape) { void CollisionObject3D::_input_event_call(Camera3D *p_camera, const Ref<InputEvent> &p_input_event, const Vector3 &p_pos, const Vector3 &p_normal, int p_shape) {
GDVIRTUAL_CALL(_input_event, p_camera, p_input_event, p_pos, p_normal, p_shape); GDVIRTUAL_CALL(_input_event, p_camera, p_input_event, p_pos, p_normal, p_shape);
emit_signal(SceneStringNames::get_singleton()->input_event, p_camera, p_input_event, p_pos, p_normal, p_shape); emit_signal(SceneStringName(input_event), p_camera, p_input_event, p_pos, p_normal, p_shape);
} }
void CollisionObject3D::_mouse_enter() { void CollisionObject3D::_mouse_enter() {
GDVIRTUAL_CALL(_mouse_enter); GDVIRTUAL_CALL(_mouse_enter);
emit_signal(SceneStringNames::get_singleton()->mouse_entered); emit_signal(SceneStringName(mouse_entered));
} }
void CollisionObject3D::_mouse_exit() { void CollisionObject3D::_mouse_exit() {
GDVIRTUAL_CALL(_mouse_exit); GDVIRTUAL_CALL(_mouse_exit);
emit_signal(SceneStringNames::get_singleton()->mouse_exited); emit_signal(SceneStringName(mouse_exited));
} }
void CollisionObject3D::set_body_mode(PhysicsServer3D::BodyMode p_mode) { void CollisionObject3D::set_body_mode(PhysicsServer3D::BodyMode p_mode) {

8
scene/3d/physics/joints/joint_3d.cpp
View File

@ -36,13 +36,13 @@ void Joint3D::_disconnect_signals() {
Node *node_a = get_node_or_null(a); Node *node_a = get_node_or_null(a);
PhysicsBody3D *body_a = Object::cast_to<PhysicsBody3D>(node_a); PhysicsBody3D *body_a = Object::cast_to<PhysicsBody3D>(node_a);
if (body_a) { if (body_a) {
body_a->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint3D::_body_exit_tree)); body_a->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Joint3D::_body_exit_tree));
} }
Node *node_b = get_node_or_null(b); Node *node_b = get_node_or_null(b);
PhysicsBody3D *body_b = Object::cast_to<PhysicsBody3D>(node_b); PhysicsBody3D *body_b = Object::cast_to<PhysicsBody3D>(node_b);
if (body_b) { if (body_b) {
body_b->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint3D::_body_exit_tree)); body_b->disconnect(SceneStringName(tree_exiting), callable_mp(this, &Joint3D::_body_exit_tree));
} }
} }
@ -108,12 +108,12 @@ void Joint3D::_update_joint(bool p_only_free) {
if (body_a) { if (body_a) {
ba = body_a->get_rid(); ba = body_a->get_rid();
body_a->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint3D::_body_exit_tree)); body_a->connect(SceneStringName(tree_exiting), callable_mp(this, &Joint3D::_body_exit_tree));
} }
if (body_b) { if (body_b) {
bb = body_b->get_rid(); bb = body_b->get_rid();
body_b->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &Joint3D::_body_exit_tree)); body_b->connect(SceneStringName(tree_exiting), callable_mp(this, &Joint3D::_body_exit_tree));
} }
PhysicsServer3D::get_singleton()->joint_disable_collisions_between_bodies(joint, exclude_from_collision); PhysicsServer3D::get_singleton()->joint_disable_collisions_between_bodies(joint, exclude_from_collision);

30
scene/3d/physics/rigid_body_3d.cpp
View File

@ -45,10 +45,10 @@ void RigidBody3D::_body_enter_tree(ObjectID p_id) {
contact_monitor->locked = true; contact_monitor->locked = true;
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape); emit_signal(SceneStringName(body_shape_entered), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape);
} }
contact_monitor->locked = false; contact_monitor->locked = false;
@ -66,10 +66,10 @@ void RigidBody3D::_body_exit_tree(ObjectID p_id) {
contact_monitor->locked = true; contact_monitor->locked = true;
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
for (int i = 0; i < E->value.shapes.size(); i++) { for (int i = 0; i < E->value.shapes.size(); i++) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape); emit_signal(SceneStringName(body_shape_exited), E->value.rid, node, E->value.shapes[i].body_shape, E->value.shapes[i].local_shape);
} }
contact_monitor->locked = false; contact_monitor->locked = false;
@ -94,10 +94,10 @@ void RigidBody3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instan
//E->value.rc=0; //E->value.rc=0;
E->value.in_tree = node && node->is_inside_tree(); E->value.in_tree = node && node->is_inside_tree();
if (node) { if (node) {
node->connect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &RigidBody3D::_body_enter_tree).bind(objid)); node->connect(SceneStringName(tree_entered), callable_mp(this, &RigidBody3D::_body_enter_tree).bind(objid));
node->connect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &RigidBody3D::_body_exit_tree).bind(objid)); node->connect(SceneStringName(tree_exiting), callable_mp(this, &RigidBody3D::_body_exit_tree).bind(objid));
if (E->value.in_tree) { if (E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_entered, node); emit_signal(SceneStringName(body_entered), node);
} }
} }
} }
@ -107,7 +107,7 @@ void RigidBody3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instan
} }
if (E->value.in_tree) { if (E->value.in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_shape_entered, p_body, node, p_body_shape, p_local_shape); emit_signal(SceneStringName(body_shape_entered), p_body, node, p_body_shape, p_local_shape);
} }
} else { } else {
@ -121,17 +121,17 @@ void RigidBody3D::_body_inout(int p_status, const RID &p_body, ObjectID p_instan
if (E->value.shapes.is_empty()) { if (E->value.shapes.is_empty()) {
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &RigidBody3D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &RigidBody3D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &RigidBody3D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &RigidBody3D::_body_exit_tree));
if (in_tree) { if (in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_exited, node); emit_signal(SceneStringName(body_exited), node);
} }
} }
contact_monitor->body_map.remove(E); contact_monitor->body_map.remove(E);
} }
if (node && in_tree) { if (node && in_tree) {
emit_signal(SceneStringNames::get_singleton()->body_shape_exited, p_body, obj, p_body_shape, p_local_shape); emit_signal(SceneStringName(body_shape_exited), p_body, obj, p_body_shape, p_local_shape);
} }
} }
} }
@ -157,7 +157,7 @@ void RigidBody3D::_sync_body_state(PhysicsDirectBodyState3D *p_state) {
if (sleeping != p_state->is_sleeping()) { if (sleeping != p_state->is_sleeping()) {
sleeping = p_state->is_sleeping(); sleeping = p_state->is_sleeping();
emit_signal(SceneStringNames::get_singleton()->sleeping_state_changed); emit_signal(SceneStringName(sleeping_state_changed));
} }
} }
@ -613,8 +613,8 @@ void RigidBody3D::set_contact_monitor(bool p_enabled) {
Node *node = Object::cast_to<Node>(obj); Node *node = Object::cast_to<Node>(obj);
if (node) { if (node) {
node->disconnect(SceneStringNames::get_singleton()->tree_entered, callable_mp(this, &RigidBody3D::_body_enter_tree)); node->disconnect(SceneStringName(tree_entered), callable_mp(this, &RigidBody3D::_body_enter_tree));
node->disconnect(SceneStringNames::get_singleton()->tree_exiting, callable_mp(this, &RigidBody3D::_body_exit_tree)); node->disconnect(SceneStringName(tree_exiting), callable_mp(this, &RigidBody3D::_body_exit_tree));
} }
} }

8
scene/3d/skeleton_3d.cpp
View File

@ -314,7 +314,7 @@ void Skeleton3D::_notification(int p_what) {
_process_modifiers(); _process_modifiers();
} }
emit_signal(SceneStringNames::get_singleton()->skeleton_updated); emit_signal(SceneStringName(skeleton_updated));
// Update skins. // Update skins.
RenderingServer *rs = RenderingServer::get_singleton(); RenderingServer *rs = RenderingServer::get_singleton();
@ -605,7 +605,7 @@ void Skeleton3D::set_bone_enabled(int p_bone, bool p_enabled) {
ERR_FAIL_INDEX(p_bone, bone_size); ERR_FAIL_INDEX(p_bone, bone_size);
bones.write[p_bone].enabled = p_enabled; bones.write[p_bone].enabled = p_enabled;
emit_signal(SceneStringNames::get_singleton()->bone_enabled_changed, p_bone); emit_signal(SceneStringName(bone_enabled_changed), p_bone);
_make_dirty(); _make_dirty();
} }
@ -617,7 +617,7 @@ bool Skeleton3D::is_bone_enabled(int p_bone) const {
void Skeleton3D::set_show_rest_only(bool p_enabled) { void Skeleton3D::set_show_rest_only(bool p_enabled) {
show_rest_only = p_enabled; show_rest_only = p_enabled;
emit_signal(SceneStringNames::get_singleton()->show_rest_only_changed); emit_signal(SceneStringName(show_rest_only_changed));
_make_dirty(); _make_dirty();
} }
@ -840,7 +840,7 @@ void Skeleton3D::force_update_all_bone_transforms() {
if (updating) { if (updating) {
return; return;
} }
emit_signal(SceneStringNames::get_singleton()->pose_updated); emit_signal(SceneStringName(pose_updated));
} }
void Skeleton3D::force_update_bone_children_transforms(int p_bone_idx) { void Skeleton3D::force_update_bone_children_transforms(int p_bone_idx) {

22
scene/3d/sprite_3d.cpp
View File

@ -796,15 +796,15 @@ void Sprite3D::set_texture(const Ref<Texture2D> &p_texture) {
return; return;
} }
if (texture.is_valid()) { if (texture.is_valid()) {
texture->disconnect(SceneStringNames::get_singleton()->changed, callable_mp((SpriteBase3D *)this, &Sprite3D::_queue_redraw)); texture->disconnect(SceneStringName(changed), callable_mp((SpriteBase3D *)this, &Sprite3D::_queue_redraw));
} }
texture = p_texture; texture = p_texture;
if (texture.is_valid()) { if (texture.is_valid()) {
texture->connect(SceneStringNames::get_singleton()->changed, callable_mp((SpriteBase3D *)this, &Sprite3D::_queue_redraw)); texture->connect(SceneStringName(changed), callable_mp((SpriteBase3D *)this, &Sprite3D::_queue_redraw));
} }
_queue_redraw(); _queue_redraw();
emit_signal(SceneStringNames::get_singleton()->texture_changed); emit_signal(SceneStringName(texture_changed));
} }
Ref<Texture2D> Sprite3D::get_texture() const { Ref<Texture2D> Sprite3D::get_texture() const {
@ -849,7 +849,7 @@ void Sprite3D::set_frame(int p_frame) {
frame = p_frame; frame = p_frame;
_queue_redraw(); _queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
int Sprite3D::get_frame() const { int Sprite3D::get_frame() const {
@ -1122,7 +1122,7 @@ void AnimatedSprite3D::_notification(int p_what) {
} else { } else {
frame = last_frame; frame = last_frame;
pause(); pause();
emit_signal(SceneStringNames::get_singleton()->animation_finished); emit_signal(SceneStringName(animation_finished));
return; return;
} }
} else { } else {
@ -1131,7 +1131,7 @@ void AnimatedSprite3D::_notification(int p_what) {
_calc_frame_speed_scale(); _calc_frame_speed_scale();
frame_progress = 0.0; frame_progress = 0.0;
_queue_redraw(); _queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
double to_process = MIN((1.0 - frame_progress) / abs_speed, remaining); double to_process = MIN((1.0 - frame_progress) / abs_speed, remaining);
frame_progress += to_process * abs_speed; frame_progress += to_process * abs_speed;
@ -1146,7 +1146,7 @@ void AnimatedSprite3D::_notification(int p_what) {
} else { } else {
frame = 0; frame = 0;
pause(); pause();
emit_signal(SceneStringNames::get_singleton()->animation_finished); emit_signal(SceneStringName(animation_finished));
return; return;
} }
} else { } else {
@ -1155,7 +1155,7 @@ void AnimatedSprite3D::_notification(int p_what) {
_calc_frame_speed_scale(); _calc_frame_speed_scale();
frame_progress = 1.0; frame_progress = 1.0;
_queue_redraw(); _queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
double to_process = MIN(frame_progress / abs_speed, remaining); double to_process = MIN(frame_progress / abs_speed, remaining);
frame_progress -= to_process * abs_speed; frame_progress -= to_process * abs_speed;
@ -1177,12 +1177,12 @@ void AnimatedSprite3D::set_sprite_frames(const Ref<SpriteFrames> &p_frames) {
} }
if (frames.is_valid()) { if (frames.is_valid()) {
frames->disconnect(SceneStringNames::get_singleton()->changed, callable_mp(this, &AnimatedSprite3D::_res_changed)); frames->disconnect(SceneStringName(changed), callable_mp(this, &AnimatedSprite3D::_res_changed));
} }
stop(); stop();
frames = p_frames; frames = p_frames;
if (frames.is_valid()) { if (frames.is_valid()) {
frames->connect(SceneStringNames::get_singleton()->changed, callable_mp(this, &AnimatedSprite3D::_res_changed)); frames->connect(SceneStringName(changed), callable_mp(this, &AnimatedSprite3D::_res_changed));
List<StringName> al; List<StringName> al;
frames->get_animation_list(&al); frames->get_animation_list(&al);
@ -1249,7 +1249,7 @@ void AnimatedSprite3D::set_frame_and_progress(int p_frame, real_t p_progress) {
return; // No change, don't redraw. return; // No change, don't redraw.
} }
_queue_redraw(); _queue_redraw();
emit_signal(SceneStringNames::get_singleton()->frame_changed); emit_signal(SceneStringName(frame_changed));
} }
void AnimatedSprite3D::set_speed_scale(float p_speed_scale) { void AnimatedSprite3D::set_speed_scale(float p_speed_scale) {

4
scene/3d/visible_on_screen_notifier_3d.cpp
View File

@ -38,7 +38,7 @@ void VisibleOnScreenNotifier3D::_visibility_enter() {
} }
on_screen = true; on_screen = true;
emit_signal(SceneStringNames::get_singleton()->screen_entered); emit_signal(SceneStringName(screen_entered));
_screen_enter(); _screen_enter();
} }
void VisibleOnScreenNotifier3D::_visibility_exit() { void VisibleOnScreenNotifier3D::_visibility_exit() {
@ -47,7 +47,7 @@ void VisibleOnScreenNotifier3D::_visibility_exit() {
} }
on_screen = false; on_screen = false;
emit_signal(SceneStringNames::get_singleton()->screen_exited); emit_signal(SceneStringName(screen_exited));
_screen_exit(); _screen_exit();
} }

8
scene/3d/visual_instance_3d.cpp
View File

@ -169,11 +169,11 @@ VisualInstance3D::~VisualInstance3D() {
void GeometryInstance3D::set_material_override(const Ref<Material> &p_material) { void GeometryInstance3D::set_material_override(const Ref<Material> &p_material) {
if (material_override.is_valid()) { if (material_override.is_valid()) {
material_override->disconnect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); material_override->disconnect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
material_override = p_material; material_override = p_material;
if (material_override.is_valid()) { if (material_override.is_valid()) {
material_override->connect(CoreStringNames::get_singleton()->property_list_changed, callable_mp((Object *)this, &Object::notify_property_list_changed)); material_override->connect(CoreStringName(property_list_changed), callable_mp((Object *)this, &Object::notify_property_list_changed));
} }
RS::get_singleton()->instance_geometry_set_material_override(get_instance(), p_material.is_valid() ? p_material->get_rid() : RID()); RS::get_singleton()->instance_geometry_set_material_override(get_instance(), p_material.is_valid() ? p_material->get_rid() : RID());
} }
@ -279,12 +279,12 @@ bool GeometryInstance3D::_set(const StringName &p_name, const Variant &p_value)
return true; return true;
} }
#ifndef DISABLE_DEPRECATED #ifndef DISABLE_DEPRECATED
if (p_name == SceneStringNames::get_singleton()->use_in_baked_light && bool(p_value)) { if (p_name == SceneStringName(use_in_baked_light) && bool(p_value)) {
set_gi_mode(GI_MODE_STATIC); set_gi_mode(GI_MODE_STATIC);
return true; return true;
} }
if (p_name == SceneStringNames::get_singleton()->use_dynamic_gi && bool(p_value)) { if (p_name == SceneStringName(use_dynamic_gi) && bool(p_value)) {
set_gi_mode(GI_MODE_DYNAMIC); set_gi_mode(GI_MODE_DYNAMIC);
return true; return true;
} }

16
scene/animation/animation_blend_tree.cpp
View File

@ -1421,7 +1421,7 @@ AnimationNodeOutput::AnimationNodeOutput() {
void AnimationNodeBlendTree::add_node(const StringName &p_name, Ref<AnimationNode> p_node, const Vector2 &p_position) { void AnimationNodeBlendTree::add_node(const StringName &p_name, Ref<AnimationNode> p_node, const Vector2 &p_position) {
ERR_FAIL_COND(nodes.has(p_name)); ERR_FAIL_COND(nodes.has(p_name));
ERR_FAIL_COND(p_node.is_null()); ERR_FAIL_COND(p_node.is_null());
ERR_FAIL_COND(p_name == SceneStringNames::get_singleton()->output); ERR_FAIL_COND(p_name == SceneStringName(output));
ERR_FAIL_COND(String(p_name).contains("/")); ERR_FAIL_COND(String(p_name).contains("/"));
Node n; Node n;
@ -1491,7 +1491,7 @@ Vector<StringName> AnimationNodeBlendTree::get_node_connection_array(const Strin
void AnimationNodeBlendTree::remove_node(const StringName &p_name) { void AnimationNodeBlendTree::remove_node(const StringName &p_name) {
ERR_FAIL_COND(!nodes.has(p_name)); ERR_FAIL_COND(!nodes.has(p_name));
ERR_FAIL_COND(p_name == SceneStringNames::get_singleton()->output); //can't delete output ERR_FAIL_COND(p_name == SceneStringName(output)); //can't delete output
{ {
Ref<AnimationNode> node = nodes[p_name].node; Ref<AnimationNode> node = nodes[p_name].node;
@ -1520,8 +1520,8 @@ void AnimationNodeBlendTree::remove_node(const StringName &p_name) {
void AnimationNodeBlendTree::rename_node(const StringName &p_name, const StringName &p_new_name) { void AnimationNodeBlendTree::rename_node(const StringName &p_name, const StringName &p_new_name) {
ERR_FAIL_COND(!nodes.has(p_name)); ERR_FAIL_COND(!nodes.has(p_name));
ERR_FAIL_COND(nodes.has(p_new_name)); ERR_FAIL_COND(nodes.has(p_new_name));
ERR_FAIL_COND(p_name == SceneStringNames::get_singleton()->output); ERR_FAIL_COND(p_name == SceneStringName(output));
ERR_FAIL_COND(p_new_name == SceneStringNames::get_singleton()->output); ERR_FAIL_COND(p_new_name == SceneStringName(output));
nodes[p_name].node->disconnect_changed(callable_mp(this, &AnimationNodeBlendTree::_node_changed)); nodes[p_name].node->disconnect_changed(callable_mp(this, &AnimationNodeBlendTree::_node_changed));
@ -1546,7 +1546,7 @@ void AnimationNodeBlendTree::rename_node(const StringName &p_name, const StringN
void AnimationNodeBlendTree::connect_node(const StringName &p_input_node, int p_input_index, const StringName &p_output_node) { void AnimationNodeBlendTree::connect_node(const StringName &p_input_node, int p_input_index, const StringName &p_output_node) {
ERR_FAIL_COND(!nodes.has(p_output_node)); ERR_FAIL_COND(!nodes.has(p_output_node));
ERR_FAIL_COND(!nodes.has(p_input_node)); ERR_FAIL_COND(!nodes.has(p_input_node));
ERR_FAIL_COND(p_output_node == SceneStringNames::get_singleton()->output); ERR_FAIL_COND(p_output_node == SceneStringName(output));
ERR_FAIL_COND(p_input_node == p_output_node); ERR_FAIL_COND(p_input_node == p_output_node);
Ref<AnimationNode> input = nodes[p_input_node].node; Ref<AnimationNode> input = nodes[p_input_node].node;
@ -1574,7 +1574,7 @@ void AnimationNodeBlendTree::disconnect_node(const StringName &p_node, int p_inp
} }
AnimationNodeBlendTree::ConnectionError AnimationNodeBlendTree::can_connect_node(const StringName &p_input_node, int p_input_index, const StringName &p_output_node) const { AnimationNodeBlendTree::ConnectionError AnimationNodeBlendTree::can_connect_node(const StringName &p_input_node, int p_input_index, const StringName &p_output_node) const {
if (!nodes.has(p_output_node) || p_output_node == SceneStringNames::get_singleton()->output) { if (!nodes.has(p_output_node) || p_output_node == SceneStringName(output)) {
return CONNECTION_ERROR_NO_OUTPUT; return CONNECTION_ERROR_NO_OUTPUT;
} }
@ -1627,8 +1627,8 @@ String AnimationNodeBlendTree::get_caption() const {
} }
AnimationNode::NodeTimeInfo AnimationNodeBlendTree::_process(const AnimationMixer::PlaybackInfo p_playback_info, bool p_test_only) { AnimationNode::NodeTimeInfo AnimationNodeBlendTree::_process(const AnimationMixer::PlaybackInfo p_playback_info, bool p_test_only) {
Ref<AnimationNodeOutput> output = nodes[SceneStringNames::get_singleton()->output].node; Ref<AnimationNodeOutput> output = nodes[SceneStringName(output)].node;
node_state.connections = nodes[SceneStringNames::get_singleton()->output].connections; node_state.connections = nodes[SceneStringName(output)].connections;
ERR_FAIL_COND_V(output.is_null(), NodeTimeInfo()); ERR_FAIL_COND_V(output.is_null(), NodeTimeInfo());
AnimationMixer::PlaybackInfo pi = p_playback_info; AnimationMixer::PlaybackInfo pi = p_playback_info;

20
scene/animation/animation_mixer.cpp
View File

@ -628,9 +628,9 @@ bool AnimationMixer::_update_caches() {
#endif #endif
Ref<Animation> reset_anim; Ref<Animation> reset_anim;
bool has_reset_anim = has_animation(SceneStringNames::get_singleton()->RESET); bool has_reset_anim = has_animation(SceneStringName(RESET));
if (has_reset_anim) { if (has_reset_anim) {
reset_anim = get_animation(SceneStringNames::get_singleton()->RESET); reset_anim = get_animation(SceneStringName(RESET));
} }
for (const StringName &E : sname) { for (const StringName &E : sname) {
Ref<Animation> anim = get_animation(E); Ref<Animation> anim = get_animation(E);
@ -1926,7 +1926,7 @@ bool AnimationMixer::is_reset_on_save_enabled() const {
} }
bool AnimationMixer::can_apply_reset() const { bool AnimationMixer::can_apply_reset() const {
return has_animation(SceneStringNames::get_singleton()->RESET); return has_animation(SceneStringName(RESET));
} }
void AnimationMixer::_build_backup_track_cache() { void AnimationMixer::_build_backup_track_cache() {
@ -2013,7 +2013,7 @@ Ref<AnimatedValuesBackup> AnimationMixer::make_backup() {
Ref<AnimatedValuesBackup> backup; Ref<AnimatedValuesBackup> backup;
backup.instantiate(); backup.instantiate();
Ref<Animation> reset_anim = animation_set[SceneStringNames::get_singleton()->RESET].animation; Ref<Animation> reset_anim = animation_set[SceneStringName(RESET)].animation;
ERR_FAIL_COND_V(reset_anim.is_null(), Ref<AnimatedValuesBackup>()); ERR_FAIL_COND_V(reset_anim.is_null(), Ref<AnimatedValuesBackup>());
_blend_init(); _blend_init();
@ -2022,7 +2022,7 @@ Ref<AnimatedValuesBackup> AnimationMixer::make_backup() {
pi.delta = 0; pi.delta = 0;
pi.seeked = true; pi.seeked = true;
pi.weight = 1.0; pi.weight = 1.0;
make_animation_instance(SceneStringNames::get_singleton()->RESET, pi); make_animation_instance(SceneStringName(RESET), pi);
_build_backup_track_cache(); _build_backup_track_cache();
backup->set_data(track_cache); backup->set_data(track_cache);
@ -2034,7 +2034,7 @@ Ref<AnimatedValuesBackup> AnimationMixer::make_backup() {
void AnimationMixer::reset() { void AnimationMixer::reset() {
ERR_FAIL_COND(!can_apply_reset()); ERR_FAIL_COND(!can_apply_reset());
Ref<Animation> reset_anim = animation_set[SceneStringNames::get_singleton()->RESET].animation; Ref<Animation> reset_anim = animation_set[SceneStringName(RESET)].animation;
ERR_FAIL_COND(reset_anim.is_null()); ERR_FAIL_COND(reset_anim.is_null());
Node *root_node_object = get_node_or_null(root_node); Node *root_node_object = get_node_or_null(root_node);
@ -2044,11 +2044,11 @@ void AnimationMixer::reset() {
root_node_object->add_child(aux_player); root_node_object->add_child(aux_player);
Ref<AnimationLibrary> al; Ref<AnimationLibrary> al;
al.instantiate(); al.instantiate();
al->add_animation(SceneStringNames::get_singleton()->RESET, reset_anim); al->add_animation(SceneStringName(RESET), reset_anim);
aux_player->set_reset_on_save_enabled(false); aux_player->set_reset_on_save_enabled(false);
aux_player->set_root_node(aux_player->get_path_to(root_node_object)); aux_player->set_root_node(aux_player->get_path_to(root_node_object));
aux_player->add_animation_library("", al); aux_player->add_animation_library("", al);
aux_player->set_assigned_animation(SceneStringNames::get_singleton()->RESET); aux_player->set_assigned_animation(SceneStringName(RESET));
aux_player->seek(0.0f, true); aux_player->seek(0.0f, true);
aux_player->queue_free(); aux_player->queue_free();
} }
@ -2068,7 +2068,7 @@ Ref<AnimatedValuesBackup> AnimationMixer::apply_reset(bool p_user_initiated) {
} }
ERR_FAIL_COND_V(!can_apply_reset(), Ref<AnimatedValuesBackup>()); ERR_FAIL_COND_V(!can_apply_reset(), Ref<AnimatedValuesBackup>());
Ref<Animation> reset_anim = animation_set[SceneStringNames::get_singleton()->RESET].animation; Ref<Animation> reset_anim = animation_set[SceneStringName(RESET)].animation;
ERR_FAIL_COND_V(reset_anim.is_null(), Ref<AnimatedValuesBackup>()); ERR_FAIL_COND_V(reset_anim.is_null(), Ref<AnimatedValuesBackup>());
Ref<AnimatedValuesBackup> backup_current = make_backup(); Ref<AnimatedValuesBackup> backup_current = make_backup();
@ -2286,7 +2286,7 @@ void AnimationMixer::_bind_methods() {
} }
AnimationMixer::AnimationMixer() { AnimationMixer::AnimationMixer() {
root_node = SceneStringNames::get_singleton()->path_pp; root_node = SceneStringName(path_pp);
} }
AnimationMixer::~AnimationMixer() { AnimationMixer::~AnimationMixer() {

8
scene/animation/animation_player.cpp
View File

@ -41,7 +41,7 @@ bool AnimationPlayer::_set(const StringName &p_name, const Variant &p_value) {
} else if (name.begins_with("next/")) { } else if (name.begins_with("next/")) {
String which = name.get_slicec('/', 1); String which = name.get_slicec('/', 1);
animation_set_next(which, p_value); animation_set_next(which, p_value);
} else if (p_name == SceneStringNames::get_singleton()->blend_times) { } else if (p_name == SceneStringName(blend_times)) {
Array array = p_value; Array array = p_value;
int len = array.size(); int len = array.size();
ERR_FAIL_COND_V(len % 3, false); ERR_FAIL_COND_V(len % 3, false);
@ -326,14 +326,14 @@ void AnimationPlayer::_blend_post_process() {
String new_name = playback.assigned; String new_name = playback.assigned;
playback_queue.pop_front(); playback_queue.pop_front();
if (end_notify) { if (end_notify) {
emit_signal(SceneStringNames::get_singleton()->animation_changed, old, new_name); emit_signal(SceneStringName(animation_changed), old, new_name);
} }
} else { } else {
_clear_caches(); _clear_caches();
playing = false; playing = false;
_set_process(false); _set_process(false);
if (end_notify) { if (end_notify) {
emit_signal(SceneStringNames::get_singleton()->animation_finished, playback.assigned); emit_signal(SceneStringName(animation_finished), playback.assigned);
if (movie_quit_on_finish && OS::get_singleton()->has_feature("movie")) { if (movie_quit_on_finish && OS::get_singleton()->has_feature("movie")) {
print_line(vformat("Movie Maker mode is enabled. Quitting on animation finish as requested by: %s", get_path())); print_line(vformat("Movie Maker mode is enabled. Quitting on animation finish as requested by: %s", get_path()));
get_tree()->quit(); get_tree()->quit();
@ -463,7 +463,7 @@ void AnimationPlayer::_play(const StringName &p_name, double p_custom_blend, flo
_set_process(true); // Always process when starting an animation. _set_process(true); // Always process when starting an animation.
playing = true; playing = true;
emit_signal(SceneStringNames::get_singleton()->animation_started, c.assigned); emit_signal(SceneStringName(animation_started), c.assigned);
if (is_inside_tree() && Engine::get_singleton()->is_editor_hint()) { if (is_inside_tree() && Engine::get_singleton()->is_editor_hint()) {
return; // No next in this case. return; // No next in this case.

6
scene/animation/animation_tree.cpp
View File

@ -627,7 +627,7 @@ bool AnimationTree::_blend_pre_process(double p_delta, int p_track_count, const
for (int i = 0; i < p_track_count; i++) { for (int i = 0; i < p_track_count; i++) {
src_blendsw[i] = 1.0; // By default all go to 1 for the root input. src_blendsw[i] = 1.0; // By default all go to 1 for the root input.
} }
root_animation_node->node_state.base_path = SceneStringNames::get_singleton()->parameters_base_path; root_animation_node->node_state.base_path = SceneStringName(parameters_base_path);
root_animation_node->node_state.parent = nullptr; root_animation_node->node_state.parent = nullptr;
} }
@ -788,7 +788,7 @@ void AnimationTree::_update_properties() {
input_activity_map_get.clear(); input_activity_map_get.clear();
if (root_animation_node.is_valid()) { if (root_animation_node.is_valid()) {
_update_properties_for_node(SceneStringNames::get_singleton()->parameters_base_path, root_animation_node); _update_properties_for_node(SceneStringName(parameters_base_path), root_animation_node);
} }
properties_dirty = false; properties_dirty = false;
@ -810,7 +810,7 @@ void AnimationTree::_notification(int p_what) {
void AnimationTree::set_animation_player(const NodePath &p_path) { void AnimationTree::set_animation_player(const NodePath &p_path) {
animation_player = p_path; animation_player = p_path;
if (p_path.is_empty()) { if (p_path.is_empty()) {
set_root_node(SceneStringNames::get_singleton()->path_pp); set_root_node(SceneStringName(path_pp));
while (animation_libraries.size()) { while (animation_libraries.size()) {
remove_animation_library(animation_libraries[0].name); remove_animation_library(animation_libraries[0].name);
} }

4
scene/audio/audio_stream_player_internal.cpp
View File

@ -307,14 +307,14 @@ StringName AudioStreamPlayerInternal::get_bus() const {
return bus; return bus;
} }
} }
return SceneStringNames::get_singleton()->Master; return SceneStringName(Master);
} }
AudioStreamPlayerInternal::AudioStreamPlayerInternal(Node *p_node, const Callable &p_play_callable, bool p_physical) { AudioStreamPlayerInternal::AudioStreamPlayerInternal(Node *p_node, const Callable &p_play_callable, bool p_physical) {
node = p_node; node = p_node;
play_callable = p_play_callable; play_callable = p_play_callable;
physical = p_physical; physical = p_physical;
bus = SceneStringNames::get_singleton()->Master; bus = SceneStringName(Master);
AudioServer::get_singleton()->connect("bus_layout_changed", callable_mp((Object *)node, &Object::notify_property_list_changed)); AudioServer::get_singleton()->connect("bus_layout_changed", callable_mp((Object *)node, &Object::notify_property_list_changed));
AudioServer::get_singleton()->connect("bus_renamed", callable_mp((Object *)node, &Object::notify_property_list_changed).unbind(3)); AudioServer::get_singleton()->connect("bus_renamed", callable_mp((Object *)node, &Object::notify_property_list_changed).unbind(3));

4
scene/gui/container.cpp
View File

@ -86,10 +86,10 @@ void Container::_sort_children() {
} }
notification(NOTIFICATION_PRE_SORT_CHILDREN); notification(NOTIFICATION_PRE_SORT_CHILDREN);
emit_signal(SceneStringNames::get_singleton()->pre_sort_children); emit_signal(SceneStringName(pre_sort_children));
notification(NOTIFICATION_SORT_CHILDREN); notification(NOTIFICATION_SORT_CHILDREN);
emit_signal(SceneStringNames::get_singleton()->sort_children); emit_signal(SceneStringName(sort_children));
pending_sort = false; pending_sort = false;
} }

22
scene/gui/control.cpp
View File

@ -1606,7 +1606,7 @@ void Control::_update_minimum_size() {
if (minsize != data.last_minimum_size) { if (minsize != data.last_minimum_size) {
data.last_minimum_size = minsize; data.last_minimum_size = minsize;
_size_changed(); _size_changed();
emit_signal(SceneStringNames::get_singleton()->minimum_size_changed); emit_signal(SceneStringName(minimum_size_changed));
} }
} }
@ -1770,7 +1770,7 @@ void Control::set_h_size_flags(BitField<SizeFlags> p_flags) {
return; return;
} }
data.h_size_flags = p_flags; data.h_size_flags = p_flags;
emit_signal(SceneStringNames::get_singleton()->size_flags_changed); emit_signal(SceneStringName(size_flags_changed));
} }
BitField<Control::SizeFlags> Control::get_h_size_flags() const { BitField<Control::SizeFlags> Control::get_h_size_flags() const {
@ -1784,7 +1784,7 @@ void Control::set_v_size_flags(BitField<SizeFlags> p_flags) {
return; return;
} }
data.v_size_flags = p_flags; data.v_size_flags = p_flags;
emit_signal(SceneStringNames::get_singleton()->size_flags_changed); emit_signal(SceneStringName(size_flags_changed));
} }
BitField<Control::SizeFlags> Control::get_v_size_flags() const { BitField<Control::SizeFlags> Control::get_v_size_flags() const {
@ -1799,7 +1799,7 @@ void Control::set_stretch_ratio(real_t p_ratio) {
} }
data.expand = p_ratio; data.expand = p_ratio;
emit_signal(SceneStringNames::get_singleton()->size_flags_changed); emit_signal(SceneStringName(size_flags_changed));
} }
real_t Control::get_stretch_ratio() const { real_t Control::get_stretch_ratio() const {
@ -1811,7 +1811,7 @@ real_t Control::get_stretch_ratio() const {
void Control::_call_gui_input(const Ref<InputEvent> &p_event) { void Control::_call_gui_input(const Ref<InputEvent> &p_event) {
if (p_event->get_device() != InputEvent::DEVICE_ID_INTERNAL) { if (p_event->get_device() != InputEvent::DEVICE_ID_INTERNAL) {
emit_signal(SceneStringNames::get_singleton()->gui_input, p_event); // Signal should be first, so it's possible to override an event (and then accept it). emit_signal(SceneStringName(gui_input), p_event); // Signal should be first, so it's possible to override an event (and then accept it).
} }
if (!is_inside_tree() || get_viewport()->is_input_handled()) { if (!is_inside_tree() || get_viewport()->is_input_handled()) {
return; // Input was handled, abort. return; // Input was handled, abort.
@ -3299,7 +3299,7 @@ void Control::_notification(int p_notification) {
} break; } break;
case NOTIFICATION_RESIZED: { case NOTIFICATION_RESIZED: {
emit_signal(SceneStringNames::get_singleton()->resized); emit_signal(SceneStringName(resized));
} break; } break;
case NOTIFICATION_DRAW: { case NOTIFICATION_DRAW: {
@ -3309,25 +3309,25 @@ void Control::_notification(int p_notification) {
} break; } break;
case NOTIFICATION_MOUSE_ENTER: { case NOTIFICATION_MOUSE_ENTER: {
emit_signal(SceneStringNames::get_singleton()->mouse_entered); emit_signal(SceneStringName(mouse_entered));
} break; } break;
case NOTIFICATION_MOUSE_EXIT: { case NOTIFICATION_MOUSE_EXIT: {
emit_signal(SceneStringNames::get_singleton()->mouse_exited); emit_signal(SceneStringName(mouse_exited));
} break; } break;
case NOTIFICATION_FOCUS_ENTER: { case NOTIFICATION_FOCUS_ENTER: {
emit_signal(SceneStringNames::get_singleton()->focus_entered); emit_signal(SceneStringName(focus_entered));
queue_redraw(); queue_redraw();
} break; } break;
case NOTIFICATION_FOCUS_EXIT: { case NOTIFICATION_FOCUS_EXIT: {
emit_signal(SceneStringNames::get_singleton()->focus_exited); emit_signal(SceneStringName(focus_exited));
queue_redraw(); queue_redraw();
} break; } break;
case NOTIFICATION_THEME_CHANGED: { case NOTIFICATION_THEME_CHANGED: {
emit_signal(SceneStringNames::get_singleton()->theme_changed); emit_signal(SceneStringName(theme_changed));
_invalidate_theme_cache(); _invalidate_theme_cache();
_update_theme_item_cache(); _update_theme_item_cache();

2
scene/gui/nine_patch_rect.cpp
View File

@ -111,7 +111,7 @@ void NinePatchRect::set_texture(const Ref<Texture2D> &p_tex) {
queue_redraw(); queue_redraw();
update_minimum_size(); update_minimum_size();
emit_signal(SceneStringNames::get_singleton()->texture_changed); emit_signal(SceneStringName(texture_changed));
} }
Ref<Texture2D> NinePatchRect::get_texture() const { Ref<Texture2D> NinePatchRect::get_texture() const {

4
scene/gui/video_stream_player.cpp
View File

@ -163,7 +163,7 @@ void VideoStreamPlayer::_notification(int p_notification) {
play(); play();
return; return;
} }
emit_signal(SceneStringNames::get_singleton()->finished); emit_signal(SceneStringName(finished));
} }
} break; } break;
@ -460,7 +460,7 @@ StringName VideoStreamPlayer::get_bus() const {
return bus; return bus;
} }
} }
return SceneStringNames::get_singleton()->Master; return SceneStringName(Master);
} }
void VideoStreamPlayer::_validate_property(PropertyInfo &p_property) const { void VideoStreamPlayer::_validate_property(PropertyInfo &p_property) const {

12
scene/main/canvas_item.cpp
View File

@ -95,7 +95,7 @@ void CanvasItem::_handle_visibility_change(bool p_visible) {
if (p_visible) { if (p_visible) {
queue_redraw(); queue_redraw();
} else { } else {
emit_signal(SceneStringNames::get_singleton()->hidden); emit_signal(SceneStringName(hidden));
} }
_block(); _block();
@ -141,7 +141,7 @@ void CanvasItem::_redraw_callback() {
drawing = true; drawing = true;
current_item_drawn = this; current_item_drawn = this;
notification(NOTIFICATION_DRAW); notification(NOTIFICATION_DRAW);
emit_signal(SceneStringNames::get_singleton()->draw); emit_signal(SceneStringName(draw));
GDVIRTUAL_CALL(_draw); GDVIRTUAL_CALL(_draw);
current_item_drawn = nullptr; current_item_drawn = nullptr;
drawing = false; drawing = false;
@ -309,7 +309,7 @@ void CanvasItem::_notification(int p_what) {
window = Object::cast_to<Window>(viewport); window = Object::cast_to<Window>(viewport);
if (window) { if (window) {
window->connect(SceneStringNames::get_singleton()->visibility_changed, callable_mp(this, &CanvasItem::_window_visibility_changed)); window->connect(SceneStringName(visibility_changed), callable_mp(this, &CanvasItem::_window_visibility_changed));
parent_visible_in_tree = window->is_visible(); parent_visible_in_tree = window->is_visible();
} else { } else {
parent_visible_in_tree = true; parent_visible_in_tree = true;
@ -363,7 +363,7 @@ void CanvasItem::_notification(int p_what) {
C = nullptr; C = nullptr;
} }
if (window) { if (window) {
window->disconnect(SceneStringNames::get_singleton()->visibility_changed, callable_mp(this, &CanvasItem::_window_visibility_changed)); window->disconnect(SceneStringName(visibility_changed), callable_mp(this, &CanvasItem::_window_visibility_changed));
window = nullptr; window = nullptr;
} }
_set_global_invalid(true); _set_global_invalid(true);
@ -383,7 +383,7 @@ void CanvasItem::_notification(int p_what) {
case NOTIFICATION_VISIBILITY_CHANGED: { case NOTIFICATION_VISIBILITY_CHANGED: {
ERR_MAIN_THREAD_GUARD; ERR_MAIN_THREAD_GUARD;
emit_signal(SceneStringNames::get_singleton()->visibility_changed); emit_signal(SceneStringName(visibility_changed));
} break; } break;
case NOTIFICATION_WORLD_2D_CHANGED: { case NOTIFICATION_WORLD_2D_CHANGED: {
ERR_MAIN_THREAD_GUARD; ERR_MAIN_THREAD_GUARD;
@ -555,7 +555,7 @@ void CanvasItem::item_rect_changed(bool p_size_changed) {
if (p_size_changed) { if (p_size_changed) {
queue_redraw(); queue_redraw();
} }
emit_signal(SceneStringNames::get_singleton()->item_rect_changed); emit_signal(SceneStringName(item_rect_changed));
} }
void CanvasItem::set_z_index(int p_z) { void CanvasItem::set_z_index(int p_z) {

16
scene/main/node.cpp
View File

@ -266,7 +266,7 @@ void Node::_propagate_ready() {
if (data.ready_first) { if (data.ready_first) {
data.ready_first = false; data.ready_first = false;
notification(NOTIFICATION_READY); notification(NOTIFICATION_READY);
emit_signal(SceneStringNames::get_singleton()->ready); emit_signal(SceneStringName(ready));
} }
} }
@ -295,7 +295,7 @@ void Node::_propagate_enter_tree() {
GDVIRTUAL_CALL(_enter_tree); GDVIRTUAL_CALL(_enter_tree);
emit_signal(SceneStringNames::get_singleton()->tree_entered); emit_signal(SceneStringName(tree_entered));
data.tree->node_added(this); data.tree->node_added(this);
@ -350,7 +350,7 @@ void Node::_propagate_after_exit_tree() {
data.blocked--; data.blocked--;
emit_signal(SceneStringNames::get_singleton()->tree_exited); emit_signal(SceneStringName(tree_exited));
} }
void Node::_propagate_exit_tree() { void Node::_propagate_exit_tree() {
@ -372,7 +372,7 @@ void Node::_propagate_exit_tree() {
GDVIRTUAL_CALL(_exit_tree); GDVIRTUAL_CALL(_exit_tree);
emit_signal(SceneStringNames::get_singleton()->tree_exiting); emit_signal(SceneStringName(tree_exiting));
notification(NOTIFICATION_EXIT_TREE, true); notification(NOTIFICATION_EXIT_TREE, true);
if (data.tree) { if (data.tree) {
@ -1738,11 +1738,11 @@ Node *Node::get_node_or_null(const NodePath &p_path) const {
StringName name = p_path.get_name(i); StringName name = p_path.get_name(i);
Node *next = nullptr; Node *next = nullptr;
if (name == SceneStringNames::get_singleton()->dot) { // . if (name == SceneStringName(dot)) { // .
next = current; next = current;
} else if (name == SceneStringNames::get_singleton()->doubledot) { // .. } else if (name == SceneStringName(doubledot)) { // ..
if (current == nullptr || !current->data.parent) { if (current == nullptr || !current->data.parent) {
return nullptr; return nullptr;
@ -2667,7 +2667,7 @@ Node *Node::_duplicate(int p_flags, HashMap<const Node *, Node *> *r_duplimap) c
node->data.editable_instance = data.editable_instance; node->data.editable_instance = data.editable_instance;
} }
StringName script_property_name = CoreStringNames::get_singleton()->_script; StringName script_property_name = CoreStringName(script);
List<const Node *> hidden_roots; List<const Node *> hidden_roots;
List<const Node *> node_tree; List<const Node *> node_tree;
@ -3323,7 +3323,7 @@ void Node::update_configuration_warnings() {
return; return;
} }
if (get_tree()->get_edited_scene_root() && (get_tree()->get_edited_scene_root() == this || get_tree()->get_edited_scene_root()->is_ancestor_of(this))) { if (get_tree()->get_edited_scene_root() && (get_tree()->get_edited_scene_root() == this || get_tree()->get_edited_scene_root()->is_ancestor_of(this))) {
get_tree()->emit_signal(SceneStringNames::get_singleton()->node_configuration_warning_changed, this); get_tree()->emit_signal(SceneStringName(node_configuration_warning_changed), this);
} }
#endif #endif
} }

12
scene/main/shader_globals_override.cpp
View File

@ -223,11 +223,11 @@ void ShaderGlobalsOverride::_get_property_list(List<PropertyInfo> *p_list) const
void ShaderGlobalsOverride::_activate() { void ShaderGlobalsOverride::_activate() {
ERR_FAIL_NULL(get_tree()); ERR_FAIL_NULL(get_tree());
List<Node *> nodes; List<Node *> nodes;
get_tree()->get_nodes_in_group(SceneStringNames::get_singleton()->shader_overrides_group_active, &nodes); get_tree()->get_nodes_in_group(SceneStringName(shader_overrides_group_active), &nodes);
if (nodes.size() == 0) { if (nodes.size() == 0) {
//good we are the only override, enable all //good we are the only override, enable all
active = true; active = true;
add_to_group(SceneStringNames::get_singleton()->shader_overrides_group_active); add_to_group(SceneStringName(shader_overrides_group_active));
for (const KeyValue<StringName, Override> &E : overrides) { for (const KeyValue<StringName, Override> &E : overrides) {
const Override *o = &E.value; const Override *o = &E.value;
@ -248,7 +248,7 @@ void ShaderGlobalsOverride::_activate() {
void ShaderGlobalsOverride::_notification(int p_what) { void ShaderGlobalsOverride::_notification(int p_what) {
switch (p_what) { switch (p_what) {
case Node::NOTIFICATION_ENTER_TREE: { case Node::NOTIFICATION_ENTER_TREE: {
add_to_group(SceneStringNames::get_singleton()->shader_overrides_group); add_to_group(SceneStringName(shader_overrides_group));
_activate(); _activate();
} break; } break;
@ -263,9 +263,9 @@ void ShaderGlobalsOverride::_notification(int p_what) {
} }
} }
remove_from_group(SceneStringNames::get_singleton()->shader_overrides_group_active); remove_from_group(SceneStringName(shader_overrides_group_active));
remove_from_group(SceneStringNames::get_singleton()->shader_overrides_group); remove_from_group(SceneStringName(shader_overrides_group));
get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringNames::get_singleton()->shader_overrides_group, "_activate"); //another may want to activate when this is removed get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, SceneStringName(shader_overrides_group), "_activate"); //another may want to activate when this is removed
active = false; active = false;
} break; } break;
} }

12
scene/main/window.cpp
View File

@ -846,7 +846,7 @@ void Window::set_visible(bool p_visible) {
focused = false; focused = false;
} }
notification(NOTIFICATION_VISIBILITY_CHANGED); notification(NOTIFICATION_VISIBILITY_CHANGED);
emit_signal(SceneStringNames::get_singleton()->visibility_changed); emit_signal(SceneStringName(visibility_changed));
RS::get_singleton()->viewport_set_active(get_viewport_rid(), visible); RS::get_singleton()->viewport_set_active(get_viewport_rid(), visible);
@ -1321,7 +1321,7 @@ void Window::_notification(int p_what) {
} }
if (visible) { if (visible) {
notification(NOTIFICATION_VISIBILITY_CHANGED); notification(NOTIFICATION_VISIBILITY_CHANGED);
emit_signal(SceneStringNames::get_singleton()->visibility_changed); emit_signal(SceneStringName(visibility_changed));
RS::get_singleton()->viewport_set_active(get_viewport_rid(), true); RS::get_singleton()->viewport_set_active(get_viewport_rid(), true);
} }
@ -1337,7 +1337,7 @@ void Window::_notification(int p_what) {
} break; } break;
case NOTIFICATION_THEME_CHANGED: { case NOTIFICATION_THEME_CHANGED: {
emit_signal(SceneStringNames::get_singleton()->theme_changed); emit_signal(SceneStringName(theme_changed));
_invalidate_theme_cache(); _invalidate_theme_cache();
_update_theme_item_cache(); _update_theme_item_cache();
} break; } break;
@ -1404,11 +1404,11 @@ void Window::_notification(int p_what) {
} break; } break;
case NOTIFICATION_VP_MOUSE_ENTER: { case NOTIFICATION_VP_MOUSE_ENTER: {
emit_signal(SceneStringNames::get_singleton()->mouse_entered); emit_signal(SceneStringName(mouse_entered));
} break; } break;
case NOTIFICATION_VP_MOUSE_EXIT: { case NOTIFICATION_VP_MOUSE_EXIT: {
emit_signal(SceneStringNames::get_singleton()->mouse_exited); emit_signal(SceneStringName(mouse_exited));
} break; } break;
} }
} }
@ -1622,7 +1622,7 @@ void Window::_window_input(const Ref<InputEvent> &p_ev) {
_input_from_window(p_ev); _input_from_window(p_ev);
if (p_ev->get_device() != InputEvent::DEVICE_ID_INTERNAL && is_inside_tree()) { if (p_ev->get_device() != InputEvent::DEVICE_ID_INTERNAL && is_inside_tree()) {
emit_signal(SceneStringNames::get_singleton()->window_input, p_ev); emit_signal(SceneStringName(window_input), p_ev);
} }
if (is_inside_tree()) { if (is_inside_tree()) {

2
scene/resources/packed_scene.cpp
View File

@ -328,7 +328,7 @@ Node *SceneState::instantiate(GenEditState p_edit_state) const {
ERR_FAIL_INDEX_V(nprops[j].name, sname_count, nullptr); ERR_FAIL_INDEX_V(nprops[j].name, sname_count, nullptr);
if (snames[nprops[j].name] == CoreStringNames::get_singleton()->_script) { if (snames[nprops[j].name] == CoreStringName(script)) {
//work around to avoid old script variables from disappearing, should be the proper fix to: //work around to avoid old script variables from disappearing, should be the proper fix to:
//https://github.com/godotengine/godot/issues/2958 //https://github.com/godotengine/godot/issues/2958

2
scene/resources/sprite_frames.cpp
View File

@ -277,5 +277,5 @@ void SpriteFrames::_bind_methods() {
} }
SpriteFrames::SpriteFrames() { SpriteFrames::SpriteFrames() {
add_animation(SceneStringNames::get_singleton()->_default); add_animation(SceneStringName(default_));
} }

2
scene/scene_string_names.cpp
View File

@ -196,7 +196,7 @@ SceneStringNames::SceneStringNames() {
// Audio bus name. // Audio bus name.
Master = StaticCString::create("Master"); Master = StaticCString::create("Master");
_default = StaticCString::create("default"); default_ = StaticCString::create("default");
_window_group = StaticCString::create("_window_group"); _window_group = StaticCString::create("_window_group");
_window_input = StaticCString::create("_window_input"); _window_input = StaticCString::create("_window_input");

4
scene/scene_string_names.h
View File

@ -198,7 +198,7 @@ public:
NodePath path_pp; NodePath path_pp;
StringName _default; StringName default_; // "default", conflict with C++ keyword.
StringName node_configuration_warning_changed; StringName node_configuration_warning_changed;
@ -224,4 +224,6 @@ public:
#endif #endif
}; };
#define SceneStringName(m_name) SceneStringNames::get_singleton()->m_name
#endif // SCENE_STRING_NAMES_H #endif // SCENE_STRING_NAMES_H

6
servers/audio_server.cpp
View File

@ -762,7 +762,7 @@ void AudioServer::set_bus_count(int p_count) {
buses[i]->bypass = false; buses[i]->bypass = false;
buses[i]->volume_db = 0; buses[i]->volume_db = 0;
if (i > 0) { if (i > 0) {
buses[i]->send = SceneStringNames::get_singleton()->Master; buses[i]->send = SceneStringName(Master);
} }
bus_map[attempt] = buses[i]; bus_map[attempt] = buses[i];
@ -1600,7 +1600,7 @@ void AudioServer::set_bus_layout(const Ref<AudioBusLayout> &p_bus_layout) {
for (int i = 0; i < p_bus_layout->buses.size(); i++) { for (int i = 0; i < p_bus_layout->buses.size(); i++) {
Bus *bus = memnew(Bus); Bus *bus = memnew(Bus);
if (i == 0) { if (i == 0) {
bus->name = SceneStringNames::get_singleton()->Master; bus->name = SceneStringName(Master);
} else { } else {
bus->name = p_bus_layout->buses[i].name; bus->name = p_bus_layout->buses[i].name;
bus->send = p_bus_layout->buses[i].send; bus->send = p_bus_layout->buses[i].send;
@ -1923,5 +1923,5 @@ void AudioBusLayout::_get_property_list(List<PropertyInfo> *p_list) const {
AudioBusLayout::AudioBusLayout() { AudioBusLayout::AudioBusLayout() {
buses.resize(1); buses.resize(1);
buses.write[0].name = SceneStringNames::get_singleton()->Master; buses.write[0].name = SceneStringName(Master);
} }

4
tests/core/object/test_object.h
View File

@ -251,7 +251,7 @@ TEST_CASE("[Object] Script property setter") {
Variant script; Variant script;
bool valid = false; bool valid = false;
object.set(CoreStringNames::get_singleton()->_script, script, &valid); object.set(CoreStringName(script), script, &valid);
CHECK(valid); CHECK(valid);
CHECK_MESSAGE( CHECK_MESSAGE(
object.get_script() == script, object.get_script() == script,
@ -264,7 +264,7 @@ TEST_CASE("[Object] Script property getter") {
object.set_script(script); object.set_script(script);
bool valid = false; bool valid = false;
const Variant &actual_value = object.get(CoreStringNames::get_singleton()->_script, &valid); const Variant &actual_value = object.get(CoreStringName(script), &valid);
CHECK(valid); CHECK(valid);
CHECK_MESSAGE( CHECK_MESSAGE(
actual_value == script, actual_value == script,