From a3cad44f442596893bf44a24b28af925b94a5f44 Mon Sep 17 00:00:00 2001 From: "Andrii Doroshenko (Xrayez)" Date: Wed, 20 May 2020 15:38:20 +0300 Subject: [PATCH] Add `Image.save_png_to_buffer` method Backported from da0457fa29e1ea63f89b1e1d73e72c4dc80a9966. This commit additionally exposes the method to scripting (4.0). --- core/image.cpp | 11 +++++++++++ core/image.h | 3 +++ drivers/png/resource_saver_png.cpp | 9 +++++++++ drivers/png/resource_saver_png.h | 1 + 4 files changed, 24 insertions(+) diff --git a/core/image.cpp b/core/image.cpp index eee81772159..ac2edf9c42f 100644 --- a/core/image.cpp +++ b/core/image.cpp @@ -85,6 +85,8 @@ const char *Image::format_names[Image::FORMAT_MAX] = { SavePNGFunc Image::save_png_func = NULL; SaveEXRFunc Image::save_exr_func = NULL; +SavePNGBufferFunc Image::save_png_buffer_func = NULL; + void Image::_put_pixelb(int p_x, int p_y, uint32_t p_pixelsize, uint8_t *p_data, const uint8_t *p_pixel) { uint32_t ofs = (p_y * width + p_x) * p_pixelsize; @@ -1898,6 +1900,14 @@ Error Image::save_png(const String &p_path) const { return save_png_func(p_path, Ref((Image *)this)); } +PoolVector Image::save_png_to_buffer() const { + if (save_png_buffer_func == NULL) { + return PoolVector(); + } + + return save_png_buffer_func(Ref((Image *)this)); +} + Error Image::save_exr(const String &p_path, bool p_grayscale) const { if (save_exr_func == NULL) @@ -2728,6 +2738,7 @@ void Image::_bind_methods() { ClassDB::bind_method(D_METHOD("load", "path"), &Image::load); ClassDB::bind_method(D_METHOD("save_png", "path"), &Image::save_png); + ClassDB::bind_method(D_METHOD("save_png_to_buffer"), &Image::save_png_to_buffer); ClassDB::bind_method(D_METHOD("save_exr", "path", "grayscale"), &Image::save_exr, DEFVAL(false)); ClassDB::bind_method(D_METHOD("detect_alpha"), &Image::detect_alpha); diff --git a/core/image.h b/core/image.h index c15cfc9f6ff..dfb0bce2701 100644 --- a/core/image.h +++ b/core/image.h @@ -47,6 +47,7 @@ class Image; typedef Error (*SavePNGFunc)(const String &p_path, const Ref &p_img); +typedef PoolVector (*SavePNGBufferFunc)(const Ref &p_img); typedef Ref (*ImageMemLoadFunc)(const uint8_t *p_png, int p_size); typedef Error (*SaveEXRFunc)(const String &p_path, const Ref &p_img, bool p_grayscale); @@ -57,6 +58,7 @@ class Image : public Resource { public: static SavePNGFunc save_png_func; static SaveEXRFunc save_exr_func; + static SavePNGBufferFunc save_png_buffer_func; enum { MAX_WIDTH = 16384, // force a limit somehow @@ -259,6 +261,7 @@ public: Error load(const String &p_path); Error save_png(const String &p_path) const; + PoolVector save_png_to_buffer() const; Error save_exr(const String &p_path, bool p_grayscale) const; /** diff --git a/drivers/png/resource_saver_png.cpp b/drivers/png/resource_saver_png.cpp index b15a84d3b93..566bfbcc1d4 100644 --- a/drivers/png/resource_saver_png.cpp +++ b/drivers/png/resource_saver_png.cpp @@ -71,6 +71,14 @@ Error ResourceSaverPNG::save_image(const String &p_path, const Ref &p_img return OK; } +PoolVector ResourceSaverPNG::save_image_to_buffer(const Ref &p_img) { + + PoolVector buffer; + Error err = PNGDriverCommon::image_to_png(p_img, buffer); + ERR_FAIL_COND_V_MSG(err, PoolVector(), "Can't convert image to PNG."); + return buffer; +} + bool ResourceSaverPNG::recognize(const RES &p_resource) const { return (p_resource.is_valid() && p_resource->is_class("ImageTexture")); @@ -86,4 +94,5 @@ void ResourceSaverPNG::get_recognized_extensions(const RES &p_resource, List &p_img); + static PoolVector save_image_to_buffer(const Ref &p_img); virtual Error save(const String &p_path, const RES &p_resource, uint32_t p_flags = 0); virtual bool recognize(const RES &p_resource) const;