godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Trigger IO error only after exhausting attempts

This commit is contained in:
Tom Dobbelaere 2018-03-30 18:13:19 +02:00
parent c2c82a6ea2
commit a4fae0e5e3
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/windows/file_access_windows.cpp
View File

@ -139,19 +139,22 @@ void FileAccessWindows::close() {
//atomic replace for existing file //atomic replace for existing file
rename_error = !ReplaceFileW(save_path.c_str(), (save_path + ".tmp").c_str(), NULL, 2 | 4, NULL, NULL); rename_error = !ReplaceFileW(save_path.c_str(), (save_path + ".tmp").c_str(), NULL, 2 | 4, NULL, NULL);
} }
if (rename_error && close_fail_notify) {
close_fail_notify(save_path);
}
if (rename_error) { if (rename_error) {
attempts--; attempts--;
OS::get_singleton()->delay_usec(1000000); //wait 100msec and try again OS::get_singleton()->delay_usec(1000000); //wait 100msec and try again
} }
} }
save_path = "";
if (rename_error) { if (rename_error) {
if (close_fail_notify) {
close_fail_notify(save_path);
}
ERR_EXPLAIN("Safe save failed. This may be a permissions problem, but also may happen because you are running a paranoid antivirus. If this is the case, please switch to Windows Defender or disable the 'safe save' option in editor settings. This makes it work, but increases the risk of file corruption in a crash."); ERR_EXPLAIN("Safe save failed. This may be a permissions problem, but also may happen because you are running a paranoid antivirus. If this is the case, please switch to Windows Defender or disable the 'safe save' option in editor settings. This makes it work, but increases the risk of file corruption in a crash.");
} }
save_path = "";
ERR_FAIL_COND(rename_error); ERR_FAIL_COND(rename_error);
} }
} }