godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Call Node3D::get_global_transform and Vector3::dot only once within Camera3D::is_position_behind to avoid redundant work.

This commit is contained in:
Adam Reichold 2020-06-26 16:52:02 +02:00
parent 759ed89640
commit b2a204799a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scene/3d/camera_3d.cpp
View File

@ -318,8 +318,8 @@ Vector3 Camera3D::project_ray_origin(const Point2 &p_pos) const {
bool Camera3D::is_position_behind(const Vector3 &p_pos) const { bool Camera3D::is_position_behind(const Vector3 &p_pos) const {
Transform t = get_global_transform(); Transform t = get_global_transform();
Vector3 eyedir = -get_global_transform().basis.get_axis(2).normalized(); Vector3 eyedir = -t.basis.get_axis(2).normalized();
return eyedir.dot(p_pos) < (eyedir.dot(t.origin) + near); return eyedir.dot(p_pos - t.origin) < near;
} }
Vector<Vector3> Camera3D::get_near_plane_points() const { Vector<Vector3> Camera3D::get_near_plane_points() const {