From b3b9342bf114809e4dbf828b6e77b3a64e05cecd Mon Sep 17 00:00:00 2001 From: Anutrix Date: Thu, 5 Oct 2023 22:11:05 +0530 Subject: [PATCH] Added docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement (cherry picked from commit 3c82f4a37165570985a049be1ab57dcdd2b8fa72) --- doc/classes/CPUParticles2D.xml | 2 +- doc/classes/CPUParticles3D.xml | 2 +- doc/classes/GPUParticles2D.xml | 3 ++- doc/classes/GPUParticles3D.xml | 3 ++- doc/classes/RenderingServer.xml | 3 ++- servers/xr_server.cpp | 4 +--- 6 files changed, 9 insertions(+), 8 deletions(-) diff --git a/doc/classes/CPUParticles2D.xml b/doc/classes/CPUParticles2D.xml index 73d859eacd1..87588ae1089 100644 --- a/doc/classes/CPUParticles2D.xml +++ b/doc/classes/CPUParticles2D.xml @@ -290,7 +290,7 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. Use with [method set_param_min], [method set_param_max], and [method set_param_curve] to set initial velocity properties. diff --git a/doc/classes/CPUParticles3D.xml b/doc/classes/CPUParticles3D.xml index 85ede2dde6e..fd06bd473d3 100644 --- a/doc/classes/CPUParticles3D.xml +++ b/doc/classes/CPUParticles3D.xml @@ -315,7 +315,7 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. Particles are drawn in order of depth. diff --git a/doc/classes/GPUParticles2D.xml b/doc/classes/GPUParticles2D.xml index d59ece4ab6d..bf3d51f2198 100644 --- a/doc/classes/GPUParticles2D.xml +++ b/doc/classes/GPUParticles2D.xml @@ -113,9 +113,10 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. + Particles are drawn in reverse order of remaining lifetime. In other words, the particle with the lowest lifetime is drawn at the front. Particle starts at the specified position. diff --git a/doc/classes/GPUParticles3D.xml b/doc/classes/GPUParticles3D.xml index c86a2227c6d..cd1e32b98b0 100644 --- a/doc/classes/GPUParticles3D.xml +++ b/doc/classes/GPUParticles3D.xml @@ -137,9 +137,10 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. + Particles are drawn in reverse order of remaining lifetime. In other words, the particle with the lowest lifetime is drawn at the front. Particles are drawn in order of depth. diff --git a/doc/classes/RenderingServer.xml b/doc/classes/RenderingServer.xml index b6f44e3ba7c..d19be1cd5db 100644 --- a/doc/classes/RenderingServer.xml +++ b/doc/classes/RenderingServer.xml @@ -4416,9 +4416,10 @@ Draw particles in the order that they appear in the particles array. - Sort particles based on their lifetime. + Sort particles based on their lifetime. In other words, the particle with the highest lifetime is drawn at the front. + Sort particles based on the inverse of their lifetime. In other words, the particle with the lowest lifetime is drawn at the front. Sort particles based on their distance to the camera. diff --git a/servers/xr_server.cpp b/servers/xr_server.cpp index bab8e9ae4b1..aae42855c4e 100644 --- a/servers/xr_server.cpp +++ b/servers/xr_server.cpp @@ -198,9 +198,7 @@ void XRServer::remove_interface(const Ref &p_interface) { }; ERR_FAIL_COND_MSG(idx == -1, "Interface not found."); - - print_verbose("XR: Removed interface" + p_interface->get_name()); - + print_verbose("XR: Removed interface \"" + p_interface->get_name() + "\""); emit_signal(SNAME("interface_removed"), p_interface->get_name()); interfaces.remove_at(idx); };