godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #84375 from Rubonnek/use-const-reference 

Add const references in `String` class
This commit is contained in:
Rémi Verschelde 2024-01-04 14:25:27 +01:00
parent 5d306202b8 dbc49d2a68
commit b66d16fcc9
No known key found for this signature in database
GPG Key ID: C3336907360768E1
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/string/ustring.cpp
View File

@ -1117,7 +1117,7 @@ String String::get_with_code_lines() const {
return ret;
}
int String::get_slice_count(String p_splitter) const {
int String::get_slice_count(const String &p_splitter) const {
if (is_empty()) {
return 0;
}
@ -1136,7 +1136,7 @@ int String::get_slice_count(String p_splitter) const {
return slices;
}
String String::get_slice(String p_splitter, int p_slice) const {
String String::get_slice(const String &p_splitter, int p_slice) const {
if (is_empty() || p_splitter.is_empty()) {
return "";
}
@ -3515,7 +3515,7 @@ bool String::matchn(const String &p_wildcard) const {
return _wildcard_match(p_wildcard.get_data(), get_data(), false);
}
String String::format(const Variant &values, String placeholder) const {
String String::format(const Variant &values, const String &placeholder) const {
String new_string = String(this->ptr());
if (values.get_type() == Variant::ARRAY) {
@ -5208,7 +5208,7 @@ String String::sprintf(const Array &values, bool *error) const {
return formatted;
}
String String::quote(String quotechar) const {
String String::quote(const String &quotechar) const {
return quotechar + *this + quotechar;
}

8
core/string/ustring.h
View File

@ -299,7 +299,7 @@ public:
bool is_quoted() const;
Vector<String> bigrams() const;
float similarity(const String &p_string) const;
String format(const Variant &values, String placeholder = "{_}") const;
String format(const Variant &values, const String &placeholder = "{_}") const;
String replace_first(const String &p_key, const String &p_with) const;
String replace(const String &p_key, const String &p_with) const;
String replace(const char *p_key, const char *p_with) const;
@ -315,7 +315,7 @@ public:
String lpad(int min_length, const String &character = " ") const;
String rpad(int min_length, const String &character = " ") const;
String sprintf(const Array &values, bool *error) const;
String quote(String quotechar = "\"") const;
String quote(const String &quotechar = "\"") const;
String unquote() const;
static String num(double p_num, int p_decimals = -1);
static String num_scientific(double p_num);
@ -349,8 +349,8 @@ public:
String to_snake_case() const;
String get_with_code_lines() const;
int get_slice_count(String p_splitter) const;
String get_slice(String p_splitter, int p_slice) const;
int get_slice_count(const String &p_splitter) const;
String get_slice(const String &p_splitter, int p_slice) const;
String get_slicec(char32_t p_splitter, int p_slice) const;
Vector<String> split(const String &p_splitter = "", bool p_allow_empty = true, int p_maxsplit = 0) const;