godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory corruption and assert failures in convex decomposition 

This PR fixes how triangular faces are decomposed into vertices and indices. The pre-increment resulted in the indices table skipping entry 0 and potentially overrunning the end of the vertices vector.
This commit is contained in:
Malcolm Nixon 2023-12-01 16:38:08 -05:00
parent 4c96e9676b
commit bf7cdc5229
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scene/resources/importer_mesh.cpp
View File

@ -969,7 +969,7 @@ Vector<Ref<Shape3D>> ImporterMesh::convex_decompose(const Ref<MeshConvexDecompos
if (found_vertex) { if (found_vertex) {
index = found_vertex->value; index = found_vertex->value;
} else { } else {
index = ++vertex_count; index = vertex_count++;
vertex_map[vertex] = index; vertex_map[vertex] = index;
vertex_w[index] = vertex; vertex_w[index] = vertex;
} }