diff --git a/core/io/resource_loader.cpp b/core/io/resource_loader.cpp index 1c23e419eed..01afa3a9e5c 100644 --- a/core/io/resource_loader.cpp +++ b/core/io/resource_loader.cpp @@ -131,18 +131,6 @@ public: ResourceInteractiveLoaderDefault() {} }; -Ref ResourceFormatLoader::load_interactive(const String &p_path, const String &p_original_path, Error *r_error) { - //either this - Ref res = load(p_path, p_original_path, r_error); - if (res.is_null()) { - return Ref(); - } - - Ref ril = Ref(memnew(ResourceInteractiveLoaderDefault)); - ril->resource = res; - return ril; -} - bool ResourceFormatLoader::exists(const String &p_path) const { return FileAccess::exists(p_path); //by default just check file } @@ -160,16 +148,33 @@ void ResourceFormatLoader::get_recognized_extensions(List *p_extensions) } } +// Warning: Derived classes must override either `load` or `load_interactive`. The base code +// here can trigger an infinite recursion otherwise, since `load` calls `load_interactive` +// vice versa. + +Ref ResourceFormatLoader::load_interactive(const String &p_path, const String &p_original_path, Error *r_error) { + // Warning: See previous note about the risk of infinite recursion. + Ref res = load(p_path, p_original_path, r_error); + if (res.is_null()) { + return Ref(); + } + + Ref ril = Ref(memnew(ResourceInteractiveLoaderDefault)); + ril->resource = res; + return ril; +} + RES ResourceFormatLoader::load(const String &p_path, const String &p_original_path, Error *r_error) { + // Check user-defined loader if there's any. Hard fail if it returns an error. if (get_script_instance() && get_script_instance()->has_method("load")) { Variant res = get_script_instance()->call("load", p_path, p_original_path); - if (res.get_type() == Variant::INT) { + if (res.get_type() == Variant::INT) { // Error code, abort. if (r_error) { *r_error = (Error)res.operator int64_t(); } - - } else { + return RES(); + } else { // Success, pass on result. if (r_error) { *r_error = OK; } @@ -177,7 +182,7 @@ RES ResourceFormatLoader::load(const String &p_path, const String &p_original_pa } } - //or this must be implemented + // Warning: See previous note about the risk of infinite recursion. Ref ril = load_interactive(p_path, p_original_path, r_error); if (!ril.is_valid()) { return RES();