From c015341221bfa1fbb64067ce0499ce5b1527ee37 Mon Sep 17 00:00:00 2001
From: George Marques <george@gmarqu.es>
Date: Fri, 24 Jun 2016 12:39:58 -0300
Subject: [PATCH] Fix bug in String==StrRange comparison

It was comparing the StrRange with itself, always return true if both
were the same length.

Fix #3843

(cherry picked from commit f4dfa37a23629e011dac74911a87860edf83c63d)
---
 core/ustring.cpp | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/core/ustring.cpp b/core/ustring.cpp
index 061a5c5f9c9..4d41d6e225f 100644
--- a/core/ustring.cpp
+++ b/core/ustring.cpp
@@ -256,13 +256,10 @@ bool String::operator==(const StrRange &p_range) const {
 		return true;
 
 	const CharType *c_str=p_range.c_str;
-
-	int l=length();
-
-	const CharType *dst = p_range.c_str;
+	const CharType *dst = &operator[](0);
 
 	/* Compare char by char */
-	for (int i=0;i<l;i++) {
+	for (int i=0;i<len;i++) {
 
 		if (c_str[i]!=dst[i])
 			return false;