godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve the asset library download UX 

The progress bar is now correctly set to 0% while initiating
the download and is hidden once the download is completed.
This commit is contained in:
Hugo Locurcio 2018-08-06 14:31:22 +02:00
parent 80a8636aa3
commit c1108a4d17
No known key found for this signature in database
GPG Key ID: 39E8F8BE30B0A49C
1 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
editor/plugins/asset_library_editor_plugin.cpp
View File

@ -384,14 +384,11 @@ void EditorAssetLibraryItemDownload::_http_download_completed(int p_status, int
return; return;
} }
progress->set_max(download->get_body_size());
progress->set_value(download->get_downloaded_bytes());
install->set_disabled(false); install->set_disabled(false);
status->set_text(TTR("Success!"));
// Make the progress bar invisible but don't reflow other Controls around it
progress->set_modulate(Color(0, 0, 0, 0));
progress->set_value(download->get_downloaded_bytes());
status->set_text(TTR("Success!") + " (" + String::humanize_size(download->get_downloaded_bytes()) + ")");
set_process(false); set_process(false);
} }
@ -413,25 +410,37 @@ void EditorAssetLibraryItemDownload::_notification(int p_what) {
if (p_what == NOTIFICATION_PROCESS) { if (p_what == NOTIFICATION_PROCESS) {
// Make the progress bar visible again when retrying the download
progress->set_modulate(Color(1, 1, 1, 1));
if (download->get_downloaded_bytes() > 0) {
progress->set_max(download->get_body_size()); progress->set_max(download->get_body_size());
progress->set_value(download->get_downloaded_bytes()); progress->set_value(download->get_downloaded_bytes());
}
int cstatus = download->get_http_client_status(); int cstatus = download->get_http_client_status();
if (cstatus == HTTPClient::STATUS_BODY) if (cstatus == HTTPClient::STATUS_BODY) {
status->set_text(TTR("Fetching:") + " " + String::humanize_size(download->get_downloaded_bytes())); status->set_text(vformat(TTR("Downloading (%s / %s)..."), String::humanize_size(download->get_downloaded_bytes()), String::humanize_size(download->get_body_size())));
}
if (cstatus != prev_status) { if (cstatus != prev_status) {
switch (cstatus) { switch (cstatus) {
case HTTPClient::STATUS_RESOLVING: { case HTTPClient::STATUS_RESOLVING: {
status->set_text(TTR("Resolving...")); status->set_text(TTR("Resolving..."));
progress->set_max(1);
progress->set_value(0);
} break; } break;
case HTTPClient::STATUS_CONNECTING: { case HTTPClient::STATUS_CONNECTING: {
status->set_text(TTR("Connecting...")); status->set_text(TTR("Connecting..."));
progress->set_max(1);
progress->set_value(0);
} break; } break;
case HTTPClient::STATUS_REQUESTING: { case HTTPClient::STATUS_REQUESTING: {
status->set_text(TTR("Requesting...")); status->set_text(TTR("Requesting..."));
progress->set_max(1);
progress->set_value(0);
} break; } break;
default: {} default: {}
} }
@ -527,7 +536,7 @@ EditorAssetLibraryItemDownload::EditorAssetLibraryItemDownload() {
hb2->add_child(retry); hb2->add_child(retry);
hb2->add_child(install); hb2->add_child(install);
set_custom_minimum_size(Size2(250, 0)); set_custom_minimum_size(Size2(310, 0));
download = memnew(HTTPRequest); download = memnew(HTTPRequest);
add_child(download); add_child(download);