godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #55358 from timothyqiu/pop-front-3.x

Browse Source 
[3.x] Fix potential infinite loop when connecting HTTPClient
This commit is contained in:
Rémi Verschelde 2021-11-30 09:26:38 +01:00 committed by GitHub
commit c4f7ba4686
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/io/http_client.cpp
View File

@ -337,7 +337,7 @@ Error HTTPClient::poll() {
Error err = ERR_BUG; // Should be at least one entry. Error err = ERR_BUG; // Should be at least one entry.
while (ip_candidates.size() > 0) { while (ip_candidates.size() > 0) {
err = tcp_connection->connect_to_host(ip_candidates.front(), conn_port); err = tcp_connection->connect_to_host(ip_candidates.pop_front(), conn_port);
if (err == OK) { if (err == OK) {
break; break;
} }