From c6fbbdf15de5c86e057183a5d138c41558748cab Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Tue, 12 May 2020 10:10:54 +0200 Subject: [PATCH] Rename SSL certificate bundle setting to clarify the "overriding" aspect This closes https://github.com/godotengine/godot-docs/issues/2531. --- core/register_core_types.cpp | 4 ++-- doc/classes/ProjectSettings.xml | 5 +++-- main/main.cpp | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/core/register_core_types.cpp b/core/register_core_types.cpp index 23f549be1a8..4cf7e452055 100644 --- a/core/register_core_types.cpp +++ b/core/register_core_types.cpp @@ -233,8 +233,8 @@ void register_core_settings() { GLOBAL_DEF_RST("network/limits/packet_peer_stream/max_buffer_po2", (16)); ProjectSettings::get_singleton()->set_custom_property_info("network/limits/packet_peer_stream/max_buffer_po2", PropertyInfo(Variant::INT, "network/limits/packet_peer_stream/max_buffer_po2", PROPERTY_HINT_RANGE, "0,64,1,or_greater")); - GLOBAL_DEF("network/ssl/certificates", ""); - ProjectSettings::get_singleton()->set_custom_property_info("network/ssl/certificates", PropertyInfo(Variant::STRING, "network/ssl/certificates", PROPERTY_HINT_FILE, "*.crt")); + GLOBAL_DEF("network/ssl/certificate_bundle_override", ""); + ProjectSettings::get_singleton()->set_custom_property_info("network/ssl/certificate_bundle_override", PropertyInfo(Variant::STRING, "network/ssl/certificate_bundle_override", PROPERTY_HINT_FILE, "*.crt")); } void register_core_singletons() { diff --git a/doc/classes/ProjectSettings.xml b/doc/classes/ProjectSettings.xml index dc07dd88370..ccbd419734b 100644 --- a/doc/classes/ProjectSettings.xml +++ b/doc/classes/ProjectSettings.xml @@ -874,8 +874,9 @@ Page size used by remote filesystem (in bytes). - - CA certificates bundle to use for SSL connections. If not defined, Godot's internal CA certificates are used. + + The CA certificates bundle to use for SSL connections. If this is set to a non-empty value, this will [i]override[/i] Godot's default [url=https://github.com/godotengine/godot/blob/master/thirdparty/certs/ca-certificates.crt]Mozilla certificate bundle[/url]. If left empty, the default certificate bundle will be used. + If in doubt, leave this setting empty. When creating node names automatically, set the type of casing in this project. This is mostly an editor setting. diff --git a/main/main.cpp b/main/main.cpp index 65c6fdd397c..83c3e190a83 100644 --- a/main/main.cpp +++ b/main/main.cpp @@ -2011,7 +2011,7 @@ bool Main::start() { if (!project_manager && !editor) { // game // Load SSL Certificates from Project Settings (or builtin). - Crypto::load_default_certificates(GLOBAL_DEF("network/ssl/certificates", "")); + Crypto::load_default_certificates(GLOBAL_DEF("network/ssl/certificate_bundle_override", "")); if (game_path != "") { Node *scene = nullptr;