godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed help overview visibility, issue 12011 and 10407

Browse Source
This commit is contained in:
Paulb23 2017-10-14 18:51:35 +01:00
parent 9862dcd0cb
commit ca24310a13
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
editor/plugins/script_editor_plugin.cpp
View File

@ -1409,8 +1409,10 @@ void ScriptEditor::_update_members_overview() {
void ScriptEditor::_update_help_overview_visibility() { void ScriptEditor::_update_help_overview_visibility() {
int selected = tab_container->get_current_tab(); int selected = tab_container->get_current_tab();
if (selected < 0 || selected >= tab_container->get_child_count()) if (selected < 0 || selected >= tab_container->get_child_count()) {
help_overview->set_visible(false);
return; return;
}
Node *current = tab_container->get_child(tab_container->get_current_tab()); Node *current = tab_container->get_child(tab_container->get_current_tab());
EditorHelp *se = Object::cast_to<EditorHelp>(current); EditorHelp *se = Object::cast_to<EditorHelp>(current);
@ -1427,6 +1429,7 @@ void ScriptEditor::_update_help_overview_visibility() {
} }
void ScriptEditor::_update_help_overview() { void ScriptEditor::_update_help_overview() {
help_overview->clear();
int selected = tab_container->get_current_tab(); int selected = tab_container->get_current_tab();
if (selected < 0 || selected >= tab_container->get_child_count()) if (selected < 0 || selected >= tab_container->get_child_count())
@ -1438,8 +1441,6 @@ void ScriptEditor::_update_help_overview() {
return; return;
} }
help_overview->clear();
Vector<Pair<String, int> > sections = se->get_sections(); Vector<Pair<String, int> > sections = se->get_sections();
for (int i = 0; i < sections.size(); i++) { for (int i = 0; i < sections.size(); i++) {
help_overview->add_item(sections[i].first); help_overview->add_item(sections[i].first);
@ -1447,9 +1448,6 @@ void ScriptEditor::_update_help_overview() {
} }
} }
void _help_overview_selected(int p_idx) {
}
void ScriptEditor::_update_script_colors() { void ScriptEditor::_update_script_colors() {
bool script_temperature_enabled = EditorSettings::get_singleton()->get("text_editor/open_scripts/script_temperature_enabled"); bool script_temperature_enabled = EditorSettings::get_singleton()->get("text_editor/open_scripts/script_temperature_enabled");
@ -1595,6 +1593,8 @@ void ScriptEditor::_update_script_names() {
_update_members_overview(); _update_members_overview();
_update_help_overview(); _update_help_overview();
_update_members_overview_visibility();
_update_help_overview_visibility();
_update_script_colors(); _update_script_colors();
} }