godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

GDScript: Fix warning ignoring for member variables 

(cherry picked from commit c2fbb40e9a)
This commit is contained in:
Danil Alexeev 2023-04-18 14:08:48 +03:00 committed by Yuri Sizov
parent e46b14fd30
commit d00eb58381
3 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/gdscript/gdscript_analyzer.cpp
View File

@ -1308,10 +1308,11 @@ void GDScriptAnalyzer::resolve_class_body(GDScriptParser::ClassNode *p_class, co
push_error(vformat(R"(Getter with type "%s" cannot be used along with setter of type "%s".)", getter_function->datatype.to_string(), setter_function->parameters[0]->datatype.to_string()), member.variable); push_error(vformat(R"(Getter with type "%s" cannot be used along with setter of type "%s".)", getter_function->datatype.to_string(), setter_function->parameters[0]->datatype.to_string()), member.variable);
} }
} }
#ifdef DEBUG_ENABLED
parser->ignored_warnings = previously_ignored_warnings;
#endif // DEBUG_ENABLED
} }
#ifdef DEBUG_ENABLED
parser->ignored_warnings = previously_ignored_warnings;
#endif // DEBUG_ENABLED
} }
} }

10
modules/gdscript/tests/scripts/analyzer/warnings/unused_private_class_variable.gd Normal file
View File

@ -0,0 +1,10 @@
# GH-72135
var _a
@warning_ignore("unused_private_class_variable")
var _b
@warning_ignore("unused_private_class_variable") var _c
var _d
func test():
pass

9
modules/gdscript/tests/scripts/analyzer/warnings/unused_private_class_variable.out Normal file
View File

@ -0,0 +1,9 @@
GDTEST_OK
>> WARNING
>> Line: 3
>> UNUSED_PRIVATE_CLASS_VARIABLE
>> The class variable '_a' is declared but never used in the script.
>> WARNING
>> Line: 7
>> UNUSED_PRIVATE_CLASS_VARIABLE
>> The class variable '_d' is declared but never used in the script.