godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix normals computation at the 'seam' of smoothed sphere and cylinder shapes 

(cherry picked from commit 509e03c821)
This commit is contained in:
MythTitans 2022-02-16 22:23:28 +01:00 committed by Rémi Verschelde
parent e489f889c2
commit d13e1278ac
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/csg/csg_shape.cpp
View File

@ -973,6 +973,10 @@ CSGBrush *CSGSphere::_build_brush() {
double u0 = double(j) / radial_segments; double u0 = double(j) / radial_segments;
double longitude1 = longitude_step * (j + 1); double longitude1 = longitude_step * (j + 1);
if (j == radial_segments - 1) {
longitude1 = 0;
}
double x1 = Math::sin(longitude1); double x1 = Math::sin(longitude1);
double z1 = Math::cos(longitude1); double z1 = Math::cos(longitude1);
double u1 = double(j + 1) / radial_segments; double u1 = double(j + 1) / radial_segments;
@ -1328,6 +1332,9 @@ CSGBrush *CSGCylinder::_build_brush() {
for (int i = 0; i < sides; i++) { for (int i = 0; i < sides; i++) {
float inc = float(i) / sides; float inc = float(i) / sides;
float inc_n = float((i + 1)) / sides; float inc_n = float((i + 1)) / sides;
if (i == sides - 1) {
inc_n = 0;
}
float ang = inc * Math_PI * 2.0; float ang = inc * Math_PI * 2.0;
float ang_n = inc_n * Math_PI * 2.0; float ang_n = inc_n * Math_PI * 2.0;