From d5caf71c3fcdeb422d1b0ea97a836fcdb57a8713 Mon Sep 17 00:00:00 2001 From: Ignacio Etcheverry Date: Tue, 3 Oct 2017 00:01:15 +0200 Subject: [PATCH] Fix SConstruct check for config.is_enabled() --- SConstruct | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/SConstruct b/SConstruct index 8b23b60774b..6045be54c7e 100644 --- a/SConstruct +++ b/SConstruct @@ -192,13 +192,12 @@ for x in module_list: module_enabled = True tmppath = "./modules/" + x sys.path.append(tmppath) - try: - import config - if (not config.is_enabled()): - module_enabled = False - except: - pass + import config + enabled_attr = getattr(config, "is_enabled", None) + if (callable(enabled_attr) and not config.is_enabled()): + module_enabled = False sys.path.remove(tmppath) + sys.modules.pop('config') opts.Add(BoolVariable('module_' + x + '_enabled', "Enable module '%s'" % (x, ), module_enabled)) opts.Update(env_base) # update environment @@ -246,7 +245,7 @@ if selected_platform in platform_list: env = detect.create(env_base) else: env = env_base.Clone() - + if env['dev']: env["warnings"] = "all" env['verbose'] = True