godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #79141 from TokageItLab/fix-infinity-state-loop 

Fix infinite loop state check in `AnimationStateMachine`
This commit is contained in:
Rémi Verschelde 2023-07-07 16:05:05 +02:00
parent 5205ff69ca fc40ba21cd
commit dcbbde5e23
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scene/animation/animation_node_state_machine.cpp
View File

@ -901,18 +901,20 @@ bool AnimationNodeStateMachinePlayback::_transition_to_next_recursive(AnimationT
bool is_state_changed = false;
NextInfo next;
StringName transition_start = current;
Vector<StringName> transition_path;
transition_path.push_back(current);
while (true) {
next = _find_next(p_tree, p_state_machine);
if (next.node == transition_start) {
is_state_changed = false;
break; // Maybe infinity loop, do noting more.
if (transition_path.has(next.node)) {
WARN_PRINT_ONCE_ED("AnimationNodeStateMachinePlayback: " + base_path + "playback aborts the transition by detecting one or more looped transitions in the same frame to prevent to infinity loop. You may need to check the transition settings.");
break; // Maybe infinity loop, do nothing more.
}
if (!_can_transition_to_next(p_tree, p_state_machine, next, p_test_only)) {
break; // Finish transition.
}
transition_path.push_back(next.node);
is_state_changed = true;
// Setting for fading.