From eeb6c2e22c56f988a72cdc6455e55d6039d652fc Mon Sep 17 00:00:00 2001 From: Melvin Louwerse Date: Tue, 15 Sep 2020 11:54:57 +0200 Subject: [PATCH] Show correct name of signal when editing an existing one Use popup_dialog() instead of popup_centered() to show edit dialog/ With popup_centered it is not possible to change the displayed signal name. When this is not set the previous shown name is show for the current dialog. This is no problem when creating a new conenction as popop_dialog is used there and this would update the title. Fixes #42074 --- editor/connections_dialog.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/editor/connections_dialog.cpp b/editor/connections_dialog.cpp index 20d29d47f4c..d1661fd7b36 100644 --- a/editor/connections_dialog.cpp +++ b/editor/connections_dialog.cpp @@ -754,8 +754,9 @@ void ConnectionsDock::_open_connection_dialog(ConnectDialog::ConnectionData cToE Node *dst = static_cast(cToEdit.target); if (src && dst) { + const String &signalname = cToEdit.signal; connect_dialog->set_title(TTR("Edit Connection:") + cToEdit.signal); - connect_dialog->popup_centered(); + connect_dialog->popup_dialog(signalname); connect_dialog->init(cToEdit, true); } }