godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes the issue where setting global rotation would reset scale. 

This was caused because the basis for the target global transform was entirely recreated. This process did not account for the scale of the basis of the current global transform.
This PR amends this by scaling the recreated basis for the global transform by the current global scale of the Node3D.
Note that this scaling has to be done from the current global scale and not from the local scale of the Node3D, otherwise issues would arise if parents of this Node3D would be scaled.
This commit is contained in:
Birk Magnussen 2024-04-12 18:38:35 +02:00
parent 4728ff30c0
commit dd97ff44ab
No known key found for this signature in database
GPG Key ID: 4405312B1E475C4F
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scene/3d/node_3d.cpp
View File

@ -293,7 +293,7 @@ Vector3 Node3D::get_global_rotation_degrees() const {
void Node3D::set_global_rotation(const Vector3 &p_euler_rad) { void Node3D::set_global_rotation(const Vector3 &p_euler_rad) {
ERR_THREAD_GUARD; ERR_THREAD_GUARD;
Transform3D transform = get_global_transform(); Transform3D transform = get_global_transform();
transform.basis = Basis::from_euler(p_euler_rad); transform.basis = Basis::from_euler(p_euler_rad) * Basis::from_scale(transform.basis.get_scale());
set_global_transform(transform); set_global_transform(transform);
} }