godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #83257 from dalexeev/gds-fix-unresolved-type-for-incomplete-expressions

Browse Source 
GDScript: Fix unresolved datatype for incomplete expressions
This commit is contained in:
Rémi Verschelde 2023-10-16 18:44:27 +02:00
commit ddb7969cb6
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/gdscript/gdscript_analyzer.cpp
View File

@ -2500,6 +2500,14 @@ void GDScriptAnalyzer::reduce_expression(GDScriptParser::ExpressionNode *p_expre
case GDScriptParser::Node::WHILE:
ERR_FAIL_MSG("Reaching unreachable case");
}
if (p_expression->get_datatype().kind == GDScriptParser::DataType::UNRESOLVED) {
// Prevent `is_type_compatible()` errors for incomplete expressions.
// The error can still occur if `reduce_*()` is called directly.
GDScriptParser::DataType dummy;
dummy.kind = GDScriptParser::DataType::VARIANT;
p_expression->set_datatype(dummy);
}
}
void GDScriptAnalyzer::reduce_array(GDScriptParser::ArrayNode *p_array) {
@ -2802,9 +2810,6 @@ void GDScriptAnalyzer::reduce_binary_op(GDScriptParser::BinaryOpNode *p_binary_o
}
if (!left_type.is_set() || !right_type.is_set()) {
GDScriptParser::DataType dummy;
dummy.kind = GDScriptParser::DataType::VARIANT;
p_binary_op->set_datatype(dummy);
return;
}