Merge pull request #92550 from AThousandShips/join_improve

[Core] Optimize `String::join`

core/string/ustring.cpp

@@ -1639,13 +1639,43 @@ Vector<int> String::split_ints_mk(const Vector<String> &p_splitters, bool p_allo
 }
 
 String String::join(const Vector<String> &parts) const {
+	if (parts.is_empty()) {
+		return String();
+	} else if (parts.size() == 1) {
+		return parts[0];
+	}
+
+	const int this_length = length();
+
+	int new_size = (parts.size() - 1) * this_length;
+	for (const String &part : parts) {
+		new_size += part.length();
+	}
+	new_size += 1;
+
 	String ret;
-	for (int i = 0; i < parts.size(); ++i) {
+	ret.resize(new_size);
-		if (i > 0) {
+	char32_t *ret_ptrw = ret.ptrw();
-			ret += *this;
+	const char32_t *this_ptr = ptr();
+
+	bool first = true;
+	for (const String &part : parts) {
+		if (first) {
+			first = false;
+		} else if (this_length) {
+			memcpy(ret_ptrw, this_ptr, this_length * sizeof(char32_t));
+			ret_ptrw += this_length;
 		}
-		ret += parts[i];
+
+		const int part_length = part.length();
+		if (part_length) {
+			memcpy(ret_ptrw, part.ptr(), part_length * sizeof(char32_t));
+			ret_ptrw += part_length;
 		}
+	}
+
+	*ret_ptrw = 0;
+
 	return ret;
 }