From e94b8a6accfb07003ee75ba6f8aab4f7f54f070a Mon Sep 17 00:00:00 2001 From: Yuri Sizov Date: Mon, 6 Jul 2020 17:13:04 +0300 Subject: [PATCH] Improve null check in FindReplaceBar --- editor/code_editor.cpp | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/editor/code_editor.cpp b/editor/code_editor.cpp index b73a27214d1..70747b49569 100644 --- a/editor/code_editor.cpp +++ b/editor/code_editor.cpp @@ -108,22 +108,25 @@ void FindReplaceBar::_notification(int p_what) { void FindReplaceBar::_unhandled_input(const Ref &p_event) { Ref k = p_event; - if (k.is_valid()) { - if (k->is_pressed() && (text_edit->has_focus() || vbc_lineedit->is_a_parent_of(get_focus_owner()))) { - bool accepted = true; + if (!k.is_valid() || !k->is_pressed()) { + return; + } - switch (k->get_keycode()) { - case KEY_ESCAPE: { - _hide_bar(); - } break; - default: { - accepted = false; - } break; - } + Control *focus_owner = get_focus_owner(); + if (text_edit->has_focus() || (focus_owner && vbc_lineedit->is_a_parent_of(focus_owner))) { + bool accepted = true; - if (accepted) { - accept_event(); - } + switch (k->get_keycode()) { + case KEY_ESCAPE: { + _hide_bar(); + } break; + default: { + accepted = false; + } break; + } + + if (accepted) { + accept_event(); } } }