From ebff4c3e83487930990dd599d10ee1f6fa1f713e Mon Sep 17 00:00:00 2001 From: Hugo Locurcio Date: Sun, 27 Sep 2020 22:29:40 +0200 Subject: [PATCH] Allow using a comma as decimal separator in EditorSpinSlider This closes https://github.com/godotengine/godot-proposals/issues/1576. (cherry picked from commit 3800e7d2ba154f1355c62e86d9fe2addc53c37e5) --- editor/editor_spin_slider.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/editor/editor_spin_slider.cpp b/editor/editor_spin_slider.cpp index 64e6f874a60..5affdc49f3f 100644 --- a/editor/editor_spin_slider.cpp +++ b/editor/editor_spin_slider.cpp @@ -376,7 +376,12 @@ String EditorSpinSlider::get_label() const { } void EditorSpinSlider::_evaluate_input_text() { - String text = value_input->get_text(); + // Replace comma with dot to support it as decimal separator (GH-6028). + // This prevents using functions like `pow()`, but using functions + // in EditorSpinSlider is a barely known (and barely used) feature. + // Instead, we'd rather support German/French keyboard layouts out of the box. + const String text = value_input->get_text().replace(",", "."); + Ref expr; expr.instance(); Error err = expr->parse(text);