godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix invalid return from some `_get/_set` 

Invalidly returned `true` on the non-matched path

(cherry picked from commit b04cf8486d)
This commit is contained in:
A Thousand Ships 2023-10-27 15:07:42 +02:00 committed by Yuri Sizov
parent 0ca1957445
commit f311b0557c
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scene/resources/bone_map.cpp
View File

@ -37,7 +37,7 @@ bool BoneMap::_set(const StringName &p_path, const Variant &p_value) {
set_skeleton_bone_name(which, p_value); set_skeleton_bone_name(which, p_value);
return true; return true;
} }
return true; return false;
} }
bool BoneMap::_get(const StringName &p_path, Variant &r_ret) const { bool BoneMap::_get(const StringName &p_path, Variant &r_ret) const {
@ -47,7 +47,7 @@ bool BoneMap::_get(const StringName &p_path, Variant &r_ret) const {
r_ret = get_skeleton_bone_name(which); r_ret = get_skeleton_bone_name(which);
return true; return true;
} }
return true; return false;
} }
void BoneMap::_get_property_list(List<PropertyInfo> *p_list) const { void BoneMap::_get_property_list(List<PropertyInfo> *p_list) const {

2
scene/resources/mesh.cpp
View File

@ -1684,7 +1684,7 @@ bool ArrayMesh::_get(const StringName &p_name, Variant &r_ret) const {
return true; return true;
} }
return true; return false;
} }
void ArrayMesh::reset_state() { void ArrayMesh::reset_state() {

4
scene/resources/skeleton_modification_stack_2d.cpp
View File

@ -49,7 +49,7 @@ bool SkeletonModificationStack2D::_set(const StringName &p_path, const Variant &
set_modification(mod_idx, p_value); set_modification(mod_idx, p_value);
return true; return true;
} }
return true; return false;
} }
bool SkeletonModificationStack2D::_get(const StringName &p_path, Variant &r_ret) const { bool SkeletonModificationStack2D::_get(const StringName &p_path, Variant &r_ret) const {
@ -60,7 +60,7 @@ bool SkeletonModificationStack2D::_get(const StringName &p_path, Variant &r_ret)
r_ret = get_modification(mod_idx); r_ret = get_modification(mod_idx);
return true; return true;
} }
return true; return false;
} }
void SkeletonModificationStack2D::setup() { void SkeletonModificationStack2D::setup() {