godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #94135 from Calinou/vulkan-swapchain-resize-error-fail-silently 

Silence Vulkan "Unable to acquire framebuffer." swapchain error
This commit is contained in:
Rémi Verschelde 2024-07-11 00:27:36 +02:00
parent 34d4c9197d cf2d2e2dd8
commit f5bb5db8ae
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
servers/rendering/rendering_device.cpp
View File

@ -3500,7 +3500,12 @@ Error RenderingDevice::screen_prepare_for_drawing(DisplayServer::WindowID p_scre
framebuffer = driver->swap_chain_acquire_framebuffer(main_queue, it->value, resize_required); framebuffer = driver->swap_chain_acquire_framebuffer(main_queue, it->value, resize_required);
} }
ERR_FAIL_COND_V_MSG(framebuffer.id == 0, FAILED, "Unable to acquire framebuffer."); if (framebuffer.id == 0) {
// Some drivers like NVIDIA are fast enough to invalidate the swap chain between resizing and acquisition (GH-94104).
// This typically occurs during continuous window resizing operations, especially if done quickly.
// Allow this to fail silently since it has no visual consequences.
return ERR_CANT_CREATE;
}
// Store the framebuffer that will be used next to draw to this screen. // Store the framebuffer that will be used next to draw to this screen.
screen_framebuffers[p_screen] = framebuffer; screen_framebuffers[p_screen] = framebuffer;