godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix heap-use-after-free when editing project tags

Browse Source
This commit is contained in:
Haoyu Qiu 2023-06-09 18:34:07 +08:00
parent a5a23678c4
commit fade92e4a8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
editor/project_manager.cpp
View File

@ -2486,8 +2486,6 @@ void ProjectManager::_delete_project_tag(const String &p_tag) {
} }
void ProjectManager::_apply_project_tags() { void ProjectManager::_apply_project_tags() {
ProjectList::Item &item = _project_list->get_selected_projects().write[0];
PackedStringArray tags; PackedStringArray tags;
for (int i = 0; i < project_tags->get_child_count(); i++) { for (int i = 0; i < project_tags->get_child_count(); i++) {
ProjectTag *tag_control = Object::cast_to<ProjectTag>(project_tags->get_child(i)); ProjectTag *tag_control = Object::cast_to<ProjectTag>(project_tags->get_child(i));
@ -2497,7 +2495,7 @@ void ProjectManager::_apply_project_tags() {
} }
ConfigFile cfg; ConfigFile cfg;
String project_godot = item.path.path_join("project.godot"); const String project_godot = _project_list->get_selected_projects()[0].path.path_join("project.godot");
Error err = cfg.load(project_godot); Error err = cfg.load(project_godot);
if (err != OK) { if (err != OK) {
tag_edit_error->set_text(vformat(TTR("Couldn't load project at '%s' (error %d). It may be missing or corrupted."), project_godot, err)); tag_edit_error->set_text(vformat(TTR("Couldn't load project at '%s' (error %d). It may be missing or corrupted."), project_godot, err));