godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #76548 from komugi1211s/tilemap-ctrl-shift-edit-crash-fix 

Fix crashes due to stack overflow when painting a large area in tile map
This commit is contained in:
Rémi Verschelde 2023-06-18 16:29:23 +02:00
parent 829b8656ee 09fa22002a
commit fc42065281
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/object/undo_redo.cpp
View File

@ -312,6 +312,11 @@ void UndoRedo::commit_action(bool p_execute) {
}
void UndoRedo::_process_operation_list(List<Operation>::Element *E) {
const int PREALLOCATE_ARGS_COUNT = 16;
LocalVector<const Variant *> args;
args.reserve(PREALLOCATE_ARGS_COUNT);
for (; E; E = E->next()) {
Operation &op = E->get();
@ -347,12 +352,13 @@ void UndoRedo::_process_operation_list(List<Operation>::Element *E) {
if (binds.is_empty()) {
method_callback(method_callback_ud, obj, op.name, nullptr, 0);
} else {
const Variant **args = (const Variant **)alloca(sizeof(const Variant **) * binds.size());
args.clear();
for (int i = 0; i < binds.size(); i++) {
args[i] = (const Variant *)&binds[i];
args.push_back(&binds[i]);
}
method_callback(method_callback_ud, obj, op.name, args, binds.size());
method_callback(method_callback_ud, obj, op.name, args.ptr(), binds.size());
}
}
} break;