godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly remove joint when a physical bone is removed from the scene

Browse Source 
It was triggering a warning in bullet followed with a crash in some cases.
WARNING: assert_no_constraints: A body with a joints is destroyed. Please check the implementation in order to destroy the joint before the body.
     At: modules/bullet/rigid_body_bullet.cpp:465
This commit is contained in:
PouleyKetchoupp 2019-12-01 18:30:59 +01:00
parent ad95424dba
commit fdd99d4a7c
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scene/3d/physics_body.cpp
View File

@ -2161,6 +2161,9 @@ void PhysicalBone::_notification(int p_what) {
update_bone_id();
reset_to_rest_position();
_reset_physics_simulation_state();
if (!joint.is_valid() && joint_data) {
_reload_joint();
}
break;
case NOTIFICATION_EXIT_TREE:
if (parent_skeleton) {
@ -2169,7 +2172,10 @@ void PhysicalBone::_notification(int p_what) {
}
}
parent_skeleton = NULL;
update_bone_id();
if (joint.is_valid()) {
PhysicsServer::get_singleton()->free(joint);
joint = RID();
}
break;
case NOTIFICATION_TRANSFORM_CHANGED:
if (Engine::get_singleton()->is_editor_hint()) {