Commit Graph

818 Commits

Author SHA1 Message Date
Yuri Sizov 3fef8910c7 Merge pull request #85575 from TokageItLab/Make-unstore-library
Make unstore AnimationLibrary if AnimationTree is assigned AnimationPlayer
2023-12-16 17:49:43 +01:00
Haoyu Qiu 7946e84187 Make AnimationTree reference AnimationPlayer instead of AnimationMixer 2023-12-16 00:40:44 +08:00
Rémi Verschelde e1d4b3cc07
Merge pull request #85794 from TokageItLab/stablemixer
Remove differences of the code between old AnimationTree and AnimationMixer
2023-12-12 00:33:01 +01:00
Alistair Leslie-Hughes ea84effb84 Replace memory allocation point of ValueTrack correctly in AnimationMixer
When a animation track doesn't have an keys, it's possible that we leak memory due the ERR_CONTINUE_MSG macro usage.

By checking the error condition first, we avoid a allocation and thus the leak.
2023-12-12 07:33:35 +11:00
Silc Lizard (Tokage) Renew 5acf6b4ca6 Remove differences of the code between old AnimationTree and Mixer 2023-12-06 02:29:29 +09:00
Rémi Verschelde 1d520f5d11
Merge pull request #85681 from KoBeWi/continue_but_not_now
Fix Tween loop initial value
2023-12-04 23:21:34 +01:00
Rémi Verschelde b8ba602e8c
Merge pull request #85569 from TokageItLab/fix-seek-diecrete
Fix AnimationPlayer seeking for Discrete keys
2023-12-04 23:19:58 +01:00
Rémi Verschelde 6b21a185e2
Merge pull request #85428 from jsjtxietian/prevent-nullptr-crash-in-AnimationMixer--restore
Prevent a crash when calling `AnimationMixer::restore` with an invalid resource
2023-12-04 23:14:29 +01:00
kobewi 20aecefd9b Fix Tween loop initial value 2023-12-02 20:20:50 +01:00
Silc Lizard (Tokage) Renew 7ed7ea53e6 Fix AnimationPlayer seeking for Discrete keys 2023-12-01 05:26:21 +09:00
Silc Lizard (Tokage) Renew c380b1296a Make unstore AnimationLibrary if AnimationTree is assigned Player 2023-12-01 04:50:58 +09:00
Rémi Verschelde a363269479
AnimationMixer: Validate ObjectID before blend in case the object was freed
Works around #85365, but it's likely only a partial fix.
The proper fix would be to remove the Object pointer from the TrackCache
and always go back to the ObjectID before doing operations like this.
2023-11-28 12:27:23 +01:00
Rémi Verschelde a008a85443
Merge pull request #85411 from TokageItLab/fix-animpbtrack-stop
Make AnimationPlaybackTrack keep state when stopping
2023-11-28 08:28:25 +01:00
jsjtxietian 937411e152 Prevent a crash when calling AnimationMixer::restore when an invalid reference 2023-11-28 12:54:06 +08:00
Silc Lizard (Tokage) Renew d3a429962f Make AnimationPlaybakTrack keep state when stopping 2023-11-27 12:14:25 +09:00
Silc Lizard (Tokage) Renew c36200b9a1 Check the seek process immediately after playback as a special case 2023-11-26 07:32:34 +09:00
Yuri Sizov 671c04f89f Fix a crash when trying to restore uncopyable animation tracks 2023-11-24 14:20:30 +01:00
Pedro J. Estébanez fbb931df8c Perform safe copies in AnimatedValuesBackup::get_cache_copy() 2023-11-24 11:38:59 +01:00
kobewi 1c0a0f5fdd Fix TrackCache memory crash 2023-11-23 20:26:03 +01:00
Rémi Verschelde bb63963486
Merge pull request #85254 from TokageItLab/bind-reset-animedit
Bind `_reset`/`_restore` in AnimationMixer
2023-11-23 15:35:15 +01:00
Silc Lizard (Tokage) Renew f66224dd2d Bind `_reset`/`_restore` in AnimationMixer 2023-11-23 22:47:52 +09:00
Silc Lizard (Tokage) Renew 9c3104292d Clear seeked/started flag after seeking/advancing in AnimationPlayer 2023-11-22 23:40:53 +09:00
Rémi Verschelde 6ae6cc0bf5
Merge pull request #84815 from TokageItLab/array-animation
Rework blending method in `Variant` animation for `Int`/`Array`/`String`
2023-11-16 14:52:00 +01:00
Silc Lizard (Tokage) Renew 80c9533810 Rework blending method in Variant animation for Int/Array/String 2023-11-16 21:37:18 +09:00
Alistair Leslie-Hughes 5b6f641e99 Fix sizeof usage for Variant pointers in alloca
Coverity report this as a non portable usage of sizeof
2023-11-16 07:13:14 +11:00
Silc Lizard (Tokage) Renew f853d675e8 Fix ValueTrack with Resource is leaking 2023-11-16 02:12:39 +09:00
Rémi Verschelde 7c7d9e2169
Merge pull request #83781 from martinfelis/fix-animationplayer-ready-autoplay
Ensure AnimationPlayer evaluate animations when autoplay is enabled and node becomes ready
2023-11-14 11:27:44 +01:00
Martin Felis f04ec34b78 Ensure AnimationPlayer evaluate animations when autoplay is enabled and node becomes ready.
Fixes #83326.

The issue was introduced in the refactoring done in 1b95827d3e.
2023-11-14 08:30:40 +01:00
Rémi Verschelde 0e6160a00f
Merge pull request #81525 from KoBeWi/tweening_the_impossible
Check if property exists before tweening
2023-11-09 20:03:53 +01:00
kobewi 8d71095622 Fix RESET not effective when saving inactive scene 2023-11-03 12:58:56 +01:00
Silc Lizard (Tokage) Renew a33884943f Add PackedArray to the list of enforcing Discrete for AnimationMixer 2023-11-03 09:35:17 +09:00
Raul Santos ae9ac5c76e
Remove AnimationMixer bindings only bound in the editor 2023-10-16 17:56:14 +02:00
Wilson E. Alvarez 4c8497092a
Show AnimationMixer warning for non-numeric types only when relevant 2023-10-15 20:53:33 -04:00
Rémi Verschelde 1e55eeb91d
Merge pull request #83030 from TokageItLab/patch-misc-blending
AnimationMixer: Fix non-numeric misc type (`Resource`, `Dictionary` & etc.) values cannot be blended with `UpdateMode.UPDATE_CONTINUOUS`
2023-10-09 15:40:14 +02:00
Rémi Verschelde a1d7c62df7
Merge pull request #83003 from AThousandShips/null_check_extra
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-09 15:37:14 +02:00
Rémi Verschelde 35ede42d1d
Merge pull request #82695 from maiself/object-less-callables-fixes
Fixes to allow object-less callables throughout Godot
2023-10-09 15:32:38 +02:00
Silc 'Tokage' Renew c4743baba1 Patch fix for AnimationMixer: misc type values cannot be blended 2023-10-09 17:26:57 +09:00
A Thousand Ships f18aa00e85 Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-10-08 17:23:33 +02:00
Mai Lavelle 5e15586ec2 Fixes to allow object-less callables throughout Godot
This fixes #81887
2023-10-06 16:31:35 -04:00
Rémi Verschelde 249e724835
Merge pull request #82898 from TokageItLab/fix-unwanted-start-in-animation-player
Fix `AnimationPlayer::play()` process unwanted start between the same animations
2023-10-06 12:53:09 +02:00
Rémi Verschelde 373c4b22d3
Fix various typos with codespell
Using 2.2.7.dev5+g2af65969.
2023-10-06 12:52:22 +02:00
Silc 'Tokage' Renew d46c962f18 Fix AnimationPlayer::play() process unwanted start 2023-10-06 15:47:54 +09:00
Aaron Franke dcc7612823
Tweak AnimationPlayer speed scale property hint to make dragging useful 2023-10-01 13:23:31 -05:00
Silc Lizard (Tokage) Renew 599f0dbf97 Fix GroupedStateMachine reset 2023-09-30 10:37:46 +09:00
Silc Lizard (Tokage) Renew 1b95827d3e Implement AnimationManager the base class of AnimationPlayer/Tree 2023-09-29 08:23:57 +09:00
Yuri Sizov b351cffddf Fix theme access and improve UX in AnimationTree editor 2023-09-23 21:47:27 +02:00
Rémi Verschelde 3e233e1f24
Fix various typos with codespell
Using 2.2.6.dev193+g907e5380.
2023-09-18 09:53:39 +02:00
A Thousand Ships a29416e332 [Scene,Main] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-09-12 12:53:06 +02:00
kobewi bf9d971215 Check if property exists before tweening 2023-09-11 12:59:43 +02:00
Hendrik Brucker 5afe78bd9c Clean up/refactor GraphNode and make it more flexible
Split GraphNode into GraphElement and GraphNode, add custom
titlebar, and adjust theming.
2023-09-07 17:29:06 +02:00