87102e358d
Fix Android input routing logic when using a hardware keyboard
...
When a hardware keyboard is connected, all key events come through so we can route them directly to the engine.
This is not the case for soft keyboards, for which the current logic was designed as it requires extra processing.
2023-08-23 09:57:00 -07:00
f37ace7036
[Windows] Add main executable to the console wrapper dependencies to prevent simultaneous linking.
2023-08-23 09:54:06 +03:00
d026b37abd
Fix various typos in classref
2023-08-22 18:05:50 +08:00
469c462b76
Add missing tutorials to documentation classes
2023-08-19 20:29:24 +02:00
6f1152bdbe
Add a `--audio-output-latency` command-line argument
...
This allows optimizing the audio output latency on higher-end CPUs,
especially in projects that do not expose a way to override this setting.
2023-08-17 14:45:17 +02:00
c72b851dfb
Merge pull request #80104 from bruvzg/freedesktop_native_file_dialog
...
[Linux/Freedesktop] Implement native file selection dialog support.
2023-08-17 11:23:00 +02:00
9a48b14a2d
Merge pull request #80036 from PorkrollPosadist/fix-wayland-window-behavior
...
Use EWMH for `DisplayServerX11::_window_minimize_check()` implementation
2023-08-17 11:22:36 +02:00
314cdf456b
Merge pull request #79578 from Faless/web/4.x_dlink_visibility
...
[Web] Use `fvisibility=hidden` for side module when dlink_enabled.
2023-08-17 11:21:47 +02:00
ada360affe
Add a button in the export dialog to fix missing texture formats
2023-08-17 02:56:42 -05:00
6cc314e0fa
[Linux/Freedesktop] Implement native file selection dialog support.
2023-08-17 10:56:16 +03:00
3907e53ff6
SCons: Disable C++ exception handling
...
Upon investigating the extremely slow MSVC build times in #80513 , I noticed
that while Godot policy is to never use exceptions, we weren't enforcing it
with compiler flags, and thus still included exception handling code and
stack unwinding.
This is wasteful on multiple aspects:
- Binary size: Around 20% binary size reduction with exceptions disabled
for both MSVC and GCC binaries.
- Compile time:
* More than 50% build time reduction with MSVC.
* 10% to 25% build time reduction with GCC + LTO.
- Performance: Possibly, needs to be benchmarked.
Since users may want to re-enable exceptions in their own thirdparty code
or the libraries they compile with Godot, this behavior can be toggled with
the `disable_exceptions` SCons option, which defaults to true.
2023-08-16 10:23:34 +02:00
6c3735cb7c
Merge pull request #80569 from m4gr3d/show_in_app_library_settings_main
...
Add export setting to control whether to show the Godot app in the app library
2023-08-16 09:13:30 +02:00
7494ad6b54
Android stylus pressure and tilt support
2023-08-15 19:55:17 +12:00
efdff9cbc2
Fix GCC -Wmaybe-uninitialized warnings
2023-08-14 14:35:35 +02:00
63d47dced0
Add export setting to control whether to show the Godot app in the app library
2023-08-13 09:54:10 -04:00
05bc070f7c
C#: Fix exporting for Android
2023-08-12 09:22:49 +08:00
bc1aef88ee
SCons: Disable misbehaving MSVC incremental linking
...
Fixes #77968 .
2023-08-10 14:04:19 +02:00
49f0d8cee3
Merge pull request #80279 from Sauermann/fix-x11-mouse-window-event-crash
...
Track hovered `Window` in `DisplayServerX11`
2023-08-10 00:43:00 +02:00
11ea4dc466
Merge pull request #80439 from bruvzg/macos_mouse_enter_exit
...
[macOS] Fix missing mouse exit events on window close.
2023-08-09 15:20:39 +02:00
d255811443
Merge pull request #80404 from bruvzg/file_attribs
...
[FileAccess] Add methods to get/set "hidden" and "read-only" attributes on macOS/BSD and Windows.
2023-08-09 15:20:32 +02:00
a7c5849f98
Track hovered `Window` in `DisplayServerX11`
...
Send mouse-entered/exited window-events only when necessary
2023-08-09 12:20:23 +02:00
78caaf3717
[macOS] Fix missing mouse exit events on window close.
2023-08-09 10:23:57 +03:00
8aa6f29b56
[FileAccess] Add methods to get/set "hidden" and "read-only" attributes on macOS/BSD and Windows.
2023-08-08 21:51:32 +03:00
3cf1e04579
Fix Windows console wrapper and icon being swapped
...
Fixes #80238 .
2023-08-07 12:46:23 -04:00
6a0410bbc2
Merge pull request #80240 from bruvzg/x11_ext_checks
...
[X11] Do not fail DisplayServer init if non-essential extensions are missing.
2023-08-07 14:50:47 +02:00
048a164083
Merge pull request #79693 from bruvzg/com_ath
...
[Windows] Initialize COM as apartment-threaded.
2023-08-07 14:48:40 +02:00
9d6570af3b
Merge pull request #79456 from bruvzg/popup_area_fix
...
Fix native popups auto-closing when interacting with non-client area.
2023-08-07 14:47:02 +02:00
faaf27f284
Fix various typos with codespell
...
Also includes typo fixes from #79993 , #80068 , #80276 , and #80303 .
Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
2023-08-07 13:09:47 +02:00
e26a6c36c8
Fix native popups auto-closing when interacting with non-client area.
2023-08-07 10:01:48 +03:00
dc6ea03101
Merge pull request #35555 from Calinou/add-version-project-setting
...
Add a "version" project setting and use it in new export presets
2023-08-04 21:01:15 +02:00
cc6a60913a
Merge pull request #78325 from akien-mga/libpng-moar-intrinsics
...
libpng: Enable intrinsics on x86/SSE2, ppc64/VSX, and all arm/NEON
2023-08-04 17:04:07 +02:00
2c9b7fc7a8
libpng: Enable intrinsics on x86/SSE2, ppc64/VSX, and all arm/NEON
2023-08-04 14:57:21 +02:00
097c849395
Fix various typos in classref
2023-08-04 16:29:55 +08:00
ad4480bf2e
Add a "version" project setting and use it in new export presets
...
This makes it easy to retrieve the project version at runtime
for display purposes, while simplifying the export preset configuration.
You can now leave the version empty unless you need to override it on a per-preset
basis.
Since export presets save the values of default values to the `export_presets.cfg`
file, this change only affects export presets created after this commit was merged.
2023-08-04 10:29:33 +02:00
acff87ffda
[X11] Do not fail DisplayServer init if non-essential extensions are missing.
2023-08-04 10:58:14 +03:00
1610fc2ae7
Merge pull request #78539 from EIREXE/input-info
...
Add the ability to get per-platform information for joypads
2023-08-03 22:37:45 +02:00
3aa340d081
Add the ability to get per-platform information for joypads.
...
This adds the ability for games to obtain platform-specific information about joypads such as their vendor/product ID, their XInput gamepad index or the real name of the device before it gets swapped out by the gamecontrollerdb's name.
This PR also includes a rebased version of #76045 , this is because this PR is intended to be mainly to help people implementing Steam Input, as having the gamepad index is essential.
2023-08-02 22:30:30 +02:00
49305df0e0
Merge pull request #80092 from Faless/web/npm_update
...
[Web] Update npm packages
2023-08-02 21:37:05 +02:00
24049b6646
Merge pull request #79950 from bruvzg/win_app
...
[macOS Export] Disable unpacked .app bundle export on Windows.
2023-08-02 21:37:01 +02:00
b240b5be84
[Windows] Do not force redraw window background on mouse pass-through region change.
2023-08-02 10:40:40 +03:00
8c1ce404d7
Fix crash on Windows when closing `Window`
...
Send `WINDOW_EVENT_MOUSE_EXIT` when a window is destroyed.
Ensure, that on Windows, the event_callback is still valid during
destroying the `Window`.
2023-08-02 00:17:25 +02:00
5666656d42
Use EWMH for DisplayServerX11::_window_minimize_check() implementation
2023-07-31 16:35:18 -04:00
61e7d47344
[Web] Update npm packages
2023-07-31 21:43:59 +02:00
867fc02551
Fix npe when registering the sensors.
2023-07-28 18:58:16 -07:00
0c2399d6ec
Merge pull request #63826 from deakcor/dev_clipboard
...
Add `clipboard_has/get_image` methods to DisplayServer
2023-07-27 15:22:16 +02:00
56bd7adae4
[macOS Export] Disable unpacked .app bundle export on Windows.
2023-07-27 13:21:23 +03:00
63411859db
Merge pull request #79351 from Repiteo/dotnet-handle-warnings
...
C#: Fix MSVC dotnet builds failing if running `dev_mode`
2023-07-26 18:40:06 +02:00
a0c388d4e1
[Windows] Try using objcopy and strip with prefix and without prefix.
2023-07-25 09:52:38 +03:00
bec47cdbbc
Merge pull request #79846 from Faless/web/no_body_length
...
[Web] Always return -1 as body length in HTTPClientWeb
2023-07-24 19:33:48 +02:00
c8e191b7f4
Merge pull request #79724 from Repiteo/gcc-windows-fixes
...
Fix gcc builds failing on windows
2023-07-24 19:33:19 +02:00
f4713d235a
[Web] Always return -1 as body length in HTTPClientWeb.
...
Body length cannot be reliably retrieved from the web.
Reading the "content-length" value will return a meaningless value when
the response is compressed, as reading will return uncompressed chunks
in any case, resulting in a mismatch between the detected body size and
the actual size returned by repeatedly calling read_response_body_chunk.
Additionally, while "content-length" is considered a safe CORS header,
"content-encoding" is not, so using the "content-encoding" to decide if
"content-length" is meaningful is not an option either.
We simply must accept the fact that browsers are awful when it comes to
networking APIs.
2023-07-24 08:57:02 +02:00
88c1e0d528
Merge pull request #79350 from kleonc/screen_to_pixel_byte_to_float_conversion_fix
...
Fix byte to float color conversion in `DisplayServerWindows::screen_get_pixel`
2023-07-21 17:54:21 +02:00
d848c95748
Fix gcc builds failing on windows
2023-07-20 18:01:52 -05:00
4bfb820d32
[Windows] Initialize COM as apartment-threaded.
2023-07-20 12:14:16 +03:00
0c2144da90
Remove excessive include that breaks compilation on Windows
2023-07-18 22:09:48 +02:00
8f175a8649
Merge pull request #78958 from m4gr3d/refactor_android_plugin_packaging_main
...
Re-architect how Android plugins are packaged and handled at export time
2023-07-18 20:47:41 +02:00
b52e1be2c2
Clean up the XR features parameters from core
...
Following on the previous commit, the XR features logic have now be moved to the Godot OpenXR loader plugin.
See https://github.com/GodotVR/godot_openxr_loaders/pull/38
2023-07-18 19:14:53 +02:00
d17811c814
Re-architect how Android plugins are packaged and handled at export time
...
The previous packaging format for Godot Android plugins consisted of the plugin's `gdap` config file accompanied by binaries defined in the `gdap` file.
This format is now deprecated (starting with Godot 4.2), and instead Godot Android plugins are now packaged as `EditorExportPlugin` plugins.
The `EditorExportPlugin` class has been updated with the following methods to provide the necessary set of functionality:
- `_supports_platform`: returns true if the plugin supports the given platform
- `_get_android_dependencies`: retrieve the set of android dependencies (e.g: `org.godot.example:my-plugin:0.0.0`) provided by the plugin
- `_get_android_dependencies_maven_repos`: retrieve the urls of the maven repos for the provided android dependencies
- `_get_android_libraries`: retrieve the local paths of the android libraries (AAR files) provided by the plugin
- `_get_android_manifest_activity_element_contents`: update the contents of the `<activity>` element in the generated Android manifest
- `_get_android_manifest_application_element_contents`: update the contents of the `<application>` element in the generated Android manifest
- `_get_android_manifest_element_contents`: update the contents of the `<manifest>` element in the generated Android manifest
2023-07-18 19:14:53 +02:00
e8aa8c17d2
Merge pull request #79574 from bruvzg/win_nat_d
...
[Windows] Implement native file selection dialog support.
2023-07-18 19:04:40 +02:00
d3ca91ad6a
[Windows] Implement native file selection dialog support.
2023-07-18 17:23:58 +03:00
ec66c53d52
Merge pull request #79572 from bruvzg/mac_bg_ws_sync
...
[macOS] Fix uncapped frame rate for windows in the non-active workspaces.
2023-07-18 15:10:09 +02:00
c13e3a9fb0
add clipboard get image methods for windows and macos
...
Co-Authored-By: RedworkDE <10944644+RedworkDE@users.noreply.github.com>
Co-Authored-By: bruvzg <7645683+bruvzg@users.noreply.github.com>
2023-07-17 23:47:27 +02:00
57919beb05
Merge pull request #76821 from m4gr3d/prototype_godot_service_main
...
Refactor Godot Android architecture
2023-07-17 21:11:21 +02:00
897334a366
Allow MSVC dev_mode builds to succeed with dotnet
...
• Added #else section to mono #ifdef checks in relevant export_plugin scripts
2023-07-17 11:35:38 -05:00
5eed870a6a
[Web] Use fvisibility=hidden for side module when dlink_enabled.
...
This hugely reduces the number of exports, making it acceptable for
browsers.
Note that dlink + threads is still not working due to upstream issues
with the pthread emulation library.
Should hopefully be solved once emscripten move to native WASM threads.
2023-07-17 13:18:02 +02:00
076ef3bf6a
iOS: Add `export_project_only` flag
2023-07-17 11:45:03 +02:00
2ee45dc293
[macOS] Fix uncapped frame rate for windows in the non-active workspaces.
2023-07-17 10:29:49 +03:00
29bbc17b48
Godot Android re-architecture
...
Decouples the Godot java entry point from the Android Fragment component. This enables the Godot component to be more easily reused across different types of Android components including Activities and Services.
2023-07-16 18:56:58 -07:00
00c782d959
Renaming `Godot.java` to `GodotFragment.java` to better reflect its nature and role
2023-07-16 18:56:57 -07:00
7e21eb7e00
Extract and reorganize texture resource classes
2023-07-14 20:04:21 +02:00
70b5330b46
Merge pull request #78164 from 0xafbf/allow-export-tv-and-launcher
...
Add options to show icon in Android TV and run app as Android launcher
2023-07-14 18:48:54 +02:00
4790da7900
[macOS] Implement optional native file selection dialog support for sandboxed apps.
2023-07-12 22:36:24 +03:00
9d45dd812f
Fix byte to float color conversion in DisplayServerWindows::screen_get_pixel
2023-07-12 21:31:02 +02:00
1da09fd477
Merge pull request #79062 from MewPurPur/svg-optimizations
...
Optimize SVG icons and remove unused Transpose icon
2023-07-12 21:02:53 +02:00
ff689003a5
Merge pull request #77993 from bruvzg/key_lbl_from_p
...
Implement DisplayServer.keyboard_get_label_from_physical method.
2023-07-12 21:02:37 +02:00
55b74c7cdf
Merge pull request #76045 from Eoin-ONeill-Yokai/steaminput-fix
...
Prevent double input events on gamepad when running through steam input
2023-07-12 17:16:36 +02:00
661c3954a6
Merge pull request #73443 from akien-mga/unbundle-openxr
...
Allow unbundling OpenXR (for Linux distros)
2023-07-12 17:15:25 +02:00
7b7f6d45d6
Implement iOS one-click deploy.
2023-07-12 16:25:04 +03:00
5dff3c4484
Merge pull request #78538 from Sauermann/fix-code-simplifications
...
Remove unnecessary value assignments throughout the codebase
2023-07-12 15:09:26 +02:00
2b47f6715e
Merge pull request #78437 from bruvzg/set_icon
...
Add error checks and harmonize behavior of the `set_icon` method.
2023-07-12 15:09:14 +02:00
6960a1d0e8
Merge pull request #78248 from felaugmar/load-svg-adjustable-scale
...
Added `Image::load_svg_from_(buffer|string)`
2023-07-12 15:09:03 +02:00
64689c146c
Merge pull request #79089 from bruvzg/android_echo
...
[Android] Set `echo` property for the physical keyboard events.
2023-07-12 14:18:30 +02:00
5dbbdaf27b
Merge pull request #79284 from akien-mga/fix-linux-os-move_to_trash
...
Fix Linux `move_to_trash` wrongly reporting files as not found
2023-07-11 11:30:21 +02:00
a6e75f3971
Fix Linux `move_to_trash` wrongly reporting files as not found
...
We can't rely on the error code from `gio` or `kioclient5`, in my
rudimentary testing they return `1` for both missing files and other
situations like not having a Trash can on the mounted volume.
Fixes #79108 .
2023-07-11 09:55:27 +02:00
8de98dbf21
Prevent double input events on gamepad when running through steam input
...
During GDC and general testing on Steam Deck units, we found that single
gamepads would often register inputs twice under certain circumstances.
This was caused by SteamInput creating a new virtual device, which Godot
registers as a second gamepad. This resulted in two gamepad devices
reporting the same button presses, often leading to buggy input response
on games with no multi-device logic and other-wise could cause intended
Steam rebindings to not work as intended (for example, swapping o and x
on a playstation pad if that feature isn't supported by the game.)
SDL gets around this by taking in a list of devices that are to be
ignored. When valve sees a controller that wants to be rebound via
SteamInput, they push a new VID/PID entry onto the environment
variable `SDL_GAMECONTROLLER_IGNORE_DEVICES` for the original gamepad
so that all game inputs can be read from the virtual gamepad instead.
This leverages the same logic as we are already using SDL gamepad
related HID mappings.
2023-07-10 15:26:33 -07:00
dcd16a5750
Linux: Fix build with `use_sowrap=no` and various warnings/errors
2023-07-10 14:34:01 +02:00
8a06ec979e
Change explicit 'Godot 4.0' references to 'Godot 4'
...
Fixes #79276 .
2023-07-10 13:08:11 +02:00
3cd865dbe8
Fix formatting of dlopen error message on Windows
...
And harmonize the format for all platforms.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-07-09 23:39:45 +02:00
79b31a8357
Merge pull request #79105 from akien-mga/linux-libsquish-lacks-pkgconfig
...
Linux: Link libsquish directly when unbundling, .pc file unreliable
2023-07-08 18:22:18 +02:00
ce32fe974e
Merge pull request #79048 from sepTN/its-platform-not-plafrom
...
Fix a typo in the TLSOptions documentation
2023-07-08 18:21:28 +02:00
988abb2161
Merge pull request #79016 from bruvzg/fix_win_initial_ne_fs
...
[Windows] Fix setting initial non-exclusive window mode.
2023-07-08 18:21:04 +02:00
43c0fa7f4b
Merge pull request #78797 from Calinou/remove-redundant-vformat
...
Remove uses of `vformat()` with no placeholders
2023-07-08 18:18:35 +02:00
b88b6b4f48
fix typo on TLSOptions.xml and library_godot_display.js
2023-07-08 13:34:50 +07:00
fe194f8db0
Optimize SVG icons and remove unused Transpose icon
2023-07-07 17:58:15 +03:00
3a3ec4add1
Merge pull request #78263 from bruvzg/fl_all
...
[Windows] Flash both the window caption and taskbar button on `request_attention`.
2023-07-07 16:02:38 +02:00
f1e63b808a
Merge pull request #79101 from akien-mga/linux-unbundle-brotli
...
Linux: Allow unbundling brotli to use system library
2023-07-07 08:35:44 +02:00
69dbbcc313
Merge pull request #79092 from akien-mga/doctool-remove-version-attribute
...
Doctool: Remove version attribute from XML header
2023-07-07 08:34:55 +02:00
9522ef67d5
Merge pull request #79010 from bruvzg/set_native_icon_crash
...
[macOS] Fix `set_native_icon` crash with empty or invalid ICNS file.
2023-07-07 08:32:56 +02:00
b3b4f4c1c9
Linux: Link libsquish directly when unbundling, .pc file unreliable
2023-07-06 15:32:42 +02:00
153c4a4c4f
Linux: Allow unbundling brotli to use system library
2023-07-06 15:26:38 +02:00
81064cc239
Doctool: Remove version attribute from XML header
...
We don't use that info for anything, and it generates unnecessary diffs
every time we bump the minor version (and CI failures if we forget to
sync some files from opt-in modules (mono, text_server_fb).
2023-07-06 10:08:21 +02:00
c687bfa697
[Android] Set `echo` property for the physical keyboard events.
2023-07-06 09:53:50 +03:00
346f1ab86b
Bump version to 4.2-dev
...
Keep on waitin'
2023-07-05 22:07:03 +02:00
db0109b237
[Windows] Fix setting initial non-exclusive window mode.
2023-07-04 13:09:26 +03:00
618795a214
[macOS] Fix set_native_icon crash with empty or invalid ICNS file.
2023-07-04 09:09:40 +03:00
9c5a0c6c10
Add error checks and harmonize behavior of the set_icon method.
2023-07-03 13:48:28 +03:00
90f3992036
Fix: incorrectly .gitignored files.
2023-07-01 08:41:15 -05:00
dcc92c174e
Remove uses of `vformat()` with no placeholders
...
This is identical to passing the string directly.
2023-06-28 16:27:55 +02:00
0b19ec3498
Display a message about missing C# support on Android/iOS/Web platforms
...
When trying to export a C# project, this displays an error message after
creating a export preset for an unsupported platform.
Support for these platforms is planned for a future release.
2023-06-24 00:09:06 +02:00
26eb3db234
Added Image's `load_svg_from_(buffer|string)`
...
No core dependency to the svg module.
2023-06-23 00:43:43 -03:00
d586096415
Merge pull request #72720 from pkdawson/fix-mouse-capture
...
DisplayServerWindows: Fix mouse capture when button up message is missed
2023-06-22 18:29:34 +02:00
890fdd56df
Code simplifications
...
CPPcheck found most of them.
no need to assign the variable twice:
- AnimationTrackEditTypeAudio
- SSEffects
variable is assigned in all if-else clauses:
- EditorHelp
- AndroidInputHandler
- MenuBar
- ShaderCompiler
same if clause:
- ItemList
clearing an empty bitfield has no effect:
- Viewport
2023-06-21 22:37:26 +02:00
90446fe9f3
SCons: Move platform logo/run icon to `export` folder
...
Follow-up to #75932 .
Since these icons are only used by the export plugin, it makes sense to
move them and generate the headers there.
The whole `detect.is_active()` logic seems to be a leftover from before
times, as far back as 1.0-stable it already wasn't used for anything.
So I'm removing it and moving the export icon generation to
`platform_methods`, where it makes more sense.
2023-06-20 13:16:37 +02:00
ddaefb3cd6
Merge pull request #78455 from aaronfranke/macos-fix-tex-format-valid
...
macOS: Finish checking templates before validating texture formats
2023-06-20 13:14:23 +02:00
65628f23c5
Merge pull request #78175 from phil-hudson/fix-#78105
...
Android: Set pending intent flag to stop insta-crash
2023-06-20 13:14:07 +02:00
ce7f648694
fix(android): set pending intent flag to stop insta-crash
...
fix(android): add conditional check for minimum sdk version
fix(android): formatting
fix(android): formatting
fix(android): formatting
fix(android): formatting again
2023-06-20 16:56:59 +08:00
a981158d1a
macOS: Finish checking templates before validating texture formats
2023-06-19 21:36:31 -05:00
217a20a8a0
Merge pull request #78448 from akien-mga/black-23.3.0
...
CI: Update static checks to black 23.3.0
2023-06-20 00:05:39 +02:00
356a602186
Merge pull request #74511 from AThousandShips/win_cursor_fix
...
Fix clearing custom cursor
2023-06-20 00:00:57 +02:00
c9c941e339
CI: Update static checks to black 23.3.0
...
And apply it to the codebase, removing empty lines at the start of blocks.
2023-06-19 23:33:02 +02:00
eb9c96b87c
Merge pull request #78123 from YeldhamDev/if_you_want_anything_done,_do_it_yourself
...
Allow exporting release Android builds without a debug keystore
2023-06-19 10:27:44 +02:00
01e84b1da1
Merge pull request #67158 from amoriqbal/fix_error_message
...
Fix the conditions for firing 'No such file or directory' error on Linux `move_to_trash`
2023-06-19 10:26:50 +02:00
41a75cfa4f
Allow exporting release Android builds without a debug keystore
2023-06-19 01:00:13 -03:00
34a07b81ae
Allow unbundling OpenXR (for Linux distros)
...
Copy XrMatrix4x4f_CreateProjectionFov to our OpenXRUtil, instead of relying
on a private header.
2023-06-16 16:25:04 +02:00
3c42496fb0
Fix Clang dev_mode build const string conversion
2023-06-16 14:54:36 +03:00
598378513b
Merge pull request #78319 from bruvzg/fix_lipo_fa
...
[macOS export] Fix lipo file handling.
2023-06-16 10:24:37 +02:00
6d1ca52792
Merge pull request #78306 from m4gr3d/cleanup_launch_flow_main
...
Add parameters for the Godot Activity starting intent to allow restarting or force-quitting the engine
2023-06-16 10:23:50 +02:00
c7f4e3fd25
[macOS export] Fix lipo file handling.
2023-06-16 11:07:56 +03:00
28db3c7158
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:27:52 +03:00
0664f5ec3b
Add parameters for the Godot Activity starting intent to allow restarting or force-quitting the engine
...
Follow-up code cleanup for https://github.com/godotengine/godot/pull/78129
2023-06-15 21:41:49 -07:00
2d2b2cadfa
Fix `bsd` feature tag includes only "other BSDs"
2023-06-15 16:25:18 +03:00
49af2582c4
[Windows] Flash both the window caption and taskbar button on `request_attention`.
2023-06-15 11:04:54 +03:00
938a837056
Disable NVIDIA's threaded optimization on Windows
2023-06-13 11:47:40 +02:00
9e7349bda3
Merge pull request #78151 from jpcerrone/fix_windowed_move_problems
...
Fix window resizing problems on Windows
2023-06-13 10:27:14 +02:00
e01a2693d5
Add options to show icon in Android TV and run app as Android launcher
2023-06-12 22:02:48 -05:00
5c57b3aba4
Fix docs after renaming export option
2023-06-12 23:59:55 +02:00
54a8adfd50
Merge pull request #75984 from KoBeWi/ConsoleMcWrap
...
Rename console script to wrapper
2023-06-12 22:54:24 +02:00
a80584664c
Fix window resizing problems on Windows
...
Fixes godotengine#76847, Fixes godotengine#74286
Reorders problematic steps from the DisplayServerWindows::window_set_mode function.
These were causing a resize with the dimensions of the previously used mode instead
of the current one.
2023-06-12 15:26:34 -03:00
974a7a89c6
[iOS] Fix orientation change in runtime.
2023-06-12 14:13:53 +03:00
54ab17eb21
Merge pull request #78129 from m4gr3d/fix_open_new_project_main
...
Fix issue causing the last edited project to open while switching to another one
2023-06-12 11:57:59 +02:00
26e5a98306
Merge pull request #77770 from jpcerrone/fix_minimize_missing
...
Fix minimize button missing in non-resizable projects
2023-06-12 11:39:08 +02:00
a951a14b16
Fix issue causing the last edited project to open while switching to another one.
...
Fixes https://github.com/godotengine/godot/issues/76562
2023-06-11 22:29:35 -07:00
dcd31a25b4
Merge pull request #78083 from m4gr3d/fix_multitouch_detection_spatial_viewport_main
...
Fix spatial viewport multitouch detection support
2023-06-11 18:08:59 -07:00
2c050cc17e
Fix spatial viewport multitouch detection support
...
Regression introduced by https://github.com/godotengine/godot/pull/77498
2023-06-10 08:47:24 -07:00
944fbce347
Enable S3TC_BPTC but not ETC2_ASTC by default
2023-06-09 11:38:29 -05:00
19ce63d875
Added a few additional GUIDs to list of hardcoded IDs in is_xinput_device
2023-06-09 15:02:19 +02:00
a5a23678c4
Merge pull request #78029 from bruvzg/macos_fix_popup_ime_focus
...
[macOS] Fix IME focus in popup windows.
2023-06-09 11:08:06 +02:00
759309ba18
Merge pull request #77977 from zaevi/fix_windows_popup_ime
...
Fix IME doesn't work under Popup on Windows.
2023-06-09 11:06:02 +02:00
fe2d9e5bdf
[macOS] Fix IME focus in popup windows.
2023-06-09 08:03:13 +03:00
9e4315bb50
Style: Harmonize header includes in platform ports
...
This applies our existing style guide, and adds a new rule to that style
guide for modular components such as platform ports and modules:
Includes from the platform port or module should be included with relative
paths (relative to the root folder of the modular component, e.g.
`platform/linuxbsd/`), in their own section before Godot's "core" includes.
The `api` and `export` subfolders also need to be handled as self-contained
(and thus use relative paths for their "local" includes) as they are all
compiled for each editor platform, without necessarily having the api/export
matching platform folder in the include path.
E.g. the Linux editor build will compile `platform/android/{api,export}/*.cpp`
and those need to use relative includes for it to work.
2023-06-08 15:19:19 +02:00
08e8ff371d
Implement keyboard_get_label_from_physical method.
2023-06-08 10:13:31 +03:00
b2cd6a8a95
Add setting to control the window used to run the project for the Android editor
...
The follow options were added to the (new) `run/window_placement/android_window` editor setting:
- `Same as Editor`: run the project in the same window as the editor
- `Side-by-side with Editor`: run the project in an adjacent window to the editor
- `Auto`: choose how to run the project based on the device screen size
2023-06-07 18:32:52 -07:00
1b149b7440
Fix IME doesn't work under Popup on Windows.
2023-06-08 02:40:36 +08:00
2ae5a0704a
X11: Fix vformat ambiguous int types for GCC 10 (again)
2023-06-07 14:57:51 +02:00
2c5e2196bd
Replace get_rendering_device() call to prevent crashes on OpenGL.
...
And make OpenGL video adapter info align with Vulkan.
2023-06-06 23:29:36 +02:00
0010b34a37
Merge pull request #75099 from mxnemu/add-default-x11-error-handler
...
[Linux/X11] Add a default error handler for X11 to avoid crashes.
2023-06-05 18:04:49 +02:00
b13c82e964
[Linux/X11] Add a default error handler for X11 to avoid crashes.
...
The default behaviour for X11 is to crash even on non-fatal errors
when there is no error handler set. This change allows the window to
stay open and may enable users to save their work when things go
wrong.
This acts as a workaround for #65425 and #68471
2023-06-05 17:28:21 +02:00
71d8882a02
Enhance icon fallback and their docs for exporters
2023-06-03 19:28:50 -03:00
8623572b1f
Merge pull request #75666 from ronyeh/main.cpp-2
...
Rename `iconpath` => `icon_path` & `hasicon` => `has_icon`.
2023-06-02 17:26:18 +02:00
c819da7fdb
Fix minimize button missing in non-resizable projects.
...
Fixes https://github.com/godotengine/godot/issues/77603 .
On Windows, disabling the 'resizable' flag on the project
settings would also remove the minimize button from the window.
2023-06-02 10:31:50 -03:00
e15f37945b
[Linux/TTS] Cache TTS voice list.
2023-06-02 14:00:52 +03:00
a932c5e81d
Added override for window_get_vsync_mode in display_server_web.cpp
2023-05-31 18:23:06 -06:00
574f917442
Merge pull request #77686 from m4gr3d/fix_editor_audio_stream_microphone_crash_main
...
Fix issue causing the Android editor to crash when creating a new AudioStreamMicrophone
2023-06-01 00:40:49 +02:00
8ca14183f0
Fix issue causing the Android editor to crash when creating a new AudioStreamMicrophone
...
Fixes https://github.com/godotengine/godot/issues/73801
2023-05-31 00:58:27 -07:00
14908140ea
Fix `HTTPClient.get_response_body_length()` incorrect on Web
2023-05-30 15:22:51 +08:00
c670c4334a
Merge pull request #65902 from MJacred/editor/copysysteminfo
...
Add an editor option to copy system info to clipboard
2023-05-27 20:11:54 +02:00
9e5bf3d589
Copy system info to clipboard + Update bug_report.yml
...
plus minor static-related fixes
* linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times
* windows/linuxbsd: get_video_adapter_driver_info() writes info into static
* linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable
* windows/uwp/android: remove unnecessary use of static
2023-05-27 18:21:23 +02:00
01ee00f710
Improve touchpad and mouse support for the Android editor
...
- Fix issues with using a touchpad to click, drag, interact with the navigation controls, etc..
- Fix issues with panning with 2+ fingers
- Fix issues with using double-tap to magnify on the spatial editor
2023-05-25 20:27:04 -07:00
a67d37f7cf
Merge pull request #77458 from Riteo/late-night-preprocessing
...
Build `JoypadLinux` sandbox detection method only with udev
2023-05-25 09:26:33 +02:00
51dfdfab96
Build `JoypadLinux` sandbox detection method only with udev
...
Fixes an `unused-function` warning when building with `udev=no`.
2023-05-25 04:47:43 +02:00
a041f96779
Update the format for the app version code and name
2023-05-24 14:36:56 -07:00
094e88416a
Merge pull request #74569 from m4gr3d/setup_play_store_builds_main
...
Update the gradle build tasks to generate play store builds
2023-05-24 10:53:17 +02:00
774f4a7261
Merge pull request #73450 from Calinou/windows-vulkan-disable-amd-switchable-graphics
...
Disable AMD switchable graphics on Windows with Vulkan to fix driver issue
2023-05-24 08:44:46 +02:00
831b4a5366
Improve startup benchmarking
...
Move the benchmarking measuring methods from `Engine` to `OS` to allow for platform specific overrides (e.g: can be used to hook into platform specific benchmarking and tracing capabilities).
2023-05-23 13:22:35 -07:00
9dc286967f
X11: Fix vformat ambiguous int types for GCC 10
...
The build would fail with GCC 10 from our Linux SDK used for official builds.
2023-05-23 11:27:28 +02:00
7ed55c8833
Merge pull request #77258 from RedworkDE/natvis-pdb-embeded
...
Embed natvis debug views in PDB
2023-05-22 13:49:15 +02:00
9dc84e3581
Add support for DPAD Center key of Android TV remote controller
2023-05-22 13:31:22 +02:00
efa892b52a
Embed natvis debug views in PDB
...
This means the debugger can load them automatically.
2023-05-20 00:08:35 +02:00
5b9984b5a2
Add `audio/general/text_to_speech` project setting to enable/disable TTS.
2023-05-18 20:16:03 +03:00
a521b85976
Small docs syntax fixes
2023-05-18 14:20:53 +02:00
68da61e74c
Fix for Clang dev_mode Windows build
2023-05-17 19:35:37 +03:00
b0f49266f9
Merge pull request #76719 from m4gr3d/add_input_event_cancelled_state_main
...
Augment the `InputEvent` class with a `CANCELED` state
2023-05-17 11:25:21 +02:00
265c70a369
Merge pull request #75142 from bruvzg/scr
...
[DisplayServer] Implement screen_get_image method for LinuxBSD/X11, macOS and Windows.
2023-05-16 10:48:16 +02:00
250749fa79
Augment the `InputEvent` class with a `CANCELED` state
...
The `InputEvent` class currently supports the `pressed` and `released` states, which given the binary nature, is represented by a `bool` field.
This commit introduced the `CANCELED` state, which signals that an ongoing input event has been canceled.
To represent all the states, the `InputEventState` enum is added and the `InputEvent` logic is refactored accordingly.
2023-05-15 11:48:25 -07:00
58c6f88802
[TLS/Windows] Skip disallowed certs in the trusted CA list.
...
Turns out the list of trusted root certificates contains disallowed
certificates (i.e. certificates which are no longer trusted or have been
revoked).
We need to check for the property `CERT_DISALLOWED_FILETIME_PROP_ID` to
check if and when the certificates should be distrusted.
2023-05-14 14:44:14 +02:00
788cb74cc6
Linux: Don't use udev for joypad hotloading when running in a sandbox
...
udev doesn't work in sandboxes, notably the new Steam container runtime
as found notably on the Steam Deck, and in Flatpak/Snap packages.
Like SDL does, when we detect such a containerized environment, we fall
back to parsing `/dev/input` directly.
See smcv's comments in #76879 for details.
Fixes #76879 .
2023-05-12 11:30:16 +02:00
258fabdbb3
Merge pull request #76836 from Faless/tls/system_certs
...
[TLS] Add support for platform-specific CA bundles.
2023-05-12 11:17:31 +02:00
1c07717d3e
Merge pull request #76974 from dsnopek/linuxbsd-feature-tags
...
Fix 'linux' and specific BSD feature tags
2023-05-12 10:06:08 +02:00
03053eaf19
Merge pull request #76957 from Riteo/dbus-check
...
Check DBus loading status before attempting to detect its version
2023-05-12 10:04:33 +02:00
6fd9982358
[TLS] Add support for platform-specific CA bundles.
...
Adds a new OS::get_system_ca_certs method which can be implemented by
platforms to retrieve the list of trusted CA certificates using OS
specific APIs.
The function should return the certificates in PEM format, and is
currently implemented for Windows/macOS/LinuxBSD(*)/Android.
mbedTLS will fall back to bundled certificates when the OS returns no
certificates.
(*) LinuxBSD does not have a standardized certificates store location.
The current implementation will test for common locations and may
return an empty string on some distributions (falling back to the
bundled certificates).
2023-05-12 09:58:23 +02:00
87fcee2d7f
Fix 'linux' and specific BSD feature tags
2023-05-11 16:58:52 -05:00
a7542070ae
Check DBus loading status before attempting to detect its version
...
Fixes two related segfaults caused by running the DBus version check
unconditionally and potentially calling null function pointers.
This was clearly an oversight as all the other wrappers have proper
loading status checks.
2023-05-11 19:29:10 +02:00
71ee65dc57
Enable shadow warnings and fix raised errors
2023-05-11 16:00:59 +02:00
0c7c35bdc6
Merge pull request #76924 from stolk/fixuninit
...
x11: Do not use uninitialized timestamps.
2023-05-11 11:48:23 +02:00
a1db628eb3
Merge pull request #76856 from HolonProduction/macos-specific
...
Don't expose macOS and iOS specific display servers.
2023-05-11 11:47:58 +02:00
ddcb2d157d
Don't expose mac specific display server.
2023-05-11 11:02:08 +02:00
7a2e350d2b
x11: Do not use uninitialized timestamps.
...
Fixes #76922
2023-05-10 11:27:14 -07:00
74e5ad5c60
Merge pull request #76165 from and-rad/safe-credentials
...
Store sensitive export options in dedicated credentials file
2023-05-10 12:47:07 +02:00
fab160ce70
Store sensitive export options in dedicated credentials file
2023-05-10 11:40:17 +02:00
6bccdec7a1
Make documentation sorting use natural order
2023-05-09 17:47:52 +02:00
e56427b4f5
Merge pull request #76868 from chfoo/issue-72728
...
Ensure WindowData minimized/maximized are mutually exclusive
2023-05-09 17:44:53 +02:00
d550fdd7a4
Merge pull request #76791 from OmarShehata/fix-android-double-tap
...
Fix double tap & drag on Android
2023-05-09 10:45:59 +02:00
0c94750642
Fix double tap & drag on Android
2023-05-08 21:15:37 -04:00
e4d052e284
Ensure WindowData minimized/maximized are mutually exclusive
...
The window manager can break the assumption that
fullscreen/maximized/minimized values are mutually exclusive.
2023-05-08 20:23:45 -04:00
491a437df5
Merge pull request #76540 from reduz/redo-remote-filesystem
...
Redo how the remote filesystem works
2023-05-08 13:52:51 +02:00
273a6eeb66
Redo how the remote filesystem works
...
Instead of reading files over the network, the new version uses a local file cache and only updates files when it changes.
The original remote filesystem was created 14 years ago, when ethernet was faster than hard drives or even flash. Also, mobile devices have a very small amount of storage.
Nowadays, this is no longer the case so the approach is changed to using a persistent cache in the target device.
Co-authored-by: m4gr3d
2023-05-08 11:57:54 +02:00
65236fe2d5
Fix building the Windows x86_32 target
...
In x86_32, `ULONG_PTR` and `SIZE_T` are defined as `unsigned long`, which is not a type supported by Variant without the `NEED_LONG_INT` define.
2023-05-07 11:01:20 -03:00
8106d33d0f
Fixed various typos across the docs
2023-05-02 18:24:32 -04:00
92ade92fce
[Android] Fix dynamic Variant params stack constructions in JNI callbacks
...
Emitting signals with params from Android plugins could crash due to
object assignment with uninitialised mem. Instead, use 'memnew_placement'
to construct into stack addresses. Make similar JNI callbacks consistent.
Fixes #75754 .
2023-05-01 16:31:23 +10:00
0d569bea5d
Update the gradle build tasks to generate play store builds.
...
Configure the gradle builds to sign and build the release version of the Godot Android Editor
2023-04-27 22:08:55 -07:00
390aed9f11
Merge pull request #76510 from bruvzg/ios_conv_lib_load
...
[iOS] Fix loading of GDExtension dylibs auto converted to framework.
2023-04-27 23:56:36 +02:00
4aaa2e6477
Fix wait for thread not started
2023-04-27 20:28:22 +02:00
ad4d565ee7
[iOS] Fix loading of GDExtension dylibs auto converted to framework.
2023-04-27 19:04:12 +03:00
e1075e9c7c
Fix various typos with codespell
...
Also includes the grammar fix from #76206 .
Co-authored-by: Peter Anderson <BWPanda@users.noreply.github.com>
2023-04-26 13:57:09 +02:00
8f7b09916d
Merge pull request #76026 from YuriSizov/editor-running-up-that-gui
...
Extract editor run toolbar into its own component
2023-04-26 12:15:29 +02:00
fdb058f4df
Merge pull request #76464 from m4gr3d/fix_gl_window_resize_main
...
Fix issue with resizing the display on Android when using the compatibility renderer
2023-04-26 11:36:06 +02:00
b58873b98a
Merge pull request #69833 from Eoin-ONeill-Yokai/audio_invalid_mixrate
...
Fix crash caused by invalid mix_rate assignment due to bogus project settings.
2023-04-26 11:35:37 +02:00
b438b4a490
Fix issue with resizing the display on Android when using the compatibility renderer.
2023-04-26 00:43:13 -07:00
5a08091168
Fix crash caused by invalid mix_rate assignment due to bogus
...
project settings.
We'll default to a sensible value in the case that a user has
somehow managed to modify the configuration file incorrectly.
Closes 69819
2023-04-25 23:52:50 -07:00
5e383f3e3d
Merge pull request #76428 from bruvzg/finder_open
...
[macOS] Implement OS::shell_show_in_file_manager()
2023-04-25 14:44:13 +02:00
92e5f4f73a
Merge pull request #76037 from theromis/master
...
iOS splash screen rotation fix
2023-04-25 14:43:53 +02:00
53191928e5
Merge pull request #76345 from reduz/fix-thread-ids
...
Fix thread IDs.
2023-04-25 13:20:46 +02:00
a97225c753
[macOS] Implement OS::shell_show_in_file_manager()
2023-04-25 11:48:41 +03:00
76d33d187f
Merge pull request #69698 from Daylily-Zeleen/daylily-zeleen/show_in_explorer
...
Implement and expose OS::shell_show_in_file_manager()
2023-04-25 09:57:27 +02:00
b12ced0a26
Implement and expose OS::shell_show_in_file_manager()
2023-04-25 11:29:32 +08:00
60a335b24b
Merge pull request #76394 from bruvzg/macos_1013
...
[macOS] Bump min. version to 10.13, and remove deprecated code.
2023-04-24 16:48:25 +02:00
a37c30dfc9
Fix thread IDs.
...
On Linux, thread IDs were not properly assigned with the current approach.
The line:
`std::thread new_thread(&Thread::callback, _thread_id_hash(thread.get_id()), p_settings, p_callback, p_user);`
does not work because the thread ID is not assigned until the thread starts.
This PR changes the behavior to use manually generated thread IDs. Additionally, if a thread is (or may have been created) outside Godot, the method `Thread::attach_external_thread` was added.
2023-04-24 15:13:58 +02:00
628f3b2f79
[OS] Implement and expose to scripting APIs `get_memory_info` method instead of old `get_free_static_memory`.
2023-04-24 14:08:55 +03:00
fd3e7e25e8
[macOS] Bump min. version to 10.13, and remove deprecated code.
2023-04-24 10:52:50 +03:00
220d44eff4
Merge pull request #76325 from m4gr3d/downgrade_agp_main
...
Downgrade android gradle plugin to version 7.2.1.
2023-04-22 13:19:57 +02:00
4507d3a38c
Downgrade android gradle plugin to version 7.2.1.
...
Version 7.3.0 changes the build layout which causes updates to the generated shared libraries to not be picked up.
2023-04-21 14:34:07 -07:00
303bf247de
Add support for VRAM-compressed custom mouse cursor images
...
No memory is actually saved when using this, so lossless modes are
still recommended as they look better and load faster.
2023-04-21 18:01:47 +02:00
a5128e71bb
[Export docs] Move docs to platform folders.
2023-04-20 11:02:12 +03:00
8a74d8438f
Extract editor run toolbar into its own component
...
- Simplify and update its logic.
- Simplify EditorScript.
- Improve EditorNode and other relevant includes.
- Fix scene-based path in the movie writer when
reloading a scene.
2023-04-19 17:12:28 +02:00
989fa49e71
Merge pull request #75219 from bruvzg/get_focus_screen
...
Add project manager / editor initial screen settings, implement `get_keyboard_focus_screen` method.
2023-04-19 10:13:44 +02:00
520a8d8ed2
Add project manager / editor initial screen settings, implement DisplayServer.get_keyboard_focus_screen method.
2023-04-19 08:54:53 +03:00
0088981c40
[Export] Add readable descriptions and validation warnings to the export options.
2023-04-19 08:35:59 +03:00
c2edf14faf
Merge pull request #75881 from bruvzg/win_coinit
...
[Windows] Cleanup COM library initialization/uninitialization.
2023-04-18 23:40:06 +02:00
c4dba9a5ef
Merge pull request #75880 from bruvzg/win_tts_queue_fix
...
[Windows TTS] Fix queuing utterances in rapid succession.
2023-04-18 23:39:42 +02:00
efa01d36b6
Merge pull request #75383 from bruvzg/dll_deps_detect
...
[Windows] Detect missing DLL dependencies and list them in the open_dynamic_library error message.
2023-04-18 23:39:16 +02:00
63d17df83e
Merge pull request #74978 from bruvzg/linux_version_check
...
[Linux/BSD] Add dynamically loaded library version checks.
2023-04-18 23:38:51 +02:00
36bedd341a
Fix misuses of error macros
2023-04-18 10:20:48 +03:00
f5f796b0b7
Merge pull request #76040 from MightiestGoat/fix-sliding-window-linux-via-tracking-parent
...
Fix the sliding window problem in linux occur due to reparenting of the window due to decoration.
2023-04-14 13:11:36 +02:00
932afc3bf5
Fix the sliding window problem in linux occur due to reparenting of the window during the decoration via tracking the parent of the window
2023-04-14 00:45:34 +05:30
8fcca194a1
ios splash screen rotation fix
2023-04-13 11:32:52 -07:00
f8699d93f6
Fix potential null in android text entry system.
2023-04-12 09:18:11 -06:00
a3799208c0
Rename console script to wrapper
2023-04-12 15:14:51 +02:00
95791889e2
Merge pull request #75933 from akien-mga/windows-tts-hashmap
...
Windows TTS: Use HashMap instead of RBMap for ids
2023-04-11 19:41:03 +02:00
f7f7250c0d
Merge pull request #75827 from Kvel2D/fix-custom-cursor-atlas-texture-bug
...
Fix custom cursor using atlas texture
2023-04-11 19:40:44 +02:00
5722d6e3cc
Merge pull request #75451 from bruvzg/web_mac_keys
...
[Web] Detect host OS and use macOS keys on mac hosts.
2023-04-11 19:40:16 +02:00
Fredia Huya-Kouadio
bruvzg
Haoyu Qiu
Hugo Locurcio
Rémi Verschelde
Aaron Franke
pikethom
scgm0
Markus Sauermann
Tyler
Yuri Sizov
Rémi Verschelde
Yuri Sizov
Álex Román Núñez
PorkrollPosadist
Fabio Alessandrelli
Thaddeus Crews
Vincent D
Phil Hudson
Hendrik Brucker
kleonc
Eoin O'Neill
Kamil Brzoskowski
Septian
MewPurPur
Ben Rog-Wilhelm
Felipe Augusto Marques
Michael Alexsander
bitsawer
Fredia Huya-Kouadio
Danil Alexeev
Andrés Botero
RedworkDE
jpcerrone
Dominik
Zae
MJacred
nee
hlutor
Riteo
Hiroki Taira
Max Hilbrunner
David Snopek
Ninni Pipping
HolonProduction
Bram Stolk
Andreas Raddau
Omar Shehata
Christopher Foo
Juan Linietsky
Davi
UltraBIF
shendo
Samuele Panzeri
Daylily-Zeleen
mightygoat
Roman Vasilyev
Jason Knight
kobewi