Alistair Leslie-Hughes
ea84effb84
Replace memory allocation point of ValueTrack correctly in AnimationMixer
...
When a animation track doesn't have an keys, it's possible that we leak memory due the ERR_CONTINUE_MSG macro usage.
By checking the error condition first, we avoid a allocation and thus the leak.
2023-12-12 07:33:35 +11:00
Rémi Verschelde
6b21a185e2
Merge pull request #85428 from jsjtxietian/prevent-nullptr-crash-in-AnimationMixer--restore
...
Prevent a crash when calling `AnimationMixer::restore` with an invalid resource
2023-12-04 23:14:29 +01:00
Rémi Verschelde
a363269479
AnimationMixer: Validate ObjectID before blend in case the object was freed
...
Works around #85365 , but it's likely only a partial fix.
The proper fix would be to remove the Object pointer from the TrackCache
and always go back to the ObjectID before doing operations like this.
2023-11-28 12:27:23 +01:00
jsjtxietian
937411e152
Prevent a crash when calling AnimationMixer::restore when an invalid reference
2023-11-28 12:54:06 +08:00
Silc Lizard (Tokage) Renew
d3a429962f
Make AnimationPlaybakTrack keep state when stopping
2023-11-27 12:14:25 +09:00
Yuri Sizov
671c04f89f
Fix a crash when trying to restore uncopyable animation tracks
2023-11-24 14:20:30 +01:00
Pedro J. Estébanez
fbb931df8c
Perform safe copies in AnimatedValuesBackup::get_cache_copy()
2023-11-24 11:38:59 +01:00
kobewi
1c0a0f5fdd
Fix TrackCache memory crash
2023-11-23 20:26:03 +01:00
Silc Lizard (Tokage) Renew
f66224dd2d
Bind _reset/_restore in AnimationMixer
2023-11-23 22:47:52 +09:00
Rémi Verschelde
6ae6cc0bf5
Merge pull request #84815 from TokageItLab/array-animation
...
Rework blending method in `Variant` animation for `Int`/`Array`/`String`
2023-11-16 14:52:00 +01:00
Silc Lizard (Tokage) Renew
80c9533810
Rework blending method in Variant animation for Int/Array/String
2023-11-16 21:37:18 +09:00
Alistair Leslie-Hughes
5b6f641e99
Fix sizeof usage for Variant pointers in alloca
...
Coverity report this as a non portable usage of sizeof
2023-11-16 07:13:14 +11:00
Silc Lizard (Tokage) Renew
f853d675e8
Fix ValueTrack with Resource is leaking
2023-11-16 02:12:39 +09:00
kobewi
8d71095622
Fix RESET not effective when saving inactive scene
2023-11-03 12:58:56 +01:00
Silc Lizard (Tokage) Renew
a33884943f
Add PackedArray to the list of enforcing Discrete for AnimationMixer
2023-11-03 09:35:17 +09:00
Raul Santos
ae9ac5c76e
Remove AnimationMixer bindings only bound in the editor
2023-10-16 17:56:14 +02:00
Wilson E. Alvarez
4c8497092a
Show AnimationMixer warning for non-numeric types only when relevant
2023-10-15 20:53:33 -04:00
Silc 'Tokage' Renew
c4743baba1
Patch fix for AnimationMixer: misc type values cannot be blended
2023-10-09 17:26:57 +09:00
Rémi Verschelde
373c4b22d3
Fix various typos with codespell
...
Using 2.2.7.dev5+g2af65969.
2023-10-06 12:52:22 +02:00
Silc Lizard (Tokage) Renew
1b95827d3e
Implement AnimationManager the base class of AnimationPlayer/Tree
2023-09-29 08:23:57 +09:00
