64344e6d1d
Fix object leaks caused by unfulfilled yields
...
Now the stack saved in a `GDScriptFunctionState` is cleared as soon as the `yield()` operation is known not to be resumed because either the script, the instance or both are deleted.
This clears problems like leaked objects by eliminating cases of circular references between `GDScriptFunctionState`s preventing them and the objects they refer to in their saved stacks from being released. As an example, this makes using `SceneTreeTimer` safer.
Furthermore, with this change it's now possible to print early warnings about `yield()`s to released script/instances, as now we know they won't be successfully resumed as the condition for that happens. However, this PR doesn't add such messages, to keep the observed behavior the same for the time being.
Also, now a backup of the function name in `GDScriptFunctionState` is used, since the script may not be valid by the time the function name is needed for the resume-after-yield error messages.
2020-05-05 17:53:47 +02:00
40125c7cce
Mention offending function name in "Indented block expected" error
...
(cherry picked from commit e6e5ba32cd
2020-05-04 16:10:22 +02:00
2859ceec6f
Fix for marking assert lines as safe bug
...
Calling _reduce_node_type from GDScriptParser::_parse_block for assert
was using a current class with a scope that didn't include all
functions. Now calling in GDScriptParser::_check_block_types uses the
right class type. We also now check the assert node message. The assert
line was added to the set_errors associated with assert, since before
the error would be reported on the next line
(cherry picked from commit bd081df519
2020-05-01 10:56:58 +02:00
1a4530e84c
export var type reduce() implemented
...
(cherry picked from commit cd487201c6
2020-05-01 10:56:58 +02:00
68cca6e619
Fix leaked objects when game ends with yields in progress
2020-04-29 14:13:36 +02:00
3bd5fc2e5e
Mark assert lines as safe in gdscript
...
Now calling _reduce_node_type with debugging enabled to determine
if assert line is safe. Part of doing this required the assert line
to be stored away. Now the AssertNode line is being correctly set.
Newlines are now marked safe always
(cherry picked from commit 8dc8833782
2020-04-27 10:10:20 +02:00
94d0f34f70
Fixed the bool _static logic
...
(cherry picked from commit b192c7d1ac
2020-04-27 10:09:49 +02:00
95f6bdfa78
GDScript class name existance check enhanced
...
(cherry picked from commit 62280c3d47
2020-04-23 11:10:51 +02:00
12c776dba3
line unsafe for indexing with known base type & unkown identifier
...
(cherry picked from commit 0780ad2800
2020-04-23 11:10:28 +02:00
243711e77f
Pattern bind counts as assignment
...
Fixes #34697
(cherry picked from commit 44281f233d
2020-04-23 11:10:06 +02:00
253fc093b8
DocData: Skip unexposed classes
...
Properly expose classes that we actually want accessible.
(cherry picked from commit 0ef8bcac4d
2020-04-21 14:15:34 +02:00
3d69fe95e5
autocomplete for disconnect, is_connected implemented
...
(cherry picked from commit efe90fce01
2020-04-16 12:47:19 +02:00
3658f7127e
`:=` fails on some nodes fix : #37357
...
(cherry picked from commit bdd7048cb5
2020-04-16 11:46:23 +02:00
df87601c88
Fix for loop range bug: #37358
...
(cherry picked from commit 0b5bad78c0
2020-04-06 20:58:21 +02:00
c2469d0c6d
Add missing docs for assert message in GDScript
...
Seems like this was overlooked in PR #31142 . See also issue #17082 .
(cherry picked from commit 4c3c73ef9c
2020-04-06 18:17:59 +02:00
19e71f94d8
Adding missing include guards to header files identified by LGTM.
...
This addresses the issue godotengine/godot#37143
(cherry picked from commit 2ecf928ae3
2020-03-25 11:38:54 +01:00
5798c8135f
logic error in gdscript_parser.cpp for-loop-range
...
there was a logic error in for loop range argument that
check if all of the argument were constants, fixed
(cherry picked from commit bcbcf0f1ea
2020-03-25 09:45:47 +01:00
40b53bc29a
duplicate arguments in a function handled
...
(cherry picked from commit 5424b626f9
2020-03-25 09:44:51 +01:00
5736e43fe4
fix: Return only scenes for script owners on LSP completion
...
Fix : #36680
(cherry picked from commit 2f08f4ef4e
2020-03-25 09:44:09 +01:00
ecfe9c24a2
Improve LSP completion using scene owner
...
Fixes : #36473
(cherry picked from commit 06bce137e3
2020-03-25 09:43:49 +01:00
41500249e3
Fix crash after closing a GDScript LSP session
...
(cherry picked from commit ed482f6167
2020-03-25 09:43:28 +01:00
511105be67
Migrating language server from Websockets to raw TCP
...
(cherry picked from commit 24b27043fe
2020-03-25 09:43:05 +01:00
708aab7920
typo in gdscript_workspace.cpp/remove_cache_parser() fixed
...
(cherry picked from commit 07c99340d1
2020-03-09 09:51:59 +01:00
d679edfa7f
Add a practical example for `@GDScript.linear2db()`
...
One of its most common applications in games is for volume sliders.
See https://www.dr-lex.be/info-stuff/volumecontrols.html for
more information.
(cherry picked from commit a6fd6b78dd
2020-03-04 12:40:14 +01:00
21a45dda7a
Improve the `@GDScript.inverse_lerp()` documentation
...
This closes https://github.com/godotengine/godot-docs/issues/2589 .
(cherry picked from commit 6b5573700b
2020-03-04 12:40:14 +01:00
57151c5e31
Fix hover symbol content position
...
(cherry picked from commit 03d2d01082
2020-02-14 16:08:14 +01:00
f6968d5f17
Fix static functions loop using class' functions
...
Besides being incorrect, it also caused a hard editor crash for purely
static classes or classes with more static functions than methods.
2020-01-28 14:19:09 -05:00
4cee1cda5e
Merge pull request #35589 from akien-mga/doc-drop-category-property
...
doc: Drop unused 'category' property from header
2020-01-26 16:34:13 +01:00
09ced94dd4
doc: Do not expose Variant::NIL as a type in the class reference
...
Fix signals Variant arguments incorrectly listed as Nil.
Fixes #12520 .
2020-01-26 16:08:11 +01:00
2d20fc39aa
doc: Drop unused 'category' property from header
...
We already removed it from the online docs with #35132 .
Currently it can only be "Built-In Types" (Variant types) or "Core"
(everything else), which is of limited use.
We might also want to consider dropping it from `ClassDB` altogether
in Godot 4.0.
2020-01-26 16:02:39 +01:00
cbdbfb00ca
doc: Document named color constants
...
Busywork but it's good for our completion rate :)
2020-01-26 12:08:16 +01:00
36e11d1c34
Merge pull request #35412 from DaividFrank/check_overriding_self
...
Disabled re-assigning 'self'
2020-01-22 20:47:52 +01:00
badabdf8b9
GDScript: Added checks in assign operations to disable re-assigning 'self'
2020-01-22 19:00:54 +02:00
4faaf6089a
Remove unused #if 0'ed code
2020-01-21 21:41:54 +01:00
8f5e424c66
Fix subclass finding in extend statement for sub-sub classes
...
lookup was always done on top level script instead of advancing to subclass each time.
this commit changes the lookup to always be at last found subclass
2020-01-18 11:55:27 +02:00
9ffa9a6bac
Fix constant access in base class through subclass instance
...
Fixes as issue where a subclass calls a base class method that tries to access a constant from the script.
The original code went through every ower class, and for each owner, went through its inheritance tree.
This seems like the wrong order, the modified code goes to each base class, and for each base class goes through the owner tree.
This is more in line with what the parser does, as the current impelemtation allows an access that the parser does not support.
This change should not negatively affect existing code due to the way the parser works
2020-01-17 00:12:45 +02:00
8b0e2a409b
Merge pull request #35218 from bojidar-bg/26691-parse-error-errors
...
Fix errors raised when showing parse errors in the editor
2020-01-16 22:32:49 +01:00
da5b138e64
Fix errors raised when showing parse errors in the editor
...
Fixes #26691
2020-01-16 22:12:24 +02:00
f2aa99a8e2
Merge pull request #35201 from bojidar-bg/27582-gdfunction-validate-instance
...
Validate instances of objects before trying to check their type in GDScript
2020-01-16 15:57:44 +01:00
4998983bd5
Merge pull request #35199 from dalexeev/master
...
Fix function arguments hint format in GDScript editor
2020-01-16 15:53:28 +01:00
cd7b51b943
Merge pull request #35102 from ChibiDenDen/reuse_orphaned_subclass
...
#34161 : Keep a weak reference to orphan subclasses to reuse on class reload
2020-01-16 15:49:52 +01:00
dc4455d819
Validate instances of objects before trying to check their type in GDScript
...
Fixes #27582
2020-01-16 16:39:59 +02:00
19ce2d5159
Fix slight problems related to default values of exported typed arrays
2020-01-16 14:50:29 +02:00
45b510b332
Fix function arguments hint format in GDScript editor
...
for consistency with the format of the documentation:
"type func_name(arg1: type, arg2: type)"
2020-01-16 15:41:02 +03:00
86aa12e806
Keep a weak reference to orphan subclasses to reuse on class reload
2020-01-15 22:54:01 +02:00
e1a0ce5af9
Prevent GDScript language server from listening to external hosts by default
...
* Add bind_ip property to WebSocketServer defaulting to "*" (listen to everyone)
* Set default for GDscript Language Server to listen only to localhost
Fixes potential security issue with GDScript language server being exposed to the
broad net by default.
Since it is the server which primary usage is to provide utility to the local
editor there is no need to expose it.
2020-01-15 00:29:59 +00:00
40f0649e5b
Fix typos with codespell
...
Using codespell 1.16.0.
See ab3bccdb78
2020-01-15 00:49:52 +01:00
d6f10cd08e
Add fully_qualified_name for GDScript class
2020-01-14 17:33:33 +02:00
1d129f9bec
GDScript: Check function arguments on release too
...
Needed because otherwise the certain type operations (such as type
casting) used as a function argument might become unresolved on release,
causing a compilation failure.
Fix #28680
2020-01-13 15:58:53 -03:00
e32d232053
Merge pull request #35076 from vnen/gdscript-type-match-assign
...
Type match on assignment only if operators have type
2020-01-13 13:14:57 +01:00
e6060706ca
GDScript: Type match on assignment only if operators have type
...
This ensures that a value without type won't be wrongly assigned to a
typed variable when the types mismatch.
2020-01-13 08:51:24 -03:00
d5e1890c85
Fix infinite loop error in document link parsing
2020-01-13 19:23:29 +08:00
e804eebfe5
Remove completion triggers for ',' and '(' which may conflict with signature helper
2020-01-11 23:51:25 +08:00
d901d5993b
Allow enable/disable threading for LSP server
...
Restart LSP server when configurations change without restart the editor
2020-01-11 23:50:32 +08:00
4c20d9407d
GDScript: Forbid using "script" as member name
...
Avoids the user breaking things by creating a "script" variable with
something else, effectively overwriting the "script" slot on Object.
2020-01-10 19:43:33 -03:00
0d2993659b
Merge pull request #34978 from GodotExplorer/lsp-fix-bracket-completion
...
LSP: Fix bracket completion for functions with one argument
2020-01-10 07:58:26 +01:00
09aa12a0dd
Merge pull request #34958 from vnen/gdscript-is-check-valid-instance
...
GDScript: Validate object instance on `is` operation
2020-01-10 07:40:56 +01:00
6190d42825
LSP: Fix bracket completion for functions with one argument
2020-01-10 14:23:01 +08:00
76678b2609
GDScript: Fix type name on error message for function parameters
2020-01-09 15:50:06 -03:00
1aef8bfeb1
GDScript: Fix resolution of default parameter values
...
Fix #26556
2020-01-09 15:42:31 -03:00
3718f8f592
GDScript: Validate object instance on `is` operation
...
Avoids crashes on debug mode. Instead it now breaks the execution and
show the error in-editor. Will still crash on release.
Also add a similar check to Marshalls to ensure the debugger doesn't
crash when trying to serialize the invalid instance.
2020-01-09 13:59:33 -03:00
cc9ca9eb34
GDScript: Don't re-evaluate index on assigment with operation
...
Pass the calculated index from the stack and use the same to get and set
the value. This avoids a function with side effects being evaluated
twice when using indexing in an assignment with operation statement
(e.g. a[function()] += 1).
2020-01-09 10:43:29 -03:00
e97e951741
Merge pull request #34948 from vnen/gdscript-copy-constructor
...
GDScript: Allow copy constructor for built-in types
2020-01-09 13:42:10 +01:00
41ed905c1a
GDScript: Allow copy constructor for built-in types
...
Those are implicitly defined in Variant.
2020-01-09 09:03:09 -03:00
7d4fc79eb3
Add GDScript warning for standalone expression
...
This makes the error message clearer as it might be used to call
functions with side effects.
2020-01-09 08:30:14 -03:00
e7b7dc57fc
GDScript: set assign operation on local var made by match
...
This is needed in a all local variables with assigment to properly set
the typed operation.
Fix #34928
2020-01-08 19:28:07 -03:00
5a8107f70a
Merge pull request #34920 from GodotExplorer/lsp-signatureHelper
...
GDScript LSP: Implement signatureHelp
2020-01-08 18:29:39 +01:00
c456d87ee6
Merge pull request #34918 from vnen/gdscript-assign-op
...
GDScript: enable type checks on release mode
2020-01-08 18:22:38 +01:00
d35c018a7a
GDScript LSP: Implement signatureHelp
...
Enable smart resolve default to true as it is required for script symbol lookup
2020-01-09 00:57:54 +08:00
d26414f9fe
GDScript: enable type checks on release mode
...
Also make builtin GDScript functions report return type as Variant in
release so type is converted when needed.
2020-01-08 12:38:18 -03:00
899f7999b4
GDScript: properly set type of local variable initialization
...
Properly sets the type of the identifier for the local variable
that is stored in the assignment operation. This makes sure that the
compiler is aware of typing for local variables when they are
initialized with the declaration.
2020-01-08 11:36:50 -03:00
eb5861f9f1
GDScript LSP: Implement goto declaration
2020-01-04 20:02:26 +08:00
b93b7aca74
Allow the usage of newlines in export hints
...
Fixes #34689
2020-01-02 18:03:11 +02:00
a7f49ac9a1
Update copyright statements to 2020
...
Happy new year to the wonderful Godot community!
We're starting a new decade with a well-established, non-profit, free
and open source game engine, and tons of further improvements in the
pipeline from hundreds of contributors.
Godot will keep getting better, and we're looking forward to all the
games that the community will keep developing and releasing with it.
2020-01-01 11:16:22 +01:00
078c0d75f2
Cleans up headers included in editor_node.h
2019-12-24 21:46:05 +08:00
74977277fa
Merge pull request #34280 from zaksnet/fix-yield-documentation
...
Fix documentation for yield
2019-12-16 08:49:32 +01:00
468fcd80bb
Updates docs for GDScript built-in functions
...
* Adds description for `ord()`
* Adds relationship description between `char()` and `ord()`
* Describes the argument of `char()` as Unicode code point instead of ASCII code
* Fixes wrong interval notation in `randi()` description
2019-12-15 19:06:29 +08:00
cb887324e6
GDScript: Convert values when setting member variables
...
This allows doing: self.x = 1 even if self.x is declared as float.
2019-12-13 12:51:53 -03:00
475d7f0e52
GDScript: Fix type conversion in assignment with operation
2019-12-13 12:51:08 -03:00
0fd7186971
Fix documentation for yield
...
#33872 PR was misleading as i though inheritance from GDScriptFunctionState was optional.
2019-12-13 11:17:12 +02:00
f065b34e96
Merge pull request #34286 from bojidar-bg/31818-cast-autocomplete
...
Fix GDScript autocompletion with "as" or typed variables
2019-12-12 14:53:38 +01:00
a665b3878b
Fix GDScript autocompletion with `as` or typed variables
...
Fixes #31818 , fixes #33434
2019-12-12 01:16:23 +02:00
6cc3bb2d9b
Add note in 'load()' docs that the path must be absolute
2019-12-11 17:14:58 -03:00
98c3990f7d
Merge pull request #34271 from vnen/gdscript-unused-class-variable-disable
...
Disable GDScript warning for unused class variable by default
2019-12-11 16:27:42 +01:00
df2e3e3f7f
Merge pull request #33018 from Xrayez/fix-inst2dict-getters
...
Fix `inst2dict` calling to getters to retrieve value
2019-12-11 15:06:38 +01:00
cbf5641a74
Disable GDScript warning for unused class variable by default
2019-12-11 11:02:07 -03:00
2845e6a21a
Merge pull request #34040 from qarmin/unused_variable_more_precise_numbers
...
Removed unused variables, add some constants numbers
2019-12-10 08:25:31 +01:00
ed1c4bc77d
Removed unused variables, add some constants numbers
2019-12-10 05:13:02 +01:00
4eff13d768
doc: Markup fixes for enums and constants
2019-12-06 23:09:20 +01:00
f326913f4d
Merge pull request #34067 from bojidar-bg/32370-retype-message
...
Make error when accidentially redeclaring a variable's type clearer
2019-12-04 06:52:22 +01:00
1fcdeaee39
Mention that `int()` can be used as an alternative to `floor()`
2019-12-03 08:43:24 +01:00
79c26344e8
Make error when accidentially redeclaring a variable's type clearer
...
Fixes #32370
2019-12-02 22:26:05 +02:00
3231fca934
Add docs for is_equal_approx on structures
2019-11-30 16:52:27 -05:00
d747c61187
Fixed typo in docs for Script and GDScript classes ("exends" -> "extends")
2019-11-30 21:16:11 +03:00
247767eb89
Document how to bypass the unused argument/variable warning in message
...
Note that prefixing with an underscore only works with unused arguments
and local variables, not class variables and signals.
This closes #26056 .
2019-11-27 22:52:43 +01:00
4f14a1f59c
Remove type hint from the @GDScript class documentation
...
The current consensus in the Godot documentation is to avoid using
type hints unless they're relevant to the behavior explained.
2019-11-26 19:13:55 +01:00
5cfff77ca6
Added missing documentation for yield()
...
Added some missing documentation about yield() being able to wait for a function also. I cant believe something like that was missing from the docs, it would have saved me so much time (and others i assume).
2019-11-25 18:08:18 +02:00
ab3bccdb78
Fix typos with codespell
...
Using codespell 1.16.0.
Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
curvelinear
dof
doubleclick
leapyear
lod
merchantibility
nd
numer
ois
ony
que
seeked
synching
te
uint
unselect
webp
EOF
$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2019-11-22 08:35:03 +01:00
7ecaff578b
Make the script templates' blank lines conform with the official style guide
2019-11-17 08:54:43 -03:00
9254961297
Parser: Check all the arguments of the ternary operator
2019-11-15 01:29:18 +01:00
30d4c923cb
Merge pull request #32966 from ffaristocrat/fix-hex-parsing
...
Fix base 16 hex literal parsing
2019-11-12 23:04:20 +01:00
4b9fd961d6
Fixes #32963 by correctly parsing bin/hex literals
2019-11-12 15:57:38 -05:00
83069a3c0f
Remove ERR_EXPLAIN macros and the scaffolding they needed.
2019-11-11 10:57:00 +01:00
d18b2e599d
Remove all uses of ERR_EXPLAIN macros.
2019-11-11 10:24:04 +01:00
d7137a6b72
Add setting to exclude addons from script warnings
2019-11-07 23:01:22 -05:00
91518defa5
Merge pull request #33257 from aaronfranke/printraw
...
Document behavior of GDScript printraw
2019-11-07 13:21:09 +01:00
76aa975460
Merge pull request #33266 from Xrayez/inst2dict-original-path
...
Use GDScript resource path over script path for `inst2dict`
2019-11-04 08:59:30 +01:00
7f40b69022
Use GDScript resource path over script path for `inst2dict`
...
The resource path holds the original path which can be used to convert
a dictionary to instance consistently both within editor and exported projects
as the original path is automatically remapped from `gd` to `gdc` or `gde` in
exported projects.
2019-11-02 15:11:52 +02:00
c4e46b8800
Document behavior of printraw
2019-11-02 04:55:39 -04:00
b67f252016
Fix Color8 GDScript documentation
2019-11-02 04:48:08 -04:00
9fcd38fc70
GDScript: validate instance before accessing it on error
...
Make sure the instance is valid before trying to access the script in
after an error happened. If the instance is not valid it's possible that
the script is invalid as well.
Fix #29623
2019-11-01 14:41:52 -03:00
15800b4db8
GDScript: Avoid editor crashes when there's cyclic inheritance
...
Make sure the script is fully compiled before looking into the base.
2019-11-01 12:00:20 -03:00
56925b9c28
Provide and print error messages for JSON parsing
...
Core is not touched, only for binding and scripting.
2019-10-31 13:15:44 +02:00
bcbe5b5850
Fixed leak in gdscript when creating empty WeakRef
...
Fixes #33150
2019-10-29 23:53:56 +01:00
c43c3747cf
Merge pull request #32808 from bojidar-bg/30937-less-strict-mixed-spacing
...
Allow mixed tabs and spaces when indentation does not depend on tab size
2019-10-25 23:16:04 +02:00
afbde3314a
Allow mixed tabs and spaces when indentation does not depend on tab size
...
(hopefully) Closes #30937 , fixes #32612
2019-10-25 14:54:57 +03:00
1b9a7e1c21
Fix `inst2dict` calling to getters to retrieve value
...
Use `GDScriptInstance` to iterate through all members directly instead.
This is similar to how `dict2inst` works and makes the serialization
behaviour more consistent.
2019-10-24 14:45:04 +03:00
8228b93fcd
Merge pull request #32919 from vnen/gdscript-unused-args
...
Fix wrong counting of function argument usage
2019-10-22 14:15:58 +02:00
e4cfb77961
Merge pull request #32903 from madmiraal/fix-27649-part9
...
Remove duplicate valid value check in gdscript_tokenizer.cpp.
2019-10-22 13:51:28 +02:00
fddc60c85c
Merge pull request #32878 from EbbDrop/no_autocompletion_for_singeltons
...
Fixes auto completion for singletons
2019-10-22 13:50:25 +02:00
05465b9693
GDScript: Add _ prefix on class name in type compatibility check
...
This makes sure that the classes internally represented with an
underscore (_) prefix, such as singletons, are still properly checked
for inheritance in the ClassDB.
2019-10-19 13:45:52 -03:00
bb20e420af
Fix wrong counting of function argument usage
...
There's no need to subtract 1 from the assignment usages because it's
not incremented anywhere else.
Also put back the assignment with operators because they should not
count as usage if the argument is on the left side.
2019-10-19 10:59:57 -03:00
5b96233c34
Remove duplicate valid value check in gdscript_tokenizer.cpp.
2019-10-18 11:58:34 +02:00
f70fd781fc
Fix autocompletion for singletons
2019-10-17 10:48:13 +02:00
616ab4fac2
Small fixes to redundand code, copy paste bugs
2019-10-14 11:40:55 +02:00
d9dfc4496c
fix #32588 crash in language server
2019-10-11 14:43:39 +02:00
7f49c5dd42
Decrease polling frequency to 20 Hz in the GDScript language server
...
This decreases the language server's CPU usage.
2019-10-10 16:42:05 +02:00
55ef6a0f25
Merge pull request #32671 from GodotExplorer/lsp-send-godot-class-tree
...
lsp: Send godot class tree to clients
2019-10-09 08:35:05 +02:00
1ab34bc3c2
lsp: Send godot class tree to clients
2019-10-09 13:40:50 +08:00
2b5b5874a2
lsp: Fix signature of void returned functions in native methods
2019-10-09 10:01:48 +08:00
3659e3db9d
Fixed some obvious typos in error messages
...
In some errors, there were closing quotation marks but no opening (e. g. "Unable to iterate on object of type " +
Variant::get_type_name(container->get_type()) + "'."
2019-10-05 15:33:30 +02:00
9f27a4838c
Format documentations to markdown only when needed
2019-10-05 14:09:38 +08:00
e199488bc7
Add custom api `textDocument/nativeSymbol` to allow inspect native symbols from LSP clients
2019-10-04 23:00:33 +08:00
39813939fc
Fix enumeration value of SymbolKind.
...
Add custom notification 'gdscript/show_native_symbol' to show native symbols in clients.
Close client connections when stop gdscript-lsp
2019-10-04 19:36:40 +08:00
d66cce0215
Merge pull request #32517 from GodotExplorer/gdscript-lsp
...
GDScript LSP server improvement
2019-10-03 13:40:09 +02:00
6a8303f82f
Implement DocumentLink of GDScript LSP Server
2019-10-03 18:51:03 +08:00
c9781df316
Merge pull request #32403 from yeonghoey/enforce4space
...
Print errors when tab indent found in [codeblock]
2019-10-03 08:41:21 +02:00
d1a6964d39
Fix codeblock formating to markdown
2019-10-03 14:22:26 +08:00
621bafb948
Tweak the default function definition color when using a dark theme
...
This decreases its saturation to make it less visually jarring.
The code was also refactored for clarity and to avoid repetition.
2019-10-02 09:36:47 +02:00
d4a55fb639
Print errors when tab indent found in [codeblock]
2019-10-01 23:39:45 +09:00
d66d970fdb
Merge pull request #32172 from WindyDarian/gdscript_allow_null_weakref
...
Allow weakref(null) in gdscript
2019-10-01 10:35:37 +02:00
db89fef8fa
Highlight singletons and class_names in GDScript
...
Also, implement a small QoL change for auto-typed variables.
Closes #5739
2019-09-28 13:13:18 +03:00
dec10dd776
Merge pull request #32051 from qarmin/some_error_explanation
...
Added some obvious errors explanations
2019-09-25 11:51:54 +02:00
17732fe698
Added some obvious errors explanations
2019-09-25 10:28:50 +02:00
64d09b7de5
GDScript: Fix type resolution not being return in some cases
...
Some situations caused the parser node type to not being update when
trying to resolve the type, returning invalid data and breaking the
parsing when it shouldn't. This patch fix the behavior.
2019-09-24 18:05:20 -03:00
4f294b958f
doc: Sync classref with current source
...
Fix a few missing bindings or unspecified argument names and default values.
2019-09-24 11:52:06 +02:00
c1fcb22677
Fix `line` being assigned to twice in the GDScript language server
...
This closes #32090 .
2019-09-23 15:27:30 +02:00
50be65bf43
Changed some code found by Clang Tidy and Coverity
2019-09-22 18:45:08 +02:00
25a1bfed5c
Merge pull request #32210 from Calinou/editor-log-distinguish-messages
...
Distinguish editor-originating messages in the editor log
2019-09-20 20:22:43 +02:00
fdc2463a1b
Merge pull request #32150 from luzpaz/typos
...
Fix misc. source comment typos
2019-09-20 17:09:05 +02:00
ba566dff2e
Distinguish editor-originating messages in the editor log
...
This fades out messages originating from the editor to make messages
printed by the project stand out more.
This also tweaks wording in some editor messages for consistency.
2019-09-20 01:59:02 +02:00
91ecd7b6a6
Fix misc. source comment typos
...
Found using `codespell -q 3 -S ./thirdparty,*.po -L ang,ba,cas,dof,doubleclick,fave,hist,leapyear,lod,nd,numer,ois,paket,seeked,sinc,switchs,te,uint -D ~/Projects/codespell/codespell_lib/data/dictionary.txt `
2019-09-19 14:36:52 -04:00
c3d5c96494
Merge pull request #31921 from bojidar-bg/28978-uninitialized-array-value
...
Fix uninitialized arrays and dictionaries retaining value
2019-09-19 20:31:12 +02:00
291f408fcf
Merge pull request #32100 from SaracenOne/gdscript_parent_const_types
...
Fix const deceleration for inherited scripts above immediate parent
2019-09-19 20:11:37 +02:00
b5f14cc6f7
Merge pull request #31934 from mitchcurtis/28187
...
Produce an error when a class has the same name as a Singleton
2019-09-19 20:05:41 +02:00
318ac6ee13
Merge pull request #31142 from mitchcurtis/assert-message
...
GDScript: add an optional message parameter to assert()
2019-09-19 19:56:05 +02:00
628f467605
Allow weakref(null) in gdscript
...
Tiny addition I personally found useful - this allows us to `var my_ref := weakref(null)` for nullable weak ref (with type hint!). When trying to test if `my_ref` is holding valid reference, we can just `if my_ref.get_ref():` instead of `if my_ref and my_ref.get_ref():` everywhere.
2019-09-16 23:15:34 -04:00
aa8e3e7b0f
GDScript: add an optional message parameter to assert()
...
Before this patch, assert() only took the condition to assert on:
assert(item_data)
Now, it can optionally take a string that will be printed upon failure:
assert(item_data, item_name + " has no item data in ItemDatabase")
This makes it easier to immediately see what the issue is by being
able to write informative failure messages.
Thanks to @wiped1 for sharing their patch, upon which this is based.
Closes #17082
2019-09-11 15:37:11 +02:00
cf00f35a8e
Allow for constant deceleration to be detected inherited scripts above the immediate parent.
2019-09-11 06:19:20 +01:00
8f5ffeeacc
Produce an error when a class has the same name as a Singleton
...
If you somehow end up with a Singleton.gd that looks like this:
extends Node
class_name Singleton
func foo():
pass
You will get an error when using it in another file:
extends Node2D
func _init():
# Parser Error: Non-static function "foo" can only be called from an instance.
Singleton.foo()
This error is confusing. This patch ensures that an error on the class_name line will be produced:
Parse Error: The class "Singleton" conflicts with the AutoLoad singleton of the same name, and is therefore redundant. Remove the class_name declaration to fix this error.
Fixes #28187 .
2019-09-06 17:12:43 +02:00
617797c47c
Adds skip-breakpoints feature
2019-09-03 20:49:09 +02:00
9e9c16c1e5
Try and show all the properties added with _get_property_list() when triggering completion.
...
Closes https://github.com/godotengine/godot/issues/25097
2019-09-03 14:27:27 +02:00
3ca7b4ee45
Fix uninitialized arrays and dictionaries retaining value
...
Fixes #28978
2019-09-03 10:39:04 +03:00
10b040ab20
Merge pull request #31893 from bojidar-bg/25081-gdscript-index-self
...
Re-allow indexing on objects and other non-builtin types
2019-09-02 20:25:14 +02:00
85955c5f25
Merge pull request #31843 from 2shady4u/parserCtrlClick
...
Solves ctrl+click on functions by ignoring the cursor
2019-09-02 19:56:35 +02:00
e3d05fa42d
Re-allow indexing on "self" and object types in GDScript
...
Fixes #25081
2019-09-02 20:18:15 +03:00
eb38bc6c0a
gdscript: Fix build after #24925
...
The PR did not use the ScriptCodeCompletionOption system introduced
later on, and somehow this did not generate a merge conflict even
though neighboring code was changed.
2019-09-02 16:31:43 +02:00
877912b23c
Merge pull request #24925 from Mr-Slurpy/typed-autoload
...
Added autoloads as a potential type.
2019-09-02 16:05:05 +02:00
d767edb9b3
Merge pull request #21443 from deepmax/ord_function
...
Add ord() function to return Unicode code point of a string of length one
2019-09-02 15:28:15 +02:00
dbd253d7a2
Solves ctrl+click on functions by ignoring the cursor
...
Obeyed CLANG format rules
Obeying CLANG format rules attempt 2
Obeying CLANG format rules attempt 3
Clean up
Fixed runaway while loop
Removed int initialization
2019-09-02 13:46:38 +02:00
65d61d0360
doc: Sync classref with current source
2019-08-29 15:33:52 +02:00
02ed79f7f7
Updated description for "stepify"
...
Mentioned the possibility to use stepify as a rounding function; +code examples
2019-08-29 14:03:18 +02:00
b97169740e
Merge pull request #31741 from akien-mga/lsp-requires-websocket-jsonrpc
...
GDScript: Disable LSP if either jsonrpc or websocket are disabled
2019-08-29 08:37:40 +02:00
7995ce03f3
Merge pull request #31738 from bojidar-bg/31056-class_name-extends
...
Remove check for class_name and extends order
2019-08-29 08:33:51 +02:00
5565f5591f
Add ord() function to return Unicode code point of a string of length one
2019-08-28 16:14:11 +02:00
b791efdb16
Merge pull request #31737 from bojidar-bg/31455-stack-underflow
...
Fix yield check in GDScriptFunction
2019-08-28 15:36:08 +02:00
b994124df3
GDScript: Disable LSP if either jsonrpc or websocket are disabled
...
Follow-up to #29780 .
2019-08-28 13:29:37 +02:00
46ad60385b
Merge pull request #29780 from GodotExplorer/gdscript-lsp
...
Add Language Server Protocol for GDScript
2019-08-28 13:06:51 +02:00
b70b16a20f
Remove check for class_name and extends order
...
Closes #31056
2019-08-28 12:05:21 +03:00
112aa6e367
Fix yield check in GDScriptFunction
...
Fixes #31455
2019-08-28 11:15:43 +03:00
185072015f
Merge pull request #31606 from toasteater/fix/nativescript-new-json-return-type
...
Fix the return type of NativeScript::new in API json
2019-08-28 09:15:40 +02:00
a8826ad3b8
Make 'break' and 'continue' be marked as safe
2019-08-27 23:10:33 -03:00
e2121c97ae
Make VarArg methods return types show up as Variant in API json
...
VarArg methods have the return type Object in the API json for GDNative. This
can cause undefined behavior in some language bindings due to lack of
documentation on VarArg methods' behavior.
This changes the MethodInfo of:
- CSharpScript::_new
- GDScript::_new
- PluginScript::_new
2019-08-26 16:36:51 +00:00
a4794af5df
Improve writing style in GDScript error/warning messages
...
This uses double quotes everywhere for consistency.
2019-08-23 20:55:50 +02:00
d3153c28f0
Replace last occurrences of 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG'
...
The last remaining ERR_EXPLAIN call is in FreeType code and makes sense as is
(conditionally defines the error message).
There are a few ERR_EXPLAINC calls for C-strings where String is not included
which can stay as is to avoid adding additional _MSGC macros just for that.
Part of #31244 .
2019-08-17 13:31:22 +02:00
37a16fee05
Export: Remove temp files from cache after export
...
So far we left most temporary files lying around, so this attempts to
fix that.
I added a helper method to DirAccess to factor out the boilerplate of
creating a DirAccess, checking if the file exists, remove it or print
an error on failure.
2019-08-12 13:31:59 +02:00
e5b91a15e6
Improve code compeletion for virtual methods with signatures
2019-08-11 14:06:39 +08:00
72d11cd173
Add optional goto definition support for native symbols
...
This action will show help for target symbol in godot editor and bring the godot editor window to foreground
Improved markdown documentation for symbols.
2019-08-11 13:30:15 +08:00
666ed89011
Add generate script api to dictionary support
...
Expose GDScriptLanguageProtocol singleton and classes for editor plugins (Not visiable in class tree)
Fix minor bug in symbol resolve
2019-08-11 13:30:15 +08:00
9618b0c63e
Check client workspace directory is valid
...
Drop test initialize message sent to client
Remove unused code property for the parser class
2019-08-11 13:30:15 +08:00
b2f02317fa
Improve symbol resolve for inner classes
...
Only level one inner classes would be resolved currently but it sould cover most real world use case
Improve documation parseing for const values
Improve documation format for native symbols
2019-08-11 13:30:15 +08:00
76c9e4ceb7
Improved performance for completion and symbol resolvation.
...
Improved uri and workspace path translatation on windows platform.
The smart resolvation is much faster than builtin's in the server side.
The smart resolve mode is still disabled as default as the clients might be slow with a planty of completion items.
2019-08-11 13:30:15 +08:00
fa6d6a329c
Add optional smart resolve sulotion
...
The smart resolvaion can guess most symbols but it might be slow so disabled by default users can turn on it in the editor setting
2019-08-11 13:30:15 +08:00
37aafaaa9c
Add a symbol pool to cache all native symbols and workspackes symbols.
...
Implement hover
Implement completion documentation resolve
Implement hover documentation
Implement go to definition
2019-08-11 13:30:15 +08:00
f58560ac36
Add GDScript Language Protocol plugin
2019-08-11 13:30:15 +08:00
80c7cb6378
Merge pull request #31227 from profan/fix/err-explain-usages
...
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in "platform", "modules/gdnative", "modules/gdscript" directories.
2019-08-09 12:28:06 +02:00
6ab118c464
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in "platform", "modules/gdnative", "modules/gdscript" directories.
2019-08-09 11:13:24 +02:00
2339e85b78
Expression before 'is' may be null
2019-08-09 01:24:03 -07:00
be3b2f3ff9
Merge pull request #31041 from 2shady4u/master
...
Mark class_name line as safe in editor
2019-08-05 08:05:49 +02:00
1e6a52b215
Mark class_name line as safe in editor
2019-08-02 20:07:54 +02:00
a2c81a7455
Add a reference to pow to the description of exp.
...
This might be especially usefull since godot script doesn't support ** or ^ as operators, so beginners might search for the exponential function, when what they really need is the pow function.
This is exactly what happened to me and since I couldn't find helpfull information in the documentation I had to look it up online, where I found the answer on a helpfull [reddit thread](https://www.reddit.com/r/godot/comments/3mvwz0/how_do_i_do_exponents_in_godot/ ).
@akien-mga told me how to reference methods here:
godotengine#30909
2019-07-29 18:17:52 +02:00
1107799de5
Merge pull request #30849 from bojidar-bg/7898-mixed-indentation
...
Disallow using of both tabs and spaces for indentation in the same file
2019-07-27 10:48:31 +02:00
f12f3cf726
Disallow using of both tabs and spaces for indentation in the same file
...
Closes #7898
2019-07-26 21:24:34 +03:00
d844e30614
Inspector: Make default float step configurable
...
Also allow lifting the decimal step formatting with a hint range step
of 0. A new `range_step_decimals()` is added for this to avoid breaking
compatibility on the general purpose `step_decimals()` (which still
returns 0 for an input step of 0).
Supersedes #25470 .
Partial fix for #18251 .
2019-07-23 17:31:38 +02:00
07e289963c
doc: Sync classref with current source
2019-07-22 12:27:52 +02:00
60efd67034
Merge pull request #30693 from Chaosus/lerp_angle
...
Added lerp_angle built-in function
2019-07-20 13:37:13 +02:00
d15cf7b672
Merge pull request #30576 from qarmin/lgtm_coverage
...
Changed some code reported by LGTM and Coverity
2019-07-20 12:00:13 +02:00
6694c119d0
Added lerp_angles built-in function
...
Co-authored-by: Xrayez <https://github.com/Xrayez >
Co-authored-by: DleanJeans <https://github.com/DleanJeans >
2019-07-20 12:59:41 +03:00
6cbaf7662f
Changed some code showed in LGTM and Coverage
2019-07-20 08:09:57 +02:00
a60f242982
Add integer posmod and rename default arg names
...
"posmod" is the integer version of "fposmod". We do not need a "mod" because of the % operator.
I changed the default arg names from "x" and "y" to "a" and "b" because they are not coordinates. I also changed pow's arg names to "base" and "exp". Also, I reorganized the code in the VS built-in funcs switch statement.
2019-07-18 16:33:43 -04:00
950153757b
Merge pull request #30648 from NilsIrl/useless_casts
...
Remove useless casts to String
2019-07-18 09:34:55 +02:00
8336590154
Fix stack underflows when yielding twice
...
Also, refactor GDScriptFunctionState::_signal_callback, removing some excessive repetition.
Fixes #30269 .
2019-07-17 23:48:49 +03:00
074115338e
Remove useless casts to String
2019-07-17 11:31:42 +01:00
7b1ee28a03
Merge pull request #30567 from NilsIrl/static_func_inside_class
...
Show static functions inside classes in method list
2019-07-16 08:53:02 +02:00
9e3455cb1e
Show static functions inside classes in method list
2019-07-15 17:16:57 +01:00
206d515783
Fix unreachable code detection in match statements
2019-07-13 19:31:49 +08:00
28d3a6051c
Use base `Color()` constructors instead of `Color::html()`
...
This results in slightly smaller binaries (-17 KB for an editor binary)
as no strings need to be allocated.
2019-07-08 21:17:10 +02:00
ba211bd58c
Merge pull request #30352 from bojidar-bg/28727-enum-value-check
...
Fix parsing of enums allowing for juxtaposed identifiers
2019-07-06 20:28:53 +02:00
c43e050145
Fix parsing of enums allowing for juxtaposed identifiers
...
Fixes #28727
2019-07-05 21:40:40 +03:00
ed7ed52151
Parse more informations for code completion
2019-07-04 14:00:14 +08:00
e81ddf1242
Merge pull request #30289 from bojidar-bg/29586-class-name-constant
...
Fix inheriting from class_name messing up constants
2019-07-03 21:25:20 +02:00
2ef438c200
Fix inheriting from class_name messing up constants
...
Fixes #29586
2019-07-03 17:59:29 +03:00
f7de816f8b
Fix parsing of arguments in constant expressions
...
Fixes #8006
2019-07-03 17:28:50 +03:00
4d99408d12
Merge pull request #28884 from vnen/yield-resume-stack
...
Keep GDScript functions in stack while yielding
2019-07-01 16:35:26 +02:00
6b30f284a0
Merge pull request #29980 from Dentrax/directed-by-qarmin
...
Fix some editor crashes
2019-07-01 14:59:29 +02:00
b0ce9401ff
Merge pull request #30126 from qarmin/remove_unnecessary_code
...
Remove unnecessary code and add some error explanations
2019-07-01 14:32:04 +02:00
7d8d337b2c
fix some crashes
2019-07-01 14:28:29 +03:00
3c154eb93b
Remove unnecessary code and add some error explanations
2019-07-01 12:59:42 +02:00
d17eac735c
Merge pull request #29815 from NilsIrl/plus_file_1
...
Replace ` + "/" + ` with `String::file_add()`
2019-07-01 12:06:35 +02:00
b4aba3ae7c
Merge pull request #30177 from hbina/use_FALLTHROUGH_macro
...
Applied some of FALLTHROUGH macro usage from #30122
2019-06-29 23:40:08 +02:00
9f0c6a6009
Many fallthrough switch cases now have the FALLTHROUGH macro to tell the compiler that this is intended.
2019-06-29 16:08:48 -04:00
7c11a1b162
Add support for creating editor icons per module
...
The functionality is similar to how `doc_classes` are retrieved per module.
The build system will search for custom icons path defined per module via
`get_icons_path()` method in `config.py` or default icons path.
If such paths don't exist, only the editor's own icons will be built.
Most module icons were moved from editor/icons to respective modules.
2019-06-28 23:42:26 +03:00
6e03236574
Merge pull request #30134 from Calinou/doc-proofread
...
Proofread and improve the whole class reference
2019-06-28 12:36:41 +02:00
bd25e8d72a
Fixed regression bug caused in #30095 and actually fix the issue it was supposed to fix( #26850 )
2019-06-28 14:58:52 +05:30
f7f6115f76
Proofread and improve the whole class reference
...
- Document a few more properties and methods
- Add more information to many classes
- Fix lots of typos and gramar mistakes
- Use [code] tags for parameters consistently
- Use [b] and [i] tags consistently
- Put "Warning:" and "Note:" on their own line to be more visible,
and make them always bold
- Tweak formatting in code examples to be more readable
- Use double quotes consistently
- Add more links to third-party technologies
2019-06-27 22:30:19 +02:00
eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
...
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
a859643f7e
Fixed parser treating compound assignment the same as assignment which gave wrong argument usage count
2019-06-26 22:43:08 +05:30
4e5310cc60
Some code changed with Clang-Tidy
2019-06-26 15:08:25 +02:00
4c137bebe8
Extends wrapi/wrapf docs
2019-06-25 14:12:37 +03:00
d2833d4f4d
Replace ` + "/" + ` with `String::file_add()`
2019-06-23 13:33:50 +01:00
92277d3a28
Merge pull request #29866 from akien-mga/nothing-that-surrounds-us-is-object-all-is-subject
...
GDScript: Improve error on Object to Object invalid argument calls
2019-06-19 10:40:51 +02:00
0764451dc5
doc: Improve docs for Resource* classes
...
Also move module-specific classes to their own module's `doc_classes`
folder.
2019-06-18 20:07:26 +02:00
d6176db271
Unexpose subclasses of ResourceFormatLoader and -Saver
...
ResourceFormatLoader and ResourceFormatSaver are meant to be overridden
to add support for different formats in ResourceLoader and ResourceSaver.
Those should be exposed as they can be overridden in plugins.
On the other hand, all predefined subclasses of those two base classes
are only meant to register support for new file and resource types, but
should not and cannot be used directly from script, so they should not
be exposed.
Also unexposed ResourceImporterOGGVorbis (and thus its base class
ResourceImporter) which are editor-only.
2019-06-18 17:56:23 +02:00
6750e1b3cd
GDScript: Improve error on Object to Object invalid argument calls
...
Fixes #27804 .
2019-06-18 11:27:43 +02:00
971b5160c6
Merge pull request #29306 from qarmin/small_code_fixes
...
Small fixes to unrechable code, possibly overflows, using NULL pointers
2019-06-12 12:49:21 +02:00
4043c8a8c9
Merge pull request #29678 from akien-mga/err-macros-semicolon
...
Fix error macro calls not ending with semicolon
2019-06-11 19:01:26 +02:00
6d16f2f053
Fix error macro calls not ending with semicolon
...
It's not necessary, but the vast majority of calls of error macros
do have an ending semicolon, so it's best to be consistent.
Most WARN_DEPRECATED calls did *not* have a semicolon, but there's
no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
74d336d0f4
Added export hint to 2D and 3D physics and render layers.
2019-06-07 16:30:54 +02:00
8245db869f
Small fixes to unrechable code, possibly overflows, using NULL pointers
2019-06-03 21:52:50 +02:00
8cc8383a7f
Merge pull request #29433 from bojidar-bg/29406-dictionary-constant
...
Properly catch certain errors in Dictionary and Array declarations
2019-06-03 20:53:02 +02:00
Pedro J. Estébanez
Steven Schoen
Tom Evans
Thakee Nathees
Umang Kalra
Stoofin
Rémi Verschelde
Thomas ten Cate
Rajat Goswami
Rafael Delboni
Oliver Frank
of9
Hugo Locurcio
geequlim
Francois Belair
DaividFrank
Dani Frank
Bojidar Marinov
Danil Alexeev
Houkime
George Marques
Haoyu Qiu
Zak
Michael Alexsander
Rafał Mikrut
Aaron Franke
miere43
lupoDharkael
Micheál Keane
Marcel Admiraal
mashumafi
Andrii Doroshenko (Xrayez)
PouleyKetchoupp
EbbDrop
HaSa1002
noname1477
Yeongho Kim
luz.paz
Windy Darian
Mitch Curtis
Saracen
iwek7
MrCdK
shaderbeast
Thomas Karcher
Masoud Montazeri
toasteater
Robin Hübner
Cameron Reikes
Kaligule
Chaosus
Nils ANDRÉ-CHANG
Nils ANDRÉ-CHANG
Shiqing
Furkan Türkal
hbina085
unknown