Commit Graph

17007 Commits

Author SHA1 Message Date
Rémi Verschelde 2024666305 SCons: Add 'werror' opt-in to treat warning as errors
Also reorder advanced options to a more natural order,
and fix MSVC warning when disabling warnings in secondary environment.
2018-10-04 10:11:07 +02:00
Rémi Verschelde 0e2de7481d SCons: Set default warnings level to all (-Wall or /W3) 2018-10-04 10:11:07 +02:00
Rémi Verschelde cfa373c69f
Merge pull request #22708 from akien-mga/fix-warnings
Fix warnings about non-static data member initializers in nativescript
2018-10-04 10:09:20 +02:00
Rémi Verschelde e9cb01e366 Fix warnings about non-static data member initializers in nativescript
Fixes the following GCC/Clang warnings:
```
modules/gdnative/nativescript/nativescript.h:280:37: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:281:37: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:283:42: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:285:38: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:287:38: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:290:45: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
modules/gdnative/nativescript/nativescript.h:291:44: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
```
2018-10-04 09:59:49 +02:00
Rémi Verschelde bdf898e38d
Merge pull request #22707 from karroffel/clang-warnings
fix enum cast warnings on clang
2018-10-04 09:25:07 +02:00
karroffel a0f206aae8 fix enum cast warnings on clang 2018-10-04 09:17:59 +02:00
Rémi Verschelde 171be91804
Merge pull request #22694 from swarnimarun/fix-create-spatial-root
Fixing create spatial root button
2018-10-04 08:37:57 +02:00
swarnimarun 97ffdf74c3 Fixing create spatial root button 2018-10-04 06:06:58 +05:30
Rémi Verschelde caa141a1ac
Merge pull request #22659 from YeldhamDev/animation_doc_example
Add example to Animation doc
2018-10-03 20:35:09 +02:00
Rémi Verschelde 864772b900
Merge pull request #22643 from akerudesu/dynamic_font_fallback
Fix oversampling of DynamicFont fallback fonts
2018-10-03 20:34:52 +02:00
Rémi Verschelde 89d955615a
Merge pull request #22691 from jfmichaud31/fix_export_editor
Fix #22588: missing preset save after removing a export preset.
2018-10-03 20:25:24 +02:00
Rémi Verschelde 05fe312180
Merge pull request #22690 from jfmichaud31/fix_gles2_shader
Fix #22591: shader error when shadow enabled
2018-10-03 20:24:30 +02:00
Juan Linietsky fdd6950fc1 Fix lightmap baking crash, may close some issues but I am not sure. 2018-10-03 14:58:33 -03:00
Jean-François Michaud 700d5d26c9 Fix #22591: shader failed to compile when shadow enabled because of incompatible assignment of vec3 to a vec4. 2018-10-03 13:42:17 -04:00
Jean-François Michaud 00616360a3 Fix #22588: missing preset save after removing a export preset. 2018-10-03 13:40:16 -04:00
Rémi Verschelde 344a453bb8
Merge pull request #22681 from akien-mga/fix-warnings
Fix warnings on release builds and some MSVC warnings
2018-10-03 19:05:55 +02:00
Rémi Verschelde 1aa1398012
Merge pull request #22671 from Dragoncraft89/master
ItemList signals additional documentation
2018-10-03 18:20:23 +02:00
Rémi Verschelde 75fceb37f8
Merge pull request #22674 from Dragoncraft89/find_node
Document find_node()'s owner argument behaviour
2018-10-03 18:19:58 +02:00
Rémi Verschelde 0fa25206d2
Merge pull request #22683 from qonnop/fix-dds-w-h-attribs
Fixed DDS loader width/height attribs, fixes #22530
2018-10-03 18:19:11 +02:00
Michael Alexsander Silva Dias a02f02b9ed Add example to Animation doc 2018-10-03 13:17:49 -03:00
florian c14e034f06 Document find_node()'s owner argument behaviour 2018-10-03 18:16:27 +02:00
florian 65d182a939 ItemList signals additional documentation
Signals:
* item_selected
* item_rmb_select
2018-10-03 18:13:59 +02:00
Rémi Verschelde f7cb23f9e3
Merge pull request #22675 from DualMatrix/duplicate_err
Fixed error when duplicating node with signal from editor.
2018-10-03 18:07:13 +02:00
Rémi Verschelde dec20a987b Fix some warnings raised by MSVC 2017
Disabled signed/unsigned warnings like for GCC/Clang
(warning C4018: '>=': signed/unsigned mismatch).

Fixes the following MSVC 2017 warnings:
```
core\image.cpp(999): warning C4804: '>': unsafe use of type 'bool' in operation

core\io\compression.cpp(178): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
editor\doc\doc_dump.cpp(226): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
scene/resources/material.h(289): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
scene/resources/material.h(298): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

editor\editor_themes.cpp(379): warning C4805: '==': unsafe mix of type 'int' and type 'bool' in operation
```
2018-10-03 17:34:56 +02:00
Rémi Verschelde 95131e6f23 Fix warnings on release builds (not DEBUG_ENABLED)
Fixes the following Clang 5 warnings:
```
modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]

core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable]
core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable]
core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable]
core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable]

modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function]
modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable]
modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function]
scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function]
```
2018-10-03 17:34:55 +02:00
Akeru 81fa121909 Fix fallback font oversampling. 2018-10-03 17:25:28 +02:00
qonnop a93edeb307 Fixed DDS loader according to issue #22530
width and height attributes have to be switched according to the
official DDS header docs:
https://docs.microsoft.com/en-us/windows/desktop/direct3ddds/dds-header
2018-10-03 17:11:14 +02:00
Rémi Verschelde 874e3b4a37
Merge pull request #22676 from akien-mga/fix-warnings
Fix warnings in Android platform
2018-10-03 15:34:29 +02:00
Rémi Verschelde d952126caf Fix warnings in Android platform
Fixes the following Clang 7 warnings:
```
platform/android/os_android.h:240:16: warning: 'OS_Android::native_video_play' hides overloaded virtual function [-Woverloaded-virtual]
platform/android/os_android.h:241:15: warning: 'OS_Android::native_video_is_playing' hides overloaded virtual function [-Woverloaded-virtual]

platform/android/audio_driver_opensl.cpp:104:3: warning: suggest braces around initialization of subobject [-Wmissing-braces]

platform/android/audio_driver_opensl.cpp:129:10: warning: unused variable 'numOutputs' [-Wunused-variable]
platform/android/audio_driver_opensl.cpp:130:11: warning: unused variable 'deviceID' [-Wunused-variable]
platform/android/java_glue.cpp:795:10: warning: unused variable 'clsio' [-Wunused-variable]
platform/android/java_glue.cpp:890:12: warning: unused variable 'gob' [-Wunused-variable]
platform/android/java_glue.cpp:592:13: warning: unused variable 'resized' [-Wunused-variable]
platform/android/java_glue.cpp:593:13: warning: unused variable 'resized_reload' [-Wunused-variable]

modules/mobile_vr/mobile_vr_interface.cpp:401:8: warning: unused variable 'aspect_ratio' [-Wunused-variable]

drivers/unix/dir_access_unix.cpp:394:2: warning: THIS IS BROKEN [-W#warnings]
```
2018-10-03 15:17:00 +02:00
Rémi Verschelde f8484bb77d
Merge pull request #22672 from akien-mga/fix-warnings
Fix various warnings reported by CI in #22620
2018-10-03 15:09:00 +02:00
DualMatrix cb9559350f Fixed error when duplicating node from editor.
Fixed error when duplicating node from editor.
2018-10-03 14:59:16 +02:00
Rémi Verschelde 60688c3fe7 Fix GDNative build warning on Android [-Wignored-attributes]
Fixes the following kind of warning spam:
```
modules/gdnative/include/gdnative/color.h:61:6: warning: calling convention 'sysv_abi' ignored for this target [-Wignored-attributes]
void GDAPI godot_color_new_rgba(godot_color *r_dest, const godot_real p_r, const godot_real p_g, const godot_real p_b, const godot_real p_a);
     ^
modules/gdnative/include/gdnative/gdnative.h:52:15: note: expanded from macro 'GDAPI'
              ^
modules/gdnative/include/gdnative/gdnative.h:51:38: note: expanded from macro 'GDCALLINGCONV'
                                     ^
```
2018-10-03 14:23:04 +02:00
Rémi Verschelde 6ab78d9ffb Fix some more warnings reported by CI
Fixes the following Clang 7 warnings:
```
core/io/marshalls.cpp:872:10: warning: unused variable 'f' [-Wunused-variable]

core/ustring.cpp:1831:2: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
core/ustring.cpp:1832:2: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]

drivers/gles3/rasterizer_gles3.cpp:82:24: warning: unused function '_gl_debug_print' [-Wunused-function,34]

main/main.cpp:118:13: warning: unused variable 'auto_build_solutions' [-Wunused-variable]

modules/csg/csg_gizmos.cpp:225:46: warning: 'current' may be used uninitialized in this function [-Wmaybe-uninitialized]
```
2018-10-03 14:13:42 +02:00
Rémi Verschelde c1cee80829
Merge pull request #22668 from groud/add_open_docs
Add a shortcut to the documentation in the scene tree RMB menu
2018-10-03 13:28:14 +02:00
Rémi Verschelde 93513ba818
Merge pull request #22598 from DualMatrix/animation_frame_next
Fixed animation editor not moving to next frame of sprites when editing.
2018-10-03 11:40:10 +02:00
Rémi Verschelde bb1503c3b7
Merge pull request #22666 from JFonS/noisetexture_remove_size
Remove redundant size property from NoiseTexture
2018-10-03 11:36:10 +02:00
groud 980aa276e3 Add a shortcut to the documentation in the scene tree RMB menu 2018-10-03 11:25:18 +02:00
JFonS e14ead32dd Remove redundant size property from NoiseTexture 2018-10-03 10:27:24 +02:00
Rémi Verschelde 0bc0baff82
Merge pull request #22657 from YeldhamDev/remove_doc_path
Remove "Doc Path" setting
2018-10-03 09:44:41 +02:00
Rémi Verschelde 64962fe605
Merge pull request #22653 from neikeq/mono-mod-fix-gcc-warnings
Fix GCC compiler warning in mono module
2018-10-03 08:43:43 +02:00
Rémi Verschelde 9941c5a132
Merge pull request #22651 from cbscribe/kcc_docs_color_rigidbody
[DOCS] Classref updates: Color, RigidBody*
2018-10-03 08:19:38 +02:00
Michael Alexsander Silva Dias 1316595c96 Remove "Doc Path" setting 2018-10-02 22:17:31 -03:00
Ignacio Etcheverry 2c8980f44c Fix GCC compiler warning in mono module
- thread_local.h: 'delegating constructors only available with -std=c++11 or -std=gnu++11'
- mono_reg_utils.cpp: 'extra tokens at end of #endif directive'
- mono_bottom_panel.cpp: '<fieldB> will be initialized after <fieldA> when initialized here'
- bindings_generator.cpp: 'name lookup of 'i' changed (...) matches this 'i' under ISO standard rules (...) matches this 'i' under old rules (...)'
2018-10-03 00:56:28 +02:00
Chris Bradfield 7bc11505b1 [DOCS] Classref updates: Color, RigidBody* 2018-10-02 15:47:10 -07:00
Rémi Verschelde d675d04f09
Merge pull request #22645 from merumelu/plugin-ready-path
PluginConfigDialog: pass subfolder name instead of plugin name on creation
2018-10-03 00:35:08 +02:00
Rémi Verschelde f511fa35e5
Merge pull request #22647 from YeldhamDev/parallaxlayer_doc_note
Add note in ParallaxLayer doc about ignoring position/scale changes after entering the scene
2018-10-03 00:18:11 +02:00
Rémi Verschelde 2da6d510bc
Merge pull request #22646 from LikeLakers2/docs-fix-enum-newlines
Add extra newline after enum members and constants, to ensure they'll…
2018-10-03 00:09:54 +02:00
Juan Linietsky 286b70839e vertex lit optimization for fog. 2018-10-02 19:08:33 -03:00
Juan Linietsky 11f088279d Implemented FOG support in GLES2. 2018-10-02 18:53:16 -03:00
LikeLakers2 0d6546ed44 Add extra newline after enum members and constants, to ensure they'll format properly after a multi-line description 2018-10-02 16:48:40 -04:00