Commit Graph

12254 Commits

Author SHA1 Message Date
Rémi Verschelde d3e32698b4
Merge pull request #69753 from lpares12/feat_meta_cursor
RichTextLabel: decouple meta cursor from underline
2022-12-09 18:06:11 +01:00
Vladislav Slobodenyuk 0b5c4216c8
Fix TileMap drawing itself twice on creation
Adds a check before calling `item_rect_changed()` in
`_recompute_rect_cache()` of `scene/2d/tile_map.cpp`. Makes sure
TileMap is only redrawn if the rect is actually changed.
Fixes #69754
2022-12-09 22:20:31 +09:00
Rémi Verschelde 2d02cb67ee
Merge pull request #69661 from Mickeon/fix-editor-cannot-disconnect-signal
Fix unable to disconnect signal in Editor once created
2022-12-09 07:34:29 +01:00
Rémi Verschelde 75e558e271
Merge pull request #69774 from Calinou/backbuffercopy-only-show-rect-when-relevant
Fix BackBufferCopy `rect` property appearing when not relevant in inspector
2022-12-09 06:52:03 +01:00
Hugo Locurcio 080b6ac1ae
Fix BackBufferCopy `rect` property appearing when not relevant in inspector
The `rect` property is only effective if `copy_mode` is Rect.
2022-12-08 19:52:48 +01:00
Rémi Verschelde a914ee8413
TouchScreenButton: Fix screen capability check
Fixes #69572.
2022-12-08 14:28:04 +01:00
Micky 885f2a4eca Fix unable to disconnect signal in Editor once created
Adds a CONNECT_INHERITED flag to connections, only available in editor builds. This flag denotes that the signal has been inherited from a previous Scene in the instancing hierarchy.
2022-12-08 13:36:48 +01:00
Lluc Pares 2005b5c44a RichTextLabel: decouple meta cursor from underline
This commit decouples the type of cursor used when the underline
of meta tag is set to False. Previous to this commit setting the
meta underline to false in the RichTextLabel would also make it
show the arrow cursor instead of the hand cursor.

Making the meta tag with no underline should not have any effect
on the type of cursor, since the text will still be clickable it
should be expected to have a hand cursor.

The same behavior is seen in other languages, like HTML+CSS, where
the setting "text-decoration" to "none" for the links, disables
the underline but maintains the clickable cursor.

Fixes godotengine/godot-proposals#3193
2022-12-08 09:43:41 +01:00
clayjohn 29dea68bab Index override surface name starting from 1 to match surface name 2022-12-07 11:56:39 -08:00
Yuri Sizov 29cc86fa6c Copy local theme overrides from Control to Window 2022-12-07 20:50:51 +03:00
Rémi Verschelde a7937fe54c
Merge pull request #69722 from TokageItLab/more-refactor-immediate-anim
More refactor AnimationPlayer process for Method track which change animation with Immediate mode
2022-12-07 15:13:55 +01:00
Silc Renew bd8395882e Change init for cache_update_size & add pointer animation player 2022-12-07 22:34:41 +09:00
Rémi Verschelde 0a3f66471e
Merge pull request #69712 from bruvzg/real_size
Rename `window_get_real_size`, add position counterpart.
2022-12-07 14:29:46 +01:00
Lucas Laukka 4e63395a78 fixed bug showing only two digits in color picker 2022-12-07 13:55:51 +01:00
Rémi Verschelde c92e70e711
Merge pull request #69685 from TokageItLab/fix-immediate-method-anim
Fix AnimationPlayer method track call oneself with IMMEDIATE mode
2022-12-07 13:26:41 +01:00
Rémi Verschelde f9bd2ace0b
Merge pull request #68682 from timothyqiu/camera-gizmo-size
Make Camera3D gizmo the same aspect ratio as its viewport
2022-12-07 13:25:35 +01:00
Rémi Verschelde 4b21e656c9
Merge pull request #69702 from bruvzg/menu_safe_rect
Fix menu popup safe rect height no including theme separation.
2022-12-07 13:25:20 +01:00
Rémi Verschelde de2d0f156e
Merge pull request #69713 from groud/rename_get_surrounding_tiles
Rename get_surrounding_tiles to get_surrounding_cells
2022-12-07 13:24:57 +01:00
Rémi Verschelde cc6321dfbe
Merge pull request #68998 from hackenshaw/makhak/avoid_error_spamming_in_animation_tree
Avoid error spamming in animation_tree when path is not found
2022-12-07 13:24:42 +01:00
Silc Renew d3b77d9cc3 Fix AnimationPlayer method track call oneself with IMMEDIATE mode 2022-12-07 19:48:06 +09:00
Gilles Roudière 3ea54bb3a1 Rename get_surrounding_tiles to get_surrounding_cells 2022-12-07 11:09:10 +01:00
Medhat Riad 03474b0985 Avoid error spamming in animation_tree when path is not found 2022-12-07 10:36:12 +01:00
bruvzg edf13eb5a6
Rename `window_get_real_size` to `window_get_size_with_decorations`, add `window_get_position_with_decorations`. 2022-12-07 11:07:30 +02:00
Markus Sauermann e18107a57c Fix Determining Window for Touchscreen
DisplayServer::screen_is_touchscreen will likely never utilize its
parameter p_screen.
This PR replaces this function by DisplayServer::is_touchscreen_available()
with the same functionality.
This solves the problem, that a SubViewport was used for determining
the screen, which resulted in error messages.
2022-12-07 09:54:29 +01:00
bruvzg 02e9134183
Fix menu popup safe rect height no including theme separation. 2022-12-07 08:21:27 +02:00
smix8 860379fc16 Stop NavigationAgents without a target from moving to world origin
Stops NavigationAgents moving to the world origin without anyone telling them to do so.
2022-12-06 22:53:18 +01:00
Rémi Verschelde 9bd7ad53f7
Merge pull request #69506 from adamscott/move-gdscript-uninit-to-finalize
Move GDScript uninitialization to `GDScriptLanguage::finish()`
2022-12-06 16:11:21 +01:00
Adam Scott 88f3045301 Move GDScript uninitialization to `GDScriptLanguage::finalize()`
Co-authored-by: Ricardo Buring <ricardo.buring@gmail.com>
Co-authored-by: kleonc <9283098+kleonc@users.noreply.github.com>
2022-12-06 09:35:39 -05:00
Rémi Verschelde 42bbb20e06
Merge pull request #69666 from akien-mga/cleanup-skeleton-modification-register
Use `GDREGISTER_CLASS` macro for SkeletonModification classes
2022-12-06 15:17:43 +01:00
Rémi Verschelde f9aea4d940
Merge pull request #69660 from xiongyaohua/fix_path2d_fish_bone_direction
Fix Path2D fish bone direction
2022-12-06 15:16:35 +01:00
Rémi Verschelde 3b6756b745
Use `GDREGISTER_CLASS` macro for SkeletonModification classes
This was likely an oversight from merging this PR after `GDREGISTER_CLASS`
was introduced. It's equivalent, unless the class is actually disabled.
2022-12-06 15:04:15 +01:00
kobewi 368b209cc3 Fix unexpected editor dependency 2022-12-06 14:47:25 +01:00
Yaohua Xiong 322dbd0955 Fix Path2D fish bone direction 2022-12-06 20:45:17 +08:00
Richard Adenling a3d8a78f1b Fix for 2D viewport not updating in the editor when the camera moves
This fixes a problem with 2D viewports not taking the camera position
into consideration when previewed in the editor.

Fixes #40441
2022-12-06 11:34:32 +01:00
Rémi Verschelde deb760fb1b
Path2D: Fix build issue after conflicts between #68860 and #69115 2022-12-06 11:22:11 +01:00
Rémi Verschelde 9cc1e9cbd0
Merge pull request #69642 from dalexeev/text-edit-fix-highlight-overlaps
Fix highlight overlaps in TextEdit
2022-12-06 11:02:38 +01:00
Rémi Verschelde e19ead8e37
Merge pull request #50294 from Calinou/distance-fade-use-circular-fade
Use circular fade instead of linear fade for distance fade
2022-12-06 10:56:58 +01:00
Rémi Verschelde 6fd5162124
Merge pull request #55757 from Calinou/light-3d-tweak-shadow-bias
Tweak shadow bias defaults for DirectionalLight3D and OmniLight3D
2022-12-06 10:56:45 +01:00
Rémi Verschelde 14861c45b5
Merge pull request #68860 from xiongyaohua/path3d_fishbones
Draw fish bones for Path3D and Path2D in the Editor
2022-12-06 10:46:54 +01:00
Danil Alexeev 53b3d1e645
Fix highlight overlaps in TextEdit 2022-12-06 12:01:31 +03:00
Hugo Locurcio d926be72ed
Use circular fade instead of linear fade for distance fade
This makes distance fade look the same regardless of the camera angle,
for all distance fade modes (Pixel Alpha, Pixel Dither, Object Dither).
Distance fade now behaves like fog in this regard.
2022-12-05 22:35:11 +01:00
Hugo Locurcio e560971bf2
Tweak shadow bias defaults for DirectionalLight3D and OmniLight3D
- Increase DirectionalLight3D normal bias to 2.0 to reduce shadow acne
  at grazing angles.
- Decrease OmniLight3D bias to 0.1 to reduce shadow peter-panning.
2022-12-05 21:53:29 +01:00
Fredia Huya-Kouadio e8d80fc747 Address Android editor crashes
- Add workaround for crash when resuming existing project
2022-12-05 10:07:09 -08:00
Rémi Verschelde f87858a8f2
Merge pull request #65101 from MrPhnix/range_value_bug
Bug: The range doesn't take into account the min value when setting the value.
2022-12-05 18:08:28 +01:00
Rémi Verschelde 6ee3268189
Merge pull request #65228 from Mickeon/fix-packed-scene-unique-name-root
Fix "Save Branch as Scene" storing root Node's `unique_name_in_owner`
2022-12-05 18:08:10 +01:00
Rémi Verschelde 45c6950f1b
Merge pull request #67123 from Rindbee/improve-caret-draw-conditions-for-LineEdit
Improve caret drawing conditions for `LineEdit`
2022-12-05 18:06:50 +01:00
Rémi Verschelde b5fd901b07
Merge pull request #69115 from xiongyaohua/curve2d_baking_refactor
Curve2d baking and sampling refactor
2022-12-05 18:06:25 +01:00
Yaohua Xiong 91e9ad92f5 Refactor baking code for Curve2D
The main change is to caculate tangent directly from bezier curve, without going
through discretized polyline, avoiding pitfalls of discretization. A similar refacor
had been applied to Curve3D.

The test cases for Curve2D is updated, comparing floating point with is_equal_approxmiate()
instead of `==`, in order to avoid float precision problem.
2022-12-05 21:22:05 +08:00
Yuri Sizov d759210f52
Merge pull request #69284 from gdixr/bugfix-69082
Prevent editor crash when deleting children of GraphNode
2022-12-05 15:56:10 +03:00
Rémi Verschelde 777dca33b0
Merge pull request #69588 from TokageItLab/fix-play-bw
Fix AnimationPlayer play backward doesn't process just current key & AnimationPlaybackTrack seeking for preview
2022-12-05 11:32:18 +01:00
Rémi Verschelde 73de09f38e
Merge pull request #69580 from bruvzg/rtl_fix_search
[RTL] Fix search method not taking nested frame and line wraps into account.
2022-12-05 10:14:00 +01:00
Rémi Verschelde 4211c6d74d
Merge pull request #69531 from BastiaanOlij/fix_origin_current_issue
Fix recurrence issue with setting current origin node
2022-12-05 10:13:55 +01:00
Yaohua Xiong 9bdc0cb16f draw fish bones for Path2D and Path3D
These fish bones are add to indicate the direction and local transforms alone the path.
2022-12-05 15:39:14 +08:00
Silc Renew 8c540b1d71 Fix animation play backward doesn't process current key&animtrack seek 2022-12-05 15:59:08 +09:00
Rémi Verschelde 9962225d89
Merge pull request #69584 from bruvzg/fix_tm_tr_4
[TextMesh] Fix autotranslate.
2022-12-05 00:06:50 +01:00
Rémi Verschelde a738f50886
Merge pull request #69357 from TokageItLab/byebye-trigger
Remove `UPDATE_TRIGGER` mode from `ValueTrack::UpdateMode` & Match behaviors between `AnimationTree` and `AnimationPlayer`
2022-12-05 00:06:23 +01:00
Rémi Verschelde a0365c140a
Merge pull request #68995 from bruvzg/sys_font_for_text
Use system fonts as fallback.
2022-12-05 00:05:49 +01:00
Rémi Verschelde 5efa254964
Merge pull request #67387 from NumbuhFour/cam_vis_layers_shader_var
Implement CAMERA_VISIBLE_LAYERS as built-in shader variable
2022-12-05 00:05:39 +01:00
Rémi Verschelde 92b5e616ae
Merge pull request #69561 from AThousandShips/tree_select_fix
Fix TreeItem::set_as_cursor check
2022-12-05 00:05:23 +01:00
Rémi Verschelde bb7dbdf1d1
Merge pull request #69312 from RumblingTurtle/double-click-editor-fix
Editor doubleclick jumping in certain positions fix
2022-12-05 00:04:36 +01:00
Bastiaan Olij 80824e9858 Fix recurrense issue with setting current origin node 2022-12-05 08:18:51 +11:00
bruvzg 08d7c24ebe
[TextMesh] Fix autotranslate. 2022-12-04 23:04:48 +02:00
bruvzg 889bcff24f
[RTL] Fix search method not taking nested frame and line wraps into account. 2022-12-04 22:11:21 +02:00
bruvzg ecec415988
Use system fonts as fallback and improve system font handling.
Add support for font weight and stretch selection when using system fonts.
Add function to get system fallback font from a font name, style, text, and language code.
Implement system font support for Android.
Use system fonts as a last resort fallback.
2022-12-04 18:44:20 +02:00
Ninni Pipping f90d3554cf Fix TreeItem::set_as_cursor check 2022-12-04 09:57:47 +01:00
NumbuhFour 1b09fd5410 Implement CAMERA_VISIBLE_LAYERS as built-in shader variable 2022-12-03 22:41:27 -08:00
Rémi Verschelde 82b1cd6753
Merge pull request #62675 from Jummit/tolerant_lookup
Allow drag-clicking before symbol lookup
2022-12-03 21:30:57 +01:00
Eduard Zalyaev b663a825a6 Script editor: Fix edge case when double-click incorrectly updates caret position
Fixes #68898.
2022-12-03 15:51:10 +03:00
Rémi Verschelde e0f9bc6629
Merge pull request #64312 from KoBeWi/StringNameEdit
Improve usage of StringNames in GraphEdit
2022-12-03 12:45:53 +01:00
Yaohua Xiong 69f84563a3 Fix Curve3D::get_closest_point() broken
The problem is caused by calling adaptive tessellation baking function by mistake, which produce too few points for straight lines. Calling the even length tessellation fix the problem.

The code for `get_closest_point()` and `get_closest_offset()` are also updated. They used to assume bake interval to be exact, which is no longer true.

The out dated document for `get_closest_point()` is also updated.
2022-12-03 17:01:03 +08:00
kobewi 5490c22ffb Improve usage of StringNames in GraphEdit 2022-12-02 22:57:23 +01:00
Silc Renew 83135aa122 Remove UPDATE_TRIGGER & Match behaviors between AnimationTree/Player
#69357
2022-12-02 20:28:10 +09:00
Rémi Verschelde 8c094207a0
Merge pull request #61958 from jtnicholl/animation_connections
Add `animation_changed` signal to `AnimationLibrary`, have `AnimationPlayer` connect to it instead of `Animation`'s `changed`
2022-12-02 12:24:32 +01:00
Rémi Verschelde 10e9a85607
Merge pull request #69336 from TokageItLab/get-anim-keys-more-exactly
Refactor process of animation to retrive keys more exactly
2022-12-02 12:24:24 +01:00
Rémi Verschelde 3ce539cad9
Merge pull request #69475 from bruvzg/rtl_fx_idx
[RichTextEffect] Restore missing `relative_index` property.
2022-12-02 12:24:13 +01:00
bruvzg 0541c746ee
[RichTextEffect] Restore missing `relative_index` property. 2022-12-02 09:50:54 +02:00
Silc Renew 962b6a3e8f Fix animation signal caches_cleared firing timing 2022-12-02 15:02:36 +09:00
kobewi 7e2a8afb57 Rework how current Camera2D is determined 2022-12-02 00:05:02 +01:00
Rémi Verschelde a7fcfacaa5
Merge pull request #69427 from TokageItLab/remove-wrong-method-root-pos
Remove unneeded calc in root motion
2022-12-01 18:11:07 +01:00
Rémi Verschelde e5f0a565e2
Merge pull request #67660 from Rindbee/improve-setter-for-Range
Improve validation when setting `max`/`min`/`page` in `Range`
2022-12-01 18:11:01 +01:00
Rémi Verschelde 86273fcf13
Merge pull request #69401 from IceflowRE/rename_theme_cache_names
Rename Tree theme cache separation names
2022-12-01 18:09:52 +01:00
Rémi Verschelde 60750a1b69
Merge pull request #69403 from KoBeWi/gdrequiredvirutalcallnoif
Simplify GDVIRTUAL_REQUIRED_CALL calls
2022-12-01 18:09:43 +01:00
Silc Renew 1fc3833617 Refactor process of animation to retrive keys more exactly 2022-12-01 22:07:47 +09:00
Silc Renew c1a29f5ef4 Remove unneeded calc in root motion 2022-12-01 11:11:21 +09:00
Fredia Huya-Kouadio 3ff7dd2aa4 Fix routing of InputEventScreenDrag events to Control nodes 2022-11-30 14:06:41 -08:00
Rémi Verschelde 0bb1e89fb7
Merge pull request #69408 from TokageItLab/spblend-more-warn
Emphasize the warning about special case blend for animation
2022-11-30 19:11:44 +01:00
kobewi 9a3960daa5 Simplify GDVIRTUAL_REQUIRED_CALL calls 2022-11-30 18:36:57 +01:00
Silc Renew 9a3d9c6cae Emphasize the warning about special case blend for animation 2022-12-01 02:13:24 +09:00
Iceflower 908f392af6
Rename theme cache separation names 2022-11-30 16:06:14 +01:00
kobewi b65a3a52ac Display transform properties of contained controls 2022-11-30 15:08:39 +01:00
zhangjianguo 8e1138d59a Prevent editor crash when deleting children of GraphNode 2022-11-30 09:25:26 +08:00
Hendrik Brucker e84f45fc93 Move z_index, z_as_relative and y_sort_enabled from Node2D to CanvasItem 2022-11-29 17:11:22 +01:00
Rémi Verschelde 610c34ea03
Merge pull request #65641 from voylin/Adding_ttf_otf_to_custom_font_dialogue
Adding .tff .otf, .woff and .woff2 to custom font extensions - Fixes #65633
2022-11-29 13:41:45 +01:00
Rémi Verschelde 55dae30177
Merge pull request #69301 from KoBeWi/ERR_WHATEVER
Don't break parsing on missing resources
2022-11-28 16:53:46 +01:00
Rémi Verschelde 4555ccdf98
Merge pull request #69224 from adamscott/fix-PackedScene-reload_from_file
Add `PackedScene::reload_from_file()` override
2022-11-28 16:53:36 +01:00
Adam Scott a34a26eb66 Add PackedScene::reload_from_file() override 2022-11-28 10:23:02 -05:00
kobewi 0765908868 Don't break parsing on missing resources 2022-11-28 16:19:15 +01:00
Rémi Verschelde ef090ee6ea
Merge pull request #68874 from TokageItLab/fix-unique-path-keying
Added option to `get_path_to()` to get the shortest path considering unique name
2022-11-28 14:49:34 +01:00
Rémi Verschelde 12f0660518
Merge pull request #68992 from TokageItLab/animtree-trackend-process
Refactor process of AnimationTree for end of animation
2022-11-28 14:49:19 +01:00
Rémi Verschelde bb9cd4063e
Merge pull request #69199 from TokageItLab/fix-and-refactor-root-motion
Fix broken root motion scale & Refactor API & Add sample codes in documentation
2022-11-28 14:49:04 +01:00
Rémi Verschelde 519b9b5c21
Merge pull request #68486 from smix8/navpoly_outline_convex_error_4.x
Add detail to NavigationPolygon outline error msg
2022-11-28 13:37:00 +01:00
dzil123 d50a2e1e51 GPUParticlesCollisionSDF3D add null `bake_step_function` check 2022-11-28 00:36:14 -08:00
Rémi Verschelde f4faa507d4
Merge pull request #68836 from Calinou/projectsettings-vrs-texture-allow-more-formats
Allow all lossless image formats to be used for VRS texture project setting
2022-11-28 08:38:08 +01:00
Rémi Verschelde 438b2e2d02
Merge pull request #59801 from Sauermann/fix-node2d-viewport-root-order
Fix Viewport root order after Node2D raise
2022-11-28 08:21:10 +01:00
Rémi Verschelde c7c9aa8d8b
Merge pull request #69240 from TokageItLab/fix-anim-tree-value-track-cache-bug
Fixed AnimationTree `TrackCacheValue` bug for special case blending
2022-11-28 08:06:25 +01:00
Rémi Verschelde 794adbe996
Merge pull request #69178 from aaronfranke/mesh-shape
Use a more specific type for Mesh create_(convex|trimesh)_shape
2022-11-28 08:05:50 +01:00
Rémi Verschelde 88e6e1e51c
Revert "`SceneTree` Fix storing removed nodes to be skipped by the group calls" 2022-11-27 13:42:24 +01:00
Silc Renew 1193c2641b Fixed AnimationTree TrackCacheValue bug for special case blending 2022-11-27 13:29:38 +09:00
Silc Renew 09adf5f20e Fix broken root motion scale and refactor API 2022-11-26 17:26:10 +09:00
Rémi Verschelde ead82feb24
Merge pull request #69008 from akien-mga/property-hint-array-type-resource-simplify
Add MAKE_RESOURCE_TYPE_HINT macro to simplify binding arrays of resources
2022-11-25 19:29:05 +01:00
Rémi Verschelde 6e693368e1
Merge pull request #69124 from zaevi/tilemap_fix_alternative_tile
[TileMap] Fix alternative tile issues.
2022-11-25 19:27:37 +01:00
Aaron Franke 93ab82536d
Use a more specific type for Mesh create_(convex|trimesh)_shape 2022-11-25 11:43:11 -06:00
Rémi Verschelde 986a4279fa
Merge pull request #68447 from Grimmr/clean-tooltips-on-WM-focus-off
Viewport cancels existing tooltip when window looses focus
2022-11-25 14:04:40 +01:00
grimmr aa9b5b917f Viewport cancels existing tooltip when window looses focus
fixes #68197

when NOTIFICATION_WM_WINDOW_FOCUS_OUT is recieved by a viewport it will now call
_gui_cancel_tooltip() to avoid it hanging around after the mouse events stop
coming in
2022-11-25 09:44:04 +00:00
Rémi Verschelde 34df77285c
Merge pull request #69146 from clayjohn/Polygon2D-error
Ensure that mesh instance is properly freed when freeing Polygon2D
2022-11-25 10:11:47 +01:00
Haoyu Qiu 06a0b26c9e Fix inspector not showing name for LabelSettings.font 2022-11-25 12:48:37 +08:00
clayjohn 5c95288a6e Ensure that mesh instance is properly freed when freeing Polygon2D 2022-11-24 17:34:25 -08:00
Jasuse 749bdad23c Fixing debug shape update of ShapeCast3D
fixed update conditiion at set_shape
added "changed" notification to update on shape changing
2022-11-24 22:31:35 +03:00
Rémi Verschelde d7e3fce995
Merge pull request #68566 from Mickeon/node-print-orphans-static
Make `Node.print_orphan_nodes()` static
2022-11-24 18:55:30 +01:00
Rémi Verschelde 0d202cb5f1
Merge pull request #69111 from TokageItLab/put-together-interpolations
Refactor interpolating functions in some classes to use `Math` class
2022-11-24 18:54:30 +01:00
Rémi Verschelde 1fa80bf9d6
Merge pull request #67330 from KoBeWi/immortal_scenes
Don't free instanced scenes when recreating tiles
2022-11-24 18:54:08 +01:00
Zae f6424e68ea [TileMap] Fix alternative tile issues. 2022-11-25 00:44:02 +08:00
Rémi Verschelde 5d20dccade
Add MAKE_RESOURCE_TYPE_HINT macro to simplify binding arrays of resources 2022-11-24 14:06:00 +01:00
Silc Renew b217c41d36 Refactor interpolating functions in some classes to use Math class 2022-11-24 20:31:43 +09:00
Yaohua Xiong f9fa182abc Refactor Curve3D::_bake() method
The main change is to caculate tangent directly from bezier curve, without going
through discretized polyline, avoiding pitfalls of discretization.

Other changes are:
1. Add an bezier_derivative() method for Vector3, Vector2, and Math;
2. Add an tesselate_even_length() method to Curve3D, which tesselate bezier curve to even length segments adaptively;
3. Cache the tangent vectors in baked_tangent_vector_cache;
2022-11-24 10:52:06 +08:00
Rémi Verschelde fa270c2456
Merge pull request #69070 from Piralein/bg-color-cell
RichTextLabel Cell Option "bg" - add possibility to use only one color
2022-11-23 23:12:22 +01:00
Rémi Verschelde 885fc1f3e7
Merge pull request #68568 from Mickeon/node-parent-busy-error
Update "Parent node is busy" errors to use `Callable.call_deferred()`
2022-11-23 23:11:06 +01:00
Hana 125d7deaff add possibility to use only one color 2022-11-23 21:47:22 +01:00
Micky c6a355b9e8 Update "Parent node is busy" errors to use `Callable.call_deferred()`
Also fixes outdated method names in the messages.
2022-11-23 17:39:34 +01:00
Rémi Verschelde 9ddb6a925e
Merge pull request #69052 from Sauermann/fix-viewport-exit-tree-visibility
Fix Viewport visibility after entering/leaving scene-tree
2022-11-23 17:22:58 +01:00
Rémi Verschelde cfb5ce771c
Merge pull request #69048 from akien-mga/thorvg-better-errors
ImageLoaderSVG: Improve error reporting
2022-11-23 17:22:16 +01:00
Markus Sauermann ebd1b0089a Fix Viewport being visible after leaving tree
When a SubViewport leaves the tree, it is still displayed in its parent
SubViewportContainer until the next redraw.
This PR makes sure, that the parent gets redrawn immediately.

This also fixes the visibility problem when a SubViewport is added as
child of a SubViewportContainer.
2022-11-23 16:04:07 +01:00
Adam Scott 0c64304ba5 Fix error while selecting last empty line 2022-11-23 09:21:41 -05:00
Rémi Verschelde d3b8faac74
ImageLoaderSVG: Improve error reporting 2022-11-23 13:27:31 +01:00
Rémi Verschelde a8a88194a5
Merge pull request #68993 from TokageItLab/fix-anim-blending-for-DISCRETE-mode
Fix animation blending for value track `UPDATE_DISCRETE` and `UPDATE_TRIGGER` mode
2022-11-23 10:25:19 +01:00
Rémi Verschelde 0afcbcfda4
Merge pull request #68996 from AThousandShips/bit_map_polygon_fix_2
Follow up for BitMap polygon generation
2022-11-23 08:33:12 +01:00
Rémi Verschelde 759e91ae00
Merge pull request #69039 from maiself/fix-negative-blend-weights
Fix blending with negative blend weights
2022-11-23 08:32:47 +01:00
Mai Lavelle ac15f6a7e2 Fix blending with negative blend weights 2022-11-22 20:51:41 -05:00
Markus Sauermann f8df18ef47 Fix CanvasTransform on RenderingServer when Viewport enters Tree
Previously the Viewport didn't initialize its canvas transform in the
RenderingServer.
2022-11-22 23:04:23 +01:00
Micky b6db09968d Fix AudioStreamPlayer2D and 3D's `playing` not updating right away 2022-11-22 15:46:28 +01:00
Silc Renew c1ec99f0e1 Refactor process of AnimationTree for end of animation 2022-11-22 18:12:45 +09:00
Ninni Pipping 28c5250c2d BitMap polygon code cleanup 2022-11-22 10:00:09 +01:00
Rémi Verschelde dff8a51c6c
Merge pull request #68593 from TokageItLab/optimize-blend-animation
Optimize animation blend tree process
2022-11-22 09:59:54 +01:00
Silc Renew dce3e07fb2 Fix animation blending for value track DISCRETE/TRIGGER mode 2022-11-22 17:39:29 +09:00
Rémi Verschelde ebf4f75c54
Merge pull request #68855 from Cafalaarl/Cafalaarl/master
Fixed incorrect gradient orientation in HSV vertical slider
2022-11-22 08:29:12 +01:00
Jonathan Nicholl f8021dae9c Add animation_changed signal to AnimationLibrary
AnimationLibrary now listens for the animation_changed signal on its
animations and emits this new signal, with the animation name added
on. AnimationPlayer now connects to this signal rather than connecting
to each individual animation, which was poor practice due to bypassing
encapsulation.
2022-11-21 15:39:03 -05:00
Markus Sauermann 28af870750 Code simplifications found by cppcheck
They are based on:
- Boolean arithmetic simplifications
- setting variables that are not accessed
- constant variables
2022-11-21 08:43:36 +01:00
Fabio Alessandrelli 145f07c037 [Net] Fix HTTPRequest gzip with high compression ratio.
Decompress each body chunk over multiple iterations, this causes more
reallocations, but it ensures decompression will not fail no matter the
compression ratio.
2022-11-20 22:41:14 +01:00
Rémi Verschelde 642859bf51
Merge pull request #68902 from TokageItLab/fix-animation-changed-signal
Fix connection of animation "changed" signal in AnimationTrackEditor
2022-11-20 15:37:42 +01:00
Rémi Verschelde 855402dfee
Merge pull request #68904 from aaronfranke/texture-methods
Rename TextureButton set_*_texture methods to set_texture_*
2022-11-20 15:37:37 +01:00
Rémi Verschelde 3a874804ab
Merge pull request #68886 from timothyqiu/motion-distance
Revert move vector parameter name to "motion"
2022-11-20 11:43:32 +01:00
Aaron Franke f6714858bf
Rename TextureButton set_*_texture methods to set_texture_* 2022-11-19 17:33:40 -06:00
Silc Renew b739bafd51 Fix connection of animation changed signal in AnimationTrackEditor 2022-11-20 06:38:51 +09:00
Hugo Locurcio 2a0afb1dcc
Improve collision exception error messages for easier understanding 2022-11-19 17:35:44 +01:00
Haoyu Qiu 42ab2b9ef5 Revert move vector parameter name to motion 2022-11-19 20:19:50 +08:00
Rémi Verschelde 895428c805
Merge pull request #68863 from clayjohn/RD-2D-skeleton
Fix drawing of 2D skeletons in the RD renderer.
2022-11-19 10:25:31 +01:00
clayjohn 0e5a98cdd8 Fix drawing of 2D skeletons in the RD renderer.
Also clean up skeleton code in preparation for adding them to GLES3

Properly update Mesh2D AABBs when skeleton is updated
2022-11-18 23:36:40 -08:00
Silc Renew b9d1550590 Add option to get_path_to() to get the shortest path with unique name 2022-11-19 15:06:25 +09:00
Rémi Verschelde 84c404f6bc
Merge pull request #68842 from Uxeron/DragPositionFix
Fixed `_get_drag_data` getting incorrect position on a scaled `Control`
2022-11-18 23:32:08 +01:00
Rémi Verschelde 80b3813b15
Merge pull request #67714 from adamscott/fix-preload-cyclic-references-part2
Fix cyclic references in GDScript 2.0
2022-11-18 23:08:01 +01:00
Flynn Garthwaite b29f7c2fe8 Fixed orientation of HSV rectangle vertical slider 2022-11-19 10:51:56 +13:00
Adam Scott 5704055d30 Fix cyclic references in GDScript 2.0 2022-11-18 16:41:31 -05:00
Hugo Locurcio 4b13093251
Allow all lossless image formats to be used for VRS texture project setting
WebP can also be lossy, but the class reference now warns about the
requirement to use a lossless format for the VRS texture to work correctly.
2022-11-18 22:21:28 +01:00
Uxeron 721e51ac28 Fixed _get_drag_data getting incorrect position on scaled controls 2022-11-18 19:10:57 +02:00
Rémi Verschelde 8ab3e73a79
Merge pull request #64212 from xiongyaohua/curve3d_baking_refactor
Move rotation interpolation to Curve3d and refactor baking
2022-11-18 16:20:14 +01:00
bruvzg 9b14b5b483
Fix multithreaded RTL resetting scroll position on resize. 2022-11-17 16:26:06 +02:00
Rémi Verschelde d33e584607
Merge pull request #68732 from AThousandShips/bit_map_polygon_fix
Fix polygon generation in BitMap
2022-11-17 14:44:30 +01:00
bruvzg 3add6dcd89
Add `Control::localize_numeral_system` property to toggle automatic numeral system conversion. 2022-11-17 14:59:56 +02:00
Rémi Verschelde 725f25487c
Merge pull request #68589 from marzecdawid/remove-default-file-save-filedialog
Remove auto selecting the first file for FileDialog with Save mode
2022-11-17 13:48:33 +01:00
Ninni Pipping f0099b28b1 Fix polygon generation in BitMap 2022-11-17 10:31:14 +01:00
Rémi Verschelde 2846ea1ffa
Merge pull request #68573 from Sauermann/fix-optionbutton-popup
Fix position and size of OptionButton PopupMenu
2022-11-16 14:41:52 +01:00
Rémi Verschelde 6d2a7cb46d
Merge pull request #68709 from MewPurPur/instance-begone-part3
Remove more instances of 'instance' being used as a verb
2022-11-16 14:41:42 +01:00
VolTer 3b4f5f8a04 Remove more instances of 'instance' being used as a verb 2022-11-16 14:01:53 +01:00
Rindbee 716e5ab166 Make sure the popup editor is hidden when selected 2022-11-16 18:36:49 +08:00
Rémi Verschelde ee1d4d4a52
Merge pull request #68725 from TokageItLab/fix-bone-renamer-for-conflicting
Improve BoneRenamer to avoid conflicting with original bone name
2022-11-16 09:27:34 +01:00
Silc Renew ac1db40614 Improve BoneRenamer to avoid conflicting with original bone name 2022-11-16 16:36:33 +09:00
Hugo Locurcio f3c20d9823
Add a node compatibility handler for ProximityGroup
This converts ProximityGroup nodes from 3.x projects into Node3Ds
(their parent), rather than bare Nodes.
2022-11-16 02:31:50 +01:00
Dawid Marzec d4d5df2314 Fix errors while deselecting all tree items; issue #65185 2022-11-15 22:48:27 +01:00
Rémi Verschelde d0025a1f02
Merge pull request #64077 from Calinou/tweak-audiostreamplayer2d3d-default-panning
Decrease default AudioStreamPlayer2D/3D panning strength
2022-11-15 22:29:23 +01:00
Silc Renew 17ce879a15 Optimize animation blend tree process 2022-11-16 02:52:04 +09:00
Rémi Verschelde 4935493f72
Merge pull request #67948 from DeeJayLSP/split_webp
Overhaul WebP packer and split compression options
2022-11-15 16:25:40 +01:00
DeeJayLSP da132f3266 Overhaul WebP packer and split compression options 2022-11-15 11:52:22 -03:00
kobewi 3e730c4277 Fix false warning when renaming Joint2D's node 2022-11-15 13:31:44 +01:00
Rémi Verschelde 7fda64a849
Merge pull request #68681 from groud/fix_infinite_loop_in_resource_loader
Fixes infinite loop in ResourceFormatText when having unexpected end of file
2022-11-15 11:56:41 +01:00
Gilles Roudière 83617790a1 Fixes infinite loop in ResourceFormatText when having unexpected end of file 2022-11-15 11:20:05 +01:00
Haoyu Qiu 6c5dc78f59 Make Camera3D gizmo the same aspect ratio as its viewport 2022-11-15 17:31:53 +08:00
Rémi Verschelde 5f78f24b08
Merge pull request #68426 from clayjohn/GLES3-particles
Add GPUParticles to the OpenGL3 renderer.
2022-11-15 10:28:44 +01:00
clayjohn 9ce57050a5 Add GPUParticles to the OpenGL3 renderer.
This includes collision (2D SDF, Box, Sphere, Heightmap),
attraction (Box, Sphere), and all sorting modes.

This does not include 3D SDF collisions, trails, or
manual emission.
2022-11-14 23:28:25 -08:00
Haoyu Qiu 3b08d0e852 Fix crash of queue_free() when main loop is not SceneTree 2022-11-15 08:25:25 +08:00
Rémi Verschelde 03f30855d1
Merge pull request #67831 from kleonc/scene-tree-fix-storing-removed-nodes
`SceneTree` Fix storing removed nodes to be skipped by the group calls
2022-11-14 23:27:41 +01:00
Rémi Verschelde f7c487f676
Merge pull request #68664 from bruvzg/bmp_base_size
[Bitmap font] Always set valid fixed size, even if it's not set in the `fnt` file.
2022-11-14 23:25:28 +01:00
Rémi Verschelde f33e482551
Merge pull request #68531 from marzecdawid/fix-gap-with-scrolling-down-in-Tree
Fix a gap with scrolling down in Tree with arrow keys (#57636)
2022-11-14 23:25:22 +01:00
Rémi Verschelde 0dbb632116
Merge pull request #68564 from Mickeon/node-no-remove-group-error
Strip ERR_FAIL from `Node.remove_from_group()`
2022-11-14 23:24:14 +01:00
Rémi Verschelde 80dbcfd995
Merge pull request #68657 from Sauermann/fix-redundant-initialization
Remove redundant non-trivial Variant types initializations
2022-11-14 23:23:54 +01:00
Dawid Marzec c068a9d0bd Fix a gap with scrolling down in Tree with arrow keys (#57636) 2022-11-14 21:37:42 +01:00
bruvzg e77b6427cb
[Bitmap font] Always set valid fixed size, even if it's not set in the `fnt` file. 2022-11-14 22:33:59 +02:00
Hugo Locurcio efe3220b2e
Fix periods in editor strings and messages
- Ensure all strings with ellipsis end with 3 periods instead of 2.
- Fix extraneous period in "Error calling from signal '...' to callable"
  messages.
2022-11-14 19:36:36 +01:00
Markus Sauermann 3b14f0334c Remove redundant Variant-types initializations 2022-11-14 19:35:19 +01:00
Rémi Verschelde 315c64282b
Fix misc formatting issues
Somehow I missed the failing CI report from trailing whitespace.

Fixed a couple typos found by codespell while at it, and misc
trailing semicolons in one of the files.
2022-11-14 19:00:48 +01:00
Rémi Verschelde d639bb87a7
Merge pull request #68272 from Sauermann/fix-windowfocus-on-resize
Fix Windowfocus on resizing
2022-11-14 16:38:00 +01:00
Rémi Verschelde 40163b9b9f
Merge pull request #68019 from Sauermann/fix-physics-mouseover-drop
Drop physics mouseover as soon as the mouse moves over a Control
2022-11-14 16:37:54 +01:00
Fabio Alessandrelli 67265d14f7 [MP] Move engine and editor profilers to a plugin.
Also refactor the editor plugin out of the ReplicationEditor.
2022-11-14 15:09:00 +01:00
Markus Sauermann 5cf6ebce63 Drop physics mouseover as soon as the mouse moves over a Control 2022-11-14 12:07:26 +01:00
Rémi Verschelde 33e65f2754
Merge pull request #68582 from bruvzg/inv_gd3_bmp_font
Add a special case for importing bitmap fonts designed for Godot 3.
2022-11-14 11:12:17 +01:00
Rémi Verschelde 5b3a03bf5c
Merge pull request #68448 from bruvzg/font_imp_tr
[Font] Add an import option to pre-render all glyphs required for the translation.
2022-11-14 11:12:01 +01:00
Bastiaan Olij 7658dc6e7e Add optional UV2 logic for lightmapping to primitive shapes 2022-11-13 19:28:10 +11:00
Dawid Marzec 5cd30be56d Remove auto selecting the first file for FileDialog with Save file mode selected 2022-11-13 02:24:17 +01:00
Micky a1c10dbbd8 Strip ERR_FAIL from `Node.remove_from_group()`
Also simplifies group check removing unnecessary `!data.grouped.has`
2022-11-13 00:01:18 +01:00
bruvzg 01b4e53e80
Add a special case for importing bitmap fonts designed for Godot 3. 2022-11-13 00:32:30 +02:00
Markus Sauermann 95597bb2ac Fix position and size of OptionButton PopupMenu
Use the correct Transform2D (get_global_transform_with_canvas) for
position and size.
2022-11-12 21:12:02 +01:00
Micky 9b42268467 Make `Node.print_orphan_nodes()` static 2022-11-12 17:55:42 +01:00
Yaohua Xiong 5241464a46 Refactor Curv3D and PathFollow3D
This commit makes the following major changes

1. Add "sample_baked_with_rotation()" to Curve3D, making it usable independently. A similar change was made to Curve2D previously.
2. Refactor the _bake() method on Curve3D, using Parallel Transport Frame instead of Frenet Frame.
3. Refactor the sample_* methods, including:
  i. Factor out common binary search code, following the DRY principe
  ii. sample_up_vector() interpolated up vector as part of rotation frame(posture) for consistancy and accuracy.
2022-11-12 12:03:54 +08:00
Yuri Rubinsky 6521eccaae
Merge pull request #68477 from dzil123/visual_shader_ufunc_input_fix
Fixes https://github.com/godotengine/godot/issues/68463
2022-11-12 06:50:35 +03:00
Marc Gilleron 2aefdcc26e Fix usages of mesh simplification functions in float=64 builds 2022-11-12 00:38:00 +00:00
Rémi Verschelde 340fb33e54
Merge pull request #68412 from bruvzg/le_caret_pl
[Line Edit] Ignore placeholder text when drawing caret.
2022-11-11 16:49:47 +01:00
Rémi Verschelde 5c7af7f391
Merge pull request #68418 from Sauermann/fix-escape-dnd
Allow canceling Drag and Drop with the Escape-Key
2022-11-11 16:49:09 +01:00
Rémi Verschelde a2ad59fb8e
Merge pull request #68513 from Chaosus/fix_shader_param
Fix `Shader::has_parameter` to return a correct value
2022-11-11 10:54:50 +01:00
Rémi Verschelde bbe8ff24f4
Merge pull request #68358 from Sauermann/fix-pink-512-viewport
Fix SubViewport with default size being pink
2022-11-11 10:44:24 +01:00
Rémi Verschelde 3263970cf6
Merge pull request #68428 from nikitalita/fix-mesh-convert
Fix deprecated mesh conversion
2022-11-11 10:44:10 +01:00
Yuri Rubinsky 9d4816fd4a Fix `Shader::has_parameter` to return a correct value 2022-11-11 11:30:34 +03:00
nikitalita 5683aa2498 fix old mesh conversion offsets 2022-11-10 22:55:01 +00:00
smix8 f30ebacbe8 Add detail to NavigationPolygon outline error msg
Adds additional information to the error msg when the convex partition fails due to invalid outline arrays.
2022-11-10 21:12:51 +01:00
dzil123 445062e43b Visual Shader UVFunc keep existing input value on function change 2022-11-10 04:31:05 -08:00
bruvzg 35528b800c
[Font] Add an import option to pre-render all glyphs required for the translation. 2022-11-10 10:43:15 +02:00
Yuri Rubinsky dca5cb8e40
Merge pull request #68413 from Chaosus/fix_instance_uniforms 2022-11-09 22:55:41 +03:00
Yuri Rubinsky c07d13182c Some fixes for instance shader parameters 2022-11-09 21:20:11 +03:00
Markus Sauermann e8af3e7e8d Fix crash from impossible Object::cast_to
A Vector<>-variant can't be used in an Object::cast_to, because
Vector doesn't inherit from Object and this cast always returns a nullptr.

This patch replaces the Object::cast_to and accesses the contained
Vector directly.
2022-11-08 22:34:01 +01:00
Markus Sauermann 226044b944 Allow canceling Drag and Drop with the Escape-Key
This patch implements the functionality to cancel Drag and Drop
by using the escape key or more general, the ui_cancel action.

Since this would be the third location, where the finalization of
Drag and Drop would have to be implemented, that functionality was
put into the private function _perform_drop.

Simplified gui.drag_data.get_type() != Variant::NIL to gui.dragging
because they are equivalent.
2022-11-08 19:10:16 +01:00
bruvzg c624b1eeac
[Line Edit] Ignore placeholder text when drawing caret. 2022-11-08 15:15:13 +02:00
ktxyz 7601808455 Update sub_windows order with respect to FLAG_ALWAYS_ON_TOP 2022-11-08 13:20:45 +01:00
kobewi d9f066d5fa Remove duplicate project settings definitions 2022-11-08 01:29:39 +01:00
Rémi Verschelde e2b39bfdc4
Merge pull request #68346 from Calinou/particles-rename-trail-length-property
Rename GPUParticles2D/3D's `trail_length_secs` to `trail_lifetime`
2022-11-07 15:05:55 +01:00
Hugo Locurcio ab7a807f2b
Rename GPUParticles2D/3D's `trail_length_secs` to `trail_lifetime`
The property already has a "seconds" suffix in the inspector.
The "lifetime" term makes it more obvious that the property is
specified as time, not a distance in units.

The property hint now allows manually entering values greater than
10 seconds.

The internal rendering value's default now matches the particles
nodes' default.
2022-11-07 13:37:40 +01:00
Rémi Verschelde a1bc636098
Merge pull request #68337 from alfredbaudisch/multi-caret-selection-fix
Fixes mouse click deselect for multi and single carets
2022-11-07 10:20:45 +01:00
Rémi Verschelde 2c8498c8a6
Merge pull request #68351 from Sauermann/fix-code-simplifications
Code simplifications
2022-11-07 10:01:37 +01:00
Markus Sauermann 7445ab95fc Fix SubViewport with default size being pink
A SubViewport with default-size doesn't display its content, but shows
pink color, until it is resized.
This patch makes sure, that the size gets set during initialization.
2022-11-07 09:23:32 +01:00
Rémi Verschelde c4f3b94abf
Merge pull request #68321 from BastiaanOlij/xrorigin_start_pos
Update XRServer with starting position of (new) current XROrigin3D
2022-11-07 08:45:24 +01:00
Markus Sauermann 18978881fe Code simplifications
CanvasItemEditor:
- p_result == ADD_MOVE is always true in this switch-clause

- both parts of the if-else-clause do the same thing and simplified an affine_inverse call

ControlEditorToolbar:
- private function ControlEditorToolbar::_anchor_to_position is used nowhere. Looks like
copy and paste from CanvasItemEditor::_anchor_to_position

ScrollContainer:
- screen_is_touchscreen is always true, because otherwise the function already returned

TextLine:
- both parts of the if-else-clause do the same thing and simplified return statement
2022-11-07 01:21:25 +01:00
kobewi f8f25adc0b Don't free instanced scenes when recreating tiles 2022-11-07 00:32:41 +01:00
Alfred Reinold Baudisch 0d2953074b Mouse click deselect removes secondary carets and puts primary caret under mouse position
Fixes and closes #67993.
2022-11-06 20:03:06 +01:00
Rémi Verschelde cf1e6bb6fc
Merge pull request #68282 from alfredbaudisch/backspace-multi-care
Correctly deletes multi-caret selection with backspace
2022-11-06 16:10:32 +01:00
Bastiaan Olij 23e0afec1d Update XRServer with starting position of (new) current XROrigin3D 2022-11-06 22:19:44 +11:00
Alfred Reinold Baudisch 7127e57bf8 Pass caret index when deleting selection with backspace
Fixes and closes #67992
2022-11-05 08:55:18 +01:00
Markus Sauermann 65647e9c7d Fix Windowfocus on resizing
When resizing a non-focused window, the previously focused
Window got resized.
This patch grabs focus for the actually resized window, before
starting with the resizing.
2022-11-04 22:24:00 +01:00
jbcolli2 c685c47f8a Fixed ColorPicker so the vertical option is not available in editor. 2022-11-04 13:59:25 -04:00
kobewi 1778301cd0 Add call_deferred() method to Callable 2022-11-04 17:24:34 +01:00
Rémi Verschelde 4e47324b3f
Merge pull request #68097 from KoBeWi/no_signal🔕
Add `set_value_no_signal()` to Range
2022-11-04 10:48:47 +01:00
Rémi Verschelde d48ba545ef
Merge pull request #67741 from cridenour/modular-color-picker
Modularize the Color Picker via properties and new picker mode.
2022-11-04 10:48:37 +01:00
Rémi Verschelde 21675625a0
Merge pull request #68228 from pasi1991/fix_typo_in_visual_instance_3d
Fix typo in method (set_transparecy) of visual_instance_3d
2022-11-04 10:06:27 +01:00
Rémi Verschelde 05ce0e3de1
Merge pull request #68222 from groud/fix_corner_terrain_painting
Fix terrain painting in corner-only matching mode
2022-11-04 10:05:58 +01:00
Chris Ridenour 286e7da162 Modularize the Color Picker via properties. 2022-11-04 00:08:46 -04:00
Patrick Siemsen 0b480c7d99 Fix typo in method of visual_instance_3d 2022-11-03 19:42:14 +01:00
Gilles Roudière ffacb31734 Fix terrain painting in corner-only matching mode 2022-11-03 19:08:43 +01:00
Hugo Locurcio a19e389f4f
Hide Antialiasing import option on DynamicFonts with MSDF enabled
Antialiasing cannot be adjusted on fonts rendered with MSDF.
Internally, Godot always uses grayscale antialiasing for those fonts.

This also tweaks property hints for consistency, and renames
uses of "sub-pixel" to the more commonly used "subpixel".
2022-11-03 18:40:44 +01:00
Rémi Verschelde 3eaf49765b
Merge pull request #68192 from aaronfranke/unify-node3d-euler
Unify Node3D RotationOrder with global EulerOrder
2022-11-03 12:07:42 +01:00
Rémi Verschelde 3cde6c0432
Merge pull request #67540 from KoBeWi/hue_hue_hue
Add a separate hue gradient for OKHSL mode
2022-11-03 11:51:45 +01:00
Aaron Franke 9225eb461e
Unify Node3D RotationOrder with global EulerOrder 2022-11-02 17:46:03 -05:00
Rémi Verschelde 08d56ac2f1
Merge pull request #66747 from aaronfranke/move-euler-order
Move EulerOrder enum to math_defs.h and global scope
2022-11-02 22:37:12 +01:00
Rémi Verschelde 9ec7aadc06
Merge pull request #66017 from Mickeon/rename-image-copy-rect
Rename Image's `get_rect` to `get_region`
2022-11-02 22:36:57 +01:00
Rémi Verschelde c9e0d787fe
Merge pull request #67928 from YeldhamDev/we_really_need_a_callback_for_after_children_is_removed
Fix problems with `tab_changed` signal when removing multiple tabs at once
2022-11-02 22:36:49 +01:00
Rémi Verschelde efefd9b198
Merge pull request #68120 from akien-mga/style-doc-cleanup
Style: Misc docs and comment style and language fixes
2022-11-02 22:36:31 +01:00
Rémi Verschelde d4bf7f4458
Fixup Clang -Wtype-limits warnings introduced by #52350 2022-11-02 22:36:01 +01:00
Markus Sauermann 022d24a9ae Fix Viewport root order after Node2D raise 2022-11-02 21:45:00 +01:00
Aaron Franke 8556fdd4bc
Move EulerOrder enum to math_defs.h and global scope 2022-11-02 13:44:13 -05:00
Rémi Verschelde f7c611ab71
Style: Misc docs and comment style and language fixes
- Removed empty paragraphs in XML.
- Consistently use bold style for "Example:", on a new line.
- Fix usage of `[code]` when hyperlinks could be used (`[member]`, `[constant]`).
- Fix invalid usage of backticks for inline code in BBCode.
- Fix some American/British English spelling inconsistencies.
- Other minor fixes spotted along the way, including typo fixes with codespell.
- Don't specify `@GlobalScope` for `enum` and `constant`.
2022-11-02 19:01:18 +01:00
Rémi Verschelde 39cece382d
Merge pull request #68170 from alfredbaudisch/clear-selection-shortcut
Unified shortcut to clear carets and selections from TextEdit
2022-11-02 18:54:19 +01:00
Rémi Verschelde 30e4e7c083
Merge pull request #67917 from Faless/mp/4.x_auth
[MP] Add peer authentication support to the default MultiplayerAPI.
2022-11-02 18:53:38 +01:00
Rémi Verschelde 23e793fd18
Merge pull request #68137 from kleonc/shape-cast-get-collider-rid
Add `ShapeCast2D/3D::get_collider_rid` method
2022-11-02 18:53:23 +01:00
Rémi Verschelde 7488b4724e
Merge pull request #67788 from 98teg/flow-container-alignment
Add alignment options to flow container
2022-11-02 18:52:53 +01:00
Rémi Verschelde 76092fb684
Merge pull request #63956 from xiongyaohua/interpolate_on_curve2d
Move rotation interpolation logic from PathFollower2D to Curve2D
2022-11-02 18:50:48 +01:00
Alfred Reinold Baudisch a862583d05 Unified shortcut to clear carets and selections
Refactors`ui_text_remove_secondary_carets` from https://github.com/godotengine/godot/pull/68089 as `ui_text_clear_carets_and_selection`, with extra behaviour:

- If there's only one active caret active with a selection, clears the selection.
- In case there's more than one caret active, removes the secondary carets and clears selections.

With this change, `TextEdit` then imitates the behaviour of VSCode for clearing carets and selections.
2022-11-02 18:23:24 +01:00
Rémi Verschelde 604abb434f
Merge pull request #52350 from BimDav/viewport_canvas_cull
Added Viewport canvas cull mask feature
2022-11-02 17:14:24 +01:00
Rémi Verschelde 06c8e406e4
Merge pull request #63335 from Spartan322/button-shortcut-feedback
Make `BaseButton` Shortcut feedback togglable
2022-11-02 17:14:00 +01:00
kobewi 84d6549c75 Change hue icons to horizontal GradientTexture2D 2022-11-02 15:34:15 +01:00
Fabio Alessandrelli 33dda2e68a [MP] Remove connection state signals from MultiplayerPeer.
Now handled directly by the MultiplayerAPI implementation.
2022-11-02 15:17:23 +01:00
kobewi f5981ff19d Add a separate hue gradient for OKHSL mode 2022-11-02 14:44:41 +01:00
Rémi Verschelde eddaab17ea
Merge pull request #63562 from Rindbee/better-scroll-conditions
Use more reasonable scrollable conditions in `ScrollContainer`
2022-11-02 14:21:21 +01:00
Rémi Verschelde ad0349c0e3
Merge pull request #59479 from Sauermann/fix-rootorder-on-layerchange
Update root order on layer change
2022-11-02 14:20:24 +01:00
Rémi Verschelde 910cf9a9b3
Merge pull request #67810 from MrBlockers/reged-fixes
Fix multiple issues with region editor
2022-11-02 14:18:12 +01:00
Rémi Verschelde 87cdc2ea60
Merge pull request #67994 from YeldhamDev/how_suggestive
Stop centering clicked suggestions in the autocomplete popup
2022-11-02 14:15:32 +01:00
Micky ebf86c96e9 Rename Image's `get_rect` to `get_region`
Also renames its parameter to from "rect" to "region".
2022-11-01 23:35:48 +01:00
kleonc bbd225a804 Add `ShapeCast2D/3D::get_collider_rid` method 2022-11-01 21:17:18 +01:00
Fabio Alessandrelli 0a0e99cadc
Merge pull request #67982 from Faless/mp/4.x_disconnect_close
[MP] Add MultiplayerPeer disconnect_peer, close.
2022-11-01 20:35:04 +01:00
Yaohua Xiong 399c2a8dea Move rotation sampling from Path2D to Curve2D
The rotation sampling code is moved from Path2D to a new method
`sample_baked_with_rotation` on Curve2D.
2022-11-01 13:18:52 +08:00
kobewi 4aa1efb0fe Add set_value_no_signal() to Range 2022-10-31 23:59:01 +01:00
Alfred Reinold Baudisch fcff978763 Shortcut and Bind to Remove Secondary Carets
Adds the bind `ui_text_remove_secondary_carets` to TextEdit, with ESC as the default shortcut.

When the bind is performed, if the TextEdit has multiple carets, `remove_secondary_carets` is called and secondary carets are removed.

This is useful when multiple selects are performed with `add_select_for_next_occurrence` #67644 or when multiple multiple carets are manually added, then it's possible to go back to a single caret with a shortcut.

Closes #67991
2022-10-31 17:44:47 +01:00
Rémi Verschelde c866f349ce
Merge pull request #67895 from bruvzg/ts_fix_obj_rects
Fix `TextLine` and `TextParagraph` `get_*_object_rect` methods not accounting for alignment and drop cap.
2022-10-31 14:29:34 +01:00
Rémi Verschelde 2529006134
Merge pull request #67486 from bruvzg/bmp_oem
[Font] Add support for OEM encoded bitmap fonts.
2022-10-31 14:20:53 +01:00
BimDav fcb9be66a2 Viewport canvas cull mask feature
Co-authored-by: Valentin Zagura <puthre@gmail.com>
2022-10-31 14:09:49 +01:00
Rémi Verschelde 5947f22be9
Merge pull request #67578 from KoBeWi/GEDITOR
Unify usage of GLOBAL/EDITOR_GET
2022-10-31 13:15:58 +01:00
Rémi Verschelde 4b92533efa
Merge pull request #68073 from timothyqiu/marker-3d-extents
Make Marker3D gizmo resizable
2022-10-31 12:17:13 +01:00
Rémi Verschelde 1518bb716e
Merge pull request #67282 from CheesecakeCG/fix-pb-start-sim
Fix Skeleton3D falsely assuming all physical bones will be children of their first bone
2022-10-31 12:04:33 +01:00
hare_ware 913f57f695 Fix Skeleton3D falsely assuming all physical bones will be children of their first bone 2022-10-31 06:59:42 -04:00
Rémi Verschelde 71a6aba3d7
Merge pull request #67710 from KoBeWi/a_bit_local_global_transform
Remove error condition from get_global_transform()
2022-10-31 11:59:08 +01:00
Rémi Verschelde 0844f0ed10
Merge pull request #65452 from timothyqiu/agent-target
Make NavigationAgent `target_location` a property
2022-10-31 11:56:17 +01:00
Rémi Verschelde be126d42d4
Merge pull request #67588 from KoBeWi/if(!GDVIRTUAL_CALL)don't
Simplify GDVIRTUAL_CALL calls
2022-10-31 11:55:56 +01:00
Rémi Verschelde 33c7c8020a
Merge pull request #67489 from timothyqiu/auto-select-all
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-31 11:55:06 +01:00
Rémi Verschelde b6cbea5e58
Merge pull request #63590 from golfinq/fbg-padding
Add padding options in theme for fg/bgcolor tags in RichTextLabel
2022-10-31 11:14:55 +01:00
Rémi Verschelde dcd86f9848
Merge pull request #67046 from Cykyrios/fix-invalid-tooltip-position
Fix invalid tooltip position
2022-10-31 11:05:19 +01:00
Rémi Verschelde 8b1a42cd47
Merge pull request #67888 from KoBeWi/overridead
Remove `override_selected_font_color` property
2022-10-31 10:59:07 +01:00
Rémi Verschelde 420eb1aa34
Merge pull request #67445 from Zylann/rename_queue_delete
Rename queue_delete => queue_free
2022-10-31 10:51:18 +01:00
Rémi Verschelde fa73211754
Merge pull request #65118 from Mickeon/editor-remote-tree-buttons
Add a few buttons in Remote Scene Tree
2022-10-31 10:46:08 +01:00
Rémi Verschelde 40258bbbe8
Merge pull request #67577 from qarmin/fix_exporting_big_templates
Fix exporting with big export templates
2022-10-31 10:39:08 +01:00
Rémi Verschelde d831ba1d6f
Merge pull request #67534 from KoBeWi/more_OK_in_OKHSL
Improve ColorPicker sliders in OKHSL mode
2022-10-31 10:37:27 +01:00
Rémi Verschelde d0fbeec66a
Merge pull request #67580 from KoBeWi/little_things
Minor code improvements
2022-10-31 10:34:57 +01:00
Rémi Verschelde 32548f9608
Merge pull request #67467 from timothyqiu/who-ami-i
Fix get_path() error when calling get_node()
2022-10-31 10:33:51 +01:00
Rémi Verschelde 68623c75b3
Merge pull request #67496 from Paulb23/text-edit-crashes
Fix TextEdit action and CodeEdit completion crash
2022-10-31 10:32:41 +01:00
Rémi Verschelde 273410ba5a
Merge pull request #67139 from PucklaMotzer09/insert_caret_at_carets
Add Caret Insert Below and Above shortcuts to TextEdit
2022-10-31 10:32:07 +01:00
Rémi Verschelde 996f7e5142
Merge pull request #66352 from arkology/progressbar_atlastexture_radial
Support AtlasTexture in radial modes of TextureProgressBar
2022-10-31 10:31:07 +01:00
Haoyu Qiu 3ded27c62d Make Marker3D gizmo resizable 2022-10-31 15:19:48 +08:00
Max Hilbrunner f013315980
Merge pull request #67754 from kleonc/tilemap-fix-collision-shapes-debug-draw
Fix `TileMap` collision shapes debug draw
2022-10-30 00:15:42 +02:00
Max Hilbrunner 11d74d606a
Merge pull request #67980 from DeeJayLSP/webpcase
Change all WEBP strings and comments to WebP
2022-10-29 19:28:47 +02:00
Markus Sauermann 35956d9128 Fix event-content and mouse-signals with 3D-capture-on-drag
Fix for 3D-physics processing:
- with enabled input_capture_on_drag now report correct position and
normals in _input_event
- mouse_enter and mouse_exit signals are emitted when the mouse cursor
leaves the visible area of the 3D-object, independently of pressed mouse
button or input_capture_on_drag
- make sure that collision input events are sent in the right order with
respect to mouse_enter and mouse_exit signals
2022-10-29 12:59:46 +02:00
Haoyu Qiu 3aed3edc06 Allow selecting SpinBox & LineEdit text when focus enters 2022-10-29 09:58:42 +08:00
Michael Alexsander 4b6e6c6758 Stop centering clicked suggestions in the autocomplete popup 2022-10-28 20:22:28 -03:00
Fabio Alessandrelli 39f3d9d59e [MP] Add MultiplayerPeer disconnect_peer, close.
Update ENet, WebRTC, and WebSocket to support peer disconnection and
unify the close function.
2022-10-28 21:18:01 +02:00
DeeJayLSP dd64ceab47 Change all WEBP strings and comments to WebP 2022-10-28 15:17:49 -03:00
Clay John ada2661a2c
Merge pull request #67956 from RedMser/safe-velocity-type
Fix type of `safe_velocity` parameter
2022-10-28 10:57:46 -07:00
Micky 0e0a233859 Fix spacing of few PROPERTY_HINT_ENUM hint_strings 2022-10-28 14:51:26 +02:00
Clay John 0486810697
Merge pull request #67644 from alfredbaudisch/add-selection-next-occurrence
Add Selection and Caret for Next Occurrence of Selection
2022-10-27 17:21:49 -07:00
RedMser b9c3a5534b Fix type of safe_velocity parameter 2022-10-27 22:45:24 +02:00
Clay John 4dc2c8ae6f
Merge pull request #67939 from sambriels/emit-signal-after-target-reached
[NavigationAgent2D/3D]: target_reached signal is emitted before internal state is updated
2022-10-27 12:52:13 -07:00
Clay John 8fd92ed867
Merge pull request #64710 from MinusKube/window-size-crash
Prevent windows from having a size greater than device limit
2022-10-27 10:02:44 -07:00
Clay John e1caa8797b
Merge pull request #67043 from clayjohn/clip_children
Improve behaviour of clip_children by clipping to parent alpha value but still retaining parent color
2022-10-27 09:59:27 -07:00
Clay John 2f2c138b44
Merge pull request #67926 from Rindbee/fix_call_shortcut_input
Fix calling `_call_shortcut_input` on a node that has been removed
2022-10-27 09:56:55 -07:00
Clay John d1cc93af89
Merge pull request #67832 from Sauermann/fix-remove-unnecessary-casts
Remove unnecessary casts
2022-10-27 09:47:34 -07:00
Clay John 682156e1f0
Merge pull request #66383 from aaronfranke/basis-from-euler
Clean up Basis from Euler code
2022-10-27 09:44:21 -07:00
Fabio Alessandrelli 7536d15fe3 [MP] Let MultiplayerAPI handle packet relaying and peer signaling.
MultiplayerPeer changes:

- Adds is_server_relay_supported virtual method

Informs the upper MultiplayerAPI layer if it can signal peers connected
to the server to other clients, and perform packet relaying among them.

- Adds get_packet_channel and get_packet_mode virtual methods

Allows the MultiplayerAPI to retrieve the channel and transfer modes to
use when relaying the last received packet.

SceneMultiplayerPeer changes:

- Implement peer signaling and packet relaying when the MultiplayerPeer
  advertise they are supported.

ENet, WebRTC, WebSocket changes:

- Removed custom code for relaying from WebSocket and ENet, and let it
  be handled by the upper layer.
- Update WebRTC to split create_client, create_server, and create_mesh,
  with the latter behaving like the old initialize with
  "server_compatibility = false", and the first two supporting the upper
  layer relaying protocol.
2022-10-27 18:08:58 +02:00
Sam Briels 815231943b Emit target_reached signal after state is updated 2022-10-27 14:05:43 +02:00
Michael Alexsander fb8588e68e Fix problems with `tab_changed` signal when removing multiple tabs at once 2022-10-27 03:16:01 -03:00
Rindbee c77349ecb7 Fix calling `_call_shortcut_input` on a node that has been removed
Nodes may have been deleted by shortcuts. For example, when switching
scenes with `Ctrl` + `Tab` / `Ctrl` + `Shift` + `Tab`, some controls
will be deleted and recreated.
2022-10-27 14:05:51 +08:00
Haoyu Qiu e4100495b5 Make NavigationAgent `target_location` a property 2022-10-27 13:51:38 +08:00
kobewi 64fc443e24 Warn if isometric TileMap is not Y-sorted 2022-10-26 14:27:58 +02:00
kobewi c7eb814ede Remove override_selected_font_color property 2022-10-26 12:59:18 +02:00
bruvzg 4a6d39c6b9
Fix `TextLine` and `TextParagraph` `get_*_object_rect` methods not accounting for alignment and drop cap. 2022-10-26 10:46:08 +03:00
MrBlockers 92ebbf2c0a Fix multiple issues with region editor
Make the filter mode of the texture preview match the node/resource
being edited where applicable, and nearest neighbor with mipmaps as a
fallback.

Make the Edit Region button for Sprite3D only appear when region is
enabled, to match behavior of Sprite2D.

Fix the editor not correctly clearing reference to previously edited
resources, resulting in a visual bug displaying the incorrect texture.
2022-10-25 18:23:23 -04:00
Yuri Rubinsky 2b505b74b9
Merge pull request #67431 from Chaosus/vs_fix_nodes_code 2022-10-25 20:38:24 +03:00
Marc Gilleron 7543a5e014 Rename queue_delete => queue_free
# Conflicts:
#	editor/plugins/tiles/tiles_editor_plugin.cpp
2022-10-24 22:07:02 +01:00
kleonc 471f2da9b6 `SceneTree` Fix storing removed nodes to be skipped by the group calls 2022-10-24 21:38:19 +02:00
Ricardo Buring 0e6b796cf6 Warn against using non-uniform scale for 3D physics
Using non-uniform scale is known to cause many issues.
Add warnings to the editor and to the class reference.
Also remove the warning from SoftBody3D since it is
not relevant there: it simulates in global space.
2022-10-24 19:31:00 +02:00
Markus Sauermann 5ee449efec Remove unnecessary casts
button_add_item and button_add are both Button

p_parent is a Node3D

CanvasItem can never be cast to Viewport
2022-10-24 15:59:18 +02:00
Clay John 040f49ed6e
Merge pull request #67390 from groud/more_conservative_terrain_painting
Make terrain painting not change neighbors centers bits
2022-10-23 17:11:06 -07:00
Clay John 9be3fd640b
Merge pull request #67513 from Calinou/editor-light2d-fix-shadow-filter-smooth-visibility
Fix Light2D Shadow Filter Smooth property being visible with filter None
2022-10-23 17:03:07 -07:00
Clay John 4134f2a464
Merge pull request #67566 from Sauermann/fix-code-simplifications
Code simplifications
2022-10-23 17:02:04 -07:00
Teggy 2b08675f37 Add alignment options to flow container 2022-10-23 13:40:17 +02:00
kleonc fcb663df51 Fix `TileMap` collision shapes debug draw 2022-10-22 16:14:54 +02:00
EricEzaM 61ad9db18c Ensure PopupMenu item is shaped when the shortcut is set. 2022-10-22 22:05:20 +10:00
Markus Sauermann 99bb7ab692 Fix Control rect coordinate system inconsistency
Fix get_rect, get_global_rect and get_screen_rect to take Controls scale into
account.
Simplify get_screen_position and get_screen_rect
2022-10-22 01:47:52 +02:00
Aaron Franke 7f9a8c99c9
Clean up Basis from Euler code 2022-10-21 17:54:49 -05:00
Max Hilbrunner d145c9b1a7
Merge pull request #67684 from patchfx/fix-typo-in-draw-rect-region
Fix tp_canvas_item typo in _draw_rect_region
2022-10-21 18:13:45 +02:00
kobewi 2ff676a696 Remove error condition from get_global_transform() 2022-10-21 14:52:43 +02:00
Max Hilbrunner c4c35ab77a
Merge pull request #67627 from KoBeWi/tilter
Fix texture filter and repeat in TileMap
2022-10-21 13:54:31 +02:00
Alfred Reinold Baudisch 7d15ecc3af Add Selection and Caret for Next Occurrence of Selection
Adds the bind `add_selection_for_next_occurrence` to TextEdit, with CTRL+D as the default shortcut.

When the bind is performed, ff a selection is currently active with the last caret in text fields, searches for the next occurrence of the selection, adds a caret and selects the next occurrence.

If no selection is currently active with the last caret in text fields, selects the word currently under the caret.

The action can be performed sequentially for all occurrences of the selection of the last caret and for all existing carets. The viewport is adjusted to the latest newly added caret.

The bind and the behaviour is similar to VS Code's "Add Selection to Next Find Match" and JetBrains' "Add Selection for Next Occurrence". It takes advantage of the multi-caret API.

The default shortcut for `select_word_under_caret` has been changed to ALT+G, in order to give priority to CTRL+D for `add_selection_for_next_occurrence` to better align with popular IDEs and editors.
2022-10-21 08:26:53 +02:00
Clay John 72b845b287
Merge pull request #67506 from squashiv/master
Expose Shape2D::get_rect to scripting
2022-10-20 13:26:40 -07:00
Richard Patching 5de65bb2d7 Fix tp_canvas_item typo in _draw_rect_region 2022-10-20 20:04:45 +01:00
Micky 809dad907a Add buttons in Remote Scene Tree
A Scene button to any scene instantiated from file. When clicked, it opens the original PackedScene.

A toggle visibility button is also available.
2022-10-20 18:02:41 +02:00
Gilles Roudière fe65d7aa7b Make terrain painting not change neighbors centers bits 2022-10-20 14:47:45 +02:00
squash 247a93845d Expose Shape2D::get_rect to scripting 2022-10-20 11:26:49 +03:00
Rindbee 075e79bf04 Improve validation when setting `max`/`min`/`page` in `Range`
The incoming value is validated first and then compared.

Previously, when the ScrollContainer was scrolled, the ScrollBar of
the other axis of the ScrollContainer would emit the changed signal.
This commit avoids that.
2022-10-20 14:04:09 +08:00
George L. Albany d846dd6e91
Make `BaseButton` Shortcut feedback togglable 2022-10-20 02:02:12 -04:00
kobewi 2f9cbbe0fb Fix texture filter and repeat in TileMap 2022-10-19 23:23:40 +02:00
Clay John a8c805be29
Merge pull request #66546 from KoBeWi/rfeipletaetr
Add methods to get target filter and repeat
2022-10-19 13:55:57 -07:00
Max Hilbrunner d148613bb1
Merge pull request #66279 from aaronfranke/control-min-size
Revert `custom_minimum_size` type back to `Vector2` instead of `Vector2i`
2022-10-19 22:40:52 +02:00
Max Hilbrunner f066f2c0de
Merge pull request #66940 from aaronfranke/doc-get-tr-aabb
Remove the global space `get_transformed_aabb` helper method
2022-10-19 22:40:02 +02:00
Max Hilbrunner 523f6263e4
Merge pull request #67249 from wuyingnan/fix_quaternion_typo
Fix a comment typo in node_3d.h
2022-10-19 21:02:14 +02:00
Max Hilbrunner 5f7906a289
Merge pull request #67527 from BastiaanOlij/fix_tracker_names
Fix two typos in tracker names and a bug in OpenXR haptic feedback
2022-10-19 18:18:36 +02:00
kobewi 4efa851d7f Add methods to get target filter and repeat 2022-10-19 14:41:42 +02:00
Rafał Mikrut 86fa3ba560 Fix exporting big templates 2022-10-19 08:29:29 +02:00
Yuri Rubinsky 19126d22a4 Fix code generation for some visual shader nodes 2022-10-19 09:09:56 +03:00
kobewi d06a8320e5 Simplify GDVIRTUAL_CALL calls 2022-10-19 00:05:48 +02:00
kobewi b42c1f82fc Improve ColorPicker sliders in OKHSL mode 2022-10-18 23:59:55 +02:00
kobewi e48c5daddf Unify usage of GLOBAL/EDITOR_GET 2022-10-18 19:01:48 +02:00
Patrick 91a9e7af3f Fix typo in VisualShader DistanceFade node 2022-10-18 18:20:31 +02:00
kobewi 4aaed4fee1 Minor code improvements 2022-10-18 16:44:57 +02:00
Aaron Franke 9ebd8c5bb5
Remove the global space `get_transformed_aabb` helper method 2022-10-18 07:30:31 -05:00
Markus Sauermann b8031bb7d6 Code simplifications
1. Viewport::get_visible_rect().position is always zero.
So Control::get_window_rect is identical to Control::get_global_rect.
Remove Control::get_window_rect since it is not used in the source code.

2. sqrt(a * a) = abs(a) for doubles

3. Simplify affine_inverse combination

4. Simplify calculation in shaders
2022-10-18 12:47:40 +02:00
PucklaMotzer09 e5354cacd0 Add Caret Insert Below and Above shortcuts to TextEdit 2022-10-18 10:38:53 +02:00
Rindbee 42073fc2bb Use more reasonable scrollable conditions in `ScrollContainer`
The visibility of the `ScrollBar` was used as a condition for judging whether it should scroll.
**Visible** and **scrollable** are currently not the same in some cases (`SCROLL_MODE_SHOW_NEVER`).
This makes `SCROLL_MODE_SHOW_NEVER` not working properly.

This patch will make `SCROLL_MODE_SHOW_NEVER` available, so that the external `SrollBar` can
share the internal `ScrollBar`'s data, we can achieve the purpose of replacing the internal
`ScrollBar` with a custom external one.
2022-10-18 16:32:39 +08:00
arkology 825f5671f1 Support AtlasTexture in radial modes of TextureProgressBar 2022-10-17 20:44:25 +03:00
Rémi Verschelde ebca8b8aea Merge pull request #67491 from Paulb23/fix-undo-redo-viewport-adjust
Fix undo redo not adjusting TextEdit viewport to caret
2022-10-17 17:31:26 +02:00
Bastiaan Olij 1e7f009492 Fix two typos in tracker names and a bug in OpenXR haptic feedback 2022-10-17 20:29:19 +11:00
Hugo Locurcio 6dcb295a07
Fix Light2D Shadow Filter Smooth property being visible with filter None 2022-10-17 01:35:10 +02:00
Markus Sauermann 13b87c13c7 Fix set_as_toplevel event propagation to child
In certain conditions events did not get propagated to Control childs of
Node2D nodes when setting a parent of the Node2D to toplevel.

This patch makes sure that such Control nodes become root control in the
viewport.
2022-10-16 21:42:16 +02:00
Paulb23 4bfb1d953c Fix undo redo not adjusting TextEdit viewport to caret 2022-10-16 19:30:03 +01:00
Paulb23 b5dc8e24be Fix crash in code completion when using an invalid / null font 2022-10-16 16:47:27 +01:00
Paulb23 76005e5ff7 Forcibly end current TextEdit action on undo redo 2022-10-16 16:28:22 +01:00
bruvzg 2aa350f701
[Font] Add support for OEM encoded bitmap fonts. 2022-10-16 18:22:21 +03:00
Haoyu Qiu 64c20a51c1 Fix get_path() error when calling get_node() 2022-10-16 10:48:59 +08:00
Markus Sauermann 39e49a8bdd Expose Viewport::get_screen_transform to GDScript 2022-10-15 23:37:59 +02:00
Rémi Verschelde dc4b616596 Merge pull request #63332 from KoBeWi/static_images_aka_photos
Make some Image methods static
2022-10-15 12:56:57 +02:00
Miguel Gonzalez Sanchez a97a00bf02
Rename pos -> index on Node 2022-10-14 19:56:34 +01:00
clayjohn b6f44859d7 Implement multiple clip_children modes for CanvasItems 2022-10-14 08:02:28 -07:00
kobewi 072f6feaba Make some Image methods static 2022-10-14 14:34:15 +02:00
Rémi Verschelde 39534a7aec
Merge pull request #67385 from Sauermann/fix-viewport-mouse-position-update-on-subwindows 2022-10-14 13:31:11 +02:00
Markus Sauermann b1d6b34662 Always update Viewport's last_mosue_position
When the mouse cursor is over a embedded Window, the Viewport's
last_mouse_position did not get updated.
This patch makes sure that the update happens on every InputEventMouse.

Document canvas layer of embedded Windows.
2022-10-14 12:51:45 +02:00
bruvzg 4b1937c73f Abort LineEdit shaping if no font is set to avoid unnecessary error messages. 2022-10-14 12:57:42 +03:00
Rémi Verschelde 7502c808fa Merge pull request #66665 from Mickeon/editor-do-not-edit-inherited-signals
Do not allow editing Scene-inherited signal connections
2022-10-14 10:19:47 +02:00
Rémi Verschelde 5f4aa11c62
Merge pull request #63607 from BastiaanOlij/fix_xr_origin
Add current setting to XROrigin3D and fix double positioning HMD
2022-10-14 09:45:00 +02:00
Rémi Verschelde 46a1b92bb7
Merge pull request #66294 from reduz/optimize-convex-collision 2022-10-13 20:34:00 +02:00
Micky 6a77563b25 Do not allow editing Scene-inherited signal connections
Inherited connections are also highlighted with the warning color in the Node dock.
2022-10-13 20:13:05 +02:00
Juan Linietsky 71d2e38cb5 Optimize Convex Collision
Implements the Gauss Mapping optimization to SAT convex collision test.

* Described [here](https://ubm-twvideo01.s3.amazonaws.com/o1/vault/gdc2013/slides/822403Gregorius_Dirk_TheSeparatingAxisTest.pdf) by Dirk Gregorius.
* Requires adding of face information to edges in MeshData
* Took the chance to convert MeshData to LocalVector for performance.
2022-10-13 19:07:53 +02:00
Rémi Verschelde f32f5b70d8 Merge pull request #67348 from Mickeon/salvage-a-dear-comment
Comment not to remove `data` structs in some Nodes
2022-10-13 18:40:58 +02:00
Micky de9e08da76 Comment not to remove `data` structs in some Nodes 2022-10-13 15:52:35 +02:00
Rémi Verschelde 9eb8eb5f7d Merge pull request #67336 from jbcolli2/Normal-of-CylinderMesh
Fix bug in CylinderMesh when computing normals
2022-10-13 15:24:55 +02:00
Rémi Verschelde 2ffb609658 Merge pull request #66337 from EricEzaM/sprite-frames
Ensure control built-in shortcuts are matched exactly & add shortcuts for SpriteFrames editor
2022-10-13 15:24:39 +02:00
Rémi Verschelde 17db8be33c Merge pull request #66357 from EricEzaM/shortcut-context-on-node
Move Shortcut Context to control and fix `shortcut_input` with `shortcut_context`
2022-10-13 15:24:30 +02:00
jbcolli2 491ec622f6 Changed normal of CylinderMesh to account for slanted side. 2022-10-13 08:24:31 -04:00
Eric M a3ed9e6f2c Move Shortcut Context to Control and ensure that `shortcut_input` adheres to contexts. Also ensure that controls with no context are only triggered AFTER nodes which do have a context. 2022-10-13 21:07:19 +10:00
MladoniSzabi 3550354fd3 fixed holding alt while zooming zooms in by 2 increments. 2022-10-13 11:38:25 +01:00
Rémi Verschelde fad0327503 Merge pull request #66953 from Sauermann/fix-top-level-connect-error
Fix Control node not disconnecting from signal
2022-10-13 09:04:25 +02:00
Rémi Verschelde c55c0a2028 Merge pull request #66349 from A-Lamia/Amount_At_Collision
PARTICLES: adds amount property to collision sub particles.
2022-10-13 09:03:43 +02:00
Bastiaan Olij 3a4866bba4 Add current setting to XROrigin3D and fix double positioning HMD 2022-10-13 13:48:52 +11:00
Lamia 5af6f4a04b particles: add amount property to sub property collision. 2022-10-13 04:25:18 +11:00
Rémi Verschelde ea47e03b36
Merge pull request #65714 from benbot/fix-double-particle-collision-calculation 2022-10-12 17:46:17 +02:00
Rémi Verschelde 15b68f7601 Merge pull request #67232 from bruvzg/popup_edit
Improve Popup / Window behavior in the edited scene tree.
2022-10-12 14:45:14 +02:00
Rémi Verschelde 6fc1715cdf Merge pull request #65779 from Mickeon/rename-camera-follow
Rename Camera2D's `smoothing` to `position_smoothing`
2022-10-12 08:53:04 +02:00
Rémi Verschelde 3229194dfc
Merge pull request #67215 from Nidjo123/project-dialog-resize
Resize project dialog only when necessary
2022-10-11 23:26:37 +02:00
Paulb23 f3eb543e67 Fix select word under caret using caret col instead of line 2022-10-11 20:32:06 +01:00
Nikola Bunjevac d7e9b8af9a Set window size after setting new limits
Otherwise this can fail as the size may not fit
into current limits. This is problematic at least
on X11.
2022-10-11 17:16:20 +02:00
Micky 43b9cc96da Rename Camera2D's `smoothing` to `position_smoothing`
For Camera2D:
`smoothing_enabled` ->  `position_smoothing_enabled`
`set_enable_follow_smoothing` -> `set_position_smoothing_enabled`
`is_follow_smoothing_enabled` -> `is_position_smoothing_enabled`
`smoothing_speed` -> `position_smoothing_speed`
`set_follow_smoothing` -> `set_position_smoothing_speed`
`get_follow_smoothing` -> `get_position_smoothing_speed`
2022-10-11 16:51:26 +02:00
Rémi Verschelde 042e81f663 Merge pull request #40274 from Juankz/clips_importing_improvement
Add animation slices for individual animations
2022-10-11 16:18:22 +02:00
Rémi Verschelde 646d59e713 Merge pull request #63271 from Chaosus/fix_texture_error
Fix error emitting when opening some textures in the inspector
2022-10-11 16:17:15 +02:00
Rémi Verschelde 6d534f6e89 Merge pull request #66221 from Mickeon/painstakingly-appending-ds-en-you-tea-es
Rename remaining "*_enable" to "*_enabled"
2022-10-11 16:17:02 +02:00
kobewi a3661ad079 Remove editor dependencies from ColorPicker 2022-10-11 16:09:27 +02:00
Rémi Verschelde f21053d189 Merge pull request #67201 from progsource/richtextlabel-icon-spritesheet
Add Spritesheet support to RichTextLabel BBCode
2022-10-11 13:58:54 +02:00
Yingnan Wu 042d228558 fix typo 2022-10-11 19:58:25 +08:00
Petra Baranski 546e017613 Add Spritesheet support to RichTextLabel BBCode
BBCode: [img region=0,0,16,16]res://icon.svg[/img]
2022-10-11 13:04:15 +02:00
Rémi Verschelde e413d1c9c3 Merge pull request #67104 from Calinou/add-viewport-transparent-project-setting
Add a project setting to make the root viewport transparent
2022-10-11 09:28:43 +02:00
Rémi Verschelde 5606551028 Merge pull request #67219 from KoBeWi/adJUSt_NAMe_cAsIng_PRopERLY
Fix node name casing issues
2022-10-11 09:27:27 +02:00
Rémi Verschelde 6b8772dbb2 Merge pull request #67192 from RedMser/light-scale-warning
Show warning when scaling Light3D nodes
2022-10-11 09:26:56 +02:00
Rémi Verschelde 55815998d4 Merge pull request #67194 from RedMser/dirlight2d-height-suffix
Remove incorrect `px` suffixes
2022-10-11 09:26:49 +02:00
bruvzg 2e1fcbe14b
Prevent `Popup`s it the edited scene tree from closing on focus loss. Hide irrelevant `Popup` flags from the editor inspector. 2022-10-11 08:55:00 +03:00
Juan Velandia 6e603f202f Connect signal animation_removed to its proper method 2022-10-10 18:39:49 -05:00
kobewi b754df2b99 Fix node name casing issues
Co-authored-by: ryburnj <jordanryburn@gmail.com>
2022-10-10 22:31:26 +02:00
RedMser 87aeb59b5b Show warning when scaling Light3D nodes 2022-10-10 18:24:28 +02:00
RedMser a8a4e290fb Remove incorrect px suffixes 2022-10-10 18:18:15 +02:00
Rémi Verschelde 8017827144 SCons: Re-enable treating `#warning` as error with `werror`
Replace all TODO uses of `#warning` by proper TODO comments, and will open
matching bug reports to keep track of them.

We don't have a great track record fixing TODOs, but I'd wager we're even
worse for fixing these "TODO #warning" so we should prohibit this usage.
2022-10-10 16:12:26 +02:00
Rémi Verschelde 8c24b35b76 Merge pull request #65942 from SaracenOne/animation_change_callback_fix
Fix animation change callbacks
2022-10-10 13:53:53 +02:00
Rémi Verschelde ddb97a0b35 Merge pull request #67117 from Jummit/tree-button-color
Expose TreeItem::set_button_color
2022-10-10 13:52:57 +02:00
Rémi Verschelde 4be5660223 Merge pull request #67145 from Paulb23/tab_textedit
Fix inserting tabs in TextEdit
2022-10-10 13:52:42 +02:00
kobewi 14b82c36a2 Defer clearing of ResourceUID cache and silence warnings 2022-10-10 11:20:23 +02:00
Rémi Verschelde 104af08e9d Merge pull request #65805 from MewPurPur/improve-breakpoint-hovering
Improve bookmark and breakpoint indicators
2022-10-10 10:03:26 +02:00
VolTer d6e60f45a1 Improved breakpoints hover indicator 2022-10-10 04:36:45 +02:00
Haoyu Qiu eac9adf7a1 Don't allow removing TextEdit's main caret 2022-10-10 08:30:23 +08:00
Paulb23 7333aa68f4 Handle tab in TextEdit 2022-10-09 17:46:40 +01:00
Jummit a6c1cfae99 Allow drag-clicking before symbol lookup
This makes it easier for touch and tablet users to do symbol lookups in
the code editor.
2022-10-09 18:42:54 +02:00
Rémi Verschelde 6f6482e82b Merge pull request #67083 from RedMser/label-font-warning
Add warning for missing characters in label font
2022-10-09 18:29:06 +02:00
Rémi Verschelde 7c1e15bfb9 Merge pull request #67076 from timothyqiu/hint-enum-suffix
Remove invalid suffix hint for enum property
2022-10-09 18:27:59 +02:00
Rémi Verschelde 49be2d2cf8 Merge pull request #66524 from microaeris/aeris/text-edit-get-scroll-bar
Getters for TextEdit scroll bars
2022-10-09 18:27:30 +02:00
Rindbee 3f20108703 Improve caret drawing conditions for `LineEdit`
Now, `caret_can_draw` will be validated when a condition that affects
the drawability of the `LineEdit`'s caret changes; `draw_caret` will
be toggled when the caret's visibility is toggled due to blink, and
`draw_caret` will be `false` when `caret_blink_enabled` is disabled.

Fix toggling `caret_blink_enabled` could cause caret to no longer be
displayed.
Fix opening the context menu causing caret to no longer appear.
2022-10-09 22:14:40 +08:00
Jummit 1e28675560 Expose TreeItem::set_button_color 2022-10-09 10:37:55 +02:00
Hugo Locurcio bab8497fa2
Add a project setting to make the root viewport transparent
This allows recording videos with a transparent background without
having to create a script.
2022-10-09 00:16:07 +02:00
Haoyu Qiu 2a921cc9f8 Fix Label text length mismatch after localization 2022-10-08 23:07:19 +08:00
RedMser 9579d49820 Add warning for missing characters in label font 2022-10-08 17:02:25 +02:00
Rémi Verschelde 2b376437a2 Merge pull request #65983 from Mickeon/rename-audio-player-volume-db
Rename AudioStreamPlayer3D's `unit_db` to `volume_db`
2022-10-08 13:56:10 +02:00
Rémi Verschelde 0a129645ac Merge pull request #67062 from timothyqiu/enum-space
Remove leading spaces from enumerator name hints
2022-10-08 13:55:58 +02:00
Haoyu Qiu 95c860c607 Remove invalid suffix hint for enum property 2022-10-08 19:24:54 +08:00
microaeris 215fe852b8 Getters for TextEdit scrollbars 2022-10-07 23:16:04 -07:00
Haoyu Qiu 344ed9ec6c Remove leading spaces from enumerator name hints
For `PROPERTY_HINT_ENUM` properties, enumerator names can be provided as
a comma separated list. There're a few properties that add leading
spaces to the names (e.g. `First, Second, Third`).

These spaces are included in the Inspector dropdown, which is
unexpected.

It's better to leave the surrounding spaces untouched because it could
be part of the resulting string value (the variable is a string enum).
And most other enum hints don't contain surrounding whitespaces.

This PR removes the spaces and documents this `PROPERTY_HINT_ENUM`
behavior.
2022-10-08 11:33:50 +08:00
Arthur J b18a553a06
declare "_validate_property" as protected
In other classes, the function _validate_property is declared as protected (in the case of Area2D), but in Area3D it's declared as private, which causes compile errors when trying to extend the class in a C++ module for example.
2022-10-07 18:36:37 -03:00
Cykyrios f0d7934055 Fix invalid tooltip position 2022-10-07 22:43:49 +02:00
Rémi Verschelde c723125dfc Merge pull request #67020 from GuilhermeGSousa/remove-transition-expression-node
Remove expression base node for transitions
2022-10-07 14:23:00 +02:00
Guilherme Sousa 12940e53c1 Remove expression base node for transitions 2022-10-07 11:13:43 +02:00
bruvzg 0103af1ddd
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4. 2022-10-07 11:32:33 +03:00
Rémi Verschelde 5b7f62af55 Merge pull request #62910 from Vitika9/gsoc-colorpicker-ux
ColorPicker UX
2022-10-07 09:49:29 +02:00
bruvzg a750ca7ec1
Add split caret direction markers. Fix block/overtype caret size. 2022-10-07 08:45:52 +03:00
Gilles Roudière 64e0c138d9 Fix TileMap occluders having a wrong transform 2022-10-06 14:06:33 +02:00
Markus Sauermann 90b01d79af Fix execution of physics picking events
Fix that physics picking can happen after the mouse has left the viewport
2022-10-06 13:58:54 +02:00
Rémi Verschelde 70d8895396 Merge pull request #66954 from Nidjo123/sample-baked-up-vector
Handle last baked vector index early
2022-10-06 08:56:59 +02:00
Rémi Verschelde d414872bfe Merge pull request #66961 from Rindbee/fix-set_custom_color
Fix wrong condition used in `set_custom_color`
2022-10-06 08:56:52 +02:00
Rémi Verschelde 48e6f84295 Merge pull request #66951 from rburing/restore_recovery_as_collision
Revert "Turn on recovery as collisions only for floor snapping"
2022-10-06 08:56:44 +02:00
Rémi Verschelde f5903215d0 Merge pull request #61902 from Paulb23/multi-caret
Add Multi-caret support to TextEdit
2022-10-06 08:56:34 +02:00
Rindbee f359abbe01 Fix wrong condition used in `set_custom_color` 2022-10-06 12:09:02 +08:00
Nikola Bunjevac e903362269 Handle last baked vector index early 2022-10-06 00:27:46 +02:00
Markus Sauermann c0f0f26615 Fix Control not disconnecting signal
If a Control has not parent CanvasItem and is set as top_level, then it does not disconnect from the "size_changed" signal when it leaves the Canvas.
This patch corrects this.
2022-10-05 23:35:44 +02:00
Ricardo Buring 311cdd2571 Revert "Turn on recovery as collisions only for floor snapping as this leads to unwanted behaviour for other surface than the floor."
This reverts commit 10395f5df2.
2022-10-05 22:51:29 +02:00
Paulb23 e9180241e8 Add multi caret support to CodeEdit 2022-10-05 17:19:26 +01:00
Paulb23 4a9d4e3dad Add mutliple Caret support to TextEdit 2022-10-05 17:19:26 +01:00
Rémi Verschelde 57ffc4d82c Merge pull request #66560 from MisterMX/fix/tileset-move-custom-data-layer
fix(tileset): Move custom data layer
2022-10-05 13:39:46 +02:00
Rémi Verschelde 5b6ccf2fd2 Merge pull request #66720 from qarmin/unintialized_memory
Remove usage of unitialized variables
2022-10-05 11:42:47 +02:00
Rémi Verschelde 9cd62741bb Merge pull request #66839 from aaronfranke/editor-prop-hide-slider
Fix `hide_slider` vs `no_slider` inconsistency in editor property code
2022-10-05 08:47:06 +02:00
Rémi Verschelde 132a0e3242 Merge pull request #66770 from EricEzaM/search-by-event
Add searching by event in Editor Settings shortcuts and Project Settings input map.
2022-10-05 08:34:45 +02:00
Rémi Verschelde 9513034b88 Merge pull request #66911 from clayjohn/imagetexture3d
Properly assign texture RID when creating ImageTexture3D
2022-10-05 08:32:11 +02:00
Rémi Verschelde 57d7e35370 Merge pull request #66509 from Mickeon/yes
Support chaining AtlasTextures inside other AtlasTextures
2022-10-05 08:29:17 +02:00
clayjohn 7fdb460e5d Properly assign texture RID when creating ImageTexture3D 2022-10-04 15:04:55 -07:00
Luis Lopez c262589e26 Add rotation smoothing to Camera2D
Camera2D has follow smoothing to interpolate towards a target position, but no rotation smoothing to align with the target rotation.

This adds rotation smoothing directly into the Camera2D API by having two new properties:
  - `rotation_smoothing_enabled`
  - `rotation_smoothing_speed`
2022-10-04 17:14:03 +02:00
Micky 1518d813be Support nesting AtlasTextures inside other AtlasTextures
Connects AtlasTexture to its `atlas`'s "changed" signal, allowing it to detect property changes to `atlas` and update accordingly, when the project is running and in the editor, as well.
2022-10-04 17:09:37 +02:00
Rémi Verschelde 2b9a145158 Merge pull request #66869 from Sauermann/fix-transform-det-0-spam
Fix Transform2D det == 0 spam for SubViewports
2022-10-04 12:05:37 +02:00
Rémi Verschelde 6a251fd0df Merge pull request #39072 from dalexeev/cs2d_debug_color
Add debug_color property to CollisionShape2D
2022-10-04 12:05:19 +02:00
Markus Sauermann 650cc16b05 Fix Transform2D det == 0 spam for SubViewports 2022-10-04 11:48:39 +02:00
Rémi Verschelde 1c6e8f7e62 Merge pull request #66712 from Cykyrios/fix-invalid-popup-position
Fix invalid popup position for embedded popups
2022-10-04 11:19:50 +02:00
Rémi Verschelde 38dd753715 Merge pull request #66859 from Rindbee/reset-gui_parent
Make sure to reset the tooltip of its gui_parent when the viewport is removed
2022-10-04 10:32:51 +02:00
Rémi Verschelde 02e9e2d3c0 Merge pull request #66559 from zaevi/fix_ScrollContainer_touch_scroll
Fix ScrollContainer touch-scrolling not working.
2022-10-04 10:30:31 +02:00
Rémi Verschelde 163582de58 Merge pull request #62188 from MaeIsBad/MaeIsBad/master
Move "Create Debug Tangents" on MeshInstance3D into an editor plugin
2022-10-04 10:29:11 +02:00
Rémi Verschelde 9928cdc2e7 Merge pull request #66807 from akien-mga/core-unix-remove-NO_FCNTL-and-NO_STATVFS
Unix: Remove now unnecessary I/O defines, cleanup
2022-10-04 10:22:29 +02:00
Rindbee 9a05ea231a Make sure to reset the tooltip of its gui_parent when the viewport is removed 2022-10-04 11:58:02 +08:00
bad a052ebaa99 Move "Create Debug Tangents" into an editor plugin
Instead of exporting the "create_debug_tangents" function via
METHOD_FLAG_EDITOR it gets executed by an editor plugin.

This moves it from the "Manage object properties" menu into a mesh menu. It also adds undo/redo functionality to the create debug tangents option.
2022-10-03 23:34:01 +02:00
Cykyrios 2237df6273 Fix invalid popup position for embedded popups 2022-10-03 21:23:32 +02:00
Aaron Franke 094e8db97c
Fix hide_slider vs no_slider inconsistency in editor property code 2022-10-03 13:40:31 -05:00
Yuri Rubinsky a656dcec01 Fix boolean connection to ports of other types in visual shader 2022-10-03 20:20:00 +03:00
Paulb23 7dd3857f7e Move selecion into caret 2022-10-03 14:09:27 +01:00
Rémi Verschelde 306cbeb9fc Merge pull request #66748 from EricEzaM/66308-66403-menubutton-improvements
Improve MenuButton and OptionButton
2022-10-03 14:51:45 +02:00
Rémi Verschelde f501e4f665 Unix: Remove now unnecessary I/O defines, cleanup
- `LIBC_FILEIO_ENABLED` wasn't defined anywhere, even in _other platforms_.
- `NO_NETWORK` is also never defined. It probably isn't enough anyway to
  disable network APIs in the current codebase.
- `UNIX_SOCKET_UNAVAILABLE` is never defined in this code but used by some
  other platforms, clarify that.
- `NO_STATVFS` can be removed as Android supports it since API level 19,
  which is our current min SDK level. It's also only used for
  `DirAccessUnix::get_space_left()` which is anyway overridden by
  `DirAccessJAndroid::get_space_left()` so it shouldn't make a difference.
  * Fixed documentation for `DirAccess.get_space_left()`.
- `NO_FCNTL` is likely also a remnant of early Android days, in current NDK
  r23 it seems to be available. Also cleaned up unused `fcntl.h` includes.
- `NO_ALLOCA` is never defined, and we use alloca in many places now.
2022-10-03 12:33:41 +02:00
EricEzaM 272c297931 Improve MenuButton and OptionButton
* MenuButton + OptionButton: Add method `show_popup()` which performs required popup setup before showing (prefer use of this over `get_popup()->popup()`, otherwise GH #66308 occurs)
* MenuButton: Ensure that the menu can be opened with a shortcut, if one is set for the button. (GH #66403). Ensure that popupmenu item shortcuts are checked first before the MenuButton shortcut.
2022-10-03 20:07:39 +10:00
EricEzaM cb6d7fd059 Add searching by event for Editor Settings shortcuts and Project Settings input map.
* Focus into the LineEdit, then perform input to search the list of events by the events assigned.
* New specialised editor-only control for this: EventListenerLineEdit. Line edit is a good candidate for such a control because you can focus it, override it's input handling, and show the event all in one control.
Update InputEventConfigurationDialog to use event listener line edit rather than the separate tabs.
* Cleaner look - no need for tabs.
* Simpler code.
2022-10-03 19:56:34 +10:00
Rémi Verschelde 54418ea659 Remove NO_THREADS fallback code, Godot 4 requires thread support
This also removes `OS::can_use_threads` from the public API since it's always
true.
2022-10-03 11:23:26 +02:00
EricEzaM 2a7e61457a Allow shortcut input to be JoypadButton. 2022-10-02 17:11:18 +10:00
Markus Sauermann 56ddf89fac Adjust SubViewportContainer event handling
Change SubViewportContainer, so that it processes events with a position property no longer in 'input', but in 'gui_input'.
This fixes the issue, that Nodes within its SubViewport receive MouseButton events before other Control-Nodes.
2022-10-02 07:23:08 +02:00
Rafał Mikrut 2233624152 Remove usage of unitialized variables 2022-10-01 21:09:22 +02:00
Markus Sauermann 2bf2217b1a Calculate window input event transform only on window change 2022-10-01 09:54:38 +02:00
Rémi Verschelde e69b7083d4 Merge pull request #65903 from groud/improve_terrain_painting
Right-click to erase TileSet terrains and bugfixes
2022-09-30 17:44:48 +02:00
Rémi Verschelde 7c7a86f0fd Merge pull request #66592 from KoBeWi/look_at_me_I_am_the_captain_now
Fail `look_at()` if not inside tree
2022-09-29 15:34:08 +02:00
Rémi Verschelde f5f4d9bf00 Merge pull request #66143 from DarkKilauea/nav-queries-agent
Update NavigationAgent to use query_path
2022-09-29 15:33:25 +02:00
kobewi c080b9dc05 Fail look_at() if not inside tree 2022-09-29 13:34:28 +02:00
MisterMX cfe518b90b fix(tileset): Move custom data layer
Fix crash when moving a custom data layer.

Signed-off-by: MisterMX <mbxd12@web.de>
2022-09-29 11:53:48 +02:00
Rémi Verschelde 6991e9b43d Merge pull request #66583 from bruvzg/constexpr
Use `constexpr` in the conditions with template parameters and `sizeof`s to suppress C4127 warnings.
2022-09-29 10:44:22 +02:00
Rémi Verschelde 5bcd019ee9 Merge pull request #66552 from bruvzg/64_bitfields
Change BitField to use 64-bit int.
2022-09-29 10:44:08 +02:00
Rémi Verschelde de31edb780 Merge pull request #65807 from clayjohn/light-units-bug
Validate physical light units in GI classes.
2022-09-29 10:43:55 +02:00
Rémi Verschelde 315a71103e Merge pull request #66565 from clayjohn/canvas-lights
Clean up canvas light shader API.
2022-09-29 10:43:42 +02:00
bruvzg ea1848ce0a
Use `constexpr` in the conditions with template parameters and `sizeof`s to suppress C4127 warnings. 2022-09-29 10:38:21 +03:00
Josh Jones a2c53b881b Update NavigationAgent to use query_path
This paves the way for having agents respond to link traversal.
2022-09-28 23:01:12 -06:00
Rémi Verschelde e3464c8fc8 Merge pull request #58995 from Sauermann/fix-mouse-cursor-change-2
Update mouse cursor shape after changes
2022-09-28 20:50:05 +02:00
Rémi Verschelde ba25a6e93b Merge pull request #66549 from MisterMX/tilemap-get-used-rect
refactor(TileMap): Return `Rect2i` in `get_used_rect`
2022-09-28 20:49:29 +02:00
Rémi Verschelde 67f79819e7 Merge pull request #66551 from bruvzg/font_is_cyclic
Fix Font::_is_cyclic.
2022-09-28 20:47:56 +02:00
Rémi Verschelde 0dd308cedd Merge pull request #66545 from akien-mga/msvc-warnings-c4324-c4389-c4456-c4459
Fix MSVC warnings C4324, C4389, C4456, and C4459
2022-09-28 20:47:43 +02:00
Rémi Verschelde a9591f3039 Merge pull request #66543 from akien-mga/msvc-warning-c4702
Fix MSVC warning C4702: unreachable code
2022-09-28 20:47:30 +02:00
clayjohn 1a0890122f Clean up canvas light shader API.
Expose LIGHT_ENERGY and LIGHT_IS_DIRECTIONAL.
Add LIGHT_DIRECTION
2022-09-28 11:46:58 -07:00
Zae 186ca020b3 Fix ScrollContainer touch-scrolling not working. 2022-09-29 01:47:03 +08:00
bruvzg 155694c7c6
Fix Font::_is_cyclic. 2022-09-28 18:11:17 +03:00
MisterMX 407bbdda20 refactor(TileMap): Return Rect2i in get_used_rect
Signed-off-by: MisterMX <mbxd12@web.de>
2022-09-28 17:04:15 +02:00
Rémi Verschelde 7ab01450cf Fix MSVC warning C4702: unreachable code
Part of #66537.
2022-09-28 16:46:48 +02:00
Rémi Verschelde d8268aae30 Fix MSVC warnings C4324, C4389, C4456, and C4459
Part of #66537.
2022-09-28 16:43:09 +02:00
bruvzg 8a9659b152
Change BitField to use 64-bit int. 2022-09-28 17:36:59 +03:00
Rémi Verschelde 0e53dd642c Fix MSVC warning C4706: assignment within conditional expression
Part of #66537.
2022-09-28 16:05:07 +02:00
Rémi Verschelde 7562932eb2 Merge pull request #66160 from dpalais/double_time
Use double instead of real_t type for time-related parameters and variables
2022-09-27 10:04:10 +02:00
Rémi Verschelde ed65f903ff Merge pull request #66444 from Calinou/fogvolume-tweak-density-property-hint
Tweak FogVolume density property to allow sliding to negative values
2022-09-27 09:55:15 +02:00
Rémi Verschelde 92371880bd Merge pull request #66445 from EricEzaM/GH-66442-shortcut-change-popupmenu-update
Ensure popup menu redraws items when shortcuts update.
2022-09-27 09:53:52 +02:00
Dave Palais 0c46068af0 Change time parameters and variables to double type
Addresses #65313
2022-09-26 13:52:54 -05:00
Rémi Verschelde 6fcf2a2862 Merge pull request #61336 from KoBeWi/where_are_you_going
Force window position if spawned outside screen
2022-09-26 15:51:22 +02:00
Rémi Verschelde 9cc4511031 Merge pull request #66434 from bruvzg/rtl_fix_def_ot
[RTL] Fix font variations / OpenType features of theme default font not updated when default font is changed.
2022-09-26 15:51:13 +02:00
Rémi Verschelde fa85821199 Merge pull request #66301 from GuilhermeGSousa/fix-animation-transition-expressions
Fix expression base path on transitions
2022-09-26 15:50:32 +02:00
Hugo Locurcio 528db5287b
Tweak FogVolume density property to allow sliding to negative values
Negative density is used to subtract fog from the rest of the world.

The visible range in the slider was reduced to [-8; 8] as FogVolume
density should generally not exceed 8.0 (it can introduce aliasing).
2022-09-26 15:44:30 +02:00
Eric M af438ae742 Ensure popup menu redraws items when shortcuts update. 2022-09-26 23:21:32 +10:00
Rémi Verschelde 49fcf4ffad Style: Cleanup header guards for consistency
Fix file names for {Static,Lightmap}RaycasterEmbree.
2022-09-26 13:51:17 +02:00
kobewi a4c3551dc6 Force window position if spawned outside screen 2022-09-26 13:44:25 +02:00
bruvzg 970592274d
[RTL] Fix font variations / OpenType features of theme default font not updated when default font is changed. 2022-09-26 13:04:40 +03:00
Rémi Verschelde 1b31241445 Merge pull request #65540 from MewPurPur/easier-bookmarks
Implement Shift+LMB as a Way to Toggle Bookmarks
2022-09-26 08:20:40 +02:00
Rémi Verschelde 56c7305f70 Merge pull request #66288 from bruvzg/te_fix_color
[TextEdit] Use error/selection font color for the current glyph only, instead of updating cached font color.
2022-09-25 11:04:14 +02:00
Guilherme Sousa 5e5bb088de Fix expression base path on transitions 2022-09-25 09:00:03 +02:00
Rémi Verschelde 61c0cb712d
Merge pull request #66355 from Mickeon/fix-color-picker-always-color-changed
Fix ColorPicker always emitting color_changed on html submit
2022-09-24 23:00:19 +02:00
Micky 544727ac1e Fix ColorPicker always emitting color_changed on html submit
The color change was always emitted when the the modal was closed, even if it was exactly the same as before.
2022-09-24 18:15:06 +02:00
Eric M 2eda77c682 Ensure all checks of `is_action` in the editor which are for 'shortcut' use, check the action exactly. 2022-09-24 18:01:02 +10:00
clayjohn 36cb3c4050 Set QuadMesh default size back to 1 2022-09-23 11:00:43 -07:00
bruvzg 3278917c7a
[TextEdit] Use error/selection font color for the current glyph only, instead of updating cached font color. 2022-09-23 11:25:39 +03:00
Rémi Verschelde 1928492b41 Merge pull request #65158 from nongvantinh/fixed-infinite-loop
Fixes engine runs into an infinite loop when searching using FindBar
2022-09-23 09:45:34 +02:00
Rémi Verschelde 3a8e711e33 Merge pull request #66254 from bruvzg/macos_title
[macOS extend-to-title] Add scene/project name to the editor title, and fix window button placement.
2022-09-23 09:44:37 +02:00
Aaron Franke c3970f8fe5
Revert custom_minimum_size type back to Vector2 instead of Vector2i 2022-09-22 19:09:12 -05:00
bruvzg 0dab11afa4
[macOS extend-to-title] Add scene/project name to the editor title, fix incorrect window button position/order when system primary language is RTL. 2022-09-22 23:09:56 +03:00
Rémi Verschelde d1a155e3cd Fix various -Wmaybe-uninitialized warnings from GCC 12.2.1
Not sure why I didn't get those before, it may be due to upstream
changes (12.2.1 is a moving target, it's basically 12.3-dev), or simply
rebuilding Godot from scratch with different options.
2022-09-22 11:29:48 +02:00
Rémi Verschelde 8e14f9ba21 Merge pull request #64679 from DarkKilauea/nav-region-props
Improve consistency of NavigationRegion setters
2022-09-22 08:27:35 +02:00
Rémi Verschelde d96b7d767a Merge pull request #66110 from Zylann/reference_get_count
get_reference_count()`
2022-09-22 08:26:29 +02:00
Rémi Verschelde 2d598bbf9a Merge pull request #66222 from Mickeon/gradual-destruction
Remove unused struct in GradientTexture1D
2022-09-22 08:26:20 +02:00
Josh Jones a25bb9811a Improve consistancy of NavigationRegion setters 2022-09-21 22:42:52 -07:00
Micky c1b5b68eee Rename remaining "*_enable" to "*_enabled"
Material.`proximity_fade_enable` -> `proximity_fade_enabled`
Material.`set_proximity_fade` -> `set_proximity_fade_enabled`
(Material.`is_proximity_fade_enabled` is unchanged)

Area3D.`reverb_bus_enable` -> `reverb_bus_enabled`
(`set_use_reverb_bus` & `is_using_reverb_bus` are unchanged)

RDPipelineRasterizationState:
`depth_bias_enable` -> `depth_bias_enabled`
`set_depth_bias_enable` -> `set_depth_bias_enabled`
`get_depth_bias_enable` -> `get_depth_bias_enabled`

Bonus:
Area3D.`set_reverb_bus` -> `set_reverb_bus_name`
Area3D.`get_reverb_bus` -> `set_get_reverb_bus_name`
2022-09-21 22:47:46 +02:00
Marc Gilleron 474cee7daf Rename and expose `RefCounted::get_reference_count()` 2022-09-21 21:18:54 +01:00
Micky 3cae53ba70 Remove unused struct in GradientTexture1D 2022-09-21 19:05:03 +02:00
Rémi Verschelde 9f2748f63c Merge pull request #66213 from KoBeWi/not_right_but_works™
Remove duplicate code in ItemList
2022-09-21 18:55:12 +02:00
kobewi 4a0e03cea5 Remove duplicate code in ItemList 2022-09-21 15:37:01 +02:00
Rémi Verschelde dd3f3f6717 Merge pull request #66210 from Rindbee/fix-font-string-size
Let the cached `TextLine` reset the width in `get_string_size`
2022-09-21 15:36:50 +02:00
Danil Alexeev df2209c700
Add `CollisionShape2D.debug_color` property 2022-09-21 16:07:47 +03:00
Rindbee 332c566a6c Let the cached `TextLine` reset the width in `get_string_size`
Previously, the cached `TextLine` would set the width in `draw_string`, but not in `get_string_size`,
which resulted in unexpected results returned by `get_string_size` in some cases.
2022-09-21 19:47:36 +08:00
Ninni Pipping df9eaf5f47 Tree recursive folding 2022-09-21 13:28:29 +02:00
Rémi Verschelde 307f560b39 Merge pull request #66183 from KoBeWi/ARE_YOU_READY
Set scene tiles' position before adding them
2022-09-21 11:07:43 +02:00
Rémi Verschelde 7bf61e3912 Merge pull request #64359 from Mickeon/rename-camera-rotating
Reverse Camera2D.`rotating` to `ignore_rotation`
2022-09-21 11:06:41 +02:00
Rémi Verschelde 28e1dc6162 Merge pull request #65828 from rburing/body_state_sync_callable
make `body_set_state_sync_callback` take a `Callable`
2022-09-21 11:05:41 +02:00
Rémi Verschelde 11602cbcfd Merge pull request #66126 from RedMser/shortcut-context-inspector
Fix editing `shortcut_context` in inspector
2022-09-21 11:04:44 +02:00
Micky ee16de583f Reverse Camera2D.`rotating` to `ignore_rotation`
`rotating` is misleading, as Camera2D is affected by `rotation` and `global_rotation` like any other Node2D

Updates description in the docs, as well.
2022-09-21 01:52:12 +02:00
kobewi a275b70b6e Set scene tiles' position before adding them 2022-09-21 00:37:18 +02:00
Rémi Verschelde c44e1c4e31
Merge pull request #66064 from kleonc/sprite3d-fix-drawing-with-vertical-margins
`Sprite3D`/`AnimatedSprite3D` Fix drawing `AtlasTexture`s with vertical margins differently than in 2D
2022-09-20 23:06:26 +02:00
Rémi Verschelde ae2d9be0fe
Merge pull request #63740 from Faless/net/4.x_http_request_decompress
[HTTP] Implement streaming decompression.
2022-09-20 22:29:16 +02:00
Fabio Alessandrelli 172a9e0b24 [HTTPRequest] Cleanup, refactor deferred call. 2022-09-20 18:39:10 +02:00
Fabio Alessandrelli 98047e791a [HTTPRequest] Body streaming decompresison.
Using a StreamPeerGZIP (which acts as a ringbuffer).
2022-09-20 18:39:10 +02:00
Rémi Verschelde bcf754d735 Merge pull request #66068 from bruvzg/rtl_fx_connected
[RTL] Add option to apply built-in effects to the individual connected glyphs.
2022-09-19 22:05:47 +02:00
Rémi Verschelde 209a837f79 Merge pull request #66112 from Zylann/get_configuration_warnings_psa
Change return type of `get_configuration_warnings` to `PackedStringArray`
2022-09-19 22:03:44 +02:00
Rémi Verschelde 73c35e8d95 Merge pull request #65918 from clayjohn/quadmesh
Add QuadMesh back as a subclass of PlaneMesh.
2022-09-19 22:03:17 +02:00
RedMser a12c71fff1 Fix #66062: editing shortcut_context in inspector 2022-09-19 19:13:52 +02:00
clayjohn 87710517fa Add QuadMesh back as a subclass of PlaneMesh.
This simplifies the creation of billboarded meshes without any code overhead.
2022-09-19 08:53:10 -07:00
Marc Gilleron aed3822a93 Change return type of `get_configuration_warnings` to `PackedStringArray` 2022-09-19 16:43:15 +01:00
bruvzg 46af7cbfdd
[RTL] Add option to apply built-in effects to the individual connected glyphs. 2022-09-19 18:10:32 +03:00
fabriceci 1937e030b5 Increases the number of maximum detected collisions 2022-09-19 16:44:31 +02:00
Rémi Verschelde 40a7fb238d Merge pull request #64728 from fabriceci/only-report-recovery-for-floor-snapping
Turn on recovery as collisions only for floor snapping
2022-09-19 15:39:55 +02:00
Rémi Verschelde 1445b052b4 Merge pull request #66104 from Zylann/notification_local_transform_changed
Expose Node3D `NOTIFICATION_LOCAL_TRANSFORM_CHANGED`
2022-09-19 15:32:43 +02:00
Marc Gilleron c00c29a136 Expose `NOTIFICATION_LOCAL_TRANSFORM_CHANGED` 2022-09-19 13:43:46 +01:00
fabriceci 10395f5df2 Turn on recovery as collisions only for floor snapping as this leads to unwanted behaviour for other surface than the floor. 2022-09-18 22:23:09 +02:00
kleonc 8a56100d39 `SpriteBase3D` Fix drawing AtlasTextures with vertical margins differently than in 2D 2022-09-18 20:08:31 +02:00
kleonc 8837d41b50 Move duplicated drawing code from `Sprite3D`/`AnimatedSprite3D` to `SpriteBase3D` 2022-09-18 20:03:03 +02:00
Markus Sauermann 52da6f1a44 Update mouse cursor shape after changes
This fixes some cases where the mouse cursor shape did not change automatically, but instead required a MouseMove to update.
2022-09-18 17:15:38 +02:00
Rindbee 65f97c671c Make the inner TabBar in a TabContainer behave as if it were in a Container 2022-09-18 20:55:13 +08:00
Rémi Verschelde e5594c26b1
Merge pull request #44143 from KoBeWi/callable_multiplayer 2022-09-18 13:47:04 +02:00
Tomasz Chabora 882a4f8906 Port remaining connections to callable_mp 2022-09-18 13:08:54 +02:00
Rémi Verschelde 80be221608 Merge pull request #66018 from Mickeon/fix-animated-sprite-outdated-warning
Fix outdated warning in AnimatedSprite2D
2022-09-18 10:52:58 +02:00
Rémi Verschelde 6e8638683e Merge pull request #66012 from Rindbee/fix-TabContainer-minimum_size
Fix minimum size calculation for `TabContainer`
2022-09-18 10:48:08 +02:00
Micky 213cc7859e Fix outdated warning in AnimatedSprite2D 2022-09-18 02:52:20 +02:00
Rindbee 464c374372 Fix minimum size calculation for TabContainer 2022-09-18 06:59:48 +08:00
Rémi Verschelde 0bb57bd9f2 Merge pull request #65931 from fabriceci/add-recovery-as-collision-in-low-level-methods
Add recovery_as_collision in move_and_collide/test_move
2022-09-18 00:42:29 +02:00
Rémi Verschelde 06c8f1c659 Merge pull request #58567 from madmiraal/fix-26470
Remove ParallaxLayer's invalid dependence on screen_offset
2022-09-18 00:42:22 +02:00
Rémi Verschelde 6ba4137f8f Merge pull request #65929 from bruvzg/rtl_theme_font_change
Fix RichTextLabel not updating on theme/theme override change until text is updated.
2022-09-18 00:40:18 +02:00
Silc Renew 96ee320fb7 Changed the rest definition of SkeletonProfileHumanoid thumb 2022-09-18 06:28:53 +09:00
Micky eb0cc08a23 Rename AudioStreamPlayer3D's `unit_db` to `volume_db`
AudioStreamPlayer3D.`unit_db` -> `volume_db`

Now matches the same name AudioStreamPlayer and AudioStreamPlayer2D use.
2022-09-17 16:06:30 +02:00
fabriceci a72d5be2c6 Add recovery_as_collision in move_and_collide/test_move 2022-09-17 11:40:03 +02:00
Micky a2c3b4ea92 Fix "Save Branch as Scene" storing root Node's `unique_name_in_owner`
Fix #64425
2022-09-17 11:04:59 +02:00
SaracenOne 6a8fbf3d25 Fix animation change callbacks 2022-09-16 14:04:24 -07:00
bruvzg 2a0b4244b7
Fix RichTextLabel not updating on theme/theme override change until text is updated. 2022-09-16 22:24:11 +03:00
Hugo Locurcio 7dee32ad14
Tweak LightmapGI defaults to be closer to the CPU lightmapper
- Use 3 bounces by default.
- Enable environment lighting from the scene by default.
  - This is not done in `3.x` for compatibility with existing projects,
    but it makes sense to do this by default since pretty much all
    outdoor scenes benefit from this.
- Set the custom environment color to white (like ReflectionProbe).
  - Its default energy is still 0, so it's invisible by default.
- Enable the generation of dynamic object probes by default.
- Tweak the `max_texture_size` property hint for better usability.
- Improve error messages when passing invalid sizes to
  `LightmapGI.set_max_texture_size()`.
2022-09-16 16:27:00 +02:00
Gilles Roudière 68ffa9a2a1 Right-click to erase TileSet terrains and bugfixes 2022-09-16 15:22:55 +02:00
kobewi 1a462bc84e Fix crash when playing Tween right after finishing 2022-09-16 14:20:12 +02:00
Rémi Verschelde d6d43dc785 Merge pull request #65873 from Chaosus/fix_uniform_sorting
Fix sorting of uniform items in the material properties
2022-09-16 09:24:18 +02:00
Rémi Verschelde d79040e7eb Merge pull request #65496 from MinusKube/popup-capture-mouse-bug
Fix MOUSE_MODE_CAPTURED not working correctly with popups
2022-09-16 09:23:40 +02:00
Rémi Verschelde d347d2f585 Merge pull request #65550 from MinusKube/small-popup-bug
Use embedding viewport instead of parent viewport to determine popup rect
2022-09-16 09:22:57 +02:00
Rémi Verschelde a981a8061f Merge pull request #65325 from TokageItLab/refactor-variant-for-anim
Move some static methods to `Animation` from `Variant` for refactoring `Animation` and `Tween`
2022-09-16 09:20:50 +02:00
Rémi Verschelde 16d44395b5 Merge pull request #65148 from Mickeon/animated-sprite-negative-speed-scale
Allow negative `speed_scale` in AnimatedSprite2D & 3D
2022-09-16 09:18:42 +02:00
Yuri Rubinsky 4f0e0f1650 Fix sorting of uniform items in the material properties
Co-authored-by: Chia-Hsiang Cheng <garychia@users.noreply.github.com>
2022-09-16 08:59:13 +03:00
Clay John 95df3e7c88
Merge pull request #65800 from dsnopek/xr-resize-viewport-3
Fix XR rendering in 'opengl3' driver and expose true size via the Viewport node
2022-09-15 18:19:24 -07:00
Rémi Verschelde 80802d2718 Merge pull request #65196 from TokageItLab/fix-redraw-anim-tree
Fix redraw timing in `AnimationBlendTreeEditor`
2022-09-15 20:11:36 +02:00
Ricardo Buring ff4e72a0bc PhysicsServer2D and PhysicsServer3D: make body_set_state_sync_callback take a Callable
Prefer Callable to a C-style callback. This is helpful for GDExtension.
2022-09-15 15:09:23 +02:00
David Snopek e82cd46a74 Fix XR rendering in 'opengl3' driver and expose true size via the Viewport node 2022-09-14 20:55:56 -05:00
clayjohn 1b5f422c73 Validate physical light units in GI classes.
Add checks for physical light units in a few more places to ensure they aren't used when disabled.
2022-09-14 17:39:25 -07:00
Lyuma 033abdc59f 2D and 3D Skeleton modification docs, and small fixes.
Mark SkeletonModificationStack3D and related as deprecated.
Mark local bone override and axis functions deprecated in Skeleton3D api.
Fix array property glitch in SkeletonModificationStack2D
Mark SkeletonModificationStack2D and related APIs as experimental. Mark SkeletonIK3D as deprecated.
2022-09-14 15:07:45 -07:00
Rémi Verschelde b094e4f1a1
Merge pull request #64092 from nathanfranke/shader-uniform 2022-09-14 22:07:15 +02:00
Silc Renew 9d47e079b7 Move some methods to Animation from Variant for refactoring 2022-09-15 04:52:43 +09:00
Rémi Verschelde fff0970c5a
Merge pull request #65628 from JohanAR/particle_billboard_normal
Calculate MODELVIEW_NORMAL_MATRIX for billboard materials
2022-09-14 21:17:30 +02:00
Hendrik Brucker 299585fcde Add configuration warning to GraphEdit regarding future refactoring 2022-09-14 18:09:21 +02:00
Voylin ab255caa07 Adding tff, otf, woff(2) to custom font extensions
This pull request is to fix #65633

When trying to add a custom font, my '.ttf' and '.otf' fonts were not visible unless I selected 'All files'. By adding these to the custom property info makes it more convenient to select a different font, without doing the extra clicks to select 'All Files'.

Not a big change, but something I wanted to fix as it seems appropriate to do so.
2022-09-14 21:29:54 +09:00
Silc Renew cff95e54e0 Fix redraw timing in AnimationBlendTreeEditor 2022-09-14 21:05:21 +09:00
Rémi Verschelde d9e974cdb0
Merge pull request #65493 from V-Sekai/lod_scaling
Fixes LOD scaling issues on skinned meshes.
2022-09-14 09:57:02 +02:00
Rémi Verschelde dbd6fa7e33
Merge pull request #65737 from bruvzg/font_do_not_emit_from_dtr
[Font] Remove unnecessary cleanup and `changed` signal emission from the destructor.
2022-09-14 07:59:59 +02:00
Rémi Verschelde e5963cf3dd
Merge pull request #65735 from bruvzg/rtl_fixes
RTL Improvements
2022-09-14 07:59:21 +02:00
SaracenOne 13f5c62124 Fix LOD-generation on skinned meshes. 2022-09-14 02:46:10 +01:00
clayjohn 8fa76a5272 Move debanding into internal sky shader code so that it is applied after everything else.
This ensures that the debanding does not scale with exposure or any other effect.
2022-09-13 10:39:04 -07:00
Micky 8142bc4ddd Allow negative `speed_scale` in AnimatedSprite2D & 3D
If the `speed_scale` is set to a negative value, the animation plays in reverse.
The second parameter of `play()` still reverses as before. if `speed_scale` and the second parameter of `play()` is true, the animation plays forward.

Also updates the documentation to better describe the pausing and playing behaviour.
2022-09-13 12:41:07 +02:00
Rémi Verschelde 3a82a1315b Merge pull request #65591 from MewPurPur/area-overlapping-function
Implement `Area[2D/3D].has_overlapping_[bodies/areas]`
2022-09-13 10:58:55 +02:00
bruvzg 2aa226f5e1
RTL Improvements
Do not apply negative line separation to the last line.
Ensure all methods immediately update cache in a single thread mode.
Fix bbcode_enabled change not being applied until text is changed.
Fix crash if line height is zero or less.
2022-09-13 11:40:20 +03:00
bruvzg 2ece5b4a6b
[Font] Remove unnecessary cleanup and `changed` signal emission from the destructor. 2022-09-13 10:28:12 +03:00
kobewi 7afaca2091 Don't print error in get_cell_tile_data() 2022-09-13 01:39:35 +02:00
kobewi d5c703b83e Don't store frame of playing AnimatedSprite 2022-09-12 22:59:35 +02:00
benbot f0ebfdb6ed removed 2nd particle collision velocity calculation 2022-09-12 13:07:26 -04:00
Rémi Verschelde 43a3fc7859
Merge pull request #64982 from V-Sekai/exp_dep_flags 2022-09-12 12:19:22 +02:00
Rémi Verschelde 97830e7187
Merge pull request #64155 from Mickeon/sprite-3d-backwards-speed-scale 2022-09-12 12:15:58 +02:00
SaracenOne cc4bda8500 Add ability to flag classes as experimental or deprecated. 2022-09-11 00:11:33 +01:00
Johan Aires Rastén bb657c04fc Calculate MODELVIEW_NORMAL_MATRIX for billboard materials
Solves #65627
2022-09-10 21:08:29 +02:00
Yuri Sizov 461037203c
Merge pull request #65574 from YuriSizov/graphedit-slot-port-conundrum 2022-09-10 14:23:11 +03:00
VolTer ed4fe1e2bd Implement Area.has_overlapping_* 2022-09-10 12:17:37 +02:00
Rémi Verschelde 8899f1eec2
Merge pull request #65595 from KoBeWi/minus_children
Allow negative indices in `move_child()`
2022-09-10 09:59:15 +02:00
kobewi 31e62ca827 Allow negative indices in move_child() 2022-09-10 03:54:04 +02:00
Rémi Verschelde 27e1323473
Merge pull request #64412 from MewPurPur/remove-remove-and-skip
Remove `Node.remove_and_skip` method
2022-09-10 00:42:55 +02:00
VolTer e19f7b2407 Remove Remove and Skip 2022-09-09 23:44:31 +02:00
Micky b648ee43ab Harmonise AnimatedSprite3D and its 2D counterpart
Add the following properties to AnimatedSprite3D:
- `backwards` parameter in `play()`;
- `speed_scale`.

Both classes' internals are more similar, down to the line spacings. They've also been updated to be clearer and less inconsistent (e.g. `!frames.is_valid()` -> `frames.is_null()`, use SceneStringNames instead of CoreStringNames, rename the internal _queue_update to _queue_redraw)
2022-09-09 21:06:24 +02:00
Rémi Verschelde ce6f284e5f
Merge pull request #64394 from smix8/navigation_obstacles_reparent_4.x
Fix NavigationObstacle 2D/3D (re)parent issues
2022-09-09 19:20:14 +02:00
Yuri Sizov 29c8504dd9 Improve parameter naming and documentation in GraphEdit and GraphNode
Co-authored-by: Maganty Rushyendra <mrushyendra@yahoo.com.sg>
2022-09-09 17:50:44 +03:00
Rémi Verschelde c909120b59
Merge pull request #64373 from YeldhamDev/edscale_likes_them_floaty 2022-09-09 09:07:53 +02:00
MinusKube 00e153f85a Use embedding viewport instead of parent viewport to determine popup rect 2022-09-09 01:22:46 +02:00
VolTer c8cb93d022 Shift+LMB to Toggle Bookmarks 2022-09-08 22:23:14 +02:00
Michael Alexsander c4c9e41073 Make `Vector2i` values paired with `EDSCALE` be just `Vector2` 2022-09-08 14:46:32 -03:00
Yuri Sizov 141fdac36c
Merge pull request #65188 from Mickeon/animated-texture-speed-scale
Rework AnimatedTexture's `fps` into `speed_scale`
2022-09-08 18:25:35 +03:00
Rémi Verschelde 69233093d7 Merge pull request #65241 from bruvzg/no_keymap_ambiguity
Fix key mapping changes when moving from macOS to other platform.
2022-09-08 09:24:24 +02:00
Rémi Verschelde 7936b3cc4c Merge pull request #60108 from KoBeWi/arise_to_top
Rename raise() to move_to_front()
2022-09-08 09:23:31 +02:00
Rémi Verschelde de739530c2 Merge pull request #63596 from Jayman2000/issue-27640
Rename `change_scene()` and `change_scene_to()`
2022-09-08 09:22:03 +02:00
Rémi Verschelde a51dc70dfb Merge pull request #65460 from Faless/net/4.x_ssl_to_tls_more
[Net] Rename "ssl" references to "tls" in methods and members.
2022-09-08 09:20:19 +02:00
Rémi Verschelde 6ac1a811dd Merge pull request #63905 from smix8/navigation_replace_old_debug_4.x
Remove / Replace old Navigation Debug Visualization
2022-09-08 09:19:13 +02:00
Fabio Alessandrelli a95d792420 [Net] Rename "ssl" references to "tls" in methods and members. 2022-09-08 03:24:23 +02:00
Jason Yundt 69963ffaa3 Rename change_scene() and change_scene_to()
Before this change, the SceneTree had methods named “change_scene” and
“change_scene_to”. One of them accepted a String as a parameter and the
other accepted a PackedScene, but you couldn’t tell which one was which
just by looking at their names.

This change renames those two methods to “change_scene_to_file” and
“change_scene_to_packed”. These new names came from this suggestion [1].
These new names make the difference between the two methods more clear
and hint at the fact that there’s more than one change_scene method.

[1]: <https://github.com/godotengine/godot/issues/27640#issuecomment-1081870955>

Fixes #27640.
2022-09-07 17:06:33 -04:00
bruvzg ac1f2b378f
[RTL] Stop threaded RTL auto-redrawing as soon as text processing is finished, instead of waiting for first redraw. 2022-09-07 22:24:30 +02:00
MinusKube 06b86fad0d Fix MOUSE_MODE_CAPTURED not working correctly with popups 2022-09-07 19:31:57 +02:00
bruvzg 6f4d233062
Fix key mapping changes when moving from macOS to other platform
Removes separate `Command` key (use `Meta` instead).
Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-07 18:45:35 +02:00
smix8 d7f75fab60 Remove / Replace old Navigation Debug Visualization
- removes / replaces leftovers from old navigation debug code
- cleanes SceneTree and ProjectSettings from old navigation debug
2022-09-07 18:30:35 +02:00
Rémi Verschelde 81de16890e Merge pull request #65375 from ItsNL/fix-accep-dialog-its_inside_tree-false
Condition "!is_inside_tree()" is true" when AcceptDialog was visible from the editor.
2022-09-07 17:53:46 +02:00
Rémi Verschelde 54942038ac Merge pull request #65389 from Rindbee/fix-file-list-in-FileDialog-not-updating
Fix file list in FileDialog not updating on first run
2022-09-07 17:53:09 +02:00
Rémi Verschelde e0c7916f73 Merge pull request #59069 from fire-forge/stylebox_margin_functions
Add all/individual setters for StyleBox default margins and StyleBoxTexture margin size and unbind `StyleBox*.set_*_individual()` methods
2022-09-07 17:52:58 +02:00
Rémi Verschelde 48705b1f03 Merge pull request #65355 from groud/split_container_min_grab_thickness
Allow SplitContainer to have a grab area larger than its visual grabber
2022-09-07 17:51:52 +02:00
= 2de52c74ae Fix "grab_focus: Condition "!is_inside_tree()" is true" when AcceptDialog was visible from the editor. 2022-09-07 17:04:26 +02:00
FireForge dcfd7622d1 Unbind StyleBox*.set_*_individual() methods
Unbinds the following methods:
- StyleBox.set_default_margin_individual()
- StyleBoxFlat.set_corner_radius_individual()
- StyleBoxFlat.set_expand_margin_individual()
- StyleBoxTexture.set_expand_margin_individual()
- StyleBoxTexture.set_margin_size_individual()
2022-09-07 16:37:36 +03:00
FireForge dd7ee37c8a Add set_default_margin_all/individual to StyleBox 2022-09-07 16:37:36 +03:00
Rindbee 88b72c3de4 Fix file list in FileDialog not updating on first run 2022-09-07 21:36:21 +08:00
Gilles Roudière 4cbcb5acda Allow SplitContainer to have a grab area larger than its visual grabber 2022-09-07 12:33:02 +02:00
Micky 08c2aab169 Rename ProgressBar.`percent_visible` to `show_percentage`
`percent_visible` -> `show_percentage`
`set_percent_visible` -> `set_show_percentage`
`is_percent_visible` -> `is_percentage_shown`
2022-09-07 11:58:30 +02:00
Micky f577bae76f Rename `legible_unique_name` param to `force_readable_name`
With the introduction of Scene Unique Nodes, `is_unique_in_owner`, "Unique Name in Scene" and other descriptions related to the feature, the second parameter of add_child() and add_simbling() could be misunderstood to be related, at first glance.
2022-09-07 11:58:30 +02:00
Rémi Verschelde 647f345ffe Merge pull request #65457 from Chaosus/vs_fix2
Add conversion for uniform_name property in visual shader
2022-09-07 09:09:58 +02:00
Rémi Verschelde 2841bc358c Merge pull request #65446 from YuriSizov/dialogs-make-styleboxes-matter
Make `AcceptDialog` and derivatives utilize `StyleBox` fully
2022-09-07 09:09:15 +02:00
Rémi Verschelde e350d79cda Merge pull request #65444 from Trashtalk217/fix-_edit_get_rect-navigation-link-2D
Fixed crash with calling _edit_get_rect() on NavigationLink2D
2022-09-07 09:09:05 +02:00
Rémi Verschelde 80dacac90c Merge pull request #65437 from YuriSizov/theme-gui-renames
Improve naming of theme properties throughout GUI code
2022-09-07 08:58:00 +02:00
Rémi Verschelde 5c5079b398 Merge pull request #65197 from Mickeon/rename-connect-one-shot
Rename CONNECT_ONESHOT to CONNECT_ONE_SHOT
2022-09-07 08:51:10 +02:00
Rémi Verschelde 3515382390 Merge pull request #64361 from Mickeon/rename-caret-blink
Rename every instance of `caret_blink_speed` to `caret_blink_interval`
2022-09-07 08:51:02 +02:00
Yuri Rubinsky b17a306239
Merge pull request #65455 from Chaosus/vs_fix 2022-09-07 08:44:01 +03:00
Yuri Rubinsky 09c98cdde9 Add conversion for uniform_name property in visual shader 2022-09-07 08:19:02 +03:00
Yuri Rubinsky 3401228fbd Fix code generation for `VisualShaderNodeTextureParameterTriplanar` 2022-09-07 07:02:07 +03:00
Yuri Sizov 5eaf82b4f0 Make AcceptDialog and derivatives utilize StyleBox fully 2022-09-07 01:42:11 +03:00
Trashtalk 1d233ce58c handled edge case where navigation_link_2d is outside of the tree when calling _edit_get_rect() 2022-09-07 00:05:56 +02:00
kobewi b218727599 Rename raise() to move_to_front() 2022-09-06 22:13:06 +02:00
Yuri Sizov 39ef611a7d Fix theming code in Panel, SplitContainer, RichTextLabel 2022-09-06 22:53:19 +03:00
Yuri Sizov 43f03e2ce6 Improve naming of theme properties throughout GUI code
Rename ItemList's bg -> panel
Rename ItemList's bg_focus -> focus
Rename ProgressBar's bg -> background
Rename ProgressBar's fg -> fill
Rename Tree's bg -> panel
Rename Tree's bg_focus -> focus
Rename ScrollContainer's bg -> panel
Rename FileDialog's *_icon_modulate -> *_icon_color
Rename FileDialog's files_disabled -> file_disabled_color
Rename CheckButton's on/off -> checked/unchecked
Rename check_v_adjust -> check_v_offset
2022-09-06 22:53:17 +03:00
Micky 9c9c5f662f Rework AnimatedTexture's `fps` into `speed_scale`
`fps` has been turned into `speed_scale`. It now affects the scale of the entire animation. If `speed_scale` is a negative value, the animation is played in reverse.

`frame_n/delay_sec` has been renamed to `frame_n/duration` _(prefixes exist, making the previous name redundant)_.

Setters and getters, documentation updated, too.
2022-09-06 21:40:09 +02:00
Micky dd26ecdd31 Rename CONNECT_ONESHOT TO CONNECT_ONE_SHOT
For consistency. Every other exposed `one_shot` is spaced out like this.
2022-09-06 19:00:33 +02:00
Micky 6dbd283ae5 Rename every instance of `caret_blink_speed` to `caret_blink_interval`
It's been changed in EditorSettings, LineEdit, TextEdit.

Affects setters and getters, and passed parameters, too.
2022-09-06 18:37:17 +02:00
Rémi Verschelde 0c4d578bdf
Merge pull request #65194 from Mickeon/rename-one-shot 2022-09-06 18:32:48 +02:00
Vitika9 1dce43d417 ColorPicker UX improvements
- Tabs and MenuButton for mode selection and enabling/disabling colorized sliders
- MenuButton for shape selection with new icon for each shape
- Drag and drop functionality for presets to arrange order
- A chronological list of recently selected presets which are global for the editor
- Presets are now highlighted as being active or inactive
- Thicker sliders for easy targeting
- `grabber_offset` theme constant for Slider
- Uncolorized sliders
2022-09-06 21:42:20 +05:30
Rémi Verschelde 5fb84e5702 Merge pull request #64661 from Mickeon/rename-tilemap-world
Rename TileMap/GridMap.`world_to_map` and opposite to `local_to_map`
2022-09-06 17:01:16 +02:00
Rémi Verschelde 49d18f0725 Merge pull request #65423 from YeldhamDev/i_want_to_ride_my_bycicle
Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()`
2022-09-06 17:00:58 +02:00
Rémi Verschelde adaec8396e Merge pull request #64880 from Mickeon/rename-camera-position
Rename Camera2D's `*_screen_center` and `*_position` to `get_screen_center_position` and `get_target_position`
2022-09-06 17:00:52 +02:00
Rémi Verschelde 5062aafc2d Merge pull request #64417 from aaronfranke/has-space
Replace AABB/Rect2/Rect2i has_no_* methods with has_* methods
2022-09-06 17:00:44 +02:00
Rémi Verschelde f40755383e Merge pull request #65361 from Mickeon/rename-range-lerp
Rename `range_lerp` to `remap`
2022-09-06 17:00:37 +02:00
Rémi Verschelde 1a1fdf78e7 Merge pull request #65367 from Mickeon/fix-audio-stream-player-exiting-tree
Fix AudioStreamPlayer not resuming after returning to SceneTree
2022-09-06 17:00:29 +02:00
Michael Alexsander 9507e91c07 Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()` 2022-09-06 10:51:14 -03:00
Micky b6daad8d4b Rename `range_lerp` to `remap` 2022-09-06 07:19:20 +02:00
Yuri Rubinsky 30395410f0 Add compatibility class for `VisualShaderNodeFloatUniform` 2022-09-06 08:04:46 +03:00
Micky 694190a354 Rename TileMap/GridMap.`world_to_map` and opposite to `local_to_map`
For both TileMap and GridMap:
- `world_to_map` -> `local_to_map`
- `map_to_world` -> `map_to_local`

Also changes any mention of "world" in this context to "local" to avoid future confusion.

Finally, updates the docs of both methods for consistency.
In particular, adding a note on how to convert the returned values from local to global coordinates and vice versa.
2022-09-05 18:08:39 +02:00
Micky a7ce7b1d3f Fix AudioStreamPlayer not resuming after returning to SceneTree 2022-09-05 16:52:46 +02:00
Rémi Verschelde 904d8bdb3c
Merge pull request #65292 from AlmightyLaxz/prevent-shapecast3d-debug-without-debugcollisions 2022-09-05 13:59:51 +02:00
Rémi Verschelde b5c053321c Merge pull request #64840 from maximkulkin/graph-edit-node-selection
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 08:36:10 +02:00
Maxim Kulkin 9a35ede23f Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit 2022-09-05 02:32:06 -04:00
Rémi Verschelde 1499840f75 Merge pull request #65028 from groud/fix_split_container
Improve SplitContainer behavior, keeping asked split position whenever possible
2022-09-05 08:30:11 +02:00
Aaron Franke 995b9f94e8
Replace Rect2(i) has_no_area with has_area 2022-09-04 23:03:36 -05:00
MinusKube f5a808192b Prevent windows from having a size greater than device limit 2022-09-04 22:48:54 +02:00
Rémi Verschelde e7a0a97c0b
Merge pull request #65299 from paddy-exe/linear-depth-disable-output-preview
Disable Output port preview of Visual Shader nodes using SpatialShader specific built-ins
2022-09-04 16:30:10 +02:00
Haoyu Qiu f0f24b9a62 Fix crash when executing `LightmapGIData._set_light_textures_data` 2022-09-04 20:43:25 +08:00
Patrick e3ee2a0a6e Disable Output port preview of Linear Depth Visual Shader node
This disables the output port preview of the node because it's enabled preview caused a shader compilation error
2022-09-03 22:36:37 +02:00
Almighty Laxz 44042a957f Stop ShapeCast3D drawing when debug collisions off 2022-09-04 02:28:30 +09:30
Rémi Verschelde a653801b17
Merge pull request #65285 from YuriSizov/window-theme-change-is-imminent
Un-defer the initial theme changed notification in `Window`
2022-09-03 18:23:45 +02:00
Yuri Sizov 41eabca0fb Un-defer the initial theme changed notification in Window 2022-09-03 14:55:13 +03:00
Xwdit f350356183 Some improvements to the SceneTreeTimer 2022-09-03 11:44:11 +02:00
Nathan Franke 82d2a97a83
prefix shader parameters with "shader_parameter/" 2022-09-02 20:41:00 -05:00
Rémi Verschelde 597bc949a4 Merge pull request #65250 from YuriSizov/theme-owner-rises 2022-09-02 23:20:49 +02:00
Rémi Verschelde 77ca96fd73 Merge pull request #59589 from Calinou/rename-or-lesser-range-property-hint 2022-09-02 23:13:20 +02:00
Yuri Sizov 8b128081e8 Un-defer the initial theme changed notification
Co-authored-by: Rindbee <idleman@yeah.net>
2022-09-02 23:44:23 +03:00
Yuri Sizov ddc55ef746 Add ThemeOwner type for managing theme propagation and lookup 2022-09-02 23:44:23 +03:00
Rémi Verschelde 33b4153764
Merge pull request #64917 from Tim-Fronsee/fix/add-gutter-total-width 2022-09-02 20:52:11 +02:00
Gilles Roudière 2ddda13339 Improve SplitContainer behavior, keeping asked split whenever possible 2022-09-02 20:48:50 +02:00
Hugo Locurcio f7292dbeb3
Rename `or_lesser` range property hint to `or_less`
"less" should be used for quantity, rather than "lesser".

Existing scripts that use `or_lesser` in `_get_property_list()`
will need to be updated to account for this change.
2022-09-02 19:08:20 +02:00
Yuri Rubinsky 1241c4b6ba Revert usage of typed array in `add_surface_from_arrays` parameters 2022-09-02 18:08:43 +03:00
Rémi Verschelde 6ccbc27093
Merge pull request #64735 from KoBeWi/viewportshifter 2022-09-02 15:42:42 +02:00
Rémi Verschelde 3a62c294c7 Merge pull request #65170 from KoBeWi/your_argument_is_TypedArray 2022-09-02 13:57:02 +02:00
Rémi Verschelde 4fa3675ffa Merge pull request #65218 from xX-Void-Xx/area2d/3d-optimization 2022-09-02 13:53:28 +02:00
Rémi Verschelde fe2cf6e406 Merge pull request #65210 from YuriSizov/control-customizable-cache-p3 2022-09-02 13:51:52 +02:00
Rémi Verschelde c82bbc38a5 Merge pull request #64952 from Chaosus/vs_rename_uniform_to_param 2022-09-02 13:49:53 +02:00
Void fdfe11d4b3 fixed and optimized Area2/3D get_overlapping_bodies/areas
fixed a type and made it so area3d get_overlapping_x is similar to its counterpart func in area2d so that it uses TypedArray instead of Array and ERR_FAIL_COND_V_MSG instead of no message, also minimized array resize calls
2022-09-02 12:00:04 +01:00
Yuri Sizov fc7cef8dec Fix theme propagation in various parts of the editor 2022-09-02 13:18:31 +03:00
Rémi Verschelde 57a163405a Merge pull request #65225 from Rindbee/fix-reparent-from-window-issue 2022-09-02 08:45:29 +02:00
Rémi Verschelde 5a136ee490 Merge pull request #64724 from KoBeWi/HVBoxContainer 2022-09-02 08:44:42 +02:00
Jonathan Nicholl 15d057c521 Add `is_zero_approx` methods to `Vector2`, `3`, and `4` 2022-09-02 00:29:50 -04:00
Rindbee 621b9a1bfe Fix getting an error message when repeatedly entering and exiting the tree 2022-09-02 10:48:20 +08:00
Rémi Verschelde c6fd311da0 Fix build after merge of #63479 2022-09-02 00:19:33 +02:00