Commit Graph

25965 Commits

Author SHA1 Message Date
Rémi Verschelde 409de53e72
Merge pull request #35423 from Faless/fix/object_emit_free
Make sure we know when deleting an emitting object
2020-01-22 14:52:54 +01:00
Fabio Alessandrelli 41f59ecfca Make sure we know when deleting an emitting object
We used a lock signals in the signal_map while emitting, because it was
not allowed to disconnect them while being emitted.
We used that lock to check if we where deleting an object during signal
emission.
Now that we allow to disconnect signals while they are being emitted, if
an object first disconnects, then gets deleted we can't know that a
signal was being emitted during the destructor.

This commit adds a new `_emitting` boolean member to Object to be set
while emitting and checked in the destructor, while removing the old
signal lock which is now unused.
2020-01-22 14:08:16 +01:00
Rémi Verschelde 829d21f1c2
Merge pull request #35352 from Feniks-Gaming/BetterDictionary
Improve dictionary description
2020-01-22 13:20:41 +01:00
Rémi Verschelde ff7e7bd260 Thread: Fix typo in destructor error message 2020-01-22 11:17:20 +01:00
Rémi Verschelde 7e76a67d1e
Merge pull request #35430 from BastiaanOlij/fix_vr_joystick_id
Incorrect joystick id was returned on an inactive ARVR controller
2020-01-22 08:48:28 +01:00
Bastiaan Olij 5cf9f4faeb Incorrect joystick id was returned on an inactive ARVR controller 2020-01-22 18:27:32 +11:00
Rémi Verschelde eefeff23e9
Merge pull request #35404 from Calinou/update-changelog-3.2
Update CHANGELOG.md for Godot 3.2
2020-01-22 08:26:10 +01:00
Rémi Verschelde de543d18e8
Merge pull request #35389 from clayjohn/DOCS-materials
Finish up docs for materials
2020-01-22 07:41:33 +01:00
Rémi Verschelde 2ee15f650e
Merge pull request #35425 from timothyqiu/assetlib-import-leak
Fixes leak when importing zip in AssetLib
2020-01-22 07:40:50 +01:00
Rémi Verschelde 7c632968b2
Merge pull request #35419 from Calinou/project-manager-loading-placeholder
Use a loading placeholder for project icons in the project manager
2020-01-22 07:29:21 +01:00
clayjohn f2ece82480 Finish up docs for materials 2020-01-21 19:28:32 -08:00
Haoyu Qiu a7368a519e Fixes leak when importing zip in AssetLib 2020-01-22 09:34:18 +08:00
Hugo Locurcio 56aae0e8bc
Use a loading placeholder for project icons in the project manager
Now that projects are loaded asynchronously, some projects in the
list may be displayed before their icon is done loading. This is
especially common on slower hardware.

In such cases, this makes the project manager display a loading
placeholder instead of the default project icon.
2020-01-21 22:56:19 +01:00
Rémi Verschelde 5127afa812
Merge pull request #35413 from akien-mga/if-0-means-couperet
Remove unused #if 0'ed code
2020-01-21 22:27:50 +01:00
Rémi Verschelde 6190690757
Merge pull request #35411 from akien-mga/greater-font-sizes-for-everyone
Allow greater values for DynamicFont size property
2020-01-21 21:45:52 +01:00
Rémi Verschelde 4faaf6089a Remove unused #if 0'ed code 2020-01-21 21:41:54 +01:00
Rémi Verschelde 79aaafc686
Merge pull request #35408 from Faless/ws/fix_packet_count
Fix MultiplayerAPI crash when peer implementation misbehave.
2020-01-21 21:06:11 +01:00
Rémi Verschelde 0be64da008 Allow greater values for DynamicFont size property
See https://github.com/godotengine/godot/issues/22581#issuecomment-576836691.

Not using `or_greater` as there *is* a max size value that the current
implementation can accept. If using e.g. size 6000 with
FiraSans-Regular.ttf, errors are printed due to failing asserts on a
glyph size that should be within 4096x4096 px.
2020-01-21 20:59:16 +01:00
Fabio Alessandrelli 50f1b035b8 Fix MultiplayerAPI crash when peer impl misbehave.
Also fix WebSocketMultiplayer::get_available_packet_count() return value
when peer is not configured to use the multiplayer API.
2020-01-21 20:46:32 +01:00
Ignacio Roldán Etcheverry 24960e2254
Merge pull request #35407 from neikeq/issue-27285
Add dummy preprocessor for the C# script class parser
2020-01-21 20:39:23 +01:00
Ignacio Etcheverry d53c15b12c Make script class parser errors to not abort the build
As our script class parser is error prone, we should not impede the build from continuing because of a parsing error.
This should be reverted in the future once we switch to Roslyn.
2020-01-21 20:07:26 +01:00
Ignacio Etcheverry 378fc592b1 Add dummy preprocessor for the C# script class parser
No attempts are made at conditional compilation. The main if branch is always assumed to be true.
2020-01-21 19:57:38 +01:00
Hugo Locurcio a60d70bc9d
Update CHANGELOG.md for Godot 3.2 2020-01-21 19:17:01 +01:00
Rémi Verschelde d4ac0ca153
Merge pull request #35393 from YeldhamDev/plugin_script_syntax
Make script made via plugin creation obey syntax settings
2020-01-21 13:21:01 +01:00
Rémi Verschelde 423f15262f
Merge pull request #35399 from ericrybick/35367-signals-dock-size-jumps-when-selecting-nodes
Clip text in NodeDock toolbuttons to prevent dock size changes
2020-01-21 11:18:35 +01:00
Eric Rybicki 371b5a450a Clip text in NodeDock toolbuttons to prevent dock size changes
Fixes #35367
2020-01-21 10:23:09 +01:00
Rémi Verschelde 4bc98c105d
Merge pull request #35394 from ericrybick/fix-assetlib-thumbnail-overlay-
Fix asset library video play overlay not being centered on the thumbnail
2020-01-21 08:20:35 +01:00
Rémi Verschelde a948782110
Merge pull request #35385 from akien-mga/bullet-prevent-div-by-zero
Bullet: Prevent potential division by zero
2020-01-21 08:13:53 +01:00
Rémi Verschelde 77f04ec52a
Merge pull request #35390 from timothyqiu/find-in-files-leak
Fixes leak in Find in Files utility
2020-01-21 08:09:07 +01:00
Eric Rybicki 99346e9654 Fix asset library video play overlay not being centered on the thumbnail 2020-01-21 08:04:32 +01:00
Michael Alexsander 3a0dc52127 Make script made via plugin creation obey syntax settings 2020-01-21 02:05:56 -03:00
Haoyu Qiu 3042b4f4cb Fixes leak in Find in Files utility 2020-01-21 08:47:59 +08:00
Rémi Verschelde 41b21dee01 Bullet: Prevent potential division by zero
Fixes #33715.
2020-01-21 00:20:57 +01:00
Rémi Verschelde 1508cc4051
Merge pull request #35363 from ericrybick/33106-importing-textureAtlas-cuts-out-the-sprites
Fix AtlasPacker ignoring semi-transparent pixels
2020-01-21 00:13:12 +01:00
Eric Rybicki 439e0027ec Fix AtlasPacker ignoring semi-transparent pixels
Fixes #33106
2020-01-20 22:43:38 +01:00
Feniks 6e24933115 Improve dictionary description
I improved dictionary description to ad some real life examples and expand on it a little bit so person who never seen dictionary can understand it better seeing them for a first time here. 
I also added note about the way to compare dictionaries  as it can catch people of guard because common assumption is that it works the same as comparing Arrays when it does not.
2020-01-20 20:36:59 +00:00
Rémi Verschelde b711c09bc8 Revert "Fix audio capture naming in Javascript"
This reverts commit 69f7263cd8.

Follow-up to #35359.
2020-01-20 21:35:19 +01:00
Rémi Verschelde 709665b15d
Merge pull request #35379 from dankan1890/quick_fix
TextureRegionEditor: Corrected typo
2020-01-20 21:34:02 +01:00
dankan1890 a2170dcd40 TextureRegionEditor: Corrected typo 2020-01-20 20:58:42 +01:00
Rémi Verschelde ad8819ca61
Merge pull request #35369 from YeldhamDev/editor_path_clip
Clip text in EditorPath button to avoid dock size changes
2020-01-20 20:00:10 +01:00
Rémi Verschelde 3829660ec0
Merge pull request #35372 from neikeq/issue-29523
Mono/C#: Fix error when parsing nested generics
2020-01-20 19:57:23 +01:00
Ignacio Etcheverry e4330e33e6 Mono/C#: Fix error when parsing nested generics
Also fixed the editor not including the parse error message in the error.
2020-01-20 19:08:08 +01:00
Michael Alexsander 324fe76afd Clip text in EditorPath button to avoid dock size changes 2020-01-20 14:25:27 -03:00
Yuri Roubinsky fa638a290f
Merge pull request #35362 from Chaosus/fix_vs_recursion
Forbid recursive connections in visual shader
2020-01-20 18:46:27 +03:00
Yuri Roubinsky a8ab4e3357 Forbid recursive connections in visual shader 2020-01-20 18:15:45 +03:00
Rémi Verschelde cfeba2c899
Merge pull request #35359 from akien-mga/revert-30648-unsafe-audioserver
Revert "Exposes capture methods to AudioServer + documentation" #30468
2020-01-20 13:40:45 +01:00
Rémi Verschelde 837adb30fd Revert "Exposes capture methods to AudioServer + documentation" #30468
Reverts the following commits:

- c81ec6f26d40b70283958a4ef3e216fb32cbaf14:
  "Exposes capture methods to AudioServer, variable renames for
  consistency, added documentation."
- 47c558b98abf842910c780294314326662410cdf:
  "Expose audio callbacks as signals."
- dabaa11b3c451e9b8f2cca7e563bd9ec51edb169:
  "Fix to make sure the capture buffers are deallocated at shutdown.
  Silences warnings."

Some documentation improvements were kept for pre-existing methods.

See rationale for reverting these changes in #30468.
2020-01-20 13:18:01 +01:00
Rémi Verschelde c3fd1012de
Merge pull request #35351 from ericrybick/32342-Resize-snapping-lines-bug
Fix editor drawing snapping lines for wrong edge/corner when resizing elements with smart snapping enabled
2020-01-20 12:57:44 +01:00
Rémi Verschelde 601500168d
Merge pull request #35357 from akien-mga/makerst-default-values-code
makerst: Use code markup for default values/overrides
2020-01-20 12:57:09 +01:00
Rémi Verschelde c0595206dd makerst: Use code markup for default values/overrides
Fixes godotengine/godot-docs#3071.
2020-01-20 12:38:08 +01:00