Commit Graph

7473 Commits

Author SHA1 Message Date
lawnjelly c7d9c3b21f Fix uninitialized data reads in Input
Found by Valgrind.

(cherry picked from commit d60eae3dbc)
2022-09-09 14:35:08 +02:00
lawnjelly 1c6467c6e4 FlowContainer fix uninitialized data
This uninitialized data was finding its way into the renderer.

(cherry picked from commit fa4a325180)
2022-09-09 14:29:43 +02:00
Michael Alexsander a65247a405 Fix some corner cases in the `Menu/OptionButton` item auto-highlight
(cherry picked from commit 1e80b17a8d)
2022-09-05 15:46:06 +02:00
Michael Alexsander 4744a8a1a9 Make `Menu/OptionButton` item auto-highlight behave better
(cherry picked from commit 50506e19a6)
2022-09-05 15:45:54 +02:00
fabriceci 6029200662 Hack as a hot fix for Bullet's collision margin issue
(cherry picked from commit b3210c5cd6)
2022-08-30 11:48:24 +02:00
Michael Alexsander 08844b6143 Fix `ItemList` selection visual when the scrollbar visibility changes
(cherry picked from commit e298144a41)
2022-08-30 11:21:19 +02:00
Yuri Sizov d92b207189 Backport fixes to documentation for paths, curves and navigation servers
(cherry picked from commit 39f46613bb)
2022-08-30 11:20:03 +02:00
Cory Petkovsek 92eab47591 Fix free(RID) abuse by various classes
(cherry picked from commit f7f112ab1f)
2022-08-30 11:18:02 +02:00
Michael Alexsander 682428279a Expose `set/get_tab_button_icon()` to scripting
(cherry picked from commit 73470e1b16)
2022-08-30 11:16:01 +02:00
Haoyu Qiu 9f4bb53a87 Improve documentation for `get_animation()`
(cherry picked from commit fed2879463)
2022-08-30 11:15:24 +02:00
smix8 1309633cdb Fix NavigationObstacle nodes not registering to default navigation map
Fix NavigationObstacle nodes not registering to default navigation map.

(cherry picked from commit 47b39ce4c2)
2022-08-30 11:14:32 +02:00
Atlinx 9f6c64135c Remove HDR warning if on low end
(cherry picked from commit e3b3462187)
2022-08-30 11:13:54 +02:00
Michael Alexsander 5becfce603 Fix crash when pressing up on an empty `PopupMenu`
(cherry picked from commit f0d380c9fd)
2022-08-30 11:12:23 +02:00
bruvzg 2678fd8202 Fix color modulation of the grayscale glyphs in font with mixed color / grayscale data.
(cherry picked from commit 4d0c0f3ffa)
2022-08-29 17:10:27 +02:00
Olivier Bombardier cd6764611c Fix has_filter of AnimationNode not being called in scripts
(cherry picked from commit c988deb3b1)
2022-08-29 17:09:40 +02:00
Haoyu Qiu e8a9d77e4b Tree: Don't draw selection background of individual cells in Row mode
(cherry picked from commit 4c47c6ab75)
2022-08-29 17:06:00 +02:00
SnailRhymer 6426f2e9c7 Change code folding behavior to include terminal indented comments
Previously, when folding a block of code that finished with an indented comment (i.e. one indented as much as or more than the starting indent of the code), that comment would be left out of the fold. Change the behavior to include such comments, but still leave less-indented ones out.

(cherry picked from commit efed5087ae)
2022-08-29 17:05:09 +02:00
kleonc 2f0577fb0f AnimatedSprite Fix updating inspector when SpriteFrames is modified
(cherry picked from commit 8ae246f15e)
2022-08-08 13:34:05 +02:00
Josh Jones 61e28c28cd Fix typo when setting NavigationRegion travel_cost
(cherry picked from commit 8c324132d0)
2022-08-08 13:18:43 +02:00
smix8 a6b75da78c Fix TileMap error msg when optional navigation node is not set
Fixes TileMap error msg spam when bake_navigation=true but the optional and depr navigation node is not set.

(cherry picked from commit 30d4555c65)
2022-08-06 22:23:01 +02:00
Haoyu Qiu 9d923764c9 Fix crash when executing `AnimationTreePlayer.are_nodes_connected` 2022-08-01 23:36:12 +08:00
Marcel Admiraal d000a5fa30 Ensure changes to Camera2D's limits don't affect smoothed_camera_pos 2022-07-28 15:30:34 +01:00
Marcel Admiraal a124d89f01 When Camera2D enters tree, ensure first update is not lost 2022-07-28 15:30:06 +01:00
Rémi Verschelde 818f1eed31 Code quality: Fix header guards consistency
Adds `header_guards.sh` bash script, used in CI to validate future
changes. Can be run locally to fix invalid header guards.
2022-07-25 14:53:37 +02:00
Rémi Verschelde be5051422b Revert "Call update_scrollbars() in sort_children() so the max is set properly so you can set scroll_container.scroll_vertical instantly after adding children to a scroll container."
This reverts commit b73d2980b7.

This caused a regression. Fixes #63417.
2022-07-25 11:29:33 +02:00
lawnjelly d4dc7c4b32 Portals - Allow more logging to be disabled
Some logging messages were still being issued when portals/debug/logging was false. This could be annoying in games that stream in parts of levels and repeatedly call `rooms_convert()`.

This PR allows all but essential logging to be disabled.
2022-07-24 13:44:59 +01:00
Jason Knight b73d2980b7 Call update_scrollbars() in sort_children() so the max is set properly so you can set scroll_container.scroll_vertical instantly after adding children to a scroll container. 2022-07-21 12:25:50 -06:00
kleonc 558b96f1b1 Fix `CanvasItem` not exiting its canvas group on canvas exit 2022-07-20 12:49:38 +02:00
Rémi Verschelde 33b5709d53
Merge pull request #61601 from Haydoggo/path-follow-fix-3.x 2022-07-18 09:36:22 +02:00
Rémi Verschelde 5aa22a21be
Merge pull request #63058 from AaronRecord/backport-global-position-rotation 2022-07-18 09:33:23 +02:00
Rémi Verschelde 090d9f6d25
Merge pull request #63084 from madmiraal/fix-56336-3.x 2022-07-18 09:31:58 +02:00
Yuri Rubinsky 229bfc8f2d Fix invalid code generation when using `VisualShaderNodeUniformRef` 2022-07-17 12:41:24 +03:00
Marcel Admiraal 162cb5748a Update camera position when updating camera limit 2022-07-17 09:02:34 +01:00
Marcel Admiraal fb4e1d2d02 Set initial SceneTree processes times to 0.0 2022-07-17 09:02:20 +01:00
foxydevloper 5238740fef Add global_translation and global_rotation to Spatial 2022-07-15 21:39:35 -06:00
Hayden e05f969adb Fix crash on NaN offset in path_follower 2d and 3d 2022-07-14 14:30:24 +12:00
Rémi Verschelde 66c4047a6c SpriteFrames: Sort animations alphabetically
Fixes #62143.
2022-07-13 15:48:55 +02:00
Thakee Nathees da626d8922 Fix FileDialog file name autocompletion with filters
Fixes #38195.

(cherry picked from commit 446f1b7052)
2022-07-06 11:39:04 +02:00
Haoyu Qiu d86a2d57cf Fix LineEdit caret after using arrow key to deselect 2022-07-06 09:32:39 +08:00
bruvzg 7f562030be
Use custom key struct, instead of raw hashes for the Label3D cache to avoid potential hash collisions. 2022-07-04 09:46:38 +03:00
reduz 995281ca90 Fix editor-only visibility for lights
* Update visibility again for editor-only lights if owner changes.

Fixes #26399, supersedes #52327

(cherry picked from commit d69e3791bf)
2022-07-03 03:21:51 +02:00
Rémi Verschelde df70aa1772
Merge pull request #57566 from Calinou/viewport-shadow-atlas-clamp-sizes 2022-07-03 03:08:03 +02:00
Rémi Verschelde 3d19f21576
Merge pull request #49967 from Calinou/viewport-2d-hdr-print-warning 2022-07-03 02:41:26 +02:00
Rémi Verschelde 86229d0b03
Merge pull request #54239 from Calinou/editor-directionallight-3d-only-show-relevant-properties-3.x
Only show relevant properties in the DirectionalLight inspector (3.x)
2022-07-03 02:02:10 +02:00
saneery cb94797ce4 Add process_mode property to InterpolatedCamera 2022-07-03 01:47:10 +02:00
hilfazer fe21fb175c print_stray_nodes() also prints node's script 2022-07-03 01:00:58 +02:00
kobewi 14f69acaa4 Fix find_next_valid_focus() freeze
(cherry picked from commit 8d62b736b2)
2022-07-01 14:00:55 +02:00
kobewi f659869a45 Fix find_next_valid_focus() freeze
(cherry picked from commit d9ede52ded)
2022-06-30 19:23:01 +02:00
smix8 381e8dd278 Group NavigationAgent properties
Groups the ill-defined NavigationAgent properties between pathfinding and avoidance to make it more clear which property affects what.

(cherry picked from commit dde09be302)
2022-06-30 19:23:01 +02:00
ConteZero a13b3028a2 Add an option to drag'n'drop selected text in TextEdit
(cherry picked from commit 5d56efcaa4)
2022-06-30 19:23:01 +02:00
smix8 fcff804844 Implement NavigationMesh bake area
Adds two new properties to NavigationMesh resources to restrict the navmesh baking to an area enclosed by an AABB with volume.

(cherry picked from commit 0c4d99f4fd)
2022-06-23 16:17:43 +02:00
needleful eb99c7243e Apply baked ambient light settings when baking lights with scene environment 2022-06-21 12:12:47 -07:00
Rémi Verschelde 3c35617c50
Merge pull request #62187 from smix8/nav_nodes_depr_3.5 2022-06-20 18:36:17 +02:00
smix8 693aeaf799 [3.5] Mark Navigation/Navigation2D nodes as deprecated
Mark Navigation/Navigation2D nodes as deprecated. They already just redirect calls to the NavigationServer and have no longer a real purpose. In Godot 4.0 both nodes are already removed for good reasons.
2022-06-20 17:37:55 +02:00
smix8 88e42b2915 Add NavigationAgent desired path distance
Add NavigationAgent desired path distance

(cherry picked from commit 07740302f3)
2022-06-20 15:11:09 +02:00
Rémi Verschelde 0cb897421a Node: Rename `child_exited_tree` to `child_exiting_tree`
The name was confusing as this signal is emitted around the same time as
`tree_exiting` and `NOTIFICATION_EXIT_TREE`, i.e. while the child node is
still in tree.

Fixes #59210.

(cherry picked from commit 3e6de687b8)
2022-06-20 15:00:09 +02:00
Rémi Verschelde 4137578369 Fix typos with codespell
Using codespell 2.2-dev from current git.

Fix a couple incorrect uses of gendered pronouns.
2022-06-19 13:48:15 +02:00
kleonc e55ba60da1 Fix `CPUParticles2D.emission_shape` enum hint 2022-06-18 16:07:34 +02:00
smix8 c6f9627c74 [3.5] Add NavigationAgent2D/3D set_navigation_map() function
Add NavigationAgent2D/3D set_navigation_map() function. Also fixes some bugs from leftover code before the backport update.
2022-06-16 19:25:52 +02:00
Rémi Verschelde 4e7363cac7
Merge pull request #61996 from smix8/navigation_bp_update_3.x
[3.5] Update NavigationServer backport
2022-06-16 00:17:16 +02:00
Rémi Verschelde 0c5c5381d7
Merge pull request #61980 from KoBeWi/obliterate_scroll
Disable scroll when dragging at edges of TextEdit
2022-06-14 23:47:17 +02:00
kobewi 053fdb8872 Disable scroll when dragging at edges of TextEdit 2022-06-14 23:36:54 +02:00
smix8 8bd7c6188b [3.5] Update NavigationServer backport
Backports features and bugfixes from current Godot 4.0 to 3.5 and brings functions and codebase of both version largely in sync to make tutorials more compatible and future backports easier.
2022-06-14 05:55:14 +02:00
Rémi Verschelde 606ec57d2c
Merge pull request #61985 from bruvzg/win_net_share3
[Windows, 3.x] Add support for handling network share paths.
2022-06-13 09:16:13 +02:00
bruvzg 64a107508a
[3.x] Improve RTL table fill. 2022-06-13 09:57:35 +03:00
bruvzg 11a7997a67 [Windows, 3.x] Add support for handling network share paths. 2022-06-13 09:24:35 +03:00
Rémi Verschelde 0b048b6d73 SoftBody: Fix attachments property names after #61180
Fixes #61581.

(cherry picked from commit 5c3081dae2)
2022-06-10 14:42:05 +02:00
Rémi Verschelde 4987cd43bf
Merge pull request #61346 from AaronRecord/fix-scrollbars-initializing 2022-06-10 14:24:27 +02:00
Rémi Verschelde a9e966c319
Merge pull request #61544 from lawnjelly/vis_notifier_max_dist
VisibilityNotifier - add max_distance feature
2022-06-10 10:57:53 +02:00
Rémi Verschelde 5c4e95e6e5
Merge pull request #61844 from smix8/navigation_default_navmap_3.x 2022-06-10 09:48:47 +02:00
smix8 96d98d8c4e Backport default World navigation maps
Backports default navigation maps created with each World or World2D.
2022-06-09 14:05:39 +02:00
lawnjelly 0c5a424f65 VisibilityNotifier - add max_distance feature
Enables turning off objects by distance to the camera in addition to testing whether they are in the view frustum.
2022-06-09 11:37:42 +01:00
smix8 e629622598 Remove slash delimiter from NavigationMesh properties
Remove slash delimiter from NavigationMesh properties.

(cherry picked from commit 2c059dcfcb)
2022-06-09 10:31:57 +02:00
smix8 c111d6b621 Expose get_mesh() for NavigationPolygon Resources
Expose get_mesh() for NavigationPolygon Resources.

(cherry picked from commit 8bcce0ebb2)
2022-06-09 10:09:46 +02:00
smix8 106bf9b793 Add NavigationMesh debug when navmesh is added later through scripts
Add NavigationMesh debug when navmesh is added later through scripts

(cherry picked from commit b6eff47bac)
2022-06-09 10:08:55 +02:00
Rémi Verschelde e9ca65207e
Merge pull request #61822 from smix8/tilemap_texture_offset_fix_3.5 2022-06-08 22:46:04 +02:00
smix8 3aa05b7b67 [3.5] Fix TileMap texture offset for navigationmesh and collisionshapes
[3.5] Fix TileMap texture offset for navigationmesh and collisionshapes
2022-06-08 19:30:52 +02:00
bruvzg f5fa1ca944
Add readable export errors. Add RTL image vertical alignment support. 2022-06-08 17:56:28 +03:00
Rémi Verschelde 6ec7e2c230
Merge pull request #61729 from lawnjelly/faster_mesh_merging
Optimized Mesh Merging
2022-06-08 07:10:32 +02:00
lawnjelly 1d870403b2 Optimized Mesh Merging
Changes from PoolVector to LocalVector and pre-reserving vectors rather than push_back.
2022-06-07 20:16:51 +01:00
Rémi Verschelde 70951b3a9c
Merge pull request #61728 from YeldhamDev/always_clear_backport
[3.x] Take into account the clear icon's size even when not visible in `LineEdit`s
2022-06-07 14:16:32 +02:00
lawnjelly ba74643594 Force unsigned behaviour for bitfield enums
Some compilers (notably MSVC) were using signed values for bitfield enums. This was causing problems where 2 bits were used to store 4 or less enum values, where they were being treated as negative numbers.

This PR explicitly requests these enums to be treated as unsigned values.
2022-06-06 16:58:21 +01:00
Haoyu Qiu d043f91b79 Fix `Viewport.own_world` documentation
Also fixed the naming of the setter's parameter and made an `if` block
straightforward.
2022-06-06 21:34:36 +08:00
Rémi Verschelde e80dfb7b12
Merge pull request #61687 from YeldhamDev/double_hover_fix
Fix hover being drawn twice inside `PopupMenu`s
2022-06-06 13:17:25 +02:00
Michael Alexsander 43b0e054be Take into account the clear icon's size even when not visible in `LineEdit`s 2022-06-05 16:22:01 -03:00
Michael Alexsander b4e4f88cd9 Fix specific bug related to submenus in `PopupMenu` 2022-06-04 13:26:12 -03:00
Michael Alexsander 78fdebf8cc Fix hover being drawn twice inside `PopupMenu`s 2022-06-04 02:51:22 -03:00
Rémi Verschelde a6b27b526f
Merge pull request #60822 from lawnjelly/fti_add_child_reset 2022-06-03 14:56:19 +02:00
FireForge ea46f32246 Fix get_data() for GradientTexture2D 2022-05-31 23:19:25 -05:00
Rémi Verschelde b44928586b
Merge pull request #61483 from kleonc/popup-update-exclusive-when-shown
[3.x] Allow changing `exclusive` of already popped up `Popup`
2022-05-31 12:14:37 +02:00
Rémi Verschelde 51e52b5ed8
Merge pull request #61496 from timothyqiu/asymmetric-le-3.x
[3.x] Fix LineEdit clear button for asymmetric stylebox
2022-05-31 08:56:13 +02:00
bruvzg 553bdc6783
[3.x] Fix Label3D oversampling. 2022-05-30 09:05:41 +03:00
Haoyu Qiu 1e6747d185 Fix LineEdit clear button for asymmetric stylebox 2022-05-28 19:51:50 +08:00
kleonc 9ba598f94f Allow changing `exclusive` of already popped up Popup 2022-05-28 01:10:49 +02:00
kleonc 736b0c4e97 PopupMenu Fix hover stylebox overflowing horizontally 2022-05-27 23:35:17 +02:00
Hugo Locurcio 011ff93aa5
Tweak TextMesh decomposition error message to mention self-intersecting lines 2022-05-24 15:12:15 +02:00
Aaron Record ae9e523025 [3.x] Allow ScrollBar params of a ScrollContainer to be modified from _ready()
Cherrypicks b8610dbd31
2022-05-23 21:46:59 -06:00
Rémi Verschelde 88dba8e625 Fix typos with codespell
Using codespell 2.2-dev from current git.
2022-05-23 21:41:46 +02:00
bruvzg eb44e23ca3
[Label3D, 3.x] Monitor default theme font changes, to prevent use of invalid materials. 2022-05-23 18:16:17 +03:00
Rémi Verschelde b2cdc16a1d
Merge pull request #61281 from bruvzg/textmesh_3x
Backport TextMesh and expose dynamic font vector outlines
2022-05-23 16:16:40 +02:00