Commit Graph

366 Commits

Author SHA1 Message Date
Rémi Verschelde 39168f125e
Merge pull request #19464 from bojidar-bg/19448-fix-subproperty-handling
Fix bug in animationplayer editor not using subproperties properly
2018-07-26 10:31:05 +02:00
Hein-Pieter van Braam 0e29f7974b Reduce unnecessary COW on Vector by make writing explicit
This commit makes operator[] on Vector const and adds a write proxy to it.  From
now on writes to Vectors need to happen through the .write proxy. So for
instance:

Vector<int> vec;
vec.push_back(10);
std::cout << vec[0] << std::endl;
vec.write[0] = 20;

Failing to use the .write proxy will cause a compilation error.

In addition COWable datatypes can now embed a CowData pointer to their data.
This means that String, CharString, and VMap no longer use or derive from
Vector.

_ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug
builds. This is a lot faster for Vector in the editor and while running tests.
The reason why this difference used to exist is because force-inlined methods
used to give a bad debugging experience. After extensive testing with modern
compilers this is no longer the case.
2018-07-26 00:54:16 +02:00
Max Hilbrunner 9f82368d40
Merge pull request #19475 from YeldhamDev/animplayer_cosmetic
Minor changes to the AnimationPlayer editor
2018-07-05 04:25:04 +02:00
Max Hilbrunner 073e77454d
Merge pull request #19713 from volzhs/fix-crash-nodepath-animation-edit
Fix crash when assigning a node on editing animation key
2018-07-05 04:20:40 +02:00
khairul169 0f616ff5d8 Hide play position if animation node is invalid 2018-07-03 13:24:47 +07:00
Michael Alexsander Silva Dias 02181292b8 Minor changes to the AnimationPlayer editor. 2018-06-30 00:12:05 -03:00
volzhs b4f60ae3ac Fix crash when assigning a node on editing animation key 2018-06-22 14:48:49 +09:00
Guilherme Felipe b75ad7b6b0 Prevent animation player crash 2018-06-18 15:57:15 -03:00
Bojidar Marinov 7b107cb180
Fix bug in animationplayer editor not using subproperties properly
Fixes  #19448
2018-06-18 15:59:13 +03:00
Juan Linietsky 257d3c3f39 Bit more of visual polish 2018-06-08 21:03:27 -03:00
Juan Linietsky e5b876e92a Remove the "go back" behavior in track editor for inspector based key editing, fixes #19434, fixes #19423 2018-06-08 19:21:26 -03:00
Juan Linietsky 66871322b9 Properly update range and valid key range when keys are in/out of view, fixes #19433 2018-06-08 17:58:37 -03:00
Juan Linietsky c8289d95cd Fixed cursor not updating in some circumstances, closes #19430 2018-06-08 16:08:24 -03:00
Juan Linietsky 7572b31a39 Disallow via add track for animation player to animate itself, fixes #19425 2018-06-08 13:59:29 -03:00
Juan Linietsky 9cb17d7af8 Avoid animation length from ever being completely, fixes #19420 2018-06-08 13:42:45 -03:00
Juan Linietsky b659fd6d74 Entirely new (and much improved) animation editor. 2018-06-07 12:52:00 -03:00