95783f7bfc
Merge pull request #58415 from V-Sekai/cyclic_assignment_gdscript_fixes
2022-02-23 12:09:44 +01:00
849d34ba8e
Rename motion_velocity to velocity
2022-02-22 23:31:33 -08:00
b6aa4ed55d
Fixes cyclic detection from variables assigning themselves to themselves in autocomplete, and restricts initialization of variables from other variables which have not been declared above it in class body
2022-02-22 01:21:21 +00:00
cea0630fef
Fix typed arrays for Object based types
...
Fixes https://github.com/godotengine/godot/issues/53771 .
2022-02-19 16:27:06 +01:00
ae0026bc7b
Make 'is_attribute' false during parse error to prevent crash
2022-02-18 12:52:46 +00:00
bac8e451c0
Describe usage of float in range documentation
2022-02-18 00:59:22 +01:00
ab2a8bd1d8
Fix using typed arrays based on script classes
2022-02-17 17:34:53 +00:00
62d87fbd8b
Return a correctly typed variant in case of a function error to prevent hard crashes
2022-02-17 15:45:19 +00:00
657b9b6596
Fix local variables not showing when breaking on final line
2022-02-16 18:12:38 +00:00
6553f5c242
Convert _notification methods to switch - Chunk C
2022-02-16 13:03:05 -05:00
d45c3cdd1d
Fix error when assigning to an explicitly annotated variant from an ambiguous source
2022-02-16 13:25:27 +00:00
b68dd2e189
Add an XML schema for documentation
...
This makes it easier to spot syntax errors when editing the
class reference. The schema is referenced locally so validation
can still work offline.
Each class XML's schema conformance is also checked on GitHub Actions.
2022-02-15 00:03:31 +01:00
b396fd4eef
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 02:46:22 +01:00
dcf19f8914
Fix "Identifier not found" compiler error when accessing inherited signals or functions as callables.
2022-02-11 20:45:04 -05:00
317cd0b19a
Refactor some object type checking code with `cast_to`
...
Less stringly typed logic, and less String allocations and comparisons.
2022-02-08 10:08:34 +01:00
086256431a
[Net] Add type check to GDScriptRPCCallable.
...
It will print an error when using an RPC defined on an object which does
not extend Node.
2022-02-07 13:39:45 +01:00
994638da4f
[Net] Implement GDScript custom RPC callable.
2022-02-07 13:39:10 +01:00
6a56314eab
Merge pull request #57748 from fabriceci/rename-script-template-variable
2022-02-07 13:22:23 +01:00
e81ccaf270
rename jump force to jump velocity
2022-02-07 11:46:30 +01:00
a6e280c5de
Add some more fixes to visual shader
2022-02-07 11:28:42 +03:00
de45534fed
Highlight "namespace" as a GDScript keyword in the syntax highlighter
...
Like "trait" and "yield", "namespace" is currently not implemented
but is still reserved for future use.
2022-02-04 17:46:13 +01:00
89eb6d372d
Merge pull request #57591 from vnen/gdscript-enum-fixes
2022-02-04 13:49:15 +01:00
244db37508
Cleanup and move char functions to the `char_utils.h` header.
2022-02-04 11:35:01 +02:00
adbe948bda
String: Add contains().
2022-02-04 01:28:02 +05:45
ceafdf347e
GDScript: Treat enum values as int and enum types as dictionary
...
Since enums resolve to a dictionary at runtime, calling dictionary
methods on an enum type is a valid use case. This ensures this is true
by adding test cases. This also makes enum values be treated as ints
when used in operations.
2022-02-03 13:32:34 -03:00
b013c0d544
GDScript: Allow tests to run on release builds
...
- Fix compilation issues by disabling warnings on release builds. This
also strips warnings from expected result before the comparison to
avoid false mismatches.
- Add a `#debug-only` flag to tests. Must be the first line of the test
script. Those won't run with release builds. Can be used for test
cases that rely on checks only available on debug builds.
2022-02-03 13:32:33 -03:00
ad6e2e82a9
GDScript: Consolidate behavior for assigning enum types
...
This makes sure that assigning values to enum-typed variables are
consistent. Same enum is always valid, different enum is always
invalid (without casting) and assigning `int` creates a warning
if there is no casting.
There are new test cases to ensure this behavior doesn't break in
the future.
2022-02-03 13:32:16 -03:00
1d6ac42b2a
Allow setting the PropertyInfo class_name from GDScript
2022-02-01 11:57:14 +01:00
8e79c5fb8d
Add support for the escaped UTF-16 and UTF-32 Unicode characters in the scripts and expressions.
2022-01-30 20:16:04 +02:00
e6caaf4c80
Merge pull request #57205 from TechnoPorg/variant-template-cast
...
Allow method binds to take Object subclasses as arguments
2022-01-27 23:46:37 +01:00
899cd34426
Merge pull request #57281 from Rubonnek/rename-subsequence
2022-01-27 11:03:13 +01:00
3eb5e0ac50
Rename String::is_subsequence_ofi to String::is_subsequence_ofn
2022-01-26 18:03:56 -05:00
28ac4d8b7d
Fix crash with non-constant keys in match statement Dictionary pattern
2022-01-26 04:10:07 +08:00
051ef479c9
Allow method binds to take Object subclasses as arguments
...
This commit adds a condition to VariantCaster that casts Variants of type OBJECT to any type T, if T is derived from Object.
This change enables a fair bit of code cleanup. First, the Variant implicit cast operators for Node and Control can be removed, which allows for some invalid includes to be removed. Second, helper methods in Tree whose sole purpose was to cast arguments to TreeItem * are no longer necessary.
A few small changes also had to be made to other files, due to the changes cascading down all the includes.
2022-01-25 09:03:36 -07:00
b69b526b7c
GDScript cache crashfix.
2022-01-22 17:42:54 -08:00
e1706be25d
Merge pull request #57052 from KoBeWi/nosort
2022-01-23 00:27:01 +01:00
b5f524d4c0
Merge pull request #55433 from V-Sekai/prev_operand_nullptr_check
...
Check for nullptr expression in parse_precedence function
2022-01-22 20:31:45 +01:00
182a36db47
Merge pull request #55214 from Scony/fix-gdscript-crash-2
...
Fix GDScript parser crash on 'dollar mixed with assignment' expression
2022-01-22 20:30:54 +01:00
f056cb8ebc
Don't sort printed Dictionary
2022-01-22 13:45:02 +01:00
7b0ed2aa5e
Rename Variant::is_ref() to is_ref_counted()
2022-01-20 18:46:25 +01:00
846c14eee9
Merge pull request #56739 from strank/master
...
GDScript: Fix parsing default parameter values from function calls
2022-01-17 21:38:01 +01:00
4cfade6212
Merge pull request #55995 from Xwdit/enum_fix
...
Fix enum int comparison
2022-01-17 20:20:16 +01:00
91909ef801
Merge pull request #55625 from cdemirer/fix-type-guessing-and-gdscript-parser-printing
...
Fix `--test gdscript-parser` crash
2022-01-17 20:17:02 +01:00
12ab19fa26
Merge pull request #55616 from cdemirer/master
...
Fix nested ternary-if codegen
2022-01-17 20:16:26 +01:00
fffeecfd68
Improvments for SyntaxHighlighters
...
- Fix immedate Funcion in lamba highlight
- Highlight signals as one colour
- Highlight node paths as one colour
- Highlight escape chars in strings
2022-01-15 15:39:55 +00:00
3efa6644c4
Merge pull request #55541 from KoBeWi/outcognito_scripts
2022-01-14 21:04:13 +01:00
858bcd5058
Fix various typos
...
Found via `codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,expct,fave,findn,gird,hist,inh,inout,leapyear,lod,nd,numer,ois,ony,paket,ro,seeked,sinc,switchs,te,uint,varn,vew`
2022-01-13 23:20:01 -05:00
960a26f6c0
GDScript: Fix parsing default parameter values from function calls
2022-01-13 19:28:39 -05:00
f0382530a7
Merge pull request #56268 from KoBeWi/ 🚗 complete_setters
2022-01-13 12:40:48 +01:00
f524ddebd5
Make script type distinguishable by icon
2022-01-13 12:29:05 +01:00
64d8b3aef2
Assign member type when parsing setters to prevent
...
'Compiler bug: unresolved assign' errors
2022-01-11 11:23:17 +00:00
b3513cffc5
Merge pull request #56326 from NNesh/fix/unknown_default_value_callable
...
Extended the _make_arguments_hint function to get default values for function arguments in hint
2022-01-10 21:29:13 +01:00
374baff747
Fixed <unknown> text for callable default value for a function arguments hint
...
Format switch
Added a case for constant subscripts
Fixed default value hinting for the enum type
Removed is_null checking for value
Added a case for dictionary
2022-01-10 23:22:35 +05:00
49482966ec
Merge pull request #55715 from nathanfranke/enum-ordered
2022-01-10 17:19:52 +01:00
1989120d3f
Merge pull request #56194 from cdemirer/fix-operation-result-type-inference
2022-01-10 17:18:32 +01:00
4acc819f9b
Merge pull request #56232 from V-Sekai/invalid_explicit_variant_assign_fix
2022-01-10 17:12:56 +01:00
cc7f634066
Merge pull request #56260 from cdemirer/fix-type-mutation-upon-assignment-with-operation
2022-01-10 17:12:34 +01:00
c8b4fe3b8d
Merge pull request #56287 from cdemirer/fix-member-property-only-getter-cant-be-set
2022-01-10 17:12:06 +01:00
1fd5954962
Merge pull request #56288 from cdemirer/fix-member-property-getter-dont-update-subscript-chain-root
2022-01-10 17:10:57 +01:00
8f8c3f4b4c
Merge pull request #56342 from NNesh/fix/class-completion
2022-01-10 17:07:08 +01:00
b3d208385f
Merge pull request #56409 from cdemirer/fix-unexpected-copying-when-parameter-is-typed
2022-01-10 17:03:47 +01:00
609964848d
Fix leak when function returning self type
...
Leak is caused by cyclic reference
2022-01-10 02:14:48 +08:00
1a1ee43e3e
Fixed completion showing for class members
2022-01-08 01:49:18 +05:00
393a44b275
Merge pull request #55213 from Scony/fix-gdscript-crash
2022-01-06 20:54:03 +01:00
c69e0d16bc
Fix multiple missing UTF-8 decoding.
2022-01-06 14:35:22 +02:00
21cfcaa129
Add a GDScript template for `VisualShaderNodeCustom`
2022-01-06 12:06:33 +03:00
6d4ed65f4c
Merge pull request #56483 from vnen/gdscript-warning-annotation
...
Add annotation to ignore warnings
2022-01-05 09:05:56 +01:00
fd643c903d
GDScript: Add annotation to ignore warnings
2022-01-04 09:32:43 -03:00
fe52458154
Update copyright statements to 2022
...
Happy new year to the wonderful Godot community!
2022-01-03 21:27:34 +01:00
98b3ba1842
Merge pull request #53957 from fabriceci/new-template-workflow
2022-01-03 20:40:33 +01:00
3033e0f8a2
Fix gdscript-parser crash
...
Fixes gdscript-parser crashing while printing empty identifiers.
2022-01-03 08:47:18 +08:00
9d5b807059
Improve editor template workflow
...
Co-Authored-By: jmb462 <jmb462@gmail.com>
2022-01-02 21:52:09 +01:00
a124f1effe
Fix various typos
...
Found via ` codespell -q 3 -S ./thirdparty,*.po,./DONORS.md -L ackward,ang,ans,ba,beng,cas,childs,childrens,dof,doubleclick,expct,fave,findn,gird,hist,inout,leapyear,lod,nd,numer,ois,ony,paket,seeked,sinc,switchs,te,uint,varn`
Update editor/import/resource_importer_layered_texture.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update doc/classes/TileSetScenesCollectionSource.xml
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/gui/graph_edit.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/resources/animation.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Update scene/gui/rich_text_label.cpp
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Revert previously committed change
2022-01-02 01:03:58 -05:00
511e699fee
Fix unexpected Packed Array copying when parameter is typed
2022-01-02 05:43:52 +08:00
bb9469aa65
Fix member properties with getters don't update as subscript chain root
2021-12-28 07:52:44 +08:00
e8305e17ff
Fix member properties with only getters can't be set
2021-12-28 07:51:18 +08:00
c055c912fb
Remove autocomplete_setters_and_getters setting
2021-12-27 00:48:32 +01:00
067b4c8c07
Fix type mutation upon compound assignment
2021-12-27 03:32:22 +08:00
b22c805dbe
Fix 'Compiler bug: unresolved assign' on explicitly annotated variants.
2021-12-25 00:53:57 +00:00
455cc07f90
Fix operation result type inference
2021-12-23 20:45:24 +08:00
b5b75cad43
Use OrderedHashMap for enum_values
2021-12-16 21:49:42 -08:00
0430e26e6d
Fix enum int comparison
...
Fix enum int comparison
2021-12-16 16:14:14 +01:00
ab8119b5f6
Avoid a crash in the gdscript analyser
2021-12-14 15:54:25 +01:00
566895732c
Fix shadowed global identifier warning duplication
2021-12-13 11:54:23 +03:00
f19a1e28c8
Revert "Fix auto reload scripts on external change"
2021-12-10 22:40:20 +01:00
1cf3f382ba
Fix "Lookup Symbol" on global class members
...
"Lookup Symbol" on global class members now does switch to the relevant script.
2021-12-10 19:56:46 +08:00
bdf8340e59
Merge pull request #43181 from nathanfranke/string-empty
...
Replace String comparisons with "", String() to is_empty()
2021-12-10 08:56:31 +01:00
012b2b5385
Merge pull request #55700 from Razoric480/raz/lsp-extraneous-code
2021-12-09 13:12:49 +01:00
49403cbfa0
Replace String comparisons with "", String() to is_empty()
...
Also:
- Adds two stress tests to test_string.h
- Changes to .empty() on std::strings
2021-12-09 04:48:38 -06:00
1a8741aaca
Merge pull request #49473 from cptchuckles/fix-auto-reload-scripts
2021-12-09 10:06:22 +01:00
ad01201f34
Remove extraneous return to LSP
2021-12-07 12:37:11 -05:00
be975e5d18
Merge pull request #55624 from Razoric480/raz/cs-lsp-signal
2021-12-06 17:46:25 +01:00
de7873c2d8
Auto-Increment Debugger Port
...
Note: This PR also changes the port of the GDScript Language Server from 6008 to 6005. This opens enough ports above the debug port (6007) for this change to be useful.
2021-12-04 15:25:13 -06:00
66f1b4bf66
Prevent LSP adding signal func to non GDScripts
2021-12-04 10:58:05 -05:00
6204d956b8
Fix nested ternary-if codegen ( #55582 )
2021-12-04 10:12:02 +08:00
c3fb5ff359
Fix typo in `gdscript_parser`
2021-12-03 21:47:27 +01:00
7da392bcc5
Don't return reference on copy assignment operators
...
We prefer to prevent using chained assignment (`T a = b = c = T();`) as this
can lead to confusing code and subtle bugs.
According to https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B) , C++
allows any arbitrary return type, so this is standard compliant.
This could be re-assessed if/when we have an actual need for a behavior more
akin to that of the C++ STL, for now this PR simply changes a handful of
cases which were inconsistent with the rest of the codebase (`void` return
type was already the most common case prior to this commit).
2021-11-30 16:26:29 +01:00
3eec759e87
Check for nullptr expression in parse_precedence function
2021-11-29 11:29:15 +00:00
ce48604eb7
Enchance descriptions of @GlobalScope/@GDScript
2021-11-25 14:24:09 +03:00
e078f970db
Rename `remove()` to `remove_at()` when removing by index
2021-11-23 18:58:57 -07:00
3ba2d17d2f
Merge pull request #54949 from Chaosus/fix_warning
2021-11-23 15:15:36 +01:00
4682f22293
Improve various texts
2021-11-23 12:20:57 +01:00
1a15a3adf6
Fix GDScript parser crash on 'dollar mixed with assignment' expression
...
fixes #53696
2021-11-21 21:18:46 +01:00
4a5d98c987
Fix godot crash on null expression, fixes #53862
2021-11-21 20:58:52 +01:00
86c0e38e8f
Fix 'unreachable-code' false-positive, fixes #55154
2021-11-21 15:53:21 +01:00
ca4c63d654
Always soft-reload scripts
2021-11-19 17:45:16 +01:00
6c1bd4d227
Replace Godot docs URL with `$DOCS_URL` in XML class reference
2021-11-15 13:02:21 +01:00
3396b25489
Allow using built-in names for variables, push warnings instead
2021-11-13 21:47:24 +03:00
88c4380737
Modules: Make sure to include modules_enabled.gen.h where needed
2021-11-12 13:42:58 +01:00
3b320cd9fe
Show built-in script names in the debugger
2021-11-11 20:47:09 +01:00
74b9892f7a
[GDScript] Check string literals for Unicode direction control characters.
2021-11-11 15:41:59 +02:00
e8870ddefc
Merge pull request #54676 from Chaosus/gds_restrict_names
2021-11-10 15:20:44 +01:00
92ae349668
Merge pull request #54358 from Shawak/feature-allow-root-node-paths-without-quote
2021-11-10 15:19:17 +01:00
c7a8e047cc
Allow using $/root node paths
...
format
fix shadowing
use match instead of comparison
Update gdscript_parser.cpp
2021-11-09 18:46:28 +01:00
605784f019
Remove hash symbol in front of opcode error messages in GDScript
...
The hash symbol creates spurious issue references on GitHub if
the message is posted outside a code block, which means some issues
have a lot more references than originally intended.
2021-11-09 12:20:16 +01:00
236fd3305b
Merge pull request #54473 from briansemrau/no-debug-functions-on-thread
2021-11-08 19:37:48 +01:00
95f6f3c756
Prevent identifiers from naming as built-in funcs and global classes
2021-11-08 21:35:31 +03:00
78ed2c05a2
Merge pull request #54118 from Pineapple/dont-ignore-type-mismatch-in-setter-master
2021-11-08 19:26:27 +01:00
4995a477ff
Fix LSP crash when parsing signal symbols.
...
If the number of parameters was less than the number of class members, the LSP would cause godot to crash because it was using the index for class members instead of the index for signal parameters.
Fixes #54720 .
2021-11-07 12:20:25 -05:00
c012fbc8b2
Rename `PROPERTY_USAGE_NOEDITOR` to `PROPERTY_USAGE_NO_EDITOR`
...
This is consistent with other constants that include `NO`,
such as `PROPERTY_HINT_COLOR_NO_ALPHA`.
2021-11-03 23:06:17 +01:00
5efb11926d
Merge pull request #54346 from mhilbrunner/used-what-instead-of-what
2021-11-02 08:48:58 +01:00
d3051b2637
GDScript gracefully handle debug functions from separate thread
2021-11-01 12:13:25 -04:00
6772ebcea0
Move the docs for constructors and operators out of methods section
2021-10-29 12:34:57 -05:00
f7d852b532
Merge pull request #54350 from akien-mga/clang-format-dont-align-operands
2021-10-28 17:10:52 +02:00
6b090e325a
Merge pull request #53526 from KoBeWi/super_print
2021-10-28 15:47:52 +02:00
3a6be64c12
clang-format: Various fixes to comments alignment from `clang-format` 13
...
All reviewed manually and occasionally rewritten to avoid bad auto formatting.
2021-10-28 15:43:36 +02:00
3b11e33a09
clang-format: Disable alignment of operands, too unreliable
...
Sets `AlignOperands` to `DontAlign`.
`clang-format` developers seem to mostly care about space-based indentation and
every other version of clang-format breaks the bad mismatch of tabs and spaces
that it seems to use for operand alignment. So it's better without, so that it
respects our two-tabs `ContinuationIndentWidth`.
2021-10-28 15:19:35 +02:00
626ca50676
Improve GDScript indentation error message
2021-10-28 13:01:53 +02:00
d03b7fbe09
Refactored Node3D rotation modes
...
* Made the Basis euler orders indexed via enum.
* Node3D has a new rotation_order property to choose Euler rotation order.
* Node3D has also a rotation_mode property to choose between Euler, Quaternion and Basis
Exposing these modes as well as the order makes Godot a lot friendlier for animators, which can choose the best way to interpolate rotations.
The new *Basis* mode makes the (exposed) transform property obsolete, so it was removed (can still be accessed by code of course).
2021-10-25 14:34:00 -03:00
42cce2891f
Don't ignore the type mismatch in setter function
2021-10-22 12:44:33 +02:00
87a4ba492e
Remove unimplemented methods
2021-10-21 18:44:25 +01:00
4387f9645b
Merge pull request #52940 from groud/toast_notification
2021-10-19 09:57:13 +02:00
560d9a4cc0
Fix incorrect debug check for setters
...
the check read the return type of the setter, which doesn't exist and
lead to a segmentation fault. Now we check the first function parameter.
Probably a bad copy/paste of the getter case
2021-10-18 09:01:16 +02:00
ad14b80e2a
Fix name used instead of doc for GDScript signals
2021-10-17 05:54:27 +02:00
08d1ce718d
Merge pull request #53856 from vnen/gdscript-setter-crash
2021-10-15 21:35:42 +02:00
b0725a3b7d
GDScript: Avoid crash if missing setter signature
2021-10-15 15:53:24 -03:00
3f888966c0
Merge pull request #53843 from vnen/gdscript-typed-array-subscript-constant
...
Fix inferred typed array marked as constant
2021-10-15 16:49:29 +02:00
540821a264
GDScript: Fix inferred typed array marked as constant
2021-10-15 10:40:50 -03:00
84abb9a76c
GDScript: Fix typing for await expression
...
Don't grab the type of the awaited value unless it's constant (which
makes it synchronous) or call (which always use the proper return type).
2021-10-14 20:30:06 -03:00
749d89ae38
GDScript: Remove error when coroutine is called without await
...
In the case the call happens as a statement, since the return value
isn't used in this case.
2021-10-14 20:12:01 -03:00
056a54db7b
GDScript: Properly return value with await on non-coroutine
...
If the keyword `await` is used without a coroutine, it should still
return the value synchronally.
2021-10-14 19:58:10 -03:00
d36213bab8
GDScript: Make sure calls don't use return when not needed
2021-10-14 19:55:45 -03:00
472ff40f71
Merge pull request #53807 from vnen/dont-share-arrays-and-dicts
2021-10-14 20:42:22 +02:00
4c14051b3f
Zero Dictionary and Array variants when changing type with reset
...
So they don't reference to the old values anymore and instead refer to
a new value.
2021-10-14 11:22:17 -03:00
bf322bacdd
Merge pull request #53726 from briansemrau/gd-outer-class
...
GDScript 2.0: Access outer scope classes
2021-10-14 10:12:52 -03:00
0587e5e018
Implement toast notifications in the editor
2021-10-14 13:30:54 +02:00
0ff0f64cd4
GDScript: Access outer scope classes
2021-10-13 22:39:12 -04:00
e4288bf728
Merge pull request #53720 from vnen/gdscript-typed-array-custom-class
2021-10-12 16:51:50 +02:00
34288b24a6
GDScript: Fix typed array with custom classes
2021-10-12 10:41:04 -03:00
45f546c1d8
GDScript: Make setter parameter type same as variable type
2021-10-12 09:39:23 -03:00
188e08307e
Merge pull request #53647 from Chaosus/gds_fix_builtin_functions_autocompletion
2021-10-11 20:29:43 +03:00
e270d1cce3
Fix autocompletion of built-in functions in GDScript
2021-10-11 19:06:17 +03:00
a6414b34e9
Merge pull request #53430 from DavidSichma/typed_safe_setter
...
Made typed member setters safe
2021-10-11 11:16:19 -03:00
f930d54140
Merge pull request #53103 from ZuBsPaCe/gdscript-analyze-properties-fix
...
GDScript: Report property type errors
2021-10-11 11:01:39 -03:00
41e271af6e
Remove redundant String operation from GDScript enum exports
2021-10-11 02:11:32 +03:00
575d4e00b6
Enhance and cleanup stringify for Vector
2021-10-09 06:19:25 +00:00
d28f2ee7a5
Only emit typed member setters if safe to do so
...
Instructions are now only emitted if input type matches expected type.
Otherwise usual setter fallback.
2021-10-08 23:54:55 +02:00
551ceb590b
GDScript: Report property type errors
...
Inline getters & setters are now FunctionNodes.
Their names are set in the parser, not in the compiler.
GDScript-Analyzer will now run through getter and setter.
Also report wrong type or signature errors regarding getset properties.
Added GDScript tests for getters and setters.
#53102
2021-10-08 22:06:15 +02:00
5733c13f53
Merge pull request #53536 from Faless/mp/4.x_rpc_config
...
[Net] Add call_local argument to Node.rpc_config.
2021-10-08 14:15:01 +02:00
b010f96c89
Merge pull request #53336 from briansemrau/gdscript-i'm-not-my-own-local-class
...
[GDScript 2.0] fix script base class self-assignment
2021-10-08 09:10:19 -03:00
54ec66a700
[Net] Rename RPCConfig.sync to call_local.
...
For consistency with the other user facing changes.
2021-10-08 12:39:09 +02:00
3a856b4fcc
GDScript: Use getter return type for the property type
...
The PropertyInfo hints are more relevant for the inspector. The getter
return type is more reliable and less likely to be incorrect and it is
what's going to be called in the end.
2021-10-07 20:22:19 -03:00
49e7e049ab
Merge pull request #53422 from KoBeWi/add_LUA_to_Godot
2021-10-07 23:37:37 +02:00
082f624ef4
GDScript: Fix method ptrcall on release
2021-10-07 15:08:21 -03:00
31012fd060
Change print_line() to use any number of Variants
2021-10-07 16:28:22 +02:00
6eb2094d4d
Merge pull request #53494 from mhilbrunner/stop-drop-and-dont-lie
...
Fix outdated no_call_local, use call_remote
2021-10-07 08:29:25 +02:00
dfe3a2fad0
GDScript: Set status on parsing steps beforehand
...
To avoid potential dependency cycles. If any happens it will not get
into infinite recursion anymore and errors will cascade later on.
2021-10-06 21:24:27 -03:00
44b68f08b4
Fix outdated no_call_local, use call_remote
2021-10-06 23:51:57 +02:00
98b81ad35c
Merge pull request #53479 from vnen/gdscript-subscript-object-self
2021-10-06 19:48:23 +02:00
ba0a103e29
Merge pull request #53478 from vnen/gdscript-avoid-hard-inference
2021-10-06 19:31:56 +02:00
1f55bd190c
GDScript: Allow subscript on self and object types
2021-10-06 12:01:34 -03:00
6bdb28f5e4
GDScript: Avoid hard errors on inferred types
...
Since inference isn't always correct, they are now treated as unsafe
instead of errors.
This also removes inferred type when a variable is reassigned. Since
it's not aware of branching, the types might become invalid in a later
context.
2021-10-06 11:42:19 -03:00
d6c799006a
GDScript: Make all warnings enabled in test generation
...
The test generation doesn't initialize the language (since it's already
initialized in main), but it still needs the warning enabled so it
matches the actual tests.
2021-10-06 11:39:00 -03:00
862994a8ef
doc: Update links to latest documentation after content reorganization
2021-10-06 13:48:48 +02:00
9e5fdbc79d
Fix LUA-style assignment in Dictionary
2021-10-05 12:17:13 +02:00
c18a27a9cd
GDScript fix wrong base class assignment
2021-10-04 20:38:08 -04:00
7725ebf3d2
GDScript: Use path cache when checking preloaded scripts
...
The path itself might not always be set in some cases, especially when
the script is just created and is already in the resource cache. Using
get_path() in this case gets the correct resource path.
This also adds a null check for safety in case the path is incorrect or
missing, to avoid a crash in the engine.
2021-10-04 20:48:39 -03:00
84956fee4b
GDScript: Fix member assignment with operation
...
It was wrongly updating the assigned value with the result of the
operation.
2021-10-04 14:09:54 -03:00
bb201c5887
Merge pull request #53303 from akien-mga/53295-gdscript-completion-quote-style
2021-10-04 17:17:27 +02:00
4a4995524c
Merge pull request #53338 from briansemrau/gdscript-handle-for-with-null-list
2021-10-04 17:11:43 +02:00
b85dfd990e
GDScript completion: Handle quote style ad-hoc to remove editor dependency
...
`core` and `scene` shouldn't depend on `editor`, so they can't query this style
setting in `get_argument_options`. But we can handle it after the fact in
GDScript's completion code.
Also cleans up a couple extra unused invalid includes in `core`.
2021-10-04 16:16:05 +02:00
cb28469281
Allow void as return type for constructors
2021-10-03 21:16:54 +02:00
dc046e5cbe
GDScript Check for null list in `for` loop
2021-10-02 13:53:56 -04:00
366e374f76
Merge pull request #53290 from Faless/mp/4.x_opts_names
...
[Net] Rename RPC constants and annotation arguments.
2021-10-01 21:35:08 +02:00
24a949ea11
[Net] Rename RPC constants and annotation arguments.
...
any -> any_peer
sync -> call_local
ordered -> unreliable_ordered
Multiplayer.RPC_MODE_ANY -> RPC_MODE_ANY_PEER
Multiplayer.TRANSFER_MODE_ORDERED -> TRANSFER_MODE_UNRELIABLE_ORDERED
2021-10-01 18:14:38 +02:00
572979d011
Fix empty line hover; fix open non-res:// script
2021-10-01 11:26:26 -04:00
06c1b40b84
Merge pull request #38397 from Calinou/doc-range-backwards-example
2021-10-01 11:58:30 +02:00
c63b18507d
Use range iterators for `Map`
2021-09-30 15:09:12 -06:00
810d8f06b7
Add an example on iterating an array backwards
...
This closes https://github.com/godotengine/godot-docs/issues/3472 .
2021-09-30 20:29:57 +02:00
d2b8560d7a
Revert "GdScript: Use reduced constant expression result when doing binary operations. Fixes #50293"
...
This reverts commit 6207708607
2021-09-30 18:57:59 +02:00
7f8e50801e
Merge pull request #51818 from MarianoGnu/gdscript2-enum-fixes
2021-09-30 18:35:49 +02:00
27d4e2f09f
Merge pull request #53216 from vnen/gdscript-builtin-type-not-id
2021-09-29 17:04:24 +02:00
72c07708e8
GDScript: Don't allow builtin type names as identifiers
2021-09-29 11:23:16 -03:00
991f4d8527
GDScript: Fix assignment with operation for properties
2021-09-29 10:54:16 -03:00
c1f59139b4
Merge pull request #53092 from Razoric480/lsp-report-_init
2021-09-29 15:47:31 +02:00
7468dd65a5
Make LSP report _init instead of Object::new
2021-09-29 08:42:01 -04:00
ea0a9e6ed3
Merge pull request #52800 from akien-mga/gdscript-remove-exp_range
2021-09-29 13:33:59 +02:00
6141ce2cb8
GDScript Don't double-reference Refs returned from native function
2021-09-28 12:40:23 -04:00
0fa574c051
Fix check for freed object during cast
2021-09-27 19:35:26 +02:00
ee238b2a4d
Fix inverted error messages about null object
2021-09-27 13:58:46 +02:00
044daf9b8d
Remove duplicate WorkspaceEdit from LSP
2021-09-25 15:17:19 -04:00
14dcb97556
Merge pull request #50378 from Razoric480/apply-edit-40
2021-09-25 20:43:17 +02:00
0abe464162
Merge pull request #52849 from KoBeWi/know_no_binds
2021-09-25 00:10:56 +02:00
7bf5fc709e
Remove binds from Signal.connect
2021-09-24 17:07:33 +02:00
679f70c1e1
Merge pull request #52906 from vnen/gdscript-show-error-on-yield
2021-09-21 20:36:39 +02:00
b3b4860d2e
Merge pull request #52905 from vnen/gdscript-single-line-declaration
2021-09-21 20:35:36 +02:00
262d6c6bef
GDScript: Show specific error when "yield" is used
...
To help people porting code, it gives a hint to use "await" instead of a
generic error.
2021-09-21 14:38:14 -03:00
e5ebc9710d
GDScript: Allow classes declaration to be done in single line
...
Incidentally, allow multiple statements in single line functions when
using semicolon as a terminator.
2021-09-21 14:14:46 -03:00
bab0afc821
GDScript: Allow multiple lines in signal parameters declaration
2021-09-21 13:40:39 -03:00
5107f9190b
GDScript: Remove conversion assign mistakenly done when unneeded
2021-09-21 11:58:57 -03:00
26e3b3908d
Merge pull request #52852 from Chaosus/gds_fix_constants
...
Prevent local constant default value from incorrect overriding by a global constant in GDScript autocompletion
2021-09-21 16:44:46 +03:00
b458feba24
Merge pull request #51655 from RevoluPowered/improve-gdscript-code-editor-performance
...
Improve GDScript Editor performance
2021-09-21 15:18:17 +02:00
82c12060b2
Merge pull request #52718 from Calinou/gdscript-add-integration-tests-2
2021-09-21 14:13:24 +02:00
1881b3adc5
Improve GDScript Editor and Improve latency
...
Improvements:
- GDScript Highlighter is faster by 25% as keys are smaller (hashes instead of strings)
- Removes message queue from _apply_settings_change to allow resize to work correctly
- Some performance fixes are pending still
Note: this resolves the code editor behaving badly when resizing in debug builds
2021-09-21 13:56:47 +02:00
05331a5bb9
Prevent local constant default value from incorrect override by a global
2021-09-21 08:40:50 +03:00
d54f2ad7ca
Don't generate empty doc sections and reduce code duplication
2021-09-20 20:59:33 -05:00
be6da39b8a
LSP: Add support for custom host setting
...
You can now configure host in the `language_server` settings in the editor
settings.
2021-09-20 13:09:51 +02:00
ae3b26da7b
GDScript: Remove reference to remove `@export_exp_range`
...
It was removed in 75688772b3
2021-09-17 22:54:43 +02:00
424ddcba37
Merge pull request #52792 from vnen/gdscript-subscript-missing-index
2021-09-17 20:16:29 +02:00
7762e8b1c1
Merge pull request #52788 from vnen/gdscript-compare-with-null
2021-09-17 19:35:55 +02:00
651319de11
GDScript: Properly catch error when missing index in subscript
2021-09-17 14:31:51 -03:00
455e142d37
Allow comparing equality between builtin types and null
2021-09-17 12:33:52 -03:00
b8fdeb6467
Merge pull request #51671 from RandomShaper/fix_gdscript_crash
...
Fix some GDScript bugs
2021-09-17 12:29:40 -03:00
4e69341c01
GDScript: Avoid inferred types from giving hard errors
2021-09-17 11:52:30 -03:00
c6ca09dc6f
Add more integration tests to the GDScript test suite
...
This also fixes a typo in the `bitwise_float_right_operand.gd` test.
2021-09-15 19:57:39 +02:00
a4187c9235
Merge pull request #52706 from vnen/gdscript-ternary-operator-crash
...
GDScript: Show error when missing expression after ternary else
2021-09-15 17:20:52 +02:00
ed11d03b56
Merge pull request #52705 from vnen/gdscript-error-unary-no-arg
...
GDScript: Show error on unary operators without argument
2021-09-15 16:43:38 +02:00
107af38fd1
GDScript: Show error when missing expression after ternary else
2021-09-15 11:43:36 -03:00
a5c299630d
Merge pull request #50456 from Blackiris/fix-extends-parent-relative
...
Fix extends with relative path to parent script
2021-09-15 11:12:24 -03:00
d49046938a
GDScript: Show error on unary operators without argument
2021-09-15 11:08:59 -03:00
5a612d61b9
Merge pull request #49765 from Blackiris/fix-assignment-with-operator-on-type-member
...
Fix assignment with operator on type member
2021-09-15 10:56:20 -03:00
c23823ac54
Merge pull request #52582 from jmb462/Prevent-non-explicit-inferring-parameter-from-null
2021-09-15 15:50:42 +02:00
5d31ce4b16
GDScript: Allow string keys on Lua-style dictionaries
...
Which is useful when the key isn't a valid identifier, such as keys with
spaces or numeric keys.
2021-09-15 09:56:24 -03:00
32f8f74d83
Merge pull request #48029 from Calinou/gdscript-add-integration-tests
...
Add dozens of new integration tests to the GDScript test suite
2021-09-15 14:00:41 +02:00
1c7aec9d9c
Merge pull request #51094 from RandomShaper/error_cast_freed_object
...
Complain if casting a freed object in a debug session
2021-09-14 21:48:10 +02:00
ddc7d7ee66
Complain if casting a freed object in a debug session
...
The idea is to give the user a chance to realize a mistake that will cause a crash in a release build (or with no debugger attached).
2021-09-14 21:07:00 +02:00
c0083c0f90
Add dozens of new integration tests to the GDScript test suite
...
This also ignores `.out` files in the file format static checks.
2021-09-14 18:42:08 +02:00
2c71134aa4
Fix an undefined behaviour
2021-09-13 22:59:28 +02:00
f6022d2aa8
Merge pull request #52362 from vnen/gdscript-lambda-completion-crash
...
GDScript: Do not complete lambda arguments from parent class
2021-09-13 21:13:40 +02:00
45d9df2e63
Merge pull request #52632 from vnen/autoload-global-script-class-conflict
...
Disallow class names to be the same as global names
2021-09-13 21:10:50 +02:00
ffe8412291
Merge pull request #52323 from vnen/gdscript-singleton-interdependence-fix
...
Fix loading of interdependent autoloads
2021-09-13 21:10:34 +02:00
e9186cfebf
Fix GDScript test cases
2021-09-13 15:02:01 -03:00
0c2ab55a58
Merge pull request #52100 from vnen/gdscript-access-outer-constants
...
GDScript: Allow access to outer constant and enum values
2021-09-13 18:04:35 +02:00
4059cf2f02
Merge pull request #52068 from ThreeRhinosInAnElephantCostume/fixgdscript
...
Fix parse error on statement-less files with only newlines, add a warning for empty files.
2021-09-13 17:30:31 +02:00
2e5fa124f4
Disallow class names to be the same as global names
...
Also forbid autoloads to have the same name as global script class.
2021-09-13 10:51:29 -03:00
b9219bedf7
Prevent non explicit inferring parameter from null
2021-09-11 21:11:10 +02:00
e99730340b
Fix error on parsing statement-less GDScript files,
...
add an empty file warning,
add relevant tests.
2021-09-11 20:38:15 +02:00
10c9c2ccd4
Avoid crash after a parsing error in GDScript
2021-09-11 11:35:25 +02:00
7c79e361f5
Fix parameter type resolution in GDScript
2021-09-11 11:35:25 +02:00
d72f12a561
Implement iterator variable typing in GDScript
2021-09-11 11:35:25 +02:00
1d1aa7a02f
GDScript: Removed spurious UNASSIGNED_VARIABLE warning for locals
...
Variable->assignment needs to be incremented when assigned a value.
Also fixed and improved unit test 'variable_declaration.gd'.
Fixes #52551
2021-09-10 22:26:50 +02:00
6423e891a6
Merge pull request #52063 from KoBeWi/double_comma_of_doom
...
Fix crash with consecutive commas in Dictionary
2021-09-10 11:24:51 -03:00
6da061faf5
Merge pull request #49897 from Blackiris/fix-dollar-point-crash-on-editor
...
Fix crash when writing $. in the editor
2021-09-10 10:55:11 -03:00
0b484c5f5f
Merge pull request #51456 from SaracenOne/super_init_fix
...
Call _init on base class if one does not exist.
2021-09-10 10:40:32 -03:00
c7452a9940
Fix crash with consecutive commas in Dictionary
2021-09-10 15:38:24 +02:00
11e457e594
Merge pull request #51593 from KoBeWi/if
...
Prevent crash when awaiting in a getter/setter
2021-09-10 10:36:25 -03:00
1234c2bdd9
Merge pull request #52081 from ThreeRhinosInAnElephantCostume/fixmatchfreeze
...
Fix gdscript pattern matching expressions
2021-09-10 09:28:18 -03:00
886ad727f8
Merge pull request #52267 from williamd67/lookup-symbol-builtin-functions
...
Show help for built-in functions (@GlobalScope)
2021-09-07 21:05:09 +02:00
bf9aae09ba
[Net] Move multiplayer to core subdir, split RPCManager.
...
Move multiplayer classes to "core/multiplayer" subdir.
Move the RPCConfig and enums (TransferMode, RPCMode) to a separate
file (multiplayer.h), and bind them to the global namespace.
Move the RPC handling code to its own class (RPCManager).
Renames "get_rpc_sender_id" to "get_remote_sender_id".
2021-09-07 11:14:30 +02:00
a92d2c447b
Fix extends with relative path to parent script
2021-09-05 00:11:04 +02:00
8c82e305ba
Merge pull request #52329 from ZuBsPaCe/gdscript-unused-private-class-variable-fix
...
GDScript: Fix for UNUSED_PRIVATE_CLASS_VARIABLE
2021-09-03 10:04:11 +02:00
c76ad6b158
GDScript: Count usages of member variables.
...
Otherwise private member variables will always lead to UNUSED_PRIVATE_CLASS_VARIABLE.
2021-09-03 07:44:46 +02:00
15ccd83ada
Added tests for expression matching
2021-09-03 06:59:13 +02:00
b0c807c75a
Fix auto reload scripts on external change
2021-09-02 20:28:02 -05:00
da9daf4c3a
GDScript: Do not complete lambda arguments from parent class
...
Since lambdas are not overriding methods from the parent class, they
should not try to check inheritance for signature matching.
2021-09-02 19:54:55 -03:00
84852585b9
Check for GDScript member and class naming conflicts in a variety of conditions.
2021-09-02 07:16:06 +01:00
3d13588057
GDScript: Fix loading of interdependent autoloads
...
Move the autoload resolution to runtime by loading it into the stack
with an extra instruction. This allows an autoload to use another
autoload singleton independent of load order.
2021-09-01 16:06:30 -03:00
bcd73fc00a
Merge pull request #52240 from Rubonnek/rename-rel-path
...
Rename `String::is_rel_path` to `String::is_relative_path`
2021-08-30 20:45:45 -03:00
b2f858870d
Show help for built-in functions (@GlobalScope)
2021-08-30 21:51:56 +02:00
d11c1afc04
Rename String::is_rel_path to String::is_relative_path
2021-08-29 20:41:29 -04:00
fafddbc143
[GDScript] [Net] Allow mixing rpc annotation paramters.
...
The strings no longer needs to be in order.
The last parameter (channel), still requires all the other parameters to
be present.
2021-08-30 00:54:38 +02:00
64b9f30b92
[Net] Rename RPC "puppet" to "auth" (authority). Drop "master".
...
This commit completely removes the RPC_MODE_MASTER ("master" keyword),
and renames the RPC_MODE_PUPPET to RPC_MODE_AUTHORITY ("auth" keyword).
This commit also renames the "Node.[get|set]_network_master" methods to
"Node.[get|set]_network_authority".
This commit also renames the RPC_MODE_REMOTE constant to RPC_MODE_ANY.
RPC_MODE_MASTER in Godot 3.x meant that a given RPC would be callable by
any puppet peer on the master, while RPC_MODE_PUPPET meant that it would
be callable by the master on any puppet.
Beside proving to be very confusing to the user (referring to where it
could be called instead of who can call it) the RPC_MODE_MASTER is quite
useless. It is almost the same as RPC_MODE_REMOTE (anyone can call) with
the exception that the network master cannot. While this could be useful
to check in some case, in such a function you would anyway need to check
in code who is the caller via get_rpc_sender_id(), so adding the check
there for those rare cases does not warrants a dedicated mode.
2021-08-30 00:54:38 +02:00
4f9509e6ba
Merge pull request #52085 from williamd67/fix-await-without-argument
...
Print error message when await is not followed by signal or coroutine
2021-08-28 23:01:34 +02:00
5d2c4faa89
Merge pull request #52164 from mhilbrunner/gd-style-fixup
...
GDScript test style fix
2021-08-28 20:16:17 +02:00
e77338978f
Print error message when await is not followed by signal or coroutine
...
When await was not followed by a signal or coroutine the GDScript parser would
crash.
This fix will check if await is followed by a signal or coroutine in case that
isn't true (element == nullptr) then an error message is printed.
2021-08-28 17:29:35 +02:00
d04aa9a114
Merge pull request #52122 from V-Sekai/autoload_list
...
Use sorted map for autoloads in ProjectSettings to preserve order.
2021-08-27 14:41:40 -07:00
f126634434
GDScript test style fix
2021-08-27 21:11:46 +02:00
4e67e9bca6
Merge pull request #52090 from balloonpopper/bug52060
...
Correct null and boolean values being capitalised by the str command
2021-08-27 21:05:47 +02:00
33773a24dc
Merge pull request #52105 from ldmnt/master
2021-08-27 19:28:59 +02:00
31f790299c
Use OrderedHashMap for autoloads to preserve order
2021-08-26 21:55:26 -07:00
4fae7ae9dc
Correct null and boolean values being capitalised by the str command
2021-08-26 17:11:34 +10:00
79578a5625
Fixed crash when parsing an empty assignment.
...
Resolves #51620 .
2021-08-25 18:48:08 +02:00
9c2ec6e697
Add a README to link to the GDScript integration tests documentation
...
This makes the documentation about creating and running GDScript
integration tests more discoverable.
2021-08-25 16:51:28 +02:00
6c258a89de
Fixed pattern matching with expressions
2021-08-25 15:30:41 +02:00
4918df4527
GDScript: Allow access to outer constant and enum values
2021-08-24 14:45:51 -03:00
583b6a594a
Merge pull request #51971 from aaronfranke/https
...
Replace HTTP URLs with HTTPS for sites with HTTPS versions
2021-08-23 15:58:54 +02:00
88db541705
Merge pull request #51947 from AnilBK/redundant-assignments
...
[cppcheck] Remove some redundant assignments.
2021-08-23 13:23:45 +00:00
ae1702bee5
Replace HTTP links with HTTPS for sites with HTTPS versions
2021-08-22 20:13:11 -05:00
3682978aee
Replace BIND_VMETHOD by new GDVIRTUAL syntax
...
* New syntax is type safe.
* New syntax allows for type safe virtuals in native extensions.
* New syntax permits extremely fast calling.
Note: Everything was replaced where possible except for `_gui_input` `_input` and `_unhandled_input`.
These will require API rework on a separate PR as they work different than the rest of the functions.
Added a new method flag METHOD_FLAG_OBJECT_CORE, used internally. Allows to not dump the core virtuals like `_notification` to the json API, since each language will implement those as it is best fits.
2021-08-22 08:23:58 -03:00
9bc5119d4e
Fix assignment with operator on type member
2021-08-21 21:56:11 +02:00
c86db8b710
Remove redundant assignments.
...
Use used_in_transfer instead of used_in_compute twice.
2021-08-21 19:20:07 +05:45
f5422c55fc
Merge pull request #49105 from vnen/gdscript-inner-preload-type
...
GDScript: Fix inner classes and preloaded scripts as types
2021-08-20 17:07:18 +02:00
2e84a46a0f
GDScript: Make singleton functions be seen as static
...
Since those can be called without an instance.
2021-08-20 10:52:58 -03:00
603502c11c
Merge pull request #51902 from vnen/variant-internal-constructor
...
Fix initialization of objects in VariantInternal
2021-08-20 08:10:38 +02:00
a685535ad5
Fix initialization of objects in VariantInternal
2021-08-19 20:19:47 -03:00
89695da337
GDScript: Fix memory leak when using self class as type
2021-08-18 18:58:45 -03:00
1c8b076502
GDScript: Fix calling builtin static functions
2021-08-18 18:58:41 -03:00
47545aeb1a
GDScript: Fix issue when calling `new()` on its own
2021-08-18 18:56:21 -03:00
2ba4ee9198
GDScript: Fix inner classes and preloaded scripts as types
2021-08-18 18:56:21 -03:00
6207708607
GdScript: Use reduced constant expression result when doing binary operations. Fixes #50293
2021-08-18 09:19:09 -03:00
70c5feb32c
Accept non unnamed enums as valid values for enums. Fixes #49357
2021-08-17 19:44:27 -03:00
7f37e2987a
When analyzing GdScript sources, consider Enums as Dictionaries. Fixes #45558
2021-08-17 19:44:27 -03:00
5161c97c9c
Remove underscore hacks
...
Way less cruft. :)
Co-authored-by: Ignacio Roldán Etcheverry <neikeq@users.noreply.github.com>
2021-08-17 16:10:28 +02:00
21a0af2686
Merge pull request #51762 from nekomatata/fix-crash-gdscript-cache
...
Fix crash when failing to load script from cache
2021-08-17 13:34:07 +02:00
9973bf93ed
Fix crash when failing to load script from cache
2021-08-16 16:27:25 -07:00
bcfc591f86
Reorganise text editor settings
2021-08-16 17:18:49 +01:00
81512a3732
Style: Cleanup code using `text_editor/completion/use_single_quotes`
2021-08-13 21:27:57 +02:00
8a605d227d
Prevent crash when awaiting in a getter/setter
2021-08-13 00:19:55 +02:00
e0572f7ef7
Fix crash when parsing Dictionary
2021-08-10 15:57:56 +02:00
861bb3a488
Automatically call the _init function on base class if one does not exist.
2021-08-10 02:41:44 +01:00
51b7179b5a
Fix infinite loop when creating a newly inherited GdScript file
2021-08-09 23:52:31 +02:00
070d634966
Fix LSP completion crashing on scene-less scripts
2021-08-06 14:55:05 -04:00
6ded4f52e8
Merge pull request #51283 from Razoric480/lsp-parse-from
...
Fix LSP parsing get_node only from the scene root
2021-08-06 10:13:09 +02:00
d7dca072aa
[Net] Default @rpc annotation should be puppet, not master.
2021-08-06 02:39:22 +02:00
03f8fa9f62
Fix LSP parsing get_node only from the scene root
2021-08-05 12:30:06 -04:00
a544e77822
Merge pull request #51247 from pycbouh/docs-extract-theme-items
...
Add theme item descriptions to the online documentation
2021-08-05 00:18:56 +02:00
73b1f5ac79
Merge pull request #48615 from Razoric480/lsp-rename
...
Implement LSP didSave notification and rename request
2021-08-05 00:18:31 +02:00
bf2839ea3e
Add theme item descriptions to the online documentation
2021-08-04 22:27:10 +03:00
80fc90e82a
Merge pull request #50454 from Ev1lbl0w/gsoc21-dap
...
Implemented initial DAP support
2021-08-03 17:12:37 +02:00
7bccd5487e
Implemented initial DAP support
...
Implemented "output" event
Refactored "seq" field generation
Prevent debugging when editor and client are in different projects
Removed unneeded references to peer on the parser
Refactored way to detect project path
Implemented "setBreakpoints" request
Fix double events when terminating from client
Refactored "stopped" event
Implemented "stopped" with breakpoint event
Implemented "stackTrace", "scopes" and "variables" request
Report incoming number of stack dump variables
Implemented proper reporting of scopes and variables from stack frames
Prevent editor from grabbing focus when a DAP session is active
Implemented "next" and "stepIn" requests
Implemented "Source" checksum computing
Switched expected errors from macros to silent guards
Refactored message_id
Respect client settings regarding lines/columns behavior
Refactored nested DAP fields
Implement reporting of "Members" and "Globals" scopes as well
Fix error messages not being shown, and improved wrong path message
2021-08-02 10:43:35 +01:00
7adf4cc9b5
doc: Use self-closing tags for `return` and `argument`
...
For the time being we don't support writing a description for those, preferring
having all details in the method's description.
Using self-closing tags saves half the lines, and prevents contributors from
thinking that they should write the argument or return documentation there.
2021-07-30 15:29:52 +02:00
41ef9cf789
Fix LSP reporting wrong types
2021-07-26 16:26:23 -04:00
92299989bd
Use Ref<T> references as iterators where relevant
...
And const when possible.
2021-07-26 19:27:11 +02:00
6938dd72f2
Fix instantiate line class
2021-07-25 14:20:31 +02:00
ac3322b0af
Use const references where possible for List range iterators
2021-07-25 12:22:25 +02:00
4e6efd1b07
Use C++ iterators for Lists in many situations
2021-07-23 17:38:28 -04:00
8ff8c1e5f8
Improve documentation for GDScript constants
2021-07-22 09:50:24 +02:00
4bd5e4fd9b
Use the standard C `INFINITY` and `NAN` constants directly
...
The `Math_INF` and `Math_NAN` defines were just aliases for those
constants, so we might as well use them directly.
Some portions of the code were already using `INFINITY` directly.
2021-07-21 10:41:08 +02:00
ddb68f76ff
[Net] Single `rpc` annotation. "sync" no longer part of mode.
...
- Move the "sync" property for RPCs to RPCConfig.
- Unify GDScript annotations into a single one:
- `@rpc(master)` # default
- `@rpc(puppet)`
- `@rpc(any)` # former `@remote`
- Implement three additional `@rpc` options:
- The second parameter is the "sync" option (which also calls the
function locally when RPCing). One of "sync", "nosync".
- The third parameter is the transfer mode (reliable, unreliable,
ordered).
- The third parameter is the channel (unused for now).
2021-07-20 11:17:59 +02:00
6631f66c2a
Optimize StringName usage
...
* Added a new macro SNAME() that constructs and caches a local stringname.
* Subsequent usages use the cached version.
* Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time.
* Replaced all theme usages by this new macro.
* Replace all signal emission usages by this new macro.
* Replace all call_deferred usages by this new macro.
This is part of ongoing work to optimize GUI and the editor.
2021-07-18 21:20:02 -03:00
7c5335081c
Implement didSave notification and rename request
2021-07-17 11:50:00 -04:00
06568bbfdf
Misc cleanup of header includes
...
Was looking for misuse of module headers without checking that the module is
actually enabled and got carried away...
2021-07-15 00:46:43 +02:00
5ad4f26659
Implement the ability to disable classes
...
* This PR adds the ability to disable classes when building.
* For now it's only possible to do this via command like:
`scons disable_classes=RayCast2D,Area3D`
* Eventually, a proper UI will be implemented to create a build config file to do this at large scale, as well as detect what is used in the project.
2021-07-13 09:25:14 -03:00
88d68346ee
[Net] Rename NetworkedMultiplayerPeer to MultiplayerPeer.
2021-07-12 16:36:34 +02:00
9a8421aa05
Implement applyEdit in LSP for signal connecting
2021-07-11 16:17:49 -04:00
bf8795c7af
Fix crash when writing $. in the editor
2021-07-08 20:49:57 +02:00
10429019ad
Implement didClose notification in LSP
2021-07-08 11:40:15 -04:00
a02620f3a5
Merge pull request #50009 from reduz/fix-suffixes-and-degrees
...
Fix editor suffixes and degrees conversion
2021-06-30 18:47:40 +02:00
75688772b3
Fix editor suffixes and degrees conversion
...
* Functions to convert to/from degrees are all gone. Conversion is done by the editor.
* Use PROPERTY_HINT_ANGLE instead of PROPERTY_HINT_RANGE to edit radian angles in degrees.
* Added possibility to add suffixes to range properties, use "min,max[,step][,suffix:<something>]" example "0,100,1,suffix:m"
* In general, can add suffixes for EditorSpinSlider
Not covered by this PR, will have to be addressed by future ones:
* Ability to switch radians/degrees in the inspector for angle properties (if actually wanted).
* Animations previously made will most likely break, need to add a way to make old ones compatible.
* Only added a "px" suffix to 2D position and a "m" one to 3D position, someone needs to go through the rest of the engine and add all remaining suffixes.
* Likely also need to track down usage of EditorSpinSlider outside properties to add suffixes to it too.
2021-06-30 12:38:25 -03:00
364416ecd8
Remove singleton variable shadowing.
2021-06-30 02:37:20 -07:00
e28fd07b2b
Rename `instance()`->`instantiate()` when it's a verb
2021-06-19 20:49:18 -06:00
9b7c963d19
Merge pull request #48804 from EricEzaM/scripting-multi-error-support
...
Added support for scripts reporting multiple errors to ScriptTextEditor
2021-06-20 00:38:49 +02:00
d88be9b70c
Merge pull request #44806 from madmiraal/consolidate_json
...
Consolidate JSON, JSONParseResults and JSONParser into JSON
2021-06-19 21:45:34 +02:00
d0e78c86d7
Added support for scripts reporting multiple errors to ScriptTextEditor
...
Scripts can now report multiple errors to the scripting editors in the engine. UI elements were added to support multiple errors.
2021-06-19 22:20:30 +10:00
2bafcd3422
Consolidate JSON, JSONParseResults and JSONParser into JSON
...
Renames JSON.parse_string() to parse()
Renames JSON.decode_data() to stringify()
2021-06-19 08:01:40 +01:00
a9c53fa599
Merge pull request #49287 from reduz/expose-variant-internal-binders
...
Make some Variant internal functions public.
2021-06-19 01:11:03 +02:00
c4fcc678df
Merge pull request #49449 from SpectralDragon/fix-enum-equal-operation
...
Fix equal operation for typed enums
2021-06-18 17:18:44 -03:00
b5f1e88b2e
GDScript: Fix setting type of operator return value
...
Also write type adjust when needed for binary operators.
2021-06-18 13:09:35 -03:00
a56c2e459b
Translate file path to URI on LSP symbol requests
2021-06-17 10:36:41 -04:00
fed31b1827
Merge pull request #49616 from BastiaanOlij/more_rename_transform
...
Adding some more missing renames for Transform3D and Quaternion
2021-06-15 16:50:52 +02:00
2161fd117b
Adding some more missing renames for Transform3D and Quaternion
2021-06-15 16:01:50 +02:00
cbcdda60c0
Merge pull request #49570 from RandomShaper/fix_slow_scene_io
2021-06-15 14:51:24 +02:00
d6ae7edd80
Fix "super" call when having at least one argument
2021-06-13 17:46:03 +02:00
2ca6b9c610
Fix slow load/save of scenes with many instances of the same script
2021-06-13 13:32:44 +02:00
04688b92ff
Rename Reference to RefCounted
2021-06-11 18:48:42 +02:00
8d4046929c
Merge pull request #49511 from akien-mga/core-diraccess-fileaccess-io
...
Core: Move DirAccess and FileAccess to `core/io`
2021-06-11 16:51:10 +02:00
6b0183ec89
Merge pull request #49279 from Calinou/rename-string-is-abs-path-method
...
Rename `String.is_abs_path()` to `String.is_absolute_path()`
2021-06-11 15:58:16 +02:00
6107d9e180
Merge pull request #34566 from Heikki00/34541_to_json_precision
...
Increased String::num default decimal precision
2021-06-11 15:56:59 +02:00
9e328bb5b7
Core: Move DirAccess and FileAccess to `core/io`
...
File handling APIs are typically considered part of I/O, and we did have most
`FileAccess` implementations in `core/io` already.
2021-06-11 14:52:39 +02:00
771190a9db
Fix regression from 160c260 causing export of non-@export properties.
2021-06-10 20:35:58 -07:00
6449c5f246
Fix equal operation for typed enums
2021-06-09 02:52:21 +03:00
69e6d65295
Merge pull request #49367 from Calinou/gdscript-highligher-add-annotations
...
Highlight annotations in the GDScript syntax highlighter
2021-06-07 17:20:11 +02:00
896aa94283
Merge pull request #49221 from Faless/mp/4.x_rpc_refactor
...
[Net] Refactor RPCs, remove RSETs
2021-06-07 17:00:08 +02:00
32e97cb805
Highlight annotations in the GDScript syntax highlighter
...
By default, a orange color is used to highlight annotations in the
script editor.
2021-06-06 21:33:23 +02:00
8acd13a456
Rename Quat to Quaternion
2021-06-04 18:14:32 +01:00
5ea1c75d63
Rename `String.is_abs_path()` to `String.is_absolute_path()`
...
This is more consistent with `NodePath.is_absolute()`.
2021-06-03 16:00:06 +02:00
08a85352fb
Rename Variant TRANSFORM to TRANSFORM3D
...
Also _transform to _transform3d
2021-06-03 07:30:01 -04:00
de3f6699a5
Rename Transform to Transform3D in core
2021-06-03 07:30:01 -04:00
d779b5aa3e
[Net] Refactor RPCs, remove RSETs
...
In this PR:
- Removed rset
- rpc_config can now optionally configure transfer mode
(reliable/unreliable/ordered) and channel (channels are not actually
implemented yet.)
- Refactor how the RPC id is computed to minimize the logic in Node and
scripts that now only needs a single `get_rpc_methods` function.
2021-06-01 17:24:21 +02:00
59b524ae4c
Merge pull request #49067 from JFonS/fix_gcc_warnings
...
Fix some warnings raised by GCC-11.1
2021-06-01 10:47:37 +02:00
1704be0a44
Rename the bundled text editor themes for consistency with themes
...
The Adaptive text editor theme is the default, and has therefore
been renamed Default for consistency with the Default theme preset.
It keeps its automatic dark/light switch status.
The Default text editor theme was actually a legacy Godot 2-style theme,
so it has been renamed to Godot 2 to match the theme preset.
Its background color has been changed to be a constant opaque color,
since the new editor theme made the theme look less good on a translucent
background. The previous background color on light theme also lacked
contrast.
2021-05-31 14:02:13 +02:00
09a905ca80
Increase String::num default decimal precision
...
Fixes #34541
Renamed MAX_DIGITS to MAX_DECIMALS, since it only changes the
amount of digits after the decimal point.
Increased MAX_DECIMALS to 32, and made String::num use
MAX_DECIMALS consistently. If -1 is passed as
decimal precision to String::num, it now gets changed to
the correct precision based on the number's magnitude,
instead of using printf default(which is 6)
String::num_real also calculates the correct precision now.
Also made the types used in floating-point math more
consistent in a few places.
2021-05-29 11:24:57 -04:00
364ea7f280
Merge pull request #49114 from vnen/gdscript-fix-self-function-type-check
...
GDScript: Fix function signature check for self calls
2021-05-26 20:59:17 +02:00
78bbb2cae1
Merge pull request #49112 from vnen/gdscript-assign-type-check
...
GDScript: Use analyzer data to decide assignment conversion
2021-05-26 20:34:43 +02:00
a23fc45727
GDScript: Fix function signature check for self calls
2021-05-26 15:33:18 -03:00
c7459e3855
GDScript: Use analyzer data to decide assignment conversion
...
Since there might be tricky cases in the analyzer (in the case of unsafe
lines) which would need to be properly checked again. Instead, this
splits the code generator in two functions and use information set by
the analyzer to tell which function to use, without a need to re-check.
2021-05-26 14:09:00 -03:00
f8e34209af
Fix some warnings raised by GCC-11.1
2021-05-25 17:23:53 +02:00
da5d7db610
Rename File::get_len() get_length()
2021-05-25 11:54:28 +01:00
215e43242c
Merge pull request #49037 from vnen/fix-callable-freed-crash
2021-05-24 19:52:32 +02:00
ea44744e2d
Make Callable not crash on call when the object has been freed
...
Also add a GDScript test for this case.
2021-05-24 14:23:02 -03:00
ffdb3cccd2
GDScript: Fix error handler for tests
...
This changes the error message to be more clear on the output files and
also fixes an issue with the relative path of the offending file that
was not trimmed correctly.
2021-05-24 14:17:20 -03:00
b1859510ab
Change behavior of String.right
2021-05-20 23:07:57 +02:00
4219a4cb6f
Fix typos with codespell
...
Using codespell 2.0.0.
Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
curvelinear
dof
doubleclick
fave
findn
GIRD
leapyear
lod
merchantibility
nd
numer
ois
ony
que
seeked
synching
te
uint
unselect
webp
EOF
$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2021-05-20 12:38:56 +02:00
169268ae20
Merge pull request #48657 from Calinou/test-add-gdscript
...
Add a unit test suite for GDScript
2021-05-19 20:49:03 +02:00
7b261d1cb7
Show colored rects for autocompletion of Color constants in functions
2021-05-19 14:40:03 +03:00
cdb3726fe6
Merge pull request #48347 from Blackiris/fix-temporary-key-not-released
...
GDScript: Fix temporary value not released when used as a dictionary key
2021-05-17 18:50:25 -03:00
2fcfc83da9
Merge pull request #48793 from vnen/gdscript-fix-temp-type-adjust
...
GDScript: Fix crash caused by uninitialized temp stack slots
2021-05-17 17:34:19 +02:00
10a1f64968
GDScript: Fix crash caused by uninitialized temp stack slots
...
This adds initialization to every typed temporary stack slot at the
beginning of the function call instead of emitting instructions, since
those might be in a conditional branch and not be called.
2021-05-17 10:59:43 -03:00
469fa47e06
Make all file access 64-bit (uint64_t)
...
This changes the types of a big number of variables.
General rules:
- Using `uint64_t` in general. We also considered `int64_t` but eventually
settled on keeping it unsigned, which is also closer to what one would expect
with `size_t`/`off_t`.
- We only keep `int64_t` for `seek_end` (takes a negative offset from the end)
and for the `Variant` bindings, since `Variant::INT` is `int64_t`. This means
we only need to guard against passing negative values in `core_bind.cpp`.
- Using `uint32_t` integers for concepts not needing such a huge range, like
pages, blocks, etc.
In addition:
- Improve usage of integer types in some related places; namely, `DirAccess`,
core binds.
Note:
- On Windows, `_ftelli64` reports invalid values when using 32-bit MinGW with
version < 8.0. This was an upstream bug fixed in 8.0. It breaks support for
big files on 32-bit Windows builds made with that toolchain. We might add a
workaround.
Fixes #44363 .
Fixes godotengine/godot-proposals#400 .
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2021-05-17 15:06:19 +02:00
a7421612d0
Merge pull request #48767 from vnen/gdscript-builtin-static-methods
...
GDScript: Add support for builtin static method calls
2021-05-16 22:29:32 +02:00
ec783dd885
GDScript: Add support for builtin static method calls
2021-05-16 11:54:33 -03:00
6c528e4fae
Add a unit test suite for GDScript
...
This tests run-time script loading.
2021-05-12 16:20:57 +02:00
8962d36bb1
Merge pull request #33577 from Calinou/highlight-control-flow-keywords
...
Highlight control flow keywords with a different color
2021-05-07 00:52:50 +02:00
82522662f8
Fix temporary value not released when used as a dictionary key
2021-05-06 22:13:05 +02:00
ae2359fc1f
Merge pull request #47776 from Razoric480/foreport
...
Implement LSP didDeleteFiles & make parser aware of sub-nodes
2021-05-06 20:46:18 +02:00
ee4ef9709d
Merge pull request #46714 from HaSa1002/fix-gdscript-underscore-strict
...
Fix GDScript Tokenizer being very strict about the number of underscores
2021-05-06 20:19:45 +02:00
3f078c99f6
Rename `IP_Unix`, `IP_Address` and `TCP_Server` to remove underscores
2021-05-06 02:52:01 +02:00
e905e8f145
Highlight control flow keywords with a different color
...
This makes them easier to distinguish from other keywords.
2021-05-05 22:38:12 +02:00
302b6ef576
Merge pull request #47798 from ray90514/bug#47620
...
Fix constants at function scope are not defined as constants for completion
2021-05-04 08:20:03 +02:00
4e06731346
Merge pull request #47958 from Xrayez/gdscript-rename-test-scripts
...
Rename GDScript test script filenames to use `snake_case`
2021-05-03 15:44:46 +02:00
5b16020846
Replace remaining uses of `NULL` with `nullptr`
...
Follow-up to #38736 (these uses were likely added after this PR was merged).
2021-04-29 11:53:27 +02:00
9ed0f0384c
GDScript: Fix crash when base of an attribute is invalid
...
In attribute expressions (`a.b`) it's possible that the base has an
incorrect syntax and thus become a nullptr expression in the tree. This
commit add the check for this case to fail gracefully instead of
crashing.
2021-04-28 11:09:40 -03:00
c201b212c7
GDScript: Implement lambdas compilation and runtime
2021-04-28 11:09:38 -03:00
3155368093
GDScript: Add lambdas to the type analyzer
...
- Lambdas are always callables (no specific signature match).
- Captures from the current context are evaluated.
2021-04-28 10:56:16 -03:00
c6e66a43b0
GDScript: Add lambda syntax parsing
...
Lambda syntax is the same as a the function syntax (using the same
`func` keyword) except that the name is optional and it can be embedded
anywhere an expression is expected. E.g.:
func _ready():
var my_lambda = func(x):
print(x)
my_lambda.call("hello")
2021-04-28 10:56:16 -03:00
8247667a3e
Core: Drop custom `copymem`/`zeromem` defines
...
We've been using standard C library functions `memcpy`/`memset` for these since
2016 with 67f65f6639
2021-04-27 16:26:27 +02:00
5d124c4a8f
Remove uses of `auto` for better readability and online code reviews
...
The current code style guidelines forbid the use of `auto`.
Some uses of `auto` are still present, such as in UWP code (which
can't be currently tested) and macros (where removing `auto` isn't
easy).
2021-04-26 14:59:28 +02:00
d1dc28e46c
Merge pull request #48139 from vnen/gdscript-dict-keys
...
Fix mismatch between String and StringName in dictionary keys
2021-04-24 19:46:59 +02:00
db90ab86b9
Merge pull request #47891 from Razoric480/lsp-update-filesystem
...
Make LSP update the filesystem for changed scripts
2021-04-24 13:17:31 +02:00
1e4ff2ede6
GDScript: Make sure Lua-style dicts use StringName as keys
2021-04-23 16:00:23 -03:00
c7511de02e
GDScript: Fix resolution of dictionary keys
...
There was a mixup between String and StringName keys. Now they're
clearly separated. This also means you have to consider which type
you're using for the dictionary keys and how you are accessing them.
2021-04-23 15:42:33 -03:00
a9ecf66342
Merge pull request #47956 from vnen/gdscript-double-stack
...
GDScript: Use special stack space for temporaries to reduce type changes
2021-04-20 17:39:09 +02:00
1e26bf23c2
Rename GDScript test script filenames to use `snake_case`
2021-04-16 22:16:19 +03:00
9411bf05a4
GDScript: Adjust type of temporaries when needed
2021-04-16 12:04:08 -03:00
200d9a734c
Merge pull request #47701 from vnen/gdscript-test-runner
2021-04-16 10:34:39 +02:00
40502a1689
GDScript: Pool temporary values by type on the stack
...
So the stack slots perform less type changes, which is useful for
future optimizations.
2021-04-14 14:35:51 -03:00
b16bb33a5b
Make LSP update the filesystem of changed scripts
...
This updates global classes and exposes base member variables.
Fixes #39713
2021-04-14 13:12:39 -04:00
8fc4a732de
Merge pull request #47330 from Blackiris/fix-corrupt-scene-when-export-has-setter
...
Fix corrupt scene when export var has setter
2021-04-14 10:00:57 -03:00
79a16b8a44
Fix corrupt scene when export var has setter
2021-04-14 09:14:50 +02:00
9936abb3d5
Fix type argument in is_builtin which was treated as an address
2021-04-11 20:34:48 +02:00
1f9524bf57
Fix Constants at function scope are not defined as constants for autocompletion
2021-04-11 22:41:04 +08:00
39f7408ccb
Implement LSP didDeleteFiles & make parser aware of sub-nodes
2021-04-10 15:21:59 -04:00
cf4079cb5f
Reduce number of addressing modes in GDScript VM
...
There's now only 3 addressing modes: stack, constant, and member.
Self, class, and nil are now present respectively in the first 3 stack
slots. Global and class constants are moved to local constants when
compiling. Named globals is only present on editor to use on tool
singletons, so its use now emits a new instruction to copy the global to
the stack.
This allow us to further optimize the VM later by embedding the
addressing modes in the instructions themselves, which is better done
with less permutations.
2021-04-08 14:29:55 -03:00
5f77f38573
Add runner for GDScript testing
...
This is meant for testing the GDScript implementation, not for testing
user scripts nor testing the engine using scripts.
Tests consists in a GDScript file and a .out file with the expected
output. The .out file format is: expected status (based on the enum
GDScriptTest::TestStatus) on the first line, followed by either an error
message or the resulting output. Warnings are added after the first
line, before the output (or compiler errors) if the parser pass without
any error.
The test script must have a function called `test()` which takes no
argument. Such function will be called by the test runner. The test
should not have any dependency unless it's part of the test too. Global
classes (using `class_name`) are registered before the runner starts, so
those should work if needed.
Use the command `godot --gdscript-generate-tests
godot-source/modules/gdscript/tests/scripts` to update the .out files
with the current output (make sure the output are the expected values
before committing).
The tests themselves are part of the doctest suite so those can be
executed with `godot --test`.
Co-authored-by: Andrii Doroshenko (Xrayez) <xrayez@gmail.com>
2021-04-08 09:34:59 -03:00
40dff7117a
Merge pull request #47648 from Blackiris/fix-gdscript-editor-hangs
...
Fix infinite loop when guessing argument type from parent class
2021-04-07 23:19:29 +02:00
43c1c680f0
Fix stack overflow in setter
2021-04-06 19:00:08 +02:00
20f18f1621
Fix infinite loop when guessing argument type from parent class
2021-04-05 16:39:41 +02:00
5b2c4ad91c
Merge pull request #47569 from vnen/gdscript-typed-return
...
GDScript: Properly validate return type
2021-04-05 15:16:43 +02:00
35682d3079
GDScript: Properly validate return type
...
When the type cannot be validated at compile time, the runtime must do a
check to ensure type safety is kept, as the code might be assuming the
return type is correct in another place, leading to crashes if the
contract is broken.
2021-04-05 09:52:05 -03:00
d83761ba80
Style: Apply clang-tidy's `readability-braces-around-statements`
2021-04-05 14:09:59 +02:00
9bbe51dc27
Style: Apply clang-tidy's `modernize-use-nullptr`
2021-04-05 14:05:07 +02:00
3168c2a513
Fix GDScript variables addresses getting mixed
2021-04-04 19:03:15 +02:00
4b6e9f3157
Merge pull request #46991 from madmiraal/rename-invert-reverse
...
Rename Array.invert() to Array.reverse()
2021-04-01 13:32:22 +02:00
737f09895d
Merge pull request #47131 from vnen/gdscript-export-fix
...
Fix a few issues with @export in GDScript
2021-03-30 15:12:04 +02:00
7c14e987b4
Merge pull request #47492 from vnen/gdscript-typed-arrays
...
GDScript: Fix array type check on constants
2021-03-30 14:37:42 +02:00
5d9585d83b
GDScript: Fix array type check on constants
...
They mistakenly pointing to the wrong union member (variable instead of
constant).
2021-03-30 09:09:13 -03:00
2b9be53243
GDScript: Implement export of typed arrays
2021-03-30 08:29:38 -03:00
160c260495
GDScript: Allow export of enum variables
...
Also fix the enum type in variables to be integer.
2021-03-30 08:29:38 -03:00
3e4ecd9669
GDScript: Show error on invalid initializer expression
2021-03-30 08:29:38 -03:00
577a17980d
Move GDSript annotation application after type-checking
...
This ensures that annotations that rely on the datatype (such as
@export) can validated it timely, allowing compound expressions instead
of only literal values.
2021-03-30 08:29:36 -03:00
aba03110ba
Merge pull request #46830 from vnen/gdscript-typed-arrays
...
GDScript typed arrays
2021-03-29 16:47:38 +02:00
85e316a5d5
Add typed arrays to GDScript
...
- Use `Array[type]` for type-hints. e.g.:
`var array: Array[int] = [1, 2, 3]`
- Array literals are typed if their storage is typed (variable
asssignment of as argument in function all). Otherwise they are
untyped.
2021-03-29 10:45:48 -03:00
eeba8d63f8
Merge pull request #44398 from RevoluPowered/unit-tests-for-export-templates
...
Add unit tests for export templates
2021-03-23 00:42:29 +01:00
6b4ff3b44b
Add unit tests for export templates
2021-03-22 18:57:08 +00:00
755c70b871
Rename Array.invert() to Array.reverse()
...
Does the same internally for List and Vector<>, which includes all
PackedArray types.
2021-03-21 10:20:08 +00:00
d7ac5ba1c6
Fix missing quote in multiline GDScript string
...
fix #47117
2021-03-19 01:24:18 +01:00
6edb0a75ab
Merge pull request #46936 from DavidSichma/match_temp_header
...
Fixed match test expression for temporaries
2021-03-14 15:46:53 +01:00
762bb5843b
Fixed match test expression for temporaries
...
Fixed that a potentially popped temporary was used for the value in
match statements.
2021-03-12 15:04:45 +01:00
91181c2086
Fixes small typos and grammar correction
2021-03-12 19:05:16 +05:30
ba1344408f
Implement Navigation layers
2021-03-10 11:23:06 +01:00
982a0ac348
Fix GDScript Tokenizer being very strict about the number of underscores
...
You can use multiple underscores in one number, just not two of them
together.
2021-03-06 01:57:37 +01:00
66a5002750
Fixed match for expression pattern
...
equality comparison now writes to right target address
2021-03-02 19:18:29 +01:00
16e88f99e2
Merge pull request #42029 from ThakeeNathees/export-type-infer-bug-fix
...
GDScript export array/dictionary type infer bug fix
2021-03-02 12:14:57 -03:00
d86369b590
Merge pull request #46559 from asmaloney/fix-code-completion
...
Script editor: Fix two special cases not being checked in code completion
2021-03-02 15:39:13 +01:00
75bfb016f2
Merge pull request #41897 from strank/not-in-conditional-done
...
Add a "not in" operator to GDScript.
2021-03-02 15:16:52 +01:00
4e89cb330b
[script editor] Fix two special cases not being checked in code completion
...
When this code was changed for 4.0, a "break" statement inside a for loop in 3.x was changed to "return".
This means that the two special cases (autoloads and input actions) are never checked.
Removing the return lets these work properly in the editor.
(Also reorder conditionals to short-circuit and avoid expensive methods.)
2021-03-01 09:39:03 -05:00
b7b70004bc
Merge pull request #46379 from ThakeeNathees/signal-idf-not-found-fix
...
GDScript: False positive "Identifier not found" error on signals fixed
2021-02-25 22:30:22 +01:00
ee5ea64e83
Merge pull request #40276 from Taywee/master
...
remove invalid codeLensProvider value from lsp
2021-02-25 17:26:26 +01:00
9869522e6a
false positive "Identifier not found" error or signals fixed
2021-02-24 19:34:01 +05:30
a5d931033e
Fixed Invalid function bindings #46135
...
Fixed GDScriptLanguageProtocol::notify_client - have 3 arguments, but only 2 are binded
2021-02-18 11:12:54 +05:30
f8d03b98e7
Improve resource load cache
...
-Added a new method in Resource: reset_state , used for reloading the same resource from disk
-Added a new cache mode "replace" in ResourceLoader, which reuses existing loaded sub-resources but resets their data from disk (or replaces them if they chaged type)
-Because the correct sub-resource paths are always loaded now, this fixes bugs with subresource folding or subresource ordering when saving.
2021-02-11 15:44:28 -03:00
f7209b459b
Initialize class/struct variables with default values in modules/
2021-02-08 10:57:18 +01:00
5525cd85c6
Merge pull request #45315 from RandomShaper/modernize_thread
...
Modernize Thread
2021-01-31 15:24:56 +01:00
99fe462452
Modernize Thread
...
- Based on C++11's `thread` and `thread_local`
- No more need to allocate-deallocate or check for null
- No pointer anymore, just a member variable
- Platform-specific implementations no longer needed (except for the few cases of non-portable functions)
- Simpler for `NO_THREADS`
- Thread ids are now the same across platforms (main is 1; others follow)
2021-01-29 12:02:13 +01:00
e829b7aee4
Unify URI encoding/decoding and add to C#
...
http_escape and percent_encode have been unified into uri_encode, and http_unescape and percent_decode have been unified into uri_decode.
2021-01-28 07:45:01 -05:00
749d0c708c
Fix highlight color for class attributes that are also keywords
2021-01-26 15:17:18 +01:00
51992250e6
Merge pull request #43176 from mateosss/crash-uninit-const
...
Fix crash by adding nullcheck for uninitialized constants
2021-01-11 14:00:54 +01:00
6d48943768
Merge pull request #43980 from gvekan/fix-missing-function-hints
...
Fix missing function hints
2021-01-11 13:54:22 +01:00
c17413f159
Merge pull request #44104 from nekomatata/coroutine-await-fix
...
Fix error when calling coroutine with await in _ready
2021-01-11 13:54:04 +01:00
813bdb4941
Merge pull request #44005 from RandomShaper/gds_needless_check
...
Remove useless check in GDScript
2021-01-11 13:53:52 +01:00
3e9a40cdc0
Merge pull request #44604 from lyuma/gdscript_dictionary_crash
...
GDScript: Fix crash when iterating through empty dictionary.
2021-01-11 13:53:12 +01:00
8363c44265
Merge pull request #44719 from ThakeeNathees/assert-argument-bug-fixed
...
GDScript assert message parsing bug fixed
2021-01-11 13:51:44 +01:00
a2021588ca
Merge pull request #44672 from ThakeeNathees/array-dict-const-fold-bug-fix
...
Array/Dictionary marked as not safe to const fold
2021-01-11 13:51:31 +01:00
bcfb698fb4
Merge pull request #44818 from ThakeeNathees/const-crash-fix
...
GDScript crash at incomplete const bug fix
2021-01-11 13:51:18 +01:00
aaf6725150
Merge pull request #44889 from ThakeeNathees/builtin-invalid-call-crash-fix
...
GDScript invalid method call on built-in crash fix
2021-01-11 13:51:07 +01:00
0dba21a4d1
Merge pull request #45076 from ThakeeNathees/gdscript-operator-precedence-bug-fix
...
GDScript operator `+` `-` precedence bug fix
2021-01-11 13:50:00 +01:00
0889f14af9
GDScript operator `+` `-` precedence bug fix
...
Fix : #43265
2021-01-10 18:33:05 +05:30
215d18814e
doc: Sync classref with current source
2021-01-04 14:33:44 +01:00
01c11ec29b
GDScript builtin invalid function call crash fix
...
Fix : #44852
2021-01-03 18:44:01 +05:30
b5334d14f7
Update copyright statements to 2021
...
Happy new year to the wonderful Godot community!
2020 has been a tough year for most of us personally, but a good year for
Godot development nonetheless with a huge amount of work done towards Godot
4.0 and great improvements backported to the long-lived 3.2 branch.
We've had close to 400 contributors to engine code this year, authoring near
7,000 commit! (And that's only for the `master` branch and for the engine code,
there's a lot more when counting docs, demos and other first-party repos.)
Here's to a great year 2021 for all Godot users 🎆
2021-01-01 20:19:21 +01:00
18f30dda63
GDScript crash at incomplete const bug fix
2020-12-30 23:27:46 +05:30
b743a2ef3c
Rename Math::stepify to snapped
2020-12-28 13:01:30 +00:00
5b937d493f
Rename empty() to is_empty()
2020-12-28 10:39:56 +00:00
ebade0e454
GDScript assert message parsing bug fixed
...
Fix : #43540
2020-12-27 13:13:50 +05:30
16bb01adfb
Array/Dictionary marked as not safe to const fold
...
Fix : #44459
2020-12-25 12:33:55 +05:30
0d4b750051
Fix crash when iterating through empty dictionary.
2020-12-21 20:15:29 -08:00
2e4ee06b7a
Fix error when calling coroutine with await in _ready
...
The code paths for calling async functions seemed to be missing in some
cases, causing a debug break and false positive error.
2020-12-17 09:01:39 -07:00
88b8c3ec00
Merge pull request #44424 from briansemrau/gdscript-fix-and
...
Fix gdscript `and` operator
2020-12-16 14:42:56 +01:00
61ac640aa0
Fix gdscript and operator
2020-12-16 07:41:10 -05:00
7d07e20bda
fixes crash in disassemlber for opcode OPCODE_ASSIGN_TYPED_NATIVE
2020-12-15 21:44:52 -06:00
94b15bfb89
Merge pull request #44275 from vnen/variant-function-arg-pointers
...
Use pointer parameters in Variant function pointers
2020-12-15 20:52:03 +01:00
abfc528439
Merge pull request #43890 from vnen/gdscript-builtin-functions-refactor
...
GDScript: Refactor builtin functions
2020-12-15 20:51:38 +01:00
4fd20015f3
Pow method doc fix
2020-12-13 17:53:30 -05:00
e4e9231420
Use pointer parameters in Variant function pointers
...
Instead of references. This is needed because those function pointers
are used in GDNative which needs to work with plain C, which doesn't
support passing parameters by reference.
2020-12-10 18:18:47 -03:00
cf62289d24
LSP: Fix iterator in enum API dump
2020-12-09 13:34:29 +01:00
644f739660
Static analyzer fixes:
...
Removes unused code in OS.
Fixes return types.
Fixes few typos.
2020-12-09 10:17:53 +02:00
90bdba576a
Merge pull request #43742 from qarmin/editor_modules_default_values
...
Initialize class/struct variables with default values in platform/ and editor/
2020-12-08 15:53:42 +01:00
a211812932
Constify ScriptLanguage.can_inherit_from_file
2020-12-08 13:06:15 +01:00
87d73faa66
Fix base script not initialized properly in some cases
...
Storing script references to pointer only in result.script_type could
lead to losing the last reference, causing further conversions from
Script* to Ref<Script> to fail.
Now result.script_type_ref is always set first, and then cleared in the
specific case of the script being the owner, to avoid cyclic reference
issues.
2020-12-06 08:20:33 -07:00
ea7dd1be36
Merge pull request #43328 from gvekan/better-keyword-completion
...
Add bracket or space to some keyword completions
2020-12-03 17:14:32 +01:00
9c30c83aee
Merge pull request #44011 from KoBeWi/red_roses_minus_blue_violets
...
Fix subtracting colors and quats
2020-12-03 14:44:52 +01:00
4c232e4222
Fix subtracting colors and quats
2020-12-03 14:22:12 +01:00
9a0610c1ff
Merge pull request #43959 from dalexeev/gds-doc
...
Several edits to the GDScript docs
2020-12-03 13:32:32 +01:00
dff3875ae3
Add bracket or space to some keyword completions
2020-12-03 09:44:42 +01:00
e1811b689b
Initialize class/struct variables with default values in platform/ and editor/
2020-12-02 16:09:11 +01:00
d1231be1c8
Merge pull request #41095 from ThakeeNathees/GDScript-Documentation
...
GDScript(2.0) Documentation generation system
2020-12-02 14:15:38 +01:00
0019aa940e
Merge pull request #41773 from ThakeeNathees/default-argument-override-buf-fix
...
GDScript default argument override bug fix
2020-12-02 09:54:47 -03:00
42bfa16996
Refactor DocData into core and editor (DocTools) parts
2020-12-02 00:48:39 +05:30
bf96056ad0
Several edits to the GDScript docs
2020-12-01 16:05:10 +03:00
86ece881e5
Remove useless check in GDScript
...
The removed check was adding a protection for the case where a `Reference` has not yet got its reference count initialized and a script is called on it. That would cause the object to be released after the call. The removed code was constructing the `Variant` via the `Object` constructor so it didn't deal with the reference count and so the release was prevented.
However, `Variant` no longer works that way so that check was useless. Now it's just illegal to run GDScript on a Reference whose reference count has not been initialized.
2020-12-01 12:28:52 +01:00
04bef80b42
Merge pull request #43992 from vnen/variant-internal-object-set
...
Fix VariantInternal initialization and setting of object
2020-11-30 20:22:15 +01:00
8f3dde18f1
Merge pull request #43504 from AndreaCatania/gds_fix_2
...
Implement proper error print, Fixes a crash when no error messages are generated by the analyser.
2020-11-30 19:10:38 +01:00
029fd88adb
Fix VariantInternal initialization and setting of object
...
- Initialize Object pointer to nullptr so it's not used by mistake.
- When setting an Object check if it's a reference so refcounting works
as intended.
2020-11-30 14:49:52 -03:00
a604e72dc9
GDScript: Don't construct ref values in compiler
...
Values that are passed by reference are not suited for being constructed
at compile time because in this case they would be shared across all the
construction statements.
2020-11-30 09:42:22 -03:00
e995d5c378
Fix missing function hints
2020-11-30 09:26:32 +01:00
d0e7d9b62f
Documentation generation for GDScript
...
- ClassDoc added to GDScript and property reflection data were extracted
from parse tree
- GDScript comments are collected from tokenizer for documentation and
applied to the ClassDoc by the GDScript compiler
- private docs were excluded (name with underscore prefix and doesn't
have any doc comments)
- default values (of non exported vars), arguments are extraced from the
parser
- Integrated with GDScript 2.0 and new enums were added.
- merge conflicts fixed
2020-11-29 19:45:36 +05:30
d42b305377
GDScript default argument override bug fix
...
Fix : #41766
2020-11-28 20:42:57 +05:30
40403b02fb
Implement proper error print, Fixes a crash when no error messages are generated by the analyser.
2020-11-28 13:47:52 +01:00
d395f70828
Merge pull request #43500 from AndreaCatania/gds_fixes
...
Fixes crash when parse_expression returns nullptr.
2020-11-27 16:37:45 +01:00
9f9b269d32
Merge pull request #43914 from ThakeeNathees/range-argument-type-bug-fix
...
GDScript: range function type check bug fixed
2020-11-27 15:08:02 +01:00
cf7a6be1db
Merge pull request #43226 from mateosss/unreachable-prop-crash
...
Fix crash due to unreachable code in properties
2020-11-27 11:03:20 -03:00
f0613a91be
GDScript range function typecheck bug fixed
...
Fix : #43586
2020-11-27 18:23:35 +05:30
fbb806fd68
Unregister GDScriptFunctionState class
...
This is not user accessible anymore so it does not need to be show in
documentation.
2020-11-26 21:39:54 -03:00
ed2f84735b
Merge pull request #43895 from vnen/gdscript-operators-fix
...
GDScript: Improve handling of operators
2020-11-26 21:19:31 +01:00
e5ff2d0ffd
Merge pull request #43894 from vnen/gdscript-some-fixes
...
Some GDScript fixes
2020-11-26 18:56:42 +01:00
0cb185927c
GDScript: Improve handling of operators
...
- Use the new functions in Variant to determine the validity and resulting
type of operators.
- Split the operator function in codegen between binary and unary, since
the unary ones have now a special requirement of having the second
argument to be the NIL type when requesting info.
2020-11-26 14:41:55 -03:00
627ca7f30e
GDScript: Don't clear depended parsers too soon
...
It can wait until the analyzer itself is destructed, otherwise other
phases might be using freed parsers.
2020-11-26 14:14:29 -03:00
817fb3d702
GDScript: Give an error if dependency can't be parsed
...
Otherwise this may lead to a crash when the dependency is not present.
2020-11-26 12:27:48 -03:00
c7b6a7adcc
GDScript: Refactor builtin functions
...
They are now called "utility functions" to avoid confusion with methods
of builtin types, and be consistent with the naming in Variant.
Core utility functions are now available in GDScript. The ones missing
in core are added specifically to GDScript as helpers for convenience.
Some functions were remove when there are better ways to do, reducing
redundancy and cleaning up the global scope.
2020-11-26 12:05:42 -03:00
afa15c5f15
fixes crash for OPCODE_CAST_TO_NATIVE opcode in gdscript disassemlber
2020-11-25 16:26:32 -06:00
fc28de64c4
Merge pull request #43856 from vnen/gdscript-some-fixes
...
A couple of GDScript fixes
2020-11-25 17:13:41 +01:00
ed3d8f31df
GDScript: Fix return of cast expression on compilation
...
It was mistakenly returning the source instead of the result.
2020-11-25 11:37:51 -03:00
fb3dc2670a
GDScript: Fix range() being treated as array when optimized out
...
The call of range() in a for loop is optimized to use int or vectors, to
avoid allocating an array, however the type was set as array still. With
the new typed VM this is an issue as the type mismatch the actual value,
resulting in wrong instructions to be selected.
2020-11-25 11:35:07 -03:00
2e528ef382
GDScript: Fix mishandling of stack pointers
...
- Replace the for loop temporaries by locals. They cause conflicts with
the stack when being popped, while locals are properly handled in the
scope.
- Change the interface for the codegen so the for loop list doesn't live
through the whole block if it's a temporary.
- Keep track of the actual amount of local variables in the stack. Using
the size of the map is misleading in cases where multiple locals have
the same name (which is allowed when there's no shadowing).
- Added a few debug checks for temporaries, to avoid them being wrongly
manipulated in the future. They should not live more than a line of
code.
- Rearrange some of compiler code to make sure the temporaries don't
live across blocks.
2020-11-25 11:24:13 -03:00
5518e2a68e
GDScript: Add faster instruction for validated constructor
...
Only for built-in types.
2020-11-21 13:30:17 -03:00
e0dca3c6b6
GDScript: Add typed iterate instructions
2020-11-21 13:24:50 -03:00
52ab64db69
GDScript: Add faster call instructions for builtin methods
...
Methods from builtin types can be called by using the function pointer
when the argument and base types are known at compile time.
2020-11-21 13:24:50 -03:00
d8b22097f2
GDScript: Add faster call instructions for native methods
2020-11-21 13:24:50 -03:00
5aeb390cd7
GDScript: Add speficic set/get instructions
...
When the base type is known at compile-time, we can get a direct
function pointer that is faster than the regular set/get paths.
2020-11-21 13:24:49 -03:00
1ad5c926dc
GDScript: Add faster operator for known types
...
It now uses the direct operator function pointer, which increases
performance in evaluation.
2020-11-21 13:24:49 -03:00
c707d6fe71
GDScript: Gather instructions arguments beforehand
...
Almost all instructions need variant arguments. With this change they
are loaded in an array before each instruction call. This makes the
addressing code be localized to less places, improving compilation
overhead and binary size by a small margin.
This should not affect performance.
2020-11-21 13:24:49 -03:00
b6519d0d03
GDScript: Split Function code into multiple files
...
To improve organization and reduce the size of compilation units.
2020-11-21 13:24:49 -03:00
02161aad5a
Remove empty lines around braces with the formatting script
2020-11-16 23:38:11 -05:00
98daa0af6b
Fixes crash when returns .
2020-11-13 15:09:52 +01:00
8bcd345782
GDScript: Fix native class not set with inheritance
2020-11-13 10:35:24 -03:00
635d33dc6c
Refactor variant built-in methods yet again.
...
* Using C-style function pointers now, InternalMethod is gone.
* This ensures much better performance in typed code.
* Renamed builtin_funcs to utility_funcs, to avoid naming confusion
2020-11-11 16:36:36 -03:00
ee79fc627c
Minor clamp and float fixes
2020-11-10 14:30:07 -05:00
0ddd4097a6
Fix completion for built-in load function
2020-11-10 12:00:08 +01:00
68067b8d97
Merge pull request #43423 from Calinou/doc-assert-avoid-side-effects
...
Clarify that code in `assert()` should avoid side effects
2020-11-10 11:31:28 +01:00
0f249f5c0a
Variant: Sync docs with new constructors, fixups after #43403
...
Change DocData comparators for MethodDoc and ArgumentDoc to get a better
ordering of constructors.
2020-11-09 23:39:53 +01:00
Rémi Verschelde
Chris Bradfield
SaracenOne
Marvin Ewald
Markus Sauermann
Jakob Bouchard
Hugo Locurcio
Hendrik Brucker
strank
Rémi Verschelde
Fabio Alessandrelli
fabriceci
Yuri Roubinsky
bruvzg
Anilforextra
George Marques
trollodel
Wilson E. Alvarez
cdemirer
TechnoPorg
K. S. Ernest (iFire) Lee
kobewi
Pedro J. Estébanez
Paulb23
luz paz
NNesh
Ger Hean
Nathan Franke
Xwdit
Gilles Roudière
Francois Belair
Raul Santos
Lightning_A
Pawel Lampe
Maximilian
Brian Semrau
Aaron Franke
Max Hilbrunner
reduz
Bartłomiej T. Listwon
Marcel Admiraal
Benjamin Navarro
opl-
Yuri Sizov
mashumafi
David Sichma
ZuBsPaCe
Max Hilbrunner
Gordon MacPherson
John J. Donna II
ThreeRhinosInAnElephantCostume
jmb462
Julien Nguyen
Jonathan Gollnick
William Deurwaarder
K. S. Ernest (iFire) Lee
Lyuma
Balloonpopper
Louis Dumont
Michael Alexsander
Mariano Suligoy
PouleyKetchoupp
Ev1lbl0w
Eric M
Bastiaan Olij
Владислав Прусаков
Heikki Simojoki
jfons
Andrii Doroshenko (Xrayez)
ray90514
Alex Hirsch
David Sichma
Anshul7sp1
Johannes
Andy Maloney
Thakee Nathees
Vignesh1-art
Rafał Mikrut
Lucas Van Mol
Jordan Schidlowsky
skyace65
Emmanuel Leblond
Gustav
Danil Alexeev
AndreaCatania