Commit Graph

3601 Commits

Author SHA1 Message Date
Rémi Verschelde 6e43c68e40
Merge pull request #44182 from clayjohn/ASSAO
Replace SAO with ASSAO as Godot's new SSAO
2020-12-22 11:27:25 +01:00
clayjohn 44f8922305 Port ASSAO to Godot to replace SAO 2020-12-21 23:08:59 -08:00
Rémi Verschelde 6532596d97
Merge pull request #44472 from winterpixelgames/PR-duplicate-packedarrays
Add support for duplicate() for Packed*Array, and they are pass by ref in godot 4.0
2020-12-21 17:30:01 +01:00
Marcel Admiraal 7b293eddfb Rename unselect to deselect 2020-12-21 10:26:41 +00:00
Marcel Admiraal fdf92ca298 Rename XRPositionalTracker methods
Renames:
- set_type() -> set_tracker_type()
- set_name() -> set_tracker_name()
- get_tracks_orientation() - `is_tracking_orientation()
- get_tracks_position() -> `is_tracking_position()
- get_hand() -> get_tracker_hand()
- set_hand() -> set_tracker_hand()
2020-12-21 06:32:53 +00:00
Rémi Verschelde bccbd4be90
Merge pull request #44261 from madmiraal/rename-trackerhand-enums
Rename TrackerHand enums
2020-12-21 00:26:44 +01:00
Rémi Verschelde 5f7c88ab4e
Merge pull request #44525 from Calinou/doc-procedural-mesh-uv-jittering
Document how to solve UV jittering when using large procedural meshes
2020-12-21 00:17:46 +01:00
Rémi Verschelde fa9332a0e7
Merge pull request #43414 from Xrayez/pi-type-string
Expose `PROPERTY_HINT_TYPE_STRING` to scripting
2020-12-20 21:18:11 +01:00
Marcel Admiraal ecf8ae5bcf Rename Camera3D near and far getters and setters
Renames:
- get_znear() -> get_near()
- set_znear() -> set_near()
- get_zfar() -> get_far()
- set_zfar() -> set_far()
2020-12-20 13:46:57 +00:00
Pedro J. Estébanez b7367ac426 Add animation reset track feature
As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
2020-12-20 12:45:08 +01:00
Rémi Verschelde e9d12f9e4e
Merge pull request #44521 from madmiraal/rename-rect2-clip
Rename Rect2 and Rect2i clip() to intersection()
2020-12-19 21:32:14 +01:00
Hugo Locurcio a86ed339a4
Document how to solve UV jittering when using large procedural meshes 2020-12-19 18:16:52 +01:00
Marcel Admiraal e1128431de Rename EditorInterface get_editor_viewport to get_editor_main_control 2020-12-19 14:17:42 +00:00
Hugo Locurcio 7ae487d2bb
Increase the default Camera Zfar to 4000
This makes it possible to view far away objects without
having to tweak any settings. This results in a more usable
editor when working on large-scale levels.

This change should have no impact on performance, but note that
Z-fighting will be visible at a distance. This can be made less
visible by increasing the Znear value (however, doing so will cause
nearby surfaces to disappear).

This change was also applied to the editor, but it will only
apply to newly created scenes.

This also changes the default camera settings in the glTF importer
to match the Camera node's defaults.
2020-12-19 14:52:44 +01:00
Marcel Admiraal 2df9a8ccad Rename Rect2 and Rect2i clip() to intersection() 2020-12-19 12:59:08 +00:00
Rémi Verschelde 16524d4ae1
Merge pull request #44445 from theogen-ratkin/master
Add interpolation parameter to resize_to_po2()
2020-12-19 09:34:41 +01:00
Theogen Ratkin 46ea6750b4 Add interpolation parameter to resize_to_po2()
Image::resize_to_po2() now takes an optional p_interpolation parameter
that it passes directly to resize() with default value INTERPOLATE_BILINEAR.
2020-12-18 14:05:07 -04:00
Yuri Roubinsky 52e44ed3ef Added GraphEdit properties to control lines thickness and antialiasing 2020-12-18 16:41:45 +03:00
Jordan Schidlowsky 2d56e09276 packed*arrays are pass by ref now. support duplicate and update documentation 2020-12-17 16:09:32 -06:00
Yuri Sizov f5bcbd8325 FIx visual issues with GraphEdit minimap 2020-12-17 22:59:04 +03:00
Rémi Verschelde c83d1b2526
Merge pull request #43416 from pycbouh/graph-minimap
Add a minimap to the GraphEdit
2020-12-17 17:34:36 +01:00
Yuri Sizov 8d608cdc40 Remove unused argument in Theme method and expose missing methods 2020-12-17 15:51:08 +03:00
Rémi Verschelde f3dccf5891
Merge pull request #44393 from Calinou/add-stdout-flush-project-setting
Add a project setting to enable stdout flushing in release builds
2020-12-17 10:06:50 +01:00
Rémi Verschelde aa64834f72
Merge pull request #44295 from akien-mga/proximity-group-fix-access-modifiers
ProximityGroup: Fix access modifiers, rename private methods for clarity
2020-12-17 10:06:02 +01:00
Rémi Verschelde 9e49dbda2a
Merge pull request #44360 from bruvzg/ctl_punct_word_break
Add word breaks on punctuation characters.
2020-12-17 09:02:01 +01:00
Rémi Verschelde fb2465b3c8
Merge pull request #44410 from KoBeWi/project--tools--thisPR
Make tool menu plugins use Callables for callback
2020-12-16 22:04:39 +01:00
kobewi 889f5e44ef Make tool menu plugins use Callables for callback 2020-12-16 20:23:51 +01:00
Rémi Verschelde f17b34c479
Merge pull request #44341 from Faless/docs/4.x_os_unixtime
Add important note about OS.get_unixtime.
2020-12-16 14:30:25 +01:00
Rémi Verschelde b09332bd4e
Merge pull request #44404 from Chaosus/doc_direction_to
Added a note describing a code behind Vector2/3.direction_to
2020-12-16 14:18:59 +01:00
Rémi Verschelde 16a249bd22
Merge pull request #44414 from skyace65/TypeHint
Document what can be used as a type hint
2020-12-16 14:17:46 +01:00
Rémi Verschelde 3d7b01723b
Merge pull request #44412 from DanielZTing/rename
Rename neighbour in Control to neighbor
2020-12-16 14:16:28 +01:00
skyace65 dbcc9d3600 Document what can be used as a type hint 2020-12-15 19:16:43 -05:00
Daniel Ting aea7fde241 Rename neighbour in Control to neighbor
This keeps things consistent with the rest of Godot, which uses the
American English spelling of Color.
2020-12-15 16:42:21 -06:00
Yuri Roubinsky fa0683ed30 Added a note describing a code behind Vector2/3.direction_to 2020-12-15 22:36:26 +03:00
Rémi Verschelde 0415a2d913
Merge pull request #44391 from madmiraal/fix-42285
Remove Generic6DOFJoint precision property
2020-12-15 19:06:25 +01:00
Hugo Locurcio 341b9cf15a
Add a project setting to enable stdout flushing in release builds
This can be used in server builds for journalctl compatibility.
2020-12-15 16:40:52 +01:00
Rémi Verschelde 6ccc6b6e28
Merge pull request #44372 from madmiraal/rename-animation-track_remove_key_at
Rename Animation::track_remove_key_at_position to track_remove_key_at_time
2020-12-15 13:42:54 +01:00
Rémi Verschelde 7e3424e3ab
Merge pull request #44377 from Calinou/rename-textureprogressbar
Rename the TextureProgress node to TextureProgressBar
2020-12-15 13:34:32 +01:00
Marcel Admiraal 9bc62bf449 Remove Generic6DOFJoint precision property 2020-12-15 10:14:48 +00:00
Hugo Locurcio 57dcc83152
Rename the TextureProgress node to TextureProgressBar
Advantages:

- When searching for "progressbar", you'll see both nodes in the
  search results.
- More consistent with Button/TextureButton.
2020-12-14 21:35:13 +01:00
Marcel Admiraal 8509c8c8fc Rename AcceptDialog get_ok() to get_ok_button()
Also renames:
- AcceptDialog add_cancel() to add_cancel_button()
- ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:43:52 +00:00
Marcel Admiraal f5a3cbda19 Rename Animation::track_remove_key_at_position to track_remove_key_at_time 2020-12-14 18:00:11 +00:00
bruvzg 06ae77a320
Add word breaks on punctuation characters. 2020-12-14 11:36:13 +02:00
bruvzg 62927383ed
[Complex Text Layouts] Add drop-caps support to TextParagraph and RTL. 2020-12-13 22:20:02 +02:00
bruvzg c1d261fdb0
[Complex Text Layouts] Add variable fonts support. 2020-12-13 18:43:39 +02:00
Fabio Alessandrelli 49741d9464 Add important note about OS.get_unixtime.
Should NEVER be used for precise time computations since its return
values are not guaranteed to be monotonic.
2020-12-13 13:56:45 +01:00
Rémi Verschelde bbf7bb3838
Merge pull request #42595 from bruvzg/ctl_rich_text
[Complex Text Layouts] Refactor RichTextLabel.
2020-12-13 13:42:00 +01:00
Hugo Locurcio 91c19308dd
Document that BaseMaterial3D doesn't support height mapping + triplanar
See #44322.
2020-12-12 17:13:01 +01:00
Rémi Verschelde 0762484473
Merge pull request #44317 from mbrlabs/geometry2d-docs
Fixed Geometry2D::get_closest_points_between_segments docs
2020-12-12 13:03:09 +01:00
Marcus Brummer 56e5ca38d7 Fixed Geometry2D::get_closest_points_between_segments docs 2020-12-12 12:45:06 +01:00
Rémi Verschelde 79ba70f7ee
ProximityGroup: Fix access modifiers, rename private methods for clarity
See #36285 which mistakenly added documentation for the whole C++ API, while
some of it is meant to be and stay private as it's not exposed to scripts.
The access modifiers and method prefix were not used properly.

Cleanup code, and rename wrong `group_name` parameters to `method`, as it's a
method name which is being broadcast.

This is a very old class from pre-open source days, chances are that it was
just forgotten and not meant to be kept as is and undocumented.
2020-12-11 14:32:05 +01:00
bruvzg 6b6f101983
[Complex Text Layouts] Refactor RichTextLabel. 2020-12-11 09:48:49 +02:00
Rémi Verschelde 9263f8eb4b
Image: Rename PVRTC{2,4} to PVRTC1_{2,4}, drop COMPRESS_PVRTC2
We haven't had a proper implementation for COMPRESS_PVRTC2 (which is PVRTC1 2-bpp) in years,
so let's drop it instead of keeping a compress type which doesn't work.

The other enum values were renamed to clarify that our PVRTC2 and PVRTC4 are respectively
PVRTC1 2-bpp and PVRTC1 4-bpp. PVRTC2 2-bpp and 4-bpp are not implemented yet.
2020-12-10 23:14:04 +01:00
Marcel Admiraal 284642be01 Rename Viewport::ClearMode::CLEAR_MODE_ONLY_NEXT_FRAME to CLEAR_MODE_ONCE 2020-12-10 12:24:49 +00:00
Rémi Verschelde d8fdb8796a
Merge pull request #44260 from madmiraal/rename-area3d-audio_bus_name
Rename Area3D audio_bus_name getter and setter
2020-12-10 12:15:46 +01:00
Rémi Verschelde 37d0d757d6
Merge pull request #40708 from bruvzg/improve_os_locale
Improve `OS::get_locale()` and documentation.
2020-12-10 11:49:00 +01:00
Marcel Admiraal e40ab06599 Rename TrackerHand enums
Renames:
TRACKER_LEFT_HAND -> TRACKER_HAND_LEFT
TRACKER_RIGHT_HAND -> TRACKER_HAND_RIGHT
2020-12-10 10:30:45 +00:00
Rémi Verschelde 67259d07db
Merge pull request #44070 from YeldhamDev/popupmenu_separator_font_color
Add "font_color_separator" theme property to 'PopupMenu'
2020-12-10 11:13:07 +01:00
Rémi Verschelde bc9b54d6ab
Merge pull request #43920 from Calinou/doc-videoplayer-no-remapping
Document the lack of localization remapping support in VideoPlayer
2020-12-10 10:57:09 +01:00
Rémi Verschelde 47fc78b599
Merge pull request #44016 from KoBeWi/emit_me_senpai
Mention that 'changed' signal needs manual emit
2020-12-10 10:48:46 +01:00
Marcel Admiraal daa084d004 Rename Area3D audio_bus_name getter and setter 2020-12-10 08:31:14 +00:00
Rémi Verschelde 70c435272a
Merge pull request #44124 from volzhs/tabs-in-front
Add option to draw all tabs in front
2020-12-10 07:55:41 +01:00
volzhs 814f9015f8 Add option to draw all tabs in front 2020-12-10 07:47:10 +09:00
Rémi Verschelde 2034a1cca0
Merge pull request #44089 from Xrayez/rng-state
Add ability to restore `RandomNumberGenerator` state
2020-12-08 21:40:38 +01:00
Marcel Admiraal 43302837eb Rename CanvasItem's hide signal to hidden 2020-12-08 12:14:15 +00:00
Marcel Admiraal 4da4feed18 Use Vector3 instead of 3 floats for CSGBox3D dimensions 2020-12-08 11:58:30 +00:00
Marcel Admiraal 43c9106806 Use box size instead of extents for Shape dimensions 2020-12-08 11:58:21 +00:00
Marcel Admiraal d5d99aaed6 Use rectangle size instead of extents for Shape dimensions 2020-12-08 11:57:46 +00:00
Rémi Verschelde 0f6745b6aa
Merge pull request #44188 from madmiraal/tabs-signal-names
Rename Tabs close and hover signals to tab_closed and tab_hovered
2020-12-08 12:30:49 +01:00
Marcel Admiraal a65e609e21 Rename Tabs close and hover signals to tab_closed and tab_hovered 2020-12-08 09:51:06 +00:00
Marcel Admiraal 58c38d957b Rename XRController signal button_release to button_released 2020-12-08 08:37:48 +00:00
Andrii Doroshenko (Xrayez) b5107715f1 Add ability to restore `RandomNumberGenerator` state
- added `state` as a property to restore internal state of RNG;
- `get_seed()` returns last seed used to initialize the state rather than the current state.

Co-authored-by: MidZik <matt.idzik1@gmail.com>
2020-12-07 13:50:46 +02:00
Aaron Franke 5465e604bb
Improve argument names for core types 2020-12-07 05:01:33 -05:00
Marcel Admiraal a24c38d1a8 Rename Vector2.tangent() to Vector2.orthogonal() 2020-12-06 18:16:06 +00:00
Rémi Verschelde c574b4d086
Merge pull request #44091 from madmiraal/rename-cubemesh-boxmesh
Rename CubeMesh to BoxMesh
2020-12-05 16:48:15 +01:00
Marcel Admiraal df6b061dbb Rename CubeMesh BoxMesh 2020-12-05 11:48:26 +00:00
Aaron Franke 5dddf4377a
Rename RD texture "type" to "texture_type"
"type" isn't very descriptive for exposed code, and this variable is exposed via RD_SETGET.
2020-12-04 19:34:50 -05:00
Aaron Franke 19bdd01438
Rename RD uniform "type" to "uniform_type"
"type" isn't very descriptive for exposed code, and this variable is exposed via RD_SETGET.
2020-12-04 19:34:50 -05:00
Aaron Franke 40b81339d0
Rebind Mesh/ArrayMesh enums 2020-12-04 19:34:50 -05:00
Aaron Franke 47f8ac7864
Rename Particles/ParticlesMaterial "Flags" enum to "ParticleFlags"
"Flags" was a bit too ambiguous, and in 3D it hid GeometryInstance.Flags
2020-12-04 19:34:29 -05:00
Aaron Franke 1b499d244a
Rename LightOccluder2D light_mask to occluder_light_mask 2020-12-04 19:34:29 -05:00
Aaron Franke ce9d87ddfd
Rename PathFollow2D rotate bool 2020-12-04 18:59:02 -05:00
Aaron Franke 888deca827
Rename XR get_type and get_name
Now called get_tracker_type and get_tracker_name
2020-12-04 18:59:02 -05:00
Rémi Verschelde 1a001ad964
doc: Sync classref with current source
And fixups:
- Add missing bindings in RenderingServer
- Remove duplicate ArrayMesh enum bindings (they're in Mesh already)
- Remove redundant _unhandled_key_input binding in Control (it's in Node
  already)
2020-12-04 22:28:08 +01:00
George Marques 02f60812ed
Rename TYPE_REAL to TYPE_FLOAT
To be consistent with the naming everywhere else.
2020-12-04 09:47:26 -03:00
Tomasz Chabora b552c26c68 Mention that 'changed' signal needs manual emit 2020-12-03 20:11:52 +01:00
Michael Alexsander 383e8919e0 Add "font_color_separator" theme property to 'PopupMenu' 2020-12-03 11:36:03 -03:00
Rémi Verschelde 9a0610c1ff
Merge pull request #43959 from dalexeev/gds-doc
Several edits to the GDScript docs
2020-12-03 13:32:32 +01:00
Fabio Alessandrelli 502ff74fee
Merge pull request #43536 from jonbonazza/hmac
feat: HMAC support in Crypto APIs
2020-12-03 11:08:16 +01:00
Hugo Locurcio 5a9600cd24
Fix incorrect `Curve3D.interpolate_baked()` description
The offset is in 3D units, not pixels.

This closes https://github.com/godotengine/godot-docs/issues/4339.
2020-12-01 16:23:34 +01:00
Danil Alexeev bf96056ad0 Several edits to the GDScript docs 2020-12-01 16:05:10 +03:00
Yuri Sizov 999ce610a2 Add a minimap to the GraphEdit 2020-11-30 16:48:52 +03:00
Eric M 12ded391f5 Exposed shortcut_context property to scripting and added documentation.
I didn't expose this as a property or add documentation in the original PR #42109.
2020-11-30 00:11:40 +10:00
Rémi Verschelde ef2d1f6d19
Merge pull request #42761 from fire/color-grading-3d
Environment brightness, contrast, saturation restore with 3d LUT.
2020-11-28 23:07:52 +01:00
clayjohn 076908bed9 Environment brightness, contrast, saturation restore with color correction.
Allow gradients and 2d images.

Use shader versions for LUT in tonemap

Co-authored-by: alex-poe <3957610+CptPotato@users.noreply.github.com>
Co-authored-by: QbieShay <cislaghi.ilaria@gmail.com>
Co-authored-by: Clay John <claynjohn@gmail.com>
2020-11-28 07:37:49 -08:00
Rémi Verschelde 53b23c6bdc
Merge pull request #43922 from Calinou/doc-projectsettings-globalize-path
Improve the `ProjectSettings.globalize_path()` documentation
2020-11-28 10:29:23 +01:00
Rémi Verschelde 95572211bb
Merge pull request #43925 from madmiraal/fix-16039a
Remove RigidBody weight property
2020-11-28 09:37:42 +01:00
Yuri Roubinsky 4a3588a51a
Merge pull request #43828 from Chaosus/restore_line_antialiasing
Restored antialiased lines by emulation using triangle strips
2020-11-28 11:32:16 +03:00
Rémi Verschelde 94341ac547
Merge pull request #42987 from clayjohn/VULKAN-sky-only
Add sky_only setting to DirectionalLight3Ds
2020-11-28 09:07:09 +01:00
Rémi Verschelde a6751e6c58
Merge pull request #41100 from bruvzg/ctl_text_server_interface
[Complex Text Layouts] Implement TextServer interface.
2020-11-28 09:03:15 +01:00
Yuri Roubinsky 3ec972fc95 Restored antialiased lines by emulation using triangle strips 2020-11-27 20:45:59 +03:00
Marcel Admiraal 981fbcd3e0 Remove RigidBody weight property 2020-11-27 17:39:20 +00:00
Fabio Alessandrelli 828d1ea59e
Merge pull request #40136 from Jummit/multiplayer-root-node-getters
Add root_node as property of MultiplayerAPI
2020-11-27 18:36:07 +01:00
Hugo Locurcio f415db5b75
Improve the `ProjectSettings.globalize_path()` documentation
This closes https://github.com/godotengine/godot-docs/issues/4409.
2020-11-27 17:12:13 +01:00
Marcel Admiraal 356a2b7235 Fix cast_motion sometimes failing
- Fixes Godot physics failing when the cast Shape is inside of, or
already colliding with another Shape.
- Fixes Bullet physics failing when there is no motion.
- Ensures Godot and Bullet physics behave the same.
- Updates the documentation to exclude the caveats for the failures and
differences.
2020-11-27 15:33:00 +00:00
Hugo Locurcio 1636fb8856
Document the lack of localization remapping support in VideoPlayer
See #43917.
2020-11-27 15:56:24 +01:00
Rémi Verschelde 2d0fda3ca2
doc: Mention iOS support for Input gravity/gyroscope sensors
It has been implemented for iOS a long time ago already with #7127.
2020-11-27 12:01:08 +01:00
Jon Bonazza d5925fd522 feat: HMAC support in Crypto APIs 2020-11-26 18:39:56 -08:00
bruvzg 7e2c0ffd1a
[Complex Text Layouts] Add TextServer documentation. Update Font, CanvasItem, Theme and modified controls documentation. 2020-11-26 14:25:52 +02:00
bruvzg 3be31c4960
[Complex Text Layouts] Refactor TextEdit and CodeEdit controls. 2020-11-26 14:25:50 +02:00
bruvzg 99666de00f
[Complex Text Layouts] Refactor Font class, default themes and controls to use Text Server interface.
Implement interface mirroring.
Add TextLine and TextParagraph classes.
Handle UTF-16 input on macOS and Windows.
2020-11-26 14:25:48 +02:00
Rémi Verschelde a8c2cc9028
Merge pull request #43807 from Xrayez/aspect-ratio-container
Add `AspectRatioContainer` class
2020-11-26 12:20:15 +01:00
HaSa1002 5a01c2a3b0 Docs: Port Code Examples to C# (F, G, H, I, J, K, L)
Includes:
 * File
 * Geometry2D
 * HashingContext
 * HTTPClient
 * HTTPRequest
 * Image
 * Input
 * int
 * ItemList
 * JSONParseResult
 * KinematicBody2D
 * LineEdit

Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
2020-11-25 22:15:13 +01:00
Rémi Verschelde 613b76cfd5
Merge pull request #43861 from JFonS/fix_gizmo_defval
Fix binding of default value in EditorSpatialGizmoPlugin::get_material()
2020-11-25 19:28:05 +01:00
jfons e6949dae72 Fix binding of default value in EditorSpatialGizmoPlugin::get_material()
It was commented for some reason I can't remember.
2020-11-25 18:55:07 +01:00
Andrii Doroshenko (Xrayez) ba68383706 Add `AspectRatioContainer` class
Co-authored-by: Ugis Brekis <ugis.brekis@productmadness.com>
2020-11-25 15:06:40 +02:00
Rémi Verschelde 6dfcc4aa80
Merge pull request #43793 from Calinou/doc-mono-resources
Document C# garbage collection caveats in Reference and Resource
2020-11-25 11:12:09 +01:00
Rémi Verschelde 59fdfc77e8
doc: Sync classref with current source 2020-11-23 23:44:44 +01:00
Hugo Locurcio 95618e2937
Improve the AudioStreamPlayer3D class documentation 2020-11-23 16:56:05 +01:00
Hugo Locurcio 0565c76e8b
Document C# garbage collection caveats in Reference and Resource 2020-11-23 14:01:50 +01:00
Rémi Verschelde ba989a1d39
Merge pull request #43627 from aaronfranke/pixelvi
Use Vector2i instead of Vector2 for Image get_pixelv and set_pixelv
2020-11-23 10:04:49 +01:00
Hugo Locurcio b297d595a5
Document that vertex displacement isn't visible in overdraw debug mode
See #24232.
2020-11-22 16:28:00 +01:00
Aaron Franke 2c53e8b0e9
Use Vector2i instead of Vector2 for Image get_pixelv and set_pixelv
Co-authored-by: Andrii Doroshenko <xrayez@gmail.com>
2020-11-21 02:42:29 -05:00
Rémi Verschelde a655de89e3
doc: Warn about using Node internal processing
See #43689.

Also 'fixed' some spelling for behavior in publicly visible strings.
(Sorry en_GB, en_CA, en_AU, and more... Silicon Valley won the tech spelling
war.)
2020-11-20 09:52:37 +01:00
Rémi Verschelde 6a683f8016
Merge pull request #43591 from madmiraal/fix-43520
Update joy button and stick names, enums and documentation
2020-11-19 20:43:44 +01:00
Marcel Admiraal 20f2b71e21 Update joy button and stick names, enums and documentation 2020-11-19 15:28:31 +00:00
Rémi Verschelde b4f81e7b88
Merge pull request #43662 from EricEzaM/PR/INP3-command_serialization_optional
Made serialization of Command toggleable when saving InputEvents.
2020-11-19 13:38:55 +01:00
Eric M c92f83d3ca Made serialization of Command toggleable when saving InputEvents.
Made serialization of Command optional. If command is serialized, Control (On Win/Linux) or Meta (on Mac) are not.
Example use case: You are on Windows and you set a shortcut to be Control + E. This would serialize as Command=true and Control=true. If you then run this project on Mac, you would need to press Command AND Control to activate the shortcut - which is not what is intended. Now, you can set store_command to true, and it will only serialize to Command = true (no Control serialized). On Windows, this means Control. On Mac, it means only command.
2020-11-19 21:05:45 +10:00
Phischermen 371d12a2f0 Clarify that SceneTree::quit() does not immediately end the application. 2020-11-18 16:45:20 -08:00
Andrii Doroshenko (Xrayez) 0ee88d6705 Describe `ImageTexture`, `Image` creation and usage 2020-11-17 16:00:41 +02:00
Rémi Verschelde c6dcf3310d
doc: Sync classref with Variant utility methods
Copied relevant documentation from the original `@GDScript` built-ins,
which will likely be removed in a future commit.

Various fixups to `variant_utility.cpp` while working on this.
2020-11-17 11:26:24 +01:00
Rémi Verschelde 9310369318
Merge pull request #43565 from rcorre/curve_handle_doc
Clarify Curve3D.get_point_{in,out} position in doc.
2020-11-17 08:21:04 +01:00
Ryan Roden-Corrent c6093ae612
Clarify Curve3D.get_point_{in,out} position in doc.
I verified this experimentally. I added a point at roughly (1,0,0), and
dragged a handle back to the origin. The result was:

```
get_point_position: (0.991079, 0, -0.000069)
get_point_in: (0.993409, 0, 0)
get_point_out: (-0.993409, 0, 0)
```
2020-11-16 17:22:44 -05:00
Rémi Verschelde bffa95fc07
Merge pull request #43537 from KoBeWi/🌳🗎🔧
Correct the doc about Tree.get_edited
2020-11-16 22:32:38 +01:00
Rémi Verschelde 7a2d721536
Merge pull request #43509 from Calinou/doc-projectsettings-packetpeerstream-size
Clarify packet peer `max_buffer_po2` in ProjectSettings documentation
2020-11-16 14:52:24 +01:00
Hugo Locurcio c475b1fd0b
Clarify packet peer `max_buffer_po2` in ProjectSettings documentation
This closes https://github.com/godotengine/godot-docs/issues/4364.
2020-11-16 14:13:59 +01:00
Rémi Verschelde fc70f986b9
Merge pull request #42008 from Calinou/theme-rename-node-type
Rename the `type` parameter to `node_type` in Theme and Control
2020-11-16 13:20:24 +01:00
Rémi Verschelde 8e1765d9c7
Merge pull request #43533 from Calinou/doc-improve-dictionary
Improve the Dictionary class documentation
2020-11-16 12:52:01 +01:00
Rémi Verschelde d7176e9040
Merge pull request #42167 from madmiraal/fix-42108
Remove the unnecessary sync() and the restrictions it imposes on 3D Physics.
2020-11-16 09:32:48 +01:00
Rémi Verschelde 19f27ab486
Merge pull request #42976 from aaronfranke/input-get-axis
Allow getting Input "axis" and "vector" values by specifying multiple actions
2020-11-16 09:30:34 +01:00
Rémi Verschelde 91dd6da2ff
Merge pull request #43246 from HaSa1002/docs-lang-5
Docs: Port code examples to C# (M, N, O, P, Q, R)
2020-11-16 09:16:18 +01:00
Hugo Locurcio 5325de4e6b
Improve the Dictionary class documentation
- Mention Lua-style syntax.
- Make the code samples self-contained.
- Mention caveat with `const` (also in Array).
- Clarify the description of `size()`.

This closes https://github.com/godotengine/godot-docs/issues/4272.
2020-11-14 22:05:53 +01:00
Tomasz Chabora b8145c182b Correct the doc about Tree.get_edited 2020-11-14 16:35:53 +01:00
Aaron Franke 4b272b18ea
Improve comments in Color documentation 2020-11-13 23:31:19 -05:00
Feniks 59ed3c1aaf Changed mouse cursor to the caret (text cursor) location. 2020-11-13 14:57:18 +00:00
Rémi Verschelde a7d610db16
Merge pull request #43408 from rcorre/path-gizmos-4.0
Make Path3D handles visible and consistent with 2D.
2020-11-12 13:12:49 +01:00
Ryan Roden-Corrent 8458ba0aef
Proposal 1246: Make Path3D handles more visible.
Resolves godotengine/godot-proposals#1246.

It is difficult to tell the difference between the handles for adjusting
curves and the points themselves when looking at a Path gizmo.
This re-uses the icons used for Path2D.

Unlike Path2D, this does not use a different icon for smooth vs sharp
points, as using a potentially different material for each point would
prevent batching the points in add_handles (and adding them out-of-order
messes up other logic based on handle indices).

This includes a public API change to allow specifying a texture for a
handle material. This allows spatial gizmo plugins to customize the way
a handle is rendered, if desired, but does not break existing behavior
(as providing no texture uses the default).

The path handle icons were resized as well.  16x16 is the standard icon
size. These icons were 10x10 rather than 16x16, and appeared rather
small in the editor.

To resize, I:

- Opened the original in Inkscape
- Resized the document to 16x16
- Opened the transform dialog
- Scaled by 160% proportionally
- Used Align/Distribute to center on the page
- Saved the document
- Cleaned with `svgcleaner --multipass`
2020-11-12 06:37:56 -05:00
Rémi Verschelde dca6bac620
Merge pull request #43244 from HaSa1002/docs-mdt
Docs: MeshDataTool: showcase tool in code example
2020-11-12 11:35:25 +01:00
HaSa1002 4f9b993423 Docs: MeshDataTool: showcase tool in code example 2020-11-12 10:56:39 +01:00
Wilson E. Alvarez a6f3ef3ac7
Document InstancePlaceholder.create_instance not being thread-safe. 2020-11-11 21:34:51 -05:00
Rémi Verschelde acb7d99fce
Merge pull request #43449 from nekomatata/line_edit_window_pos
Expose LineEdit scroll offset to scripts
2020-11-11 13:18:55 +01:00
Aaron Franke 4abf189e36
Allow getting Input axis/vector values by specifying multiple actions
For get_vector, use raw values and handle deadzones appropriately
2020-11-11 06:02:44 -05:00
PouleyKetchoupp 4775db1600 Expose LineEdit scroll offset to scripts 2020-11-11 10:07:31 +01:00
Rémi Verschelde 9397a5a272
Merge pull request #43437 from akien-mga/doc-operators
doc: Add template to document Variant operators, fixups to #43419
2020-11-10 15:58:36 +01:00
Rémi Verschelde 64e893deac
doc: Sync classref to add operators after #43419 2020-11-10 15:00:50 +01:00
Rémi Verschelde 34cad0d020
doc: Fixups to #43419 which added operators in the docs
- Escape the method names as e.g. `operator <` is invalid XML.
- Add a hack to merge all String % operator definitions for each Variant type
  as a single one with `Variant` argument type.
- Add support for the new qualifiers in makerst.py.
- Drop unused `doc_merge.py`, seems to date back to when we had all the
  documentation in a single `classes.xml`.
2020-11-10 15:00:07 +01:00
Rémi Verschelde 03ae26bb74
Merge pull request #43398 from KoBeWi/add_an_array_to_another_array_but_with_a_method
Add append_array() method to Array class
2020-11-10 13:53:58 +01:00
Tomasz Chabora cbfbb4538b Register methods for drawing 3D editor overlays 2020-11-10 11:35:34 +01:00
HaSa1002 9dad1c4943 [Docs] Add C# example for EditorPlugin::forward_canvas_draw_over_viewport
Follow up to #43356
2020-11-10 10:24:17 +01:00
Rémi Verschelde e0285dcc00
Merge pull request #43356 from KoBeWi/editor_art
Add docs for editor viewport drawing methods
2020-11-10 09:34:32 +01:00
Rémi Verschelde 0f249f5c0a
Variant: Sync docs with new constructors, fixups after #43403
Change DocData comparators for MethodDoc and ArgumentDoc to get a better
ordering of constructors.
2020-11-09 23:39:53 +01:00
Andrii Doroshenko (Xrayez) 1e6b684d44 Expose `PROPERTY_HINT_TYPE_STRING` to scripting 2020-11-09 18:12:04 +02:00
HaSa1002 a3df26e554 Docs: Port Code Examples to C# (M, N, O, P, R)
Includes:
 * MarginContainer
 * NavigationPolygon
 * Node
 * NodePath
 * OS
 * PackedByteArray
 * PackedScene
 * PacketPeerUDP
 * PCKPacker
 * Performance
 * PhysicsShapeQueryParameters2D
 * PhysicsShapeQueryParameters3D
 * PrimitiveMesh
 * ProjectSettings

Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
2020-11-09 10:05:53 +01:00
Rémi Verschelde 593e35346a
Merge pull request #42841 from HaSa1002/docs-lang-3
Port code examples to C# (D and E)
2020-11-09 08:29:44 +01:00
Tomasz Chabora 9f23a94b8a Add append_array() method to Array class 2020-11-08 21:09:45 +01:00
Rémi Verschelde 709964849f
Merge pull request #42896 from Calinou/httprequest-increase-chunk-size
Increase the default HTTPClient download chunk size to 64 KiB
2020-11-07 16:38:28 +01:00
Rémi Verschelde 329d2c1ced
Merge pull request #42947 from Calinou/image-load-bmp-from-buffer
Add `Image.load_bmp_from_buffer()` for run-time BMP image loading
2020-11-07 16:38:09 +01:00
Hugo Locurcio 13357095ee
Increase the default HTTPClient download chunk size to 64 KiB
This improves download speeds at the cost of increased memory usage.

This change also effects HTTPRequest automatically.

See #32807 and #33862.
2020-11-07 16:11:04 +01:00
Tomasz Chabora 5d8b60ac3d Add docs for editor viewport drawing methods 2020-11-06 16:42:40 +01:00
Rémi Verschelde a9bc440311
Merge pull request #41746 from Calinou/doc-projectsettings-fullscreen-borderless
Improve the documentation related to fullscreen and borderless settings
2020-11-06 14:34:22 +01:00
Rémi Verschelde aba611b6fc
Merge pull request #42870 from Calinou/doc-httprequest-tls-version
Document the supported TLS versions in HTTPRequest
2020-11-06 14:32:45 +01:00
Rémi Verschelde 52c1b5fc41
Merge pull request #43283 from Calinou/color-remove-contrasted
Remove `Color.contrasted()` as its behavior is barely useful
2020-11-06 10:17:12 +01:00
Rémi Verschelde 35e6070a35
doc: Override default value for RandomNumberGenerator.seed
It's non-deterministic so it's better to show a fixed value like 0 instead of
having it potentially change whenever `randomize()` is called.

Fixes #43317.
2020-11-05 00:41:24 +01:00
Rémi Verschelde 424cd00f8b
doc: Sync classref with current source + fixup some bindings
Includes various changes triggered by the refactoring of method bindings.
2020-11-04 15:38:26 +01:00
Ryan Roden-Corrent 3826f3348f
Fix typo in Tabs doc.
I don't know enough about grammar to say why the "ing" suffix is
correct, but I'm reasonably sure it is :)
2020-11-03 18:26:48 -05:00
Hugo Locurcio 7adb6b91b3
Remove `Color.contrasted()` as its behavior is barely useful
Returning the most contrasting color isn't a trivial task, as there
are often many possible choices. It's usually best left for the user
to implement using a script.
2020-11-03 04:46:08 -05:00
Rémi Verschelde c5d8dafec4
Tooltips: Improve code clarity and docs
The return type for `_make_custom_tooltip` is clarified as Control, and users
should make sure to return a visible node for proper size calculations.

Moreover in the current master branch, a PopupPanel will be added as parent
to the provided tooltip to make it a sub-window.

Clarifies documentation for `Control._make_custom_tooltip`, and shows how to
use the (until now undocumented) "TooltipPanel" and "TooltipLabel" theme types
to style tooltips.

Fixes #39677.
2020-11-03 09:19:03 +01:00
Rémi Verschelde 873d461785
Merge pull request #40364 from marstaik/alpha2coverage_up
Alpha Hash and Alpha2Coverage Implementation
2020-11-03 07:50:49 +01:00
Marios Staikopoulos e5d7c7d5fc Alpha Hash and Alpha2Coverage Implementation 2020-11-02 20:11:20 -08:00
Rémi Verschelde e8794b24bd
Merge pull request #43260 from HaSa1002/mainloop-remove-deprecated-methods
MainLoop: Remove deprecated methods
2020-11-02 14:26:49 +01:00
Hugo Locurcio 82bfb6273b
Correct documentation about NinePatchRect stretch modes
This closes https://github.com/godotengine/godot-docs/issues/4333.
2020-11-01 18:41:10 +01:00
HaSa1002 f8ac4c4d75 MainLoop: Remove deprecated methods 2020-11-01 12:38:30 +01:00
HaSa1002 8fb113bb4c Port code examples to C# (D)
Includes:
 * Decal
 * Dictionary
 * Directory
 * DisplayServer
 * DTLSServer
 * DynamicFont
 * EditorImportPlugin
 * EditorPlugin
 * EditorScenePostImport
 * EditorScript
 * EditorSettings
 * EditorTranslationParserPlugin
 * Engine
 * Expression

Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
2020-11-01 09:05:17 +01:00
Hugo Locurcio d7025c4167
Fix a variable being redeclared in the HTTPRequest code sample 2020-10-31 19:20:18 +01:00
Rémi Verschelde f6f38ac086
Merge pull request #42811 from Calinou/doc-packetpeerudp-wait-interrupt
Document how to interrupt `PacketPeerUDP.wait()`
2020-10-29 22:38:36 +01:00
SirQuartz 120ef02ca3 Clarify what the "item_rect_changed" signal does 2020-10-28 15:59:14 +01:00
Hugo Locurcio a1f81a52df
Improve the documentation related to fullscreen and borderless settings 2020-10-28 14:30:33 +01:00
Hugo Locurcio b3a6937c0c
Document hiding a Control when its reference point is behind the camera
See https://github.com/godotengine/godot/issues/1725.
2020-10-27 17:37:03 +01:00
Hugo Locurcio c3b246e6af
Rename the `type` parameter to `node_type` in Theme and Control
This makes it clearer that it expects a node type as a string
(such as "Label") instead of a type like "TYPE_ARRAY".
This is backwards-compatible since only the name of the parameter
is changed, not its order.
2020-10-27 14:58:52 +01:00
Dustin Petersohn 669f21d367 Improved documentation for TileMap.cell_y_sort 2020-10-27 00:30:14 +01:00
Andrii Doroshenko (Xrayez) 8ce2f401dd Fixup `ColorRamp` to `Gradient` renames 2020-10-25 18:32:44 +02:00
Aaron Franke 961ee3a1d7
Rename button group property to button_group 2020-10-24 01:30:18 -04:00
Rémi Verschelde f0f8864c9c
Merge pull request #42907 from Xrayez/add-ref-rect-border-width
Add `border_width` to `ReferenceRect`
2020-10-22 15:58:12 +02:00
clayjohn 6299575250 Add sky_only setting to DirectionalLight3Ds 2020-10-21 23:28:08 -07:00
Hugo Locurcio 0209e3790e
Add `Image.load_bmp_from_buffer()` for run-time BMP image loading
This partially addresses
https://github.com/godotengine/godot-proposals/issues/676.
2020-10-20 23:52:45 +02:00
Andrii Doroshenko (Xrayez) 803b046b38 Cross-reference `ColorRect` and `ReferenceRect` in the class reference
They use the same underlying `CanvasItem.draw_rect()` API.
2020-10-20 13:59:41 +03:00
Andrii Doroshenko (Xrayez) aef00021a9 Add `border_width` to `ReferenceRect`
Exposes a hidden parameter behind `CanvasItem.draw_rect()`.
2020-10-20 13:58:50 +03:00
Yuri Roubinsky 4f4287243c Removed underscore from GraphEdit begin/end_node_move signals 2020-10-20 09:22:40 +03:00
Hugo Locurcio 2f1d40367a
Document how to display the vertex color in `SurfaceTool.add_color()`
This closes https://github.com/godotengine/godot-docs/issues/4083.
2020-10-19 15:23:16 +02:00
Rémi Verschelde 6b20859984
Merge pull request #42558 from Chaosus/vs_curve
Added visual shader node to easy gather data from a CurveTexture
2020-10-19 14:58:45 +02:00
Marcel Admiraal 7f26ce4486 Set Bullet collision shape index to zero when using a single shape
or ConcavePolygonShape3D.
2020-10-19 11:51:11 +01:00
Rémi Verschelde bc8300d201
Merge pull request #42579 from theoway/stylebox_and_control_documentation
Documentation change: Explaining the behavior of focus stylebox overlapping the pressed stylebox
2020-10-19 09:36:24 +02:00
Juan Linietsky 53d5a252bb
Revert "Replace SAO implementation with MSSAO" 2020-10-18 19:27:51 -03:00
Juan Linietsky d98261ab8f
Merge pull request #42077 from clayjohn/MSSAO
Replace SAO implementation with MSSAO
2020-10-18 18:34:43 -03:00
Juan Linietsky e799a2ba45
Merge pull request #42201 from clayjohn/Vulkan-new-glow
Optimize Glow with local memory
2020-10-18 18:32:36 -03:00
clayjohn 366ee46774 Replace SAO implementation with MSSAO 2020-10-18 13:15:51 -07:00
clayjohn 63a34b93aa Optimize Glow with local memory 2020-10-18 11:37:12 -07:00
Rémi Verschelde d9e5c355e5
Merge pull request #41418 from clayjohn/Vulkan-aerial
Add aerial perspective to fixed fog
2020-10-18 17:32:19 +02:00
Yuri Roubinsky f402e1e675 Added VisualShaderNodeCurve to easy gather data from a CurveTexture 2020-10-18 09:57:15 +03:00
clayjohn 8c21c26fb5 Add aerial perspective to fixed fog 2020-10-17 10:53:07 -07:00
Hugo Locurcio 0ebbc7602c
Document the supported TLS versions in HTTPRequest
See #42857.
2020-10-17 14:49:56 +02:00
Tomasz Chabora 02ce2f4bb9 Document that setting node name will remove @s 2020-10-17 12:13:54 +02:00
Rémi Verschelde ea21b8ff83
Merge pull request #42823 from madmiraal/update-intersect_point-doc
Update intersect_point documentation to mention solid shapes.
2020-10-15 18:40:36 +02:00
Rémi Verschelde 14e3d68dd9
Merge pull request #42778 from madmiraal/remove-get_layers
Remove old RigidBody get_layers() methods.
2020-10-15 18:40:21 +02:00
Marcel Admiraal e496db79d8 Update intersect_point documentation to mention solid shapes. 2020-10-15 16:44:57 +01:00
Hugo Locurcio 6975bd106a
Clarify that `MultiMesh.set_instance_color()` multiplies vertex colors
This closes https://github.com/godotengine/godot-docs/issues/4273.
2020-10-15 10:19:20 +02:00
Hugo Locurcio 25777488fd
Document how to interrupt `PacketPeerUDP.wait()`
This closes #36335.
2020-10-15 10:10:32 +02:00
Hugo Locurcio 802c1e4df1
Link the Random number generation tutorial in the class reference 2020-10-14 18:03:29 +02:00
Marcel Admiraal a17fdaef09 Remove old RigidBody layers property and methods. 2020-10-13 16:59:49 +01:00
Rémi Verschelde 7baefe812a
Merge pull request #42604 from KoBeWi/da100mp
Correct the doc about linear damping
2020-10-13 11:53:01 +02:00
Tomasz Chabora ebca7d4e4e Correct the doc about linear damping 2020-10-13 11:41:18 +02:00
Rémi Verschelde 5782b3355a
Merge pull request #41576 from FIF15/remove-redundant-property-enabled-focus-mode
Remove redundant property "enabled_focus_mode"
2020-10-13 10:50:00 +02:00
FIF15 0e7e25d488 Remove redundant property "enabled_focus_mode"
Fixes #41529.
2020-10-13 10:04:37 +02:00
Charles Merriam 5160a9f650 Fix typo in the ProjectSettings class documentation 2020-10-13 09:55:31 +02:00
Rémi Verschelde 0df7793693
Merge pull request #42696 from arthurpaulino/update-kinematicbody2d-is-on-descriptions
Updating KinematicBody2D "is_on" functions' descriptions
2020-10-13 08:53:01 +02:00
Arthur Paulino 0c9a1a1cd4 updating descriptions 2020-10-12 20:24:19 -03:00
Rémi Verschelde d22791c271
doc: Sync classref with current source 2020-10-12 10:58:02 +02:00
Paulb23 b707920355 Update SyntaxHighlighter documentation 2020-10-11 17:14:37 +01:00
Rémi Verschelde 7c4d1e9c65
Merge pull request #42660 from Chaosus/remove_get_uv84_normal_bit
Removed unused method Geometry3D.get_uv84_normal_bit
2020-10-09 19:31:24 +02:00
Rémi Verschelde a33fe75050
doc: Sync classref with current source 2020-10-09 15:04:15 +02:00
Yuri Roubinsky 66c2aaf749 Removed unused method Geometry.get_uv84_normal_bit 2020-10-09 10:22:26 +03:00
Sniff 7970e4a433
Docs change: More detailed description of StreamPeerTCP.is_connected_to_host() 2020-10-07 16:35:33 +02:00
Umang Kalra 10a7eddc5e Explaining the behavior of focus & pressed stylebox overlap 2020-10-06 17:44:33 +05:30
Rémi Verschelde 3556bc48a1
Merge pull request #42439 from Xrayez/doc-gdscript-load-and-resloader-xref
Cross-reference GDScript `load` and `ResourceLoader.load` in classref
2020-10-04 20:48:07 +02:00
Rémi Verschelde b5eea37fb0
Merge pull request #42518 from Duroxxigar/update-getter-and-setters
Updated getters and setters names for toplevel
2020-10-03 21:53:35 +02:00
Marcel Admiraal e7edbcedc9 Remove reference to 3D shapes in RigidBody2D.xml contacts description. 2020-10-03 10:38:52 +01:00
Duroxxigar 4834e14493 Updated getters and setters names for toplevel 2020-10-02 19:09:01 -04:00
Rémi Verschelde 7879b0a6e5
Merge pull request #42511 from InfiniteAnts/update-ninepatchrect-class-reference
Updated NinePatchRect's patch margin descriptions
2020-10-02 17:32:45 +02:00
Anant Ahuja 00d9432f44 Updated NinePatchRect's patch margin descriptions 2020-10-02 09:41:00 -05:00
Rémi Verschelde 19f72beebb
Merge pull request #42451 from Duroxxigar/rename-toplevel
Renamed toplevel to be top_level
2020-10-02 10:57:23 +02:00
Aaron Franke 439be614f4
Link to demos from within the class reference 2020-10-01 23:57:21 -04:00
bruvzg b0152dcac5
Fix `screen_get_dpi` on macOS for non fractional display scales and restore documentation. 2020-10-01 22:52:20 +03:00
Rémi Verschelde f3e557780f
Merge pull request #37194 from lolligerjoj/expose_val_interp
Expose Animation::value_track_interpolate to GDscript
2020-10-01 15:27:32 +02:00
Rémi Verschelde c646768ba2
Merge pull request #40473 from rcorre/gizmo-doc
Fix return type on EditorNode3DGizmoPlugin::get_priority.
2020-10-01 14:28:38 +02:00
lolligerjoj ff4af94414 Expose Animation::value_track_interpolate to GDscript 2020-10-01 14:27:09 +02:00
Rémi Verschelde 63d158ff62
Merge pull request #42442 from rcorre/file_doc
Clarify store_string vs store_line.
2020-10-01 13:21:11 +02:00
Ryan Roden-Corrent 2762821c08
Clarify store_string vs store_line.
While the behavior can be implied from the name, it seems worth stating
it explicitly.
2020-10-01 07:03:24 -04:00
Rémi Verschelde 42f2098509
Merge pull request #42435 from Calinou/doc-string-is-valid-ip-address
Improve the `String.is_valid_ip_address()` documentation
2020-10-01 12:54:27 +02:00
Sergey Minakov 1d9b6b01db iOS: move touch delay to settings 2020-10-01 12:36:11 +03:00
Duroxxigar b687ace7f9 Renamed toplevel to be top_level 2020-10-01 03:17:33 -04:00