210461f2ed
Prevent `encode_variant` doing `memcpy` from `nullptr`
2023-10-29 18:06:21 +01:00
dc7e309f48
Fix heap-use-after-free when resource loaded with load_threaded_request is never fetched
...
Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com>
2023-10-23 16:21:17 +08:00
51f81e1c88
Merge pull request #82957 from bruvzg/fs_case_check
...
Add method to check if filesystem is case sensitive.
2023-10-13 12:55:35 +02:00
d8fdd419fa
Apply missing flag to vector4/projection
2023-10-12 11:18:45 -05:00
bf3f6e3b55
Error handling for `FileAccess.get_file_as_*`
...
- Assign last error in said `FileAccess.get_file_as_bytes` and `FileAccess.get_file_as_string`
- Document error handling for said methods
2023-10-11 18:52:16 +02:00
97bcd8a631
Add method to check if filesystem is case sensitive.
2023-10-09 11:00:15 +03:00
f18aa00e85
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-08 17:23:33 +02:00
d616c3ecd0
Merge pull request #82408 from hpvb/fix-import-crash
...
Fix Image import crash
2023-09-27 14:03:47 +02:00
19057c07bc
Merge pull request #67080 from Mickeon/resource-virtual-local-to-scene-setup
...
Reimplement Resource.`_setup_local_to_scene` & deprecate signal
2023-09-27 14:03:28 +02:00
b5705958e6
Fix import crash
...
I was trying to import a solid colored metal/roughness texture that
worked in Godot 4.1.1 but failed to load on master. I eventually tracked
it down to this: to_x and to_y can be 0, which then leads them to be -1
later, which then causes ofs to overflow.
Some of these cases were hidden because of the use of Vector so we were
just happily scribbling in ram elsewhere.
Switched to LocalVector as it made debugging a bit easier.
2023-09-26 23:50:50 +02:00
0b0a6109b6
Make notify_dependency_error only defer calls if called from secondary threads.
2023-09-26 03:36:11 +01:00
16c3a19d91
Expose and document Image.get_mipmap_count()
2023-09-19 14:34:59 +03:00
893f889d74
[Core] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-11 19:45:49 +02:00
79ce0c6e80
Reimplement Resource.`_local_to_scene_setup` & remove workaround
...
Reimplements the virtual method _setup_local_to_scene, lost in #51970
Also deprecates the redundant `setup_local_to_scene_requested` signal.
2023-09-09 13:51:12 +02:00
d8ff69d53c
Extract ScriptInstance to simplify includes
...
This allows to include script_instance.h directly in the
generated gdvirtual.gen.inc, and remove excessive includes
from the codebase.
This should also allow Resource to use GDVIRTUAL macros,
which wasn't possible previously due to a circular dependency.
2023-09-06 22:54:38 +02:00
067807c1cb
Remove nondeterminism in pck_packer
...
PCK files (like other build products) should be deterministic based on their inputs. Removed calls to Math::rand() that are being used to generate padding.
Looks like these were introduced as part of adding encryption support, but the padding being random does not have any cryptographic significance. This can be trivially inferred since file blocks that happen to be aligned don't get padding anyway.
If there's a desire to indroduce something that functions as a nonce it should probably be added explicitly and only if encryption is enabled.
remove Math::rand() calls in editor_export_platform.cpp
follow up to make consistent with pck_packer
2023-09-03 18:14:30 -04:00
0045dc204c
Revert "Implement loading DDS textures at run-time"
...
This reverts commit 34ab1c8a36
2023-08-29 14:25:16 +02:00
a00cf02241
Add support for KTX & KTX2 image format
...
Add support glTF KHR_texture_basisu extension
2023-08-19 10:27:29 +02:00
e73a4a382e
Merge pull request #79201 from Rindbee/fix-setup-state-not-cleared
...
Clear the previously set state when configuring for a new scene root node
2023-08-17 15:43:38 +02:00
efdff9cbc2
Fix GCC -Wmaybe-uninitialized warnings
2023-08-14 14:35:35 +02:00
8aa6f29b56
[FileAccess] Add methods to get/set "hidden" and "read-only" attributes on macOS/BSD and Windows.
2023-08-08 21:51:32 +03:00
4795c3cdfa
Clear the previously set state when configuring for a new scene root node
...
Saving a subscene causes the main scene to be re-instantiated. And the resource
instance in the main scene will be reused when the main scene is re-instantiated.
So for resources with `resource_local_to_scene` enabled, resetting state may be
necessary (at least for `ViewportTexture`).
2023-08-08 23:49:53 +08:00
faaf27f284
Fix various typos with codespell
...
Also includes typo fixes from #79993 , #80068 , #80276 , and #80303 .
Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
2023-08-07 13:09:47 +02:00
34ab1c8a36
Implement loading DDS textures at run-time
2023-07-31 21:31:26 +02:00
0be587521e
Merge pull request #79737 from Calinou/resourceloader-load-error-clarify-expected-type
...
Mention expected resource type in ResourceLoader load error
2023-07-31 21:01:28 +02:00
f37c2b5be2
Fix ImageTextureLayered serialisation issues.
2023-07-23 13:54:04 +02:00
5bf64255b0
Mention expected resource type in ResourceLoader load error
...
This helps troubleshoot issues due to incorrect import types.
2023-07-21 04:45:34 +02:00
de4a3fa151
Unify and streamline connecting to Resource changes
2023-07-17 19:35:57 +02:00
058604f5b8
Fix crash when saving resources with circular references
...
When saving resources, marking of already seen resources was
done too late, causing infinite loop traversing referenced resources
and eventual stack overflow. The change marks traversed resource
before descending to it's children, thus when this resource is
encountered again, it is already marked as seen and traversal stops.
2023-07-14 19:20:04 +02:00
f53329d045
Merge pull request #78890 from KoBeWi/who_needs_restart_anyway
...
Allow change import type without restarting editor
2023-07-12 17:16:53 +02:00
e88934cb74
Merge pull request #74238 from bitsawer/fix_image_convert
...
Fix `Image.convert()` overwriting custom mipmaps
2023-07-12 17:15:39 +02:00
f25233cbc9
Merge pull request #49524 from Calinou/document-editor-import-options
...
Document editor import options in the class reference
2023-07-12 17:15:19 +02:00
6960a1d0e8
Merge pull request #78248 from felaugmar/load-svg-adjustable-scale
...
Added `Image::load_svg_from_(buffer|string)`
2023-07-12 15:09:03 +02:00
f6d568b9e4
Merge pull request #66170 from RedMser/json-fix-invalid-escapes
...
Disallow invalid escape sequences in `JSON.parse`
2023-07-12 15:08:29 +02:00
f1e63b808a
Merge pull request #79101 from akien-mga/linux-unbundle-brotli
...
Linux: Allow unbundling brotli to use system library
2023-07-07 08:35:44 +02:00
5ee36d119f
Merge pull request #78935 from timothyqiu/zip-pack
...
Fix error when non-ASCII characters in resource pack path
2023-07-07 08:30:56 +02:00
153c4a4c4f
Linux: Allow unbundling brotli to use system library
2023-07-06 15:26:38 +02:00
cdd2313ba2
Merge pull request #78977 from RandomShaper/workaround_tls_shutdown
...
Workaround resource loading crashes due to buggy TLS
2023-07-03 19:43:07 +02:00
41c0785636
Workaround resource loading crashes due to buggy TLS
2023-07-03 13:54:55 +02:00
244968c8d1
Allow change import type without restarting editor
2023-07-03 13:24:24 +02:00
30925fcfb0
Fix management of safe-for-nodes flag in ResourceLoader and WorkerThreadPool
2023-07-03 12:27:57 +02:00
df5c68af99
Fix error when non-ASCII characters in resource pack path
2023-07-02 16:09:57 +08:00
427b293c7d
Disallow invalid escape sequences in JSON.parse
2023-06-30 21:28:36 +02:00
26eb3db234
Added Image's `load_svg_from_(buffer|string)`
...
No core dependency to the svg module.
2023-06-23 00:43:43 -03:00
fa971b7b5e
Merge pull request #77361 from jpcerrone/fix_pck_path_inconsistencies
...
Fix PCK file path inconsistencies
2023-06-20 00:02:22 +02:00
553f4f8dce
Improve error reporting when parsing CSV translation file
...
Fixes #46682 .
Also fix unit test suite to separate generic FileAccess CSV testing
from using CSV as translation. And add more CSV translation tests.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-06-19 12:47:44 +02:00
313c0c7f5d
Fix missing UID handling for binary formats
2023-06-16 13:40:10 +02:00
eb391d3302
Display `BitField[Enum]` in docs to distinguish from `Enum`
2023-06-15 17:23:02 +03:00
8352122e70
Document editor import options in the class reference
...
Tooltips are displayed when hovering import options, both in the Import
dock and in the import defaults editor (which is in the Project Settings).
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-06-15 08:30:48 +02:00
2b001db76e
Let user scripts disable thread safety checks
2023-06-09 18:24:01 +02:00
1326b7e04f
Fix buffer over-read and memory leaks when using long filepaths in a zip archive and improved robustness of long filepaths and reading files.
2023-05-31 13:11:59 +00:00
c8cac39446
Grayscale fix for Image::premultiply_alpha() and Image::convert(FORMAT_L8) while using REC.709, with added test case
2023-05-27 18:01:44 -05:00
e725b4b02b
Allow threads to mark themselves as safe for nodes
2023-05-24 00:22:58 +02:00
0fb307720c
PCK file path improvements
...
Fixes godotengine#77317 (Inconsistent PCK file path behaviour).
Simplifies all PCK file paths so that paths with extra '/' symbols in them
still match to the same path.
Fixes various FileAccess methods that didn't work when using PCK paths that
contain extra '/' symbols.
2023-05-22 15:03:05 -03:00
c450260e3e
Fix message queue issues
...
- Missing flush in resource loading.
- Wrong checks about message queue instance.
2023-05-19 13:11:34 +02:00
a6e43f71b6
Avoid multiple possibilites of deadlock in resource loading
2023-05-17 01:52:39 +02:00
fb10f45efe
Merge pull request #75867 from tefusion/fix_http_client_unicode_request
...
Fix HTTPClient _request using wrong size
2023-05-14 16:05:39 +02:00
1c8b203f70
Merge pull request #77011 from Faless/tls/fix_crashes_when_unavailable
...
[TLS] Fix crashes trying to use TLS when not available.
2023-05-12 23:26:43 +02:00
eeac6f8c7f
[TLS] Fix crashes trying to use TLS when not available.
...
If no StreamPeerTLS implementation is available, HTTPClient and
WebSocketPeer will now correctly refuse to connect using TLS returning
ERR_UNAVAILABLE.
Similarly, ENetConnection will refuse to setup DTLS when PacketPeerDTLS
is not available.
2023-05-12 20:08:10 +02:00
45d0b38076
Enhance thread safety of loaders and importers
2023-05-12 17:44:48 +02:00
7537a0521f
Simplify ResourceLoader error callbacks
2023-05-12 17:44:48 +02:00
045401c64e
Use WorkerThreadPool for threaded resource loading
2023-05-10 18:53:41 +02:00
b6647a5808
Avoid sync issues in materials with scheduled shader updates
2023-05-10 18:53:41 +02:00
5a4613f551
Avoid sync issues in resources with deferred updates
2023-05-10 18:53:41 +02:00
8983b20ccd
Avoid interaction issues between resource loading threads
2023-05-10 18:53:41 +02:00
491a437df5
Merge pull request #76540 from reduz/redo-remote-filesystem
...
Redo how the remote filesystem works
2023-05-08 13:52:51 +02:00
e85f6871ba
Merge pull request #76561 from KoBeWi/most_obscure_class_that_has_ever_existed
...
Improve and document PackedDataContainer
2023-05-08 12:20:33 +02:00
273a6eeb66
Redo how the remote filesystem works
...
Instead of reading files over the network, the new version uses a local file cache and only updates files when it changes.
The original remote filesystem was created 14 years ago, when ethernet was faster than hard drives or even flash. Also, mobile devices have a very small amount of storage.
Nowadays, this is no longer the case so the approach is changed to using a persistent cache in the target device.
Co-authored-by: m4gr3d
2023-05-08 11:57:54 +02:00
610877e326
Merge pull request #72288 from MewPurPur/use-string-repeat
...
Use `String.repeat()` to optimize several String methods
2023-05-05 09:56:48 -07:00
59f04e16b8
Support long path in file access on windows
...
Changed windows file access file to check for path length and use the \\?\ long format when needed
2023-05-05 10:04:39 +02:00
6b84e258d2
Use String.repeat() in more places
2023-05-01 02:27:46 +02:00
c08e96ef0d
Improve and document PackedDataContainer
2023-04-29 00:29:40 +02:00
efb42c3101
Merge pull request #75447 from bruvzg/brotli_packedarray
...
Expose brotli decompression to the scripting API.
2023-04-25 16:16:56 +02:00
36bedd341a
Fix misuses of error macros
2023-04-18 10:20:48 +03:00
cf64e2fa47
Expose more compression formats in Image and fix compress check
...
Check for compressing ASTC checked if the function for BPTC was present
2023-04-13 09:39:03 +02:00
1514376e46
Fix HTTPClient _request using wrong size
...
This only affects HttpClient in GDScript.
2023-04-10 11:45:41 +02:00
bff0c71e2e
Fix moving position indicator out of bounds in FileAccessMemory
2023-04-04 10:10:25 +02:00
cef3587427
Merge pull request #74120 from RandomShaper/res_loader_teardown
...
Clear resource load tasks at exit
2023-04-03 15:59:51 +02:00
0e4bd964cc
Expose brotli decompression to the scripting API.
2023-03-29 22:43:36 +03:00
09465f3fe6
Remove (or make verbose only) various debug prints.
2023-03-20 08:14:18 +02:00
0a55a32085
Modify JSON.stringify so that it doesn't create unnecessary empty lines from empty arrays
2023-03-07 10:30:28 +01:00
e80ab423ef
Merge pull request #73793 from myaaaaaaaaa/init-race
...
Fix some race conditions that happen during initialization
2023-03-06 19:57:38 +01:00
d337ed1c64
Fix data races in startup/teardown
2023-03-06 11:47:12 -05:00
bdb3738023
Merge pull request #74166 from RandomShaper/fix_res_loader_read_freed
...
Fix crash in resource load
2023-03-03 11:06:15 +01:00
5a9d7fd8a6
Fix Image.convert() overwriting custom mipmaps
2023-03-02 16:46:06 +02:00
4fceabc30c
Merge pull request #73862 from RandomShaper/fix_subthreaded_res_load
...
Lift restriction that resource load thread requester has to be the initiator
2023-03-02 11:26:54 +01:00
047671df0f
Fix crash in resource load
2023-03-01 18:30:16 +01:00
b8b6a05c17
Clear resource load tasks at exit
2023-02-28 18:56:21 +01:00
b60197d1c6
Fix deadlock in cyclic resource load
2023-02-26 17:19:48 +01:00
c51229491d
Lift restriction that resource load thread requester has to be the initiator
2023-02-24 13:19:31 +01:00
b87f9f679e
Merge pull request #73647 from RandomShaper/fix_threaded_load
...
Fix threading issues in resource loading
2023-02-23 11:04:55 +01:00
c56058fe9a
Fix FileAccess last open error flag update
2023-02-21 17:02:21 +02:00
b862fc8c9b
Fix cases of resource load tasks not being awaitable
2023-02-20 21:20:05 +01:00
618bb173ba
Fix race condition in resource loader when a load task is reused
2023-02-20 21:20:05 +01:00
c586835541
Make `ResourceCache::get_cached_resources` thread-safe
2023-02-20 01:02:08 -08:00
bc95b0b171
Restore FileAccess.close method.
2023-02-16 15:34:20 +02:00
68299e0f94
Merge pull request #72492 from maiself/fix-binary-res-typed-array
...
Fix loading of binary resources with typed arrays
2023-02-01 08:02:28 +01:00
87e6885f5e
Fix loading of binary resources with typed arrays
2023-02-01 01:22:43 -05:00
9e9eac4676
Use enum instead of int in virtual methods return type
2023-01-31 19:06:49 +01:00
28f51ba547
Refactor high quality texture import
...
* Only two texture import modes for low/high quality now:
* S3TC/BPTC
* ETC2/ASTC
* Makes sense given this is the general preferred and most compatible combination in most platforms.
* Removed lossy_quality from VRAM texture compression options. It was unused everywhere.
* Added a new "high_quality" option to texture import. When enabled, it uses BPTC/ASTC (BC7/ASTC4x4) instead of S3TC/ETC2 (DXT1-5/ETC2,ETCA).
* Changed MacOS export settings so required texture formats depend on the architecture selected.
This solves the following problems:
* Makes it simpler to import textures as high quality, without having to worry about the specific format used.
* As the editor can now run on platforms such as web, Mac OS with Apple Silicion and Android, it should no longer be assumed that S3TC/BPTC is available by default for it.
2023-01-30 15:53:23 +01:00
A Thousand Ships
Haoyu Qiu
Rémi Verschelde
Thaddeus Crews
Paul Joannon
bruvzg
Hein-Pieter van Braam
Saracen
bitsawer
Micky
Yuri Sizov
David Nikdel
clayjohn
acazuc
Rindbee
Marcin Nowak
Ithamar R. Adema
Hugo Locurcio
kobewi
Maxim Kulkin
Rémi Verschelde
Pedro J. Estébanez
RedMser
Felipe Augusto Marques
andybarcia
Danil Alexeev
Mack
Kory Postma
jpcerrone
Fabio Alessandrelli
Juan Linietsky
Samuele Panzeri
VolTer
Ninni Pipping
tefusion
Bartłomiej T. Listwon
Jakub Mateusz Marcowski
myaaaaaaaaa
voidedWarranties
Mai Lavelle
Raul Santos