f18f2740da
Merge pull request #70131 from rune-scape/preload-type-regression
...
Fix preload type regression
2022-12-16 00:31:26 +01:00
2a341a6321
Fixed GDScript crashed when two consecutive unary operators are analysed
2022-12-16 04:45:53 +06:30
17e03c29d6
Fix preload type regression
2022-12-15 16:47:13 -05:00
e1c63fee86
GDScript: Fix built-in script and other `find_class` bugs
2022-12-15 14:56:23 -05:00
6debf86d51
Merge pull request #69471 from rune-scape/rune-out-of-order
...
GDScript: Out of order member resolution
2022-12-15 07:56:23 +01:00
2dfc6d5b69
GDScript: Allow out of order member resolution
2022-12-14 21:44:05 -05:00
08449ab16e
Fix String type compatibility being too permissive
2022-12-12 07:27:41 -05:00
8410e7c9c6
Merge pull request #66733 from MewPurPur/unary-op-warnings
...
Fix unary op warnings never showing
2022-12-11 22:33:58 +01:00
98e1a2031d
Fix subscript of preloaded script
2022-12-11 07:59:43 -05:00
65a49bad5a
Fix constant base typing in extended GDScript class
2022-12-10 13:39:45 -05:00
1ac7e5a334
Merge pull request #69518 from rune-scape/rune-analyze-values
...
GDScript: Preload should make native type
2022-12-10 11:29:50 +01:00
f6ea295bb1
Merge pull request #69467 from rune-scape/rune-subclass-script-path
...
GDScript: Fix subclass script path issues
2022-12-10 10:21:19 +01:00
e79be6ce07
Unify String and StringName
2022-12-05 21:46:47 -05:00
6f8ffd5591
GDScript: preload should make native type
2022-12-04 05:36:17 -05:00
7bcaa9df9e
Fix missing parent class name identifier crash
2022-12-02 21:30:19 -05:00
d531869a7c
GDScript: Fix subclass script path issues
2022-12-01 20:43:27 -05:00
4821de146e
Merge pull request #69423 from KoBeWi/parenture
...
Improve parent signature error
2022-12-01 18:10:31 +01:00
2d96f63e09
Merge pull request #68481 from dalexeev/gds-fix-dyn-arg-def-val
...
GDScript 2.0: Fix shift due to skip of non-constant default argument values
2022-12-01 18:09:25 +01:00
d1e4146462
Improve parent signature error
2022-12-01 15:16:16 +01:00
bfc093c53f
Fix unary op warnings never showing
2022-12-01 01:09:10 +01:00
847c9bd248
GDScript: Avoid using `get_global_class_native_base`
2022-11-27 03:55:53 -05:00
c7ceb94e37
Merge pull request #69079 from adamscott/fix-singleton-scene-cyclic-load
...
Fix singleton scene cyclic loading
2022-11-25 19:29:57 +01:00
69bb7e5b11
Fix singleton scene cyclic loading
2022-11-25 12:43:55 -05:00
075cea1077
Ensure class name is printed in STATIC_CALLED_ON_INSTANCE warning
2022-11-24 12:06:11 -08:00
2918689ff1
[godot#68977] Fix constants parameters
2022-11-23 08:15:54 -05:00
0b2dc0f017
Merge pull request #68970 from Chaosus/gds_fix_lambda_signal
...
Fix using signals in lambda functions
2022-11-22 10:00:05 +01:00
f6c8c140f0
Fix using signals in lambda functions
2022-11-22 11:22:41 +03:00
eb62d241c0
[godot#61386] Fix autoload scenes implicit types
2022-11-21 23:39:31 -05:00
6d7c8533d5
Remove fix leftover that caused cyclic load issues
2022-11-18 23:37:00 -05:00
80b3813b15
Merge pull request #67714 from adamscott/fix-preload-cyclic-references-part2
...
Fix cyclic references in GDScript 2.0
2022-11-18 23:08:01 +01:00
5704055d30
Fix cyclic references in GDScript 2.0
2022-11-18 16:41:31 -05:00
13be0ab733
Fix ability to overload "script" variable
2022-11-17 17:21:12 -05:00
bce6f1792e
GDScript compiler subclass bugfixes
2022-11-13 02:29:21 -08:00
0f8e28f818
GDScript 2.0: Fix shift due to skip of non-constant default argument values
2022-11-10 19:22:52 +03:00
7eb44fa47d
Merge pull request #68125 from kleonc/range-fix-single-arg-optimized-type-mismatch
...
[GDScript] Fix type mismatch in optimized single arg `range`
2022-11-02 14:18:24 +01:00
7c0e46f1c1
Merge pull request #68040 from adamscott/fix-property-getter-return-type
...
Fix property getter with custom return type
2022-11-02 14:16:37 +01:00
c268e3a235
GDScript Fix type mismatch in optimized single arg `range`
2022-11-02 13:20:47 +01:00
213ba46672
Merge pull request #68065 from zCubed3/fix_min_max_crash
...
`GDScriptAnalyzer` Fix math utilities crashing when invalid args are passed
2022-10-31 10:59:27 +01:00
b43cc96535
Merge pull request #62695 from Spartan322/relax-constant-asserts
...
Allow non-constant string message for assert
2022-10-31 10:44:56 +01:00
b7f0ab13a4
Fix math utility functions crashing when invalid args passed
2022-10-30 15:18:03 -07:00
26f0afdce2
[godot#68001] Fix property getter with custom return type
2022-10-29 20:38:26 -04:00
a0c4002520
Clarified reason why a resource cannot be loaded.
2022-10-16 17:27:00 -04:00
0a51bb4ca5
Add STATIC_CALLED_ON_INSTANCE warning to highlight
...
when static functions are called directly from objects
2022-10-14 10:43:42 -07:00
be1e9acb7c
Implement RETURN_VALUE_DISCARDED warning in GDscript
2022-10-13 11:56:45 -07:00
0103af1ddd
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-10-07 11:32:33 +03:00
339aba1656
Add GDScript resource export.
2022-09-17 17:10:30 -05:00
4dca9975e7
Fix GDScript `preload` fails in standalone build unless files are present in directory
...
Fixes #56343 .
2022-09-15 13:52:37 +02:00
6843a484ff
Merge pull request #65065 from Atlinx/fix/65010_enum-doesnt-show-up
2022-08-31 16:51:53 +02:00
6b5640c88c
Fix inferred GDScript enum values not appearing in inspector
...
"enum_values" originally wasn't being forwarded to the new type inside "reduce_identifier_from_base", which caused hint strings derived from the new type to be blank, which ultimately caused an empty enum dropdown menu.
2022-08-30 17:40:38 -04:00
10a56981dc
Rename String `plus_file` to `path_join`
2022-08-29 19:38:13 -05:00
f81a166ab8
fix(gdscript): Infer type from preload const
...
When resolving the type of the attribute from the variant, the result_type.kind was overritten for no reason.
It is assumed that this only needs to be done, if the variant value is not valid to have any kind here.
Solves #63715
2022-08-07 16:09:24 +02:00
455c06ecd4
Implement Vector4, Vector4i, Projection
...
Implement built-in classes Vector4, Vector4i and Projection.
* Two versions of Vector4 (float and integer).
* A Projection class, which is a 4x4 matrix specialized in projection types.
These types have been requested for a long time, but given they were very corner case they were not added before.
Because in Godot 4, reimplementing parts of the rendering engine is now possible, access to these types (heavily used by the rendering code) becomes a necessity.
**Q**: Why Projection and not Matrix4?
**A**: Godot does not use Matrix2, Matrix3, Matrix4x3, etc. naming convention because, within the engine, these types always have a *purpose*. As such, Godot names them: Transform2D, Transform3D or Basis. In this case, this 4x4 matrix is _always_ used as a _Projection_, hence the naming.
2022-07-23 14:00:01 +02:00
8035f1e36f
Allow non-constant string message for assert
2022-07-18 00:53:31 -04:00
4873886830
Merge pull request #62760 from cdemirer/fix-annotation-initializer-conflict
...
Fix priority of annotated type vs initializer type
2022-07-06 15:47:56 +02:00
f280975bf1
Fix priority of annotated type vs initializer type
2022-07-06 04:25:44 +03:00
f85bafaa11
Add grouping annotations for class properties in GDScript
2022-07-05 22:01:40 +03:00
9ddebc0c22
Add a const call mode to Object, Variant and Script.
...
For this to work safely (user not call queue_free or something in the expression), a const call mode was added to Object and Variant (and optionally Script).
This mode ensures only const functions can be called, making it safe to use from the editor.
Co-Authored-By: reduz <reduzio@gmail.com>
2022-06-27 13:33:06 -07:00
860e24683f
Make enum/constant binds 64-bit.
2022-06-17 16:36:26 +03:00
3d61246bc4
use correct error for unused bind match, suppress with underscore
2022-06-03 13:28:33 -05:00
6369e495fd
Merge pull request #61279 from Trioct/fix-typed-array-assignment
2022-05-25 17:28:22 +02:00
bcbfa641ec
Fix const typed array assignment
2022-05-25 09:02:11 -05:00
24bcbe971a
GDScript: Don't show redundant await warning on unknown types
...
Also avoid it when the type is known to be a signal.
2022-05-24 14:37:50 -03:00
45af29da80
Add a new HashSet template
...
* Intended to replace RBSet in most cases.
* Optimized for iteration speed
2022-05-20 22:40:38 +02:00
746dddc067
Replace most uses of Map by HashMap
...
* Map is unnecessary and inefficient in almost every case.
* Replaced by the new HashMap.
* Renamed Map to RBMap and Set to RBSet for cases that still make sense
(order matters) but use is discouraged.
There were very few cases where replacing by HashMap was undesired because
keeping the key order was intended.
I tried to keep those (as RBMap) as much as possible, but might have missed
some. Review appreciated!
2022-05-16 10:37:48 +02:00
8b7c7f5a75
Add a new HashMap implementation
...
Adds a new, cleaned up, HashMap implementation.
* Uses Robin Hood Hashing (https://en.wikipedia.org/wiki/Hash_table#Robin_Hood_hashing ).
* Keeps elements in a double linked list for simpler, ordered, iteration.
* Allows keeping iterators for later use in removal (Unlike Map<>, it does not do much
for performance vs keeping the key, but helps replace old code).
* Uses a more modern C++ iterator API, deprecates the old one.
* Supports custom allocator (in case there is a wish to use a paged one).
This class aims to unify all the associative template usage and replace it by this one:
* Map<> (whereas key order does not matter, which is 99% of cases)
* HashMap<>
* OrderedHashMap<>
* OAHashMap<>
2022-05-12 11:21:29 +02:00
f626e8ef91
Merge pull request #60396 from vnen/gdscript-self-lambda
2022-04-27 13:11:24 +02:00
01d13ab2c1
GDScript: Allow using self in lambdas
2022-04-24 21:49:02 -03:00
b3704e664d
Fixes GDScript define nested dictionary and array as constants #50285
2022-04-19 08:57:23 -04:00
4710e2b278
GDScript: Add support for static method calls in native types
2022-04-06 14:14:38 -03:00
a647fb3e62
Fix typos with codespell
...
Using codespell 2.2-dev from current git.
Fix a couple incorrect uses of gendered pronouns.
2022-03-31 14:07:29 +02:00
be718285f7
GDScript: Fix issues with completion and `super` calls
...
- Make call errors use the call node instead of the calle, which will be
empty on super calls.
- Don't allow `super()` to be used within lambdas.
2022-03-30 11:58:29 -03:00
c14043b166
Prevent NARROWING_CONVERSION warning for int(float) function in GDScript
2022-03-22 09:17:00 +03:00
6cba2143de
Merge pull request #59056 from Chaosus/gds_fix_extends_crash
2022-03-22 08:27:03 +03:00
5a99aa3b3a
Fix default value count checking for inherited function
2022-03-14 18:00:42 +03:00
d009d96a92
Prevent crash due to empty error message on empty extends in GDScript
2022-03-12 09:46:51 +03:00
2eaadb1b52
Restore building web platform by enclosing resolve_function_signature.
2022-03-07 00:35:11 -08:00
1ebcb58e69
GDScript: Check if method signature matches the parent
...
To guarantee polymorphism, a method signature must be compatible with
the parent. This checks if:
1. Return type is the same.
2. The subclass method takes at least the same amount of parameters.
3. The matching parameters have the same type.
4. If the subclass takes more parameters, all of the extra ones have a
default value.
5. If the superclass has default values, so must have the subclass.
There's a few test cases to ensure this holds up.
2022-03-06 11:16:20 -03:00
bb8c4acdc9
Merge pull request #58185 from V-Sekai/explicit_variant_assignment_fix
2022-03-04 14:56:38 +01:00
d31aaed172
Merge pull request #58626 from groud/fix_gdscript_analyser_crash
2022-03-04 14:15:59 +01:00
57838fc0ee
Merge pull request #58262 from Sauermann/fix-range-doc
...
Describe usage of float in range documentation
2022-03-03 13:12:29 +01:00
7ae988ce5e
Fix a crash in GDScriptAnalyzer when a script class's file is not found
2022-02-28 12:20:00 +01:00
b6aa4ed55d
Fixes cyclic detection from variables assigning themselves to themselves in autocomplete, and restricts initialization of variables from other variables which have not been declared above it in class body
2022-02-22 01:21:21 +00:00
bac8e451c0
Describe usage of float in range documentation
2022-02-18 00:59:22 +01:00
d45c3cdd1d
Fix error when assigning to an explicitly annotated variant from an ambiguous source
2022-02-16 13:25:27 +00:00
317cd0b19a
Refactor some object type checking code with `cast_to`
...
Less stringly typed logic, and less String allocations and comparisons.
2022-02-08 10:08:34 +01:00
89eb6d372d
Merge pull request #57591 from vnen/gdscript-enum-fixes
2022-02-04 13:49:15 +01:00
ceafdf347e
GDScript: Treat enum values as int and enum types as dictionary
...
Since enums resolve to a dictionary at runtime, calling dictionary
methods on an enum type is a valid use case. This ensures this is true
by adding test cases. This also makes enum values be treated as ints
when used in operations.
2022-02-03 13:32:34 -03:00
ad6e2e82a9
GDScript: Consolidate behavior for assigning enum types
...
This makes sure that assigning values to enum-typed variables are
consistent. Same enum is always valid, different enum is always
invalid (without casting) and assigning `int` creates a warning
if there is no casting.
There are new test cases to ensure this behavior doesn't break in
the future.
2022-02-03 13:32:16 -03:00
28ac4d8b7d
Fix crash with non-constant keys in match statement Dictionary pattern
2022-01-26 04:10:07 +08:00
4cfade6212
Merge pull request #55995 from Xwdit/enum_fix
...
Fix enum int comparison
2022-01-17 20:20:16 +01:00
1989120d3f
Merge pull request #56194 from cdemirer/fix-operation-result-type-inference
2022-01-10 17:18:32 +01:00
4acc819f9b
Merge pull request #56232 from V-Sekai/invalid_explicit_variant_assign_fix
2022-01-10 17:12:56 +01:00
cc7f634066
Merge pull request #56260 from cdemirer/fix-type-mutation-upon-assignment-with-operation
2022-01-10 17:12:34 +01:00
6d4ed65f4c
Merge pull request #56483 from vnen/gdscript-warning-annotation
...
Add annotation to ignore warnings
2022-01-05 09:05:56 +01:00
fd643c903d
GDScript: Add annotation to ignore warnings
2022-01-04 09:32:43 -03:00
fe52458154
Update copyright statements to 2022
...
Happy new year to the wonderful Godot community!
2022-01-03 21:27:34 +01:00
067b4c8c07
Fix type mutation upon compound assignment
2021-12-27 03:32:22 +08:00
b22c805dbe
Fix 'Compiler bug: unresolved assign' on explicitly annotated variants.
2021-12-25 00:53:57 +00:00
455cc07f90
Fix operation result type inference
2021-12-23 20:45:24 +08:00
0430e26e6d
Fix enum int comparison
...
Fix enum int comparison
2021-12-16 16:14:14 +01:00
ab8119b5f6
Avoid a crash in the gdscript analyser
2021-12-14 15:54:25 +01:00
566895732c
Fix shadowed global identifier warning duplication
2021-12-13 11:54:23 +03:00
4682f22293
Improve various texts
2021-11-23 12:20:57 +01:00
560d9a4cc0
Fix incorrect debug check for setters
...
the check read the return type of the setter, which doesn't exist and
lead to a segmentation fault. Now we check the first function parameter.
Probably a bad copy/paste of the getter case
2021-10-18 09:01:16 +02:00
3f888966c0
Merge pull request #53843 from vnen/gdscript-typed-array-subscript-constant
...
Fix inferred typed array marked as constant
2021-10-15 16:49:29 +02:00
540821a264
GDScript: Fix inferred typed array marked as constant
2021-10-15 10:40:50 -03:00
84abb9a76c
GDScript: Fix typing for await expression
...
Don't grab the type of the awaited value unless it's constant (which
makes it synchronous) or call (which always use the proper return type).
2021-10-14 20:30:06 -03:00
749d89ae38
GDScript: Remove error when coroutine is called without await
...
In the case the call happens as a statement, since the return value
isn't used in this case.
2021-10-14 20:12:01 -03:00
bf322bacdd
Merge pull request #53726 from briansemrau/gd-outer-class
...
GDScript 2.0: Access outer scope classes
2021-10-14 10:12:52 -03:00
0ff0f64cd4
GDScript: Access outer scope classes
2021-10-13 22:39:12 -04:00
e4288bf728
Merge pull request #53720 from vnen/gdscript-typed-array-custom-class
2021-10-12 16:51:50 +02:00
34288b24a6
GDScript: Fix typed array with custom classes
2021-10-12 10:41:04 -03:00
45f546c1d8
GDScript: Make setter parameter type same as variable type
2021-10-12 09:39:23 -03:00
551ceb590b
GDScript: Report property type errors
...
Inline getters & setters are now FunctionNodes.
Their names are set in the parser, not in the compiler.
GDScript-Analyzer will now run through getter and setter.
Also report wrong type or signature errors regarding getset properties.
Added GDScript tests for getters and setters.
#53102
2021-10-08 22:06:15 +02:00
3a856b4fcc
GDScript: Use getter return type for the property type
...
The PropertyInfo hints are more relevant for the inspector. The getter
return type is more reliable and less likely to be incorrect and it is
what's going to be called in the end.
2021-10-07 20:22:19 -03:00
98b81ad35c
Merge pull request #53479 from vnen/gdscript-subscript-object-self
2021-10-06 19:48:23 +02:00
1f55bd190c
GDScript: Allow subscript on self and object types
2021-10-06 12:01:34 -03:00
6bdb28f5e4
GDScript: Avoid hard errors on inferred types
...
Since inference isn't always correct, they are now treated as unsafe
instead of errors.
This also removes inferred type when a variable is reassigned. Since
it's not aware of branching, the types might become invalid in a later
context.
2021-10-06 11:42:19 -03:00
7725ebf3d2
GDScript: Use path cache when checking preloaded scripts
...
The path itself might not always be set in some cases, especially when
the script is just created and is already in the resource cache. Using
get_path() in this case gets the correct resource path.
This also adds a null check for safety in case the path is incorrect or
missing, to avoid a crash in the engine.
2021-10-04 20:48:39 -03:00
4a4995524c
Merge pull request #53338 from briansemrau/gdscript-handle-for-with-null-list
2021-10-04 17:11:43 +02:00
cb28469281
Allow void as return type for constructors
2021-10-03 21:16:54 +02:00
dc046e5cbe
GDScript Check for null list in `for` loop
2021-10-02 13:53:56 -04:00
c63b18507d
Use range iterators for `Map`
2021-09-30 15:09:12 -06:00
d2b8560d7a
Revert "GdScript: Use reduced constant expression result when doing binary operations. Fixes #50293"
...
This reverts commit 6207708607
2021-09-30 18:57:59 +02:00
7f8e50801e
Merge pull request #51818 from MarianoGnu/gdscript2-enum-fixes
2021-09-30 18:35:49 +02:00
72c07708e8
GDScript: Don't allow builtin type names as identifiers
2021-09-29 11:23:16 -03:00
5107f9190b
GDScript: Remove conversion assign mistakenly done when unneeded
2021-09-21 11:58:57 -03:00
b8fdeb6467
Merge pull request #51671 from RandomShaper/fix_gdscript_crash
...
Fix some GDScript bugs
2021-09-17 12:29:40 -03:00
4e69341c01
GDScript: Avoid inferred types from giving hard errors
2021-09-17 11:52:30 -03:00
a5c299630d
Merge pull request #50456 from Blackiris/fix-extends-parent-relative
...
Fix extends with relative path to parent script
2021-09-15 11:12:24 -03:00
c23823ac54
Merge pull request #52582 from jmb462/Prevent-non-explicit-inferring-parameter-from-null
2021-09-15 15:50:42 +02:00
45d9df2e63
Merge pull request #52632 from vnen/autoload-global-script-class-conflict
...
Disallow class names to be the same as global names
2021-09-13 21:10:50 +02:00
0c2ab55a58
Merge pull request #52100 from vnen/gdscript-access-outer-constants
...
GDScript: Allow access to outer constant and enum values
2021-09-13 18:04:35 +02:00
2e5fa124f4
Disallow class names to be the same as global names
...
Also forbid autoloads to have the same name as global script class.
2021-09-13 10:51:29 -03:00
b9219bedf7
Prevent non explicit inferring parameter from null
2021-09-11 21:11:10 +02:00
7c79e361f5
Fix parameter type resolution in GDScript
2021-09-11 11:35:25 +02:00
d72f12a561
Implement iterator variable typing in GDScript
2021-09-11 11:35:25 +02:00
6da061faf5
Merge pull request #49897 from Blackiris/fix-dollar-point-crash-on-editor
...
Fix crash when writing $. in the editor
2021-09-10 10:55:11 -03:00
a92d2c447b
Fix extends with relative path to parent script
2021-09-05 00:11:04 +02:00
8c82e305ba
Merge pull request #52329 from ZuBsPaCe/gdscript-unused-private-class-variable-fix
...
GDScript: Fix for UNUSED_PRIVATE_CLASS_VARIABLE
2021-09-03 10:04:11 +02:00
c76ad6b158
GDScript: Count usages of member variables.
...
Otherwise private member variables will always lead to UNUSED_PRIVATE_CLASS_VARIABLE.
2021-09-03 07:44:46 +02:00
84852585b9
Check for GDScript member and class naming conflicts in a variety of conditions.
2021-09-02 07:16:06 +01:00
d11c1afc04
Rename String::is_rel_path to String::is_relative_path
2021-08-29 20:41:29 -04:00
4918df4527
GDScript: Allow access to outer constant and enum values
2021-08-24 14:45:51 -03:00
2e84a46a0f
GDScript: Make singleton functions be seen as static
...
Since those can be called without an instance.
2021-08-20 10:52:58 -03:00
1c8b076502
GDScript: Fix calling builtin static functions
2021-08-18 18:58:41 -03:00
47545aeb1a
GDScript: Fix issue when calling `new()` on its own
2021-08-18 18:56:21 -03:00
2ba4ee9198
GDScript: Fix inner classes and preloaded scripts as types
2021-08-18 18:56:21 -03:00
6207708607
GdScript: Use reduced constant expression result when doing binary operations. Fixes #50293
2021-08-18 09:19:09 -03:00
70c5feb32c
Accept non unnamed enums as valid values for enums. Fixes #49357
2021-08-17 19:44:27 -03:00
Rémi Verschelde
stmSi
rune-scape
Adam Scott
Rémi Verschelde
kobewi
VolTer
clayjohn
Yuri Rubinsky
ocean (they/them)
Rune
Danil Alexeev
kleonc
zCubed3
bruvzg
willnationsdev
Abdelhafidh Belalia
Atlinx
Aaron Franke
Antonio Dell'Annunziata
reduz
George L. Albany
cdemirer
Yuri Sizov
K. S. Ernest (iFire) Lee
Nathan Franke
Trioct
George Marques
PastMoments
Max Hilbrunner
Gilles Roudière
SaracenOne
Markus Sauermann
Xwdit
Benjamin Navarro
Brian Semrau
ZuBsPaCe
Lightning_A
jmb462
Pedro J. Estébanez
Julien Nguyen
Wilson E. Alvarez
Mariano Suligoy