Library code and public headers are now properly separated, we can fix include paths
to remove the redundant subfolder.
(cherry picked from commit 432ac521ef)
This is a tricky one, it used to work, but it was wrong, because in such
a scenario instead of passing NULL as required by the API, it would pass
a buffer containing the `\0` terminator.
This stopped working on a specific miniupnpc version, when they fixed
some network endianess issue on Windows, to which we made a workaround,
which in turn would probably result in failures when the interface is
specified.
This commit address the issue properly, by checking the specified
interface string size, and correctly passing NULL instead of the empty
string when necessary.
Also reverts the commit that introduced the bogus workaround:
388adac947
One of those PR when the explanation is much longer then code changes
:).
The problem could be related to different byte ordering when copying
the interface address over the binding address.
(cherry picked from commit e85330231c)
DeeJayLSP
Rémi Verschelde
Fabio Alessandrelli
CodeforEvolution
mhilbrunner